Hello there,
I just ran the static analyser "cppcheck" over the source code of ser-0.9.6
It said many things, including
1.
[parser/parse_uri.c:566] -> [parser/parse_uri.c:568]: (warning) Variable 'state' is reassigned a value before the old one has been used. 'break;' missing?
Source code is
case 'r': case 'R': b=p; state=PR2_R; default: state=URI_PARAM_P;
Suggest add missing break.
2.
[parser/parse_uri.c:624] -> [parser/parse_uri.c:624]: (warning) Variable 'state' is reassigned a value before the old one has been used. 'break;' missing? [parser/parse_uri.c:628] -> [parser/parse_uri.c:628]: (warning) Variable 'state' is reassigned a value before the old one has been used. 'break;' missing? [parser/parse_uri.c:631] -> [parser/parse_uri.c:631]: (warning) Variable 'state' is reassigned a value before the old one has been used. 'break;' missing? [parser/parse_uri.c:636] -> [parser/parse_uri.c:636]: (warning) Variable 'state' is reassigned a value before the old one has been used. 'break;' missing?
Duplicates.
Regards
David Binderman
Hello,
ser-0.9.6 is very old release, not longer maintained. At this moment ser has been absorbed in Kamailio project. You can still compile it as ser if you wish via FLAVOUR option to make command.
Maybe it is better to run the tool against the master branch in GIT repository of Kamailio to see if it reports potential issues. Here is a link showing how to get the sources from git:
- http://www.kamailio.org/wiki/install/devel/git#getting_sources_from_git
Cheers, Daniel
On 27/01/14 13:16, David Binderman wrote:
Hello there,
I just ran the static analyser "cppcheck" over the source code of ser-0.9.6
It said many things, including
[parser/parse_uri.c:566] -> [parser/parse_uri.c:568]: (warning) Variable 'state' is reassigned a value before the old one has been used. 'break;' missing?
Source code is
case 'r': case 'R': b=p; state=PR2_R; default: state=URI_PARAM_P;
Suggest add missing break.
[parser/parse_uri.c:624] -> [parser/parse_uri.c:624]: (warning) Variable 'state' is reassigned a value before the old one has been used. 'break;' missing? [parser/parse_uri.c:628] -> [parser/parse_uri.c:628]: (warning) Variable 'state' is reassigned a value before the old one has been used. 'break;' missing? [parser/parse_uri.c:631] -> [parser/parse_uri.c:631]: (warning) Variable 'state' is reassigned a value before the old one has been used. 'break;' missing? [parser/parse_uri.c:636] -> [parser/parse_uri.c:636]: (warning) Variable 'state' is reassigned a value before the old one has been used. 'break;' missing?
Duplicates.
Regards
David Binderman _______________________________________________ SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list sr-users@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users