27 Jan
2014
27 Jan
'14
7:16 a.m.
Hello there,
I just ran the static analyser "cppcheck" over the source code
of ser-0.9.6
It said many things, including
1.
[parser/parse_uri.c:566] -> [parser/parse_uri.c:568]: (warning) Variable
'state' is reassigned a value before the old one has been used. 'break;'
missing?
Source code is
case 'r':
case 'R':
b=p;
state=PR2_R;
default:
state=URI_PARAM_P;
Suggest add missing break.
2.
[parser/parse_uri.c:624] ->
[parser/parse_uri.c:624]: (warning) Variable 'state' is reassigned a value before
the old one has been used. 'break;' missing?
[parser/parse_uri.c:628] -> [parser/parse_uri.c:628]: (warning) Variable
'state' is reassigned a value before the old one has been used. 'break;'
missing?
[parser/parse_uri.c:631] -> [parser/parse_uri.c:631]: (warning) Variable
'state' is reassigned a value before the old one has been used. 'break;'
missing?
[parser/parse_uri.c:636] -> [parser/parse_uri.c:636]: (warning) Variable
'state' is reassigned a value before the old one has been used. 'break;'
missing?
Duplicates.
Regards
David Binderman