Re: [OpenSER-Users] retransmissions after final response

Hi Bogdan, all, I've made more digging and I need your opinion on my findings. Pre-condition: run an AS in forked mode with 2 children. 1. AS sends a request (RQ). 2. AS receives a "408 Request Timeout" reply (RPL) for RQ. 3. After some time (about 30 seconds) AS receives another "408 Request Timeout", initiated at another network node. 4. At this point, you want to send another request from AS. Result: Very often, the replies for the last request cannot be matched with its transaction in "tm" module, so request retransmissions occur. After a few days I've found that in "t_reply_matching" function from "t_lookup.c" file, just before returning (at the end of the function, not in the case when the reply gets matched) T is set to zero (set_t(0)). So, at step 3, the reply cannot be matched with an existing transaction and T is set to zero in a child process. If a reply of the request sent at step 4 gets handled by exactly the child process that last set T to zero, the transaction will not get matched (see t_check() and reply_received() functions), so the retransmission timer will hit => request retransmissions!!! I think the problem is that T is set to zero in t_reply_matching() when a reply cannot be matched. I've changed that to set_t(T_UNDEFINED) and everything seems to work just fine. What do you say Bogdan? Is this change safe? Is this the fix for my problem? Thanks, Sica. ----- Original Message ---- From: Bogdan-Andrei Iancu <bogdan(a)voice-system.ro> To: Vasile Zaharia <sicavz(a)yahoo.com> Cc: users(a)openser.org Sent: Tuesday, October 30, 2007 9:49:38 AM Subject: Re: [OpenSER-Users] retransmissions after final response Salut Sica, So you say that openser does retransmission even after receiving the 200 OK for the request? are you sure it is about the same transaction? Could you provide the debug log showing also the retransmission events? (just send me the entire log). Salutari, Bogdan Vasile Zaharia wrote: t_reply_matching: reply matched (T=0xb5e98bd8)!\n end=0xb5e98bd8\n trans=0xb5e98bd8, callback type 256, id 0 entered\n : removing 0xb5e98bd8 from table \n unlinking timer: tl=0xb5e98d54, timeout=364, group=0\n transaction 0xb5e98bd8\n : done\n t_reply_matching: reply matched (T=0xb5e98bd8)!\n end=0xb5e98bd8\n trans=0xb5e98bd8, callback type 256, id 0 entered\n : removing 0xb5e98bd8 from table \n unlinking timer: tl=0xb5e98d54, timeout=391, group=0\n transaction 0xb5e98bd8\n : done\n t_reply_matching: reply matched (T=0xb5e98bd8)!\n [22569] end=0xb5e98bd8\n [22569] : removing 0xb5e98bd8 from table \n unlinking timer: tl=0xb5e98d54, timeout=397, group=0\n transaction 0xb5e98bd8\n : done\n t_reply_matching: reply matched (T=0xb5e98bd8)!\n end=0xb5e98bd8\n trans=0xb5e98bd8, callback type 256, id 0 entered\n : removing 0xb5e98bd8 from table \n unlinking timer: tl=0xb5e98d54, timeout=425, group=0\n transaction 0xb5e98bd8\n : done\n t_reply_matching: reply matched (T=0xb5e98bd8)!\n end=0xb5e98bd8\n trans=0xb5e98bd8, callback type 256, id 0 entered\n : removing 0xb5e98bd8 from table \n unlinking timer: tl=0xb5e98d54, timeout=540, group=0\n transaction 0xb5e98bd8\n : done\n gets matched, removed, deleted. Many times. proprietary client (using two opensource libraries: osip and exosip). it OpenSER __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com