14 Sep
2010
14 Sep
'10
11:48 a.m.
On Monday 13 September 2010, Mikko Lehto wrote:
Hello Mikko,
a more general solution would be of course nice.
Indeed, even if i don't think this is at the moment activly used for the
lookup.
Ah, sorry. It was just a matter of "its already installed on the test machine"
as i wanted to give it a try. :-)
Regards,
Henning
Do you refer
to the fact that then also the internal logic of the module
needs to be changed as well?
Yes, exactly.
Well, the module could be changed, that maybe
could also use something
like 997 or 998 for the "not found" id could be used.
Those are part of the reserved range around here, but length is four
starting from 9900. 0998 could be "not found" and 9900 first four digit
carrier.
That would work for my case, maybe I'll try mapping zero to something else
with my vintage C skills. You're
right, it should be only in the carrier name file. I'll fix this.
Somehow this is used from german regulation authorities, it stands
probably for the country name. We could probably change it, patches are
welcome. ;-)
It's OK like that, I'll rather mess with the "not found" case for now.
Country prefix could actually be useful if one file has carrier names
from multiple countries. Great, thank
you! I'll add it to the repository, and also fix the german
one (some changes in URL)
Nice, I see you like wget more :)