22 Mar
2015
22 Mar
'15
4:39 a.m.
When you add/update/view Administrator usernames
To reproduce
Administration > User Management >
Click on any existing username. The browser goes blank.
Error in apache logs is:
PHP Fatal error: Call to a member function getQuoted() on a non-object
in /var/www/html/openbiz/bin/data/BizDataSql.php on line 237
This is on the latest Siremis v4.2.0 downloaded today
I am using CentOS v6.6, php v5.3.3
23 Mar
23 Mar
6:52 a.m.
I think I found the root cause.
Siremis database has a table called "group". That is a reserved word in
mysql that cannot be used as a table name.
http://dev.mysql.com/doc/refman/5.5/en/reserved-words.html
Do the following to prove it.
mysql
USE siremis;
SELECT * FROM group;
error
RENAME TABLE group TO group1;
SELECT * FROM group1;
no error
On 3/21/2015 4:39 PM, canuck15 wrote:
When you add/update/view Administrator usernames
To reproduce
Administration > User Management >
Click on any existing username. The browser goes blank.
Error in apache logs is:
PHP Fatal error: Call to a member function getQuoted() on a non-object
in /var/www/html/openbiz/bin/data/BizDataSql.php on line 237
This is on the latest Siremis v4.2.0 downloaded today
I am using CentOS v6.6, php v5.3.3
1:18 p.m.
The issue is calling a function which is not member of the object
referred to.
We will look into fixing it properly, for the moment do following changes:
- editi the file: /var/www/html/openbiz/bin/data/BizDataSql.php
- go to line 237
- replace the line with:
$xtable = $assoc["XTable"];
Thanks for reporting and troubleshooting.
Cheers,
Daniel
On 23/03/15 02:52, canuck15 wrote:
I think I found the root cause.
Siremis database has a table called "group". That is a reserved word
in mysql that cannot be used as a table name.
http://dev.mysql.com/doc/refman/5.5/en/reserved-words.html
Do the following to prove it.
mysql
--
Daniel-Constantin Mierla
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
Kamailio World Conference, May 27-29, 2015
Berlin, Germany - http://www.kamailioworld.com
USE siremis;
SELECT * FROM group;
error
RENAME TABLE group TO group1;
SELECT * FROM group1;
no error
On 3/21/2015 4:39 PM, canuck15 wrote:
When you add/update/view Administrator usernames
To reproduce
Administration > User Management >
Click on any existing username. The browser goes blank.
Error in apache logs is:
PHP Fatal error: Call to a member function getQuoted() on a
non-object in /var/www/html/openbiz/bin/data/BizDataSql.php on line 237
This is on the latest Siremis v4.2.0 downloaded today
I am using CentOS v6.6, php v5.3.3
_______________________________________________
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
sr-users(a)lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users
7:03 p.m.
Hi,
I figured that part out which is when I got the database error about the
"group" table. So I will need to find where to change that table name.
I should have mentioned that.
On 3/23/2015 1:18 AM, Daniel-Constantin Mierla wrote:
The issue is calling a function which is not member of
the object
referred to.
We will look into fixing it properly, for the moment do following changes:
- editi the file: /var/www/html/openbiz/bin/data/BizDataSql.php
- go to line 237
- replace the line with:
$xtable = $assoc["XTable"];
Thanks for reporting and troubleshooting.
Cheers,
Daniel
On 23/03/15 02:52, canuck15 wrote:
I think I found the root cause.
Siremis database has a table called "group". That is a reserved word
in mysql that cannot be used as a table name.
http://dev.mysql.com/doc/refman/5.5/en/reserved-words.html
Do the following to prove it.
mysql
--
Daniel-Constantin Mierla
http://twitter.com/#!/miconda -http://www.linkedin.com/in/miconda
Kamailio World Conference, May 27-29, 2015
Berlin, Germany -http://www.kamailioworld.com
_______________________________________________
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
sr-users(a)lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users USE siremis;
SELECT * FROM group;
error
RENAME TABLE group TO group1;
SELECT * FROM group1;
no error
On 3/21/2015 4:39 PM, canuck15 wrote:
When you add/update/view Administrator usernames
To reproduce
Administration > User Management >
Click on any existing username. The browser goes blank.
Error in apache logs is:
PHP Fatal error: Call to a member function getQuoted() on a
non-object in /var/www/html/openbiz/bin/data/BizDataSql.php on line 237
This is on the latest Siremis v4.2.0 downloaded today
I am using CentOS v6.6, php v5.3.3
_______________________________________________
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
sr-users(a)lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users
8:20 p.m.
Ok, so the complete fix is:
edit ...openbiz/bin/data/BizDataSql.php
go to line 237
replace the line with.
$xtable = $assoc["XTable"];
mysql -p
USE siremis;
RENAME TABLE group TO grouptable;
Or pick some other new name for the group table.
edit ..siremis/modules/system/do
Go through all the files in that directory and change
Table="group"
To
Table="grouptable"
Or whatever the new name given to the group table is. Now it all seems
to work.
On 3/23/2015 7:03 AM, canuck15 wrote:
Hi,
I figured that part out which is when I got the database error about
the "group" table. So I will need to find where to change that table
name. I should have mentioned that.
On 3/23/2015 1:18 AM, Daniel-Constantin Mierla wrote:
The issue is calling a function which is not
member of the object
referred to.
We will look into fixing it properly, for the moment do following
changes:
- editi the file: /var/www/html/openbiz/bin/data/BizDataSql.php
- go to line 237
- replace the line with:
$xtable = $assoc["XTable"];
Thanks for reporting and troubleshooting.
Cheers,
Daniel
On 23/03/15 02:52, canuck15 wrote:
I think I found the root cause.
Siremis database has a table called "group". That is a reserved
word in mysql that cannot be used as a table name.
http://dev.mysql.com/doc/refman/5.5/en/reserved-words.html
Do the following to prove it.
mysql
--
Daniel-Constantin Mierla
http://twitter.com/#!/miconda -http://www.linkedin.com/in/miconda
Kamailio World Conference, May 27-29, 2015
Berlin, Germany -http://www.kamailioworld.com
_______________________________________________
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
sr-users(a)lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users USE siremis;
SELECT * FROM group;
error
RENAME TABLE group TO group1;
SELECT * FROM group1;
no error
On 3/21/2015 4:39 PM, canuck15 wrote:
When you add/update/view Administrator usernames
To reproduce
Administration > User Management >
Click on any existing username. The browser goes blank.
Error in apache logs is:
PHP Fatal error: Call to a member function getQuoted() on a
non-object in /var/www/html/openbiz/bin/data/BizDataSql.php on line 237
This is on the latest Siremis v4.2.0 downloaded today
I am using CentOS v6.6, php v5.3.3
_______________________________________________
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
sr-users(a)lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users
24 Mar
24 Mar
2:59 a.m.
The right solution is to enclose the table name in between the
quotations marks that allow any value there, including the reserved
keywords.
In mysql you can use the back ticks, e.g:
SELECT * FROM `group`;
The above will just work. But is not standard SQL, just mysql specific.
That was the purpose of the getQuoted() function, which came as patch to
make siremis work with postgress. But apparently the patch was not
dealing with the association case. IIRC, postgress uses double quotes
instead of back ticks.
As a shorter fix would be using:
$xtable = "`" . $assoc["XTable"] . "`";
In this way, you don't need to rename the table and change the name of
it on php code.
Cheers,
Daniel
On 23/03/15 16:20, canuck15 wrote:
Ok, so the complete fix is:
edit ...openbiz/bin/data/BizDataSql.php
go to line 237
replace the line with.
$xtable = $assoc["XTable"];
mysql -p
--
Daniel-Constantin Mierla
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
Kamailio World Conference, May 27-29, 2015
Berlin, Germany - http://www.kamailioworld.com
USE siremis;
RENAME TABLE group TO grouptable;
Or pick some other new name for the group table.
edit ..siremis/modules/system/do
Go through all the files in that directory and change
Table="group"
To
Table="grouptable"
Or whatever the new name given to the group table is. Now it all
seems to work.
On 3/23/2015 7:03 AM, canuck15 wrote:
Hi,
I figured that part out which is when I got the database error about
the "group" table. So I will need to find where to change that table
name. I should have mentioned that.
On 3/23/2015 1:18 AM, Daniel-Constantin Mierla wrote:
_______________________________________________
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
sr-users(a)lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users The issue is calling a function which is not
member of the object
referred to.
We will look into fixing it properly, for the moment do following
changes:
- editi the file: /var/www/html/openbiz/bin/data/BizDataSql.php
- go to line 237
- replace the line with:
$xtable = $assoc["XTable"];
Thanks for reporting and troubleshooting.
Cheers,
Daniel
On 23/03/15 02:52, canuck15 wrote:
I think I found the root cause.
Siremis database has a table called "group". That is a reserved
word in mysql that cannot be used as a table name.
http://dev.mysql.com/doc/refman/5.5/en/reserved-words.html
Do the following to prove it.
mysql
> USE siremis;
> SELECT * FROM group;
error
> RENAME TABLE group TO group1;
> SELECT * FROM group1;
no error
On 3/21/2015 4:39 PM, canuck15 wrote:
> When you add/update/view Administrator usernames
>
> To reproduce
> Administration > User Management >
>
> Click on any existing username. The browser goes blank.
>
> Error in apache logs is:
> PHP Fatal error: Call to a member function getQuoted() on a
> non-object in /var/www/html/openbiz/bin/data/BizDataSql.php on
> line 237
> This is on the latest Siremis v4.2.0 downloaded today
>
> I am using CentOS v6.6, php v5.3.3
>
_______________________________________________
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
sr-users(a)lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users
--
Daniel-Constantin Mierla
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
Kamailio World Conference, May 27-29, 2015
Berlin, Germany - http://www.kamailioworld.com
_______________________________________________
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
sr-users(a)lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users
7:41 p.m.
Thanks for the suggestion.
It doesn't seem to work. It produces the following query.
SELECT T0.id, T0.name, T0.description FROM group T0 INNER JOIN
`user_group` TX ON TX.group_id = T0.id WHERE TX.user_id = '1'
On 3/23/2015 2:59 PM, Daniel-Constantin Mierla wrote:
The right solution is to enclose the table name in
between the
quotations marks that allow any value there, including the reserved
keywords.
In mysql you can use the back ticks, e.g:
SELECT * FROM `group`;
The above will just work. But is not standard SQL, just mysql
specific. That was the purpose of the getQuoted() function, which came
as patch to make siremis work with postgress. But apparently the patch
was not dealing with the association case. IIRC, postgress uses double
quotes instead of back ticks.
As a shorter fix would be using:
$xtable = "`" . $assoc["XTable"] . "`";
In this way, you don't need to rename the table and change the name of
it on php code.
Cheers,
Daniel
On 23/03/15 16:20, canuck15 wrote:
Ok, so the complete fix is:
edit ...openbiz/bin/data/BizDataSql.php
go to line 237
replace the line with.
$xtable = $assoc["XTable"];
mysql -p
--
Daniel-Constantin Mierla
http://twitter.com/#!/miconda -http://www.linkedin.com/in/miconda
Kamailio World Conference, May 27-29, 2015
Berlin, Germany -http://www.kamailioworld.com
_______________________________________________
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
sr-users(a)lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users USE siremis;
RENAME TABLE group TO grouptable;
Or pick some other new name for the group table.
edit ..siremis/modules/system/do
Go through all the files in that directory and change
Table="group"
To
Table="grouptable"
Or whatever the new name given to the group table is. Now it all
seems to work.
On 3/23/2015 7:03 AM, canuck15 wrote:
Hi,
I figured that part out which is when I got the database error about
the "group" table. So I will need to find where to change that
table name. I should have mentioned that.
On 3/23/2015 1:18 AM, Daniel-Constantin Mierla wrote:
_______________________________________________
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
sr-users(a)lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users The issue is calling a function which is not
member of the object
referred to.
We will look into fixing it properly, for the moment do following
changes:
- editi the file: /var/www/html/openbiz/bin/data/BizDataSql.php
- go to line 237
- replace the line with:
$xtable = $assoc["XTable"];
Thanks for reporting and troubleshooting.
Cheers,
Daniel
On 23/03/15 02:52, canuck15 wrote:
> I think I found the root cause.
>
> Siremis database has a table called "group". That is a reserved
> word in mysql that cannot be used as a table name.
> http://dev.mysql.com/doc/refman/5.5/en/reserved-words.html
>
> Do the following to prove it.
> mysql
> > USE siremis;
> > SELECT * FROM group;
>
> error
>
> > RENAME TABLE group TO group1;
> > SELECT * FROM group1;
>
> no error
>
> On 3/21/2015 4:39 PM, canuck15 wrote:
>> When you add/update/view Administrator usernames
>>
>> To reproduce
>> Administration > User Management >
>>
>> Click on any existing username. The browser goes blank.
>>
>> Error in apache logs is:
>> PHP Fatal error: Call to a member function getQuoted() on a
>> non-object in /var/www/html/openbiz/bin/data/BizDataSql.php on
>> line 237
>> This is on the latest Siremis v4.2.0 downloaded today
>>
>> I am using CentOS v6.6, php v5.3.3
>>
>
>
>
> _______________________________________________
> SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
> sr-users(a)lists.sip-router.org
> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users
--
Daniel-Constantin Mierla
http://twitter.com/#!/miconda -http://www.linkedin.com/in/miconda
Kamailio World Conference, May 27-29, 2015
Berlin, Germany -http://www.kamailioworld.com
_______________________________________________
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
sr-users(a)lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users
10:03 p.m.
I am having the same error here, applying the back ticks patch is not
working. Looks like the back ticks are not finding their way to the SQL
quesry, as I get this error:
[2015-03-24 16:41:38 (GMT)] An exception occurred while executing this
script:
Error message: #0, Error in query:: *SELECT T0.id, T0.name, T0.description
FROM group T0 INNER JOIN user_group TX ON TX.group_id = T0.id WHERE
TX.user_id = '1' LIMIT 10. SQLSTATE[42000]*: Syntax error or access
violation: 1064 You have an error in your SQL syntax; check the manual that
corresponds to your MySQL server version for the right syntax to use near
'group T0 INNER JOIN user_group TX ON TX.group_id = T0.id WHERE TX.user_id =
'1' at line 1
Script name and line number of error:
/var/www/siremis-4.2.0/openbiz/bin/data/BizDataObj_Lite.php:447
function: _run_search ( Array(2) ) @
/var/www/siremis-4.2.0/openbiz/bin/data/BizDataObj_Lite.php 243
function: fetch ( ) @ /var/www/siremis-4.2.0/openbiz/bin/easy/EasyForm.php
690
function: fetchDataSet ( ) @
/var/www/siremis-4.2.0/openbiz/bin/easy/FormRenderer.php 69
function: renderSmarty ( Object(EasyForm),
"/var/www/siremis-4.2.0/siremis/themes/default/template/system_ri..." ) @
/var/www/siremis-4.2.0/openbiz/bin/easy/FormRenderer.php 45
function: render ( Object(EasyForm) ) @
/var/www/siremis-4.2.0/openbiz/bin/easy/EasyForm.php 1648
function: renderHTML ( ) @
/var/www/siremis-4.2.0/openbiz/bin/easy/EasyForm.php 1538
function: render ( ) @
/var/www/siremis-4.2.0/openbiz/bin/easy/ViewRenderer.php 83
function: renderSmarty ( Object(EasyView),
"/var/www/siremis-4.2.0/siremis/themes/default/template/system_vi..." ) @
/var/www/siremis-4.2.0/openbiz/bin/easy/ViewRenderer.php 40
function: render ( Object(EasyView) ) @
/var/www/siremis-4.2.0/openbiz/bin/easy/EasyView.php 274
function: _render ( ) @ /var/www/siremis-4.2.0/openbiz/bin/easy/EasyView.php
237
function: render ( ) @ /var/www/siremis-4.2.0/openbiz/bin/BizController.php
221
function: renderView ( "system.view.UserDetailView", "", "",
Null, "" ) @
/var/www/siremis-4.2.0/openbiz/bin/BizController.php 107
function: dispatchRequest ( ) @
/var/www/siremis-4.2.0/openbiz/bin/BizController.php 32
function: include_once (
"/var/www/siremis-4.2.0/openbiz/bin/BizController.php" ) @
/var/www/siremis-4.2.0/siremis/bin/controller.php 6
function: include ( "/var/www/siremis-4.2.0/siremis/bin/controller.php" ) @
/var/www/siremis-4.2.0/siremis/bin/_forward.php 102
function: include ( "/var/www/siremis-4.2.0/siremis/bin/_forward.php" ) @
/var/www/siremis-4.2.0/siremis/index.php 3
FROM group doesn't show any back ticks.
Do I have to change the table name and the php code? I'm worried about
future upgrades, where these changes could be lost. Please advice, thanks.
J.
--
View this message in context:
http://sip-router.1086192.n5.nabble.com/Siremis-error-Call-to-a-member-func…
Sent from the Users mailing list archive at Nabble.com.
25 Mar
25 Mar
11:46 a.m.
Hello,
On 24/03/15 18:03, Janoz wrote:
I am having the same error here, applying the back
ticks patch is not
working. Looks like the back ticks are not finding their way to the SQL
quesry, as I get this error:
[2015-03-24 16:41:38 (GMT)] An exception occurred while executing this
script:
Error message: #0, Error in query:: *SELECT T0.id, T0.name, T0.description
FROM group T0 INNER JOIN user_group TX ON TX.group_id = T0.id WHERE
TX.user_id = '1' LIMIT 10. SQLSTATE[42000]*: Syntax error or access
violation: 1064 You have an error in your SQL syntax; check the manual that
corresponds to your MySQL server version for the right syntax to use near
'group T0 INNER JOIN user_group TX ON TX.group_id = T0.id WHERE TX.user_id =
'1' at line 1
Script name and line number of error:
/var/www/siremis-4.2.0/openbiz/bin/data/BizDataObj_Lite.php:447
function: _run_search ( Array(2) ) @
/var/www/siremis-4.2.0/openbiz/bin/data/BizDataObj_Lite.php 243
function: fetch ( ) @ /var/www/siremis-4.2.0/openbiz/bin/easy/EasyForm.php
690
function: fetchDataSet ( ) @
/var/www/siremis-4.2.0/openbiz/bin/easy/FormRenderer.php 69
function: renderSmarty ( Object(EasyForm),
"/var/www/siremis-4.2.0/siremis/themes/default/template/system_ri..." ) @
/var/www/siremis-4.2.0/openbiz/bin/easy/FormRenderer.php 45
function: render ( Object(EasyForm) ) @
/var/www/siremis-4.2.0/openbiz/bin/easy/EasyForm.php 1648
function: renderHTML ( ) @
/var/www/siremis-4.2.0/openbiz/bin/easy/EasyForm.php 1538
function: render ( ) @
/var/www/siremis-4.2.0/openbiz/bin/easy/ViewRenderer.php 83
function: renderSmarty ( Object(EasyView),
"/var/www/siremis-4.2.0/siremis/themes/default/template/system_vi..." ) @
/var/www/siremis-4.2.0/openbiz/bin/easy/ViewRenderer.php 40
function: render ( Object(EasyView) ) @
/var/www/siremis-4.2.0/openbiz/bin/easy/EasyView.php 274
function: _render ( ) @ /var/www/siremis-4.2.0/openbiz/bin/easy/EasyView.php
237
function: render ( ) @ /var/www/siremis-4.2.0/openbiz/bin/BizController.php
221
function: renderView ( "system.view.UserDetailView", "",
"", Null, "" ) @
/var/www/siremis-4.2.0/openbiz/bin/BizController.php 107
function: dispatchRequest ( ) @
/var/www/siremis-4.2.0/openbiz/bin/BizController.php 32
function: include_once (
"/var/www/siremis-4.2.0/openbiz/bin/BizController.php" ) @
/var/www/siremis-4.2.0/siremis/bin/controller.php 6
function: include ( "/var/www/siremis-4.2.0/siremis/bin/controller.php" ) @
/var/www/siremis-4.2.0/siremis/bin/_forward.php 102
function: include ( "/var/www/siremis-4.2.0/siremis/bin/_forward.php" ) @
/var/www/siremis-4.2.0/siremis/index.php 3
FROM group doesn't show any back ticks.
Do I have to change the table name and the php code? I'm worried about
future upgrades, where these changes could be lost. Please advice, thanks.
wrote in a previous mail, looks like there is another place returning
the "group" table name. The right fix is to find that one and escape the
table name with back ticks. That part of the code is part of the
phpopenbiz/cubi framework used to build siremis with. It will be
investigated and fixed with the next chance, now being caught is some
activity out of normal working schedule.
Cheers,
Daniel
--
Daniel-Constantin Mierla
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
Kamailio World Conference, May 27-29, 2015
Berlin, Germany - http://www.kamailioworld.com
3:37 p.m.
Thank you Daniel.
As correctly stated by canuck15, this problem arises by using the reserved
(in MySql) word "group" as a name of a table. You can circumvent this by
adding back ticks around this reserved word, but I'd rather change this
reserved word in a future release.
Anyway, the solution you suggested is correct, it was not functioning just
because the back ticks need to be added around the mainTable too. Here's a
quick-and-dirty patch:
Edit /var/www/siremis-4.2.0/openbiz/bin/data/BizDataSql.php (actual file
position may vary)
On line 295 (in bold below) add back ticks around $mainTable:
/**
* Add main table in the sql statement T0 alias
*
* @param string $mainTable main table name
* @return void
**/
public function addMainTable($mainTable)
{
$this->_mainTable = "$mainTable";
* $this->_tableJoins = " `$mainTable` T0 ";*
}
This will solve the error previously reported, but could leave some loophole
if the reserved word "group" ends up in another part of the SQL statement
(as constructed by BizDataSql.php
I'm sure there's a more elegant way to solve this, but for now it just
solved my problem.
J.
--
View this message in context:
http://sip-router.1086192.n5.nabble.com/Siremis-error-Call-to-a-member-func…
Sent from the Users mailing list archive at Nabble.com.
10:22 p.m.
Hello,
On 25/03/15 11:37, Janoz wrote:
Thank you Daniel.
As correctly stated by canuck15, this problem arises by using the reserved
(in MySql) word "group" as a name of a table. You can circumvent this by
adding back ticks around this reserved word, but I'd rather change this
reserved word in a future release.
that part is in the cubi/phpopenbiz, which is a rather older version by
now, so it might not make sense to update it anyhow, given it has the
features we wanted. New versions of that framework may have new features
that we don't need and upgrading to them will require additional effort
on 'siremis' specific extensions.
In conclusion, fixing for the moment in the siremis-distribution of
phpopenbiz should keep you safe, as we incorporate it anyhow (i.e., you
don't have to download it).
Actually, there is function getQuoted() that was introduced by a patch
submitted to siremis to make it work with other databases than mysql
(e.g., postgres -- this one doesn't like back ticks).
The initial error reported here was that the function getQuoted() was
not properly executed, not being a member of the association object. So
I propose to remove it and replace it with back ticks around the table
name as a quick fix, because I was not having time to investigate more
and make getQuoted() available in that part of the code.
But the right fix is to use getQuoted() for each table name, so I will
look at it and fix it with the first chance (some time this week).
Renaming the table is a solution, but in the future other existing table
name can be made reserved words by some sql servers. So might just work
for a while, that's why I prefer to have the solution with backticks or
what so ever enclosing is supported by the sql server to specify table
names.
Thanks for troubleshooting and providing further pointers with that
reserved table name.
Cheers,
Daniel
--
Daniel-Constantin Mierla
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
Kamailio World Conference, May 27-29, 2015
Berlin, Germany - http://www.kamailioworld.com
11:43 a.m.
Looks like there is another place used to return the "group" table name.
Once I get some time, I am going to look at the code and try to spot the
place where backticks have to be added for "group".
Cheers,
Daniel
On 24/03/15 15:41, canuck15 wrote:
Thanks for the suggestion.
It doesn't seem to work. It produces the following query.
SELECT T0.id, T0.name, T0.description FROM group T0 INNER JOIN
`user_group` TX ON TX.group_id = T0.id WHERE TX.user_id = '1'
On 3/23/2015 2:59 PM, Daniel-Constantin Mierla wrote:
--
Daniel-Constantin Mierla
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
Kamailio World Conference, May 27-29, 2015
Berlin, Germany - http://www.kamailioworld.com
The right solution is to enclose the table name
in between the
quotations marks that allow any value there, including the reserved
keywords.
In mysql you can use the back ticks, e.g:
SELECT * FROM `group`;
The above will just work. But is not standard SQL, just mysql
specific. That was the purpose of the getQuoted() function, which
came as patch to make siremis work with postgress. But apparently the
patch was not dealing with the association case. IIRC, postgress uses
double quotes instead of back ticks.
As a shorter fix would be using:
$xtable = "`" . $assoc["XTable"] . "`";
In this way, you don't need to rename the table and change the name
of it on php code.
Cheers,
Daniel
On 23/03/15 16:20, canuck15 wrote:
_______________________________________________
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
sr-users(a)lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users Ok, so the complete fix is:
edit ...openbiz/bin/data/BizDataSql.php
go to line 237
replace the line with.
$xtable = $assoc["XTable"];
mysql -p
--
Daniel-Constantin Mierla
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
Kamailio World Conference, May 27-29, 2015
Berlin, Germany - http://www.kamailioworld.com
_______________________________________________
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
sr-users(a)lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users USE siremis;
RENAME TABLE group TO grouptable;
Or pick some other new name for the group table.
edit ..siremis/modules/system/do
Go through all the files in that directory and change
Table="group"
To
Table="grouptable"
Or whatever the new name given to the group table is. Now it all
seems to work.
On 3/23/2015 7:03 AM, canuck15 wrote:
Hi,
I figured that part out which is when I got the database error
about the "group" table. So I will need to find where to change
that table name. I should have mentioned that.
On 3/23/2015 1:18 AM, Daniel-Constantin Mierla wrote:
> The issue is calling a function which is not member of the object
> referred to.
>
> We will look into fixing it properly, for the moment do following
> changes:
>
> - editi the file: /var/www/html/openbiz/bin/data/BizDataSql.php
> - go to line 237
> - replace the line with:
>
> $xtable = $assoc["XTable"];
>
> Thanks for reporting and troubleshooting.
>
> Cheers,
> Daniel
>
> On 23/03/15 02:52, canuck15 wrote:
>> I think I found the root cause.
>>
>> Siremis database has a table called "group". That is a reserved
>> word in mysql that cannot be used as a table name.
>> http://dev.mysql.com/doc/refman/5.5/en/reserved-words.html
>>
>> Do the following to prove it.
>> mysql
>> > USE siremis;
>> > SELECT * FROM group;
>>
>> error
>>
>> > RENAME TABLE group TO group1;
>> > SELECT * FROM group1;
>>
>> no error
>>
>> On 3/21/2015 4:39 PM, canuck15 wrote:
>>> When you add/update/view Administrator usernames
>>>
>>> To reproduce
>>> Administration > User Management >
>>>
>>> Click on any existing username. The browser goes blank.
>>>
>>> Error in apache logs is:
>>> PHP Fatal error: Call to a member function getQuoted() on a
>>> non-object in /var/www/html/openbiz/bin/data/BizDataSql.php on
>>> line 237
>>> This is on the latest Siremis v4.2.0 downloaded today
>>>
>>> I am using CentOS v6.6, php v5.3.3
>>>
>>
>>
>>
>> _______________________________________________
>> SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
>> sr-users(a)lists.sip-router.org
>> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users
>
> --
> Daniel-Constantin Mierla
> http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
> Kamailio World Conference, May 27-29, 2015
> Berlin, Germany - http://www.kamailioworld.com
>
>
> _______________________________________________
> SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
> sr-users(a)lists.sip-router.org
> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users
_______________________________________________
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
sr-users(a)lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users
3339
days inactive
3343
days old
11 comments
3 participants
participants (3)
-
canuck15 -
Daniel-Constantin Mierla -
Janoz