Hello,
the concern I have is that the return in the params of the result should be data, not a response code embedded in a form or another.
For example, if you do rpc list dispatcher records, then there is no return code, just the list of the records. The command was successful as well.
If the command is to reload the dispatcher records, then it is indeed no data returned. But the http return code is 200ok.
I don't see a benefit in embedded the return code in the returned structure, in my opinion that is not the purpose of the rpc response structure. If there is an error, then the fault code is returned, based on xmlrpc specs.
If there are people that want to embed return code, I am fine as long as:
- that is made a configuration option. - it is made consistent somehow across all commands, so one would know what to expect.
I would also try to see if other well established applications (not sip related) do for similar cases with rpc.
Cheers, Daniel
On 01/04/16 14:20, Yasin CANER wrote:
Hello; Xml rpc is useful module for kamailio that improve flexibility and can help to addons. But there is a little problem about it when use non-value response that reply empty xml or no response so there isnt ack about what happened after command sends. at least need a "OK" for acknowledgement. i can accept that there is a fault reply and it is useful with return code and description. after looking http://xmlrpc.scripting.com/spec.html webpage , there isnt any spec about "OK" . if you ask where it uses; For example , after module reloads or terminating dialog which callid. I think it is good when realtime reload in Kamailio Version 5 can be reload by remotly. it can reply which module reloaded correctly , which doesnt.What do you think about it?
Thanks
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list sr-users@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users
Hello Daniel; when i have a look xml spec , you are clearly right. there is no point about it. but i want to one more example about it. When we coding about it, my programmers ask me after send request reload/terminate dialog, "What happened now?" , no response? Because they are used to use "asterisk ami" that returns a description or data about it, "channel hung up , reloaded" and etc(of course it isnt rpc) ..
Thanks.
-- View this message in context: http://sip-router.1086192.n5.nabble.com/about-xml-rpc-response-behavior-tp14... Sent from the Users mailing list archive at Nabble.com.
Hello,
I added this to the topics to be discussed today during the Kamailio devel meeting on IRC:
- https://www.kamailio.org/wiki/devel/irc-meetings/2016a
If you can, you should join to express your opinions there.
Cheers, Daniel
On 06/04/16 08:09, ycaner wrote:
Hello Daniel; when i have a look xml spec , you are clearly right. there is no point about it. but i want to one more example about it. When we coding about it, my programmers ask me after send request reload/terminate dialog, "What happened now?" , no response? Because they are used to use "asterisk ami" that returns a description or data about it, "channel hung up , reloaded" and etc(of course it isnt rpc) ..
Thanks.
-- View this message in context: http://sip-router.1086192.n5.nabble.com/about-xml-rpc-response-behavior-tp14... Sent from the Users mailing list archive at Nabble.com.
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list sr-users@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users
Hello Daniel; Thanks , i hope i will be there.
21.04.2016 08:47 tarihinde Daniel-Constantin Mierla-6 [via SIP Router] yazdı:
Hello,
I added this to the topics to be discussed today during the Kamailio
devel meeting on IRC:
- https://www.kamailio.org/wiki/devel/irc-meetings/2016a
If you can, you should join to express your opinions there.
Cheers,
Daniel
On 06/04/16 08:09, ycaner wrote:
> Hello Daniel;
> when i have a look xml spec , you are clearly right. there is no point about
> it. but i want to one more example about it. When we coding about it, my
> programmers ask me after send request reload/terminate dialog, "What
> happened now?" , no response? Because they are used to use "asterisk ami"
> that returns a description or data about it, "channel hung up , reloaded"
> and etc(of course it isnt rpc) .. >
> Thanks.
>
>
>
>
> --
> View this message in context: http://sip-router.1086192.n5.nabble.com/about-xml-rpc-response-behavior-tp14... > Sent from the Users mailing list archive at Nabble.com.
>
> _______________________________________________
> SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
> [hidden email]
> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users
-- Daniel-Constantin Mierla
http://www.asipto.com http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda Kamailio World Conference, Berlin, May 18-20, 2016 - http://www.kamailioworld.com
_______________________________________________
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
[hidden email]
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users
If you reply to this email, your message will be added to the discussion below: http://sip-router.1086192.n5.nabble.com/about-xml-rpc-response-behavior-tp14...
To unsubscribe from about xml rpc response behavior, click here . NAML
--
yasin-imza-2014.jpg (51K) http://sip-router.1086192.n5.nabble.com/attachment/147679/0/yasin-imza-2014.jpg
-- View this message in context: http://sip-router.1086192.n5.nabble.com/about-xml-rpc-response-behavior-tp14... Sent from the Users mailing list archive at Nabble.com.
-
Daniel-Constantin Mierla -
Yasin CANER -
ycaner