On Monday 25 February 2008, Arturo Díaz Almagro wrote:
Please, see my comments below.
[..] For recent mysql driver versions this is not needed anymore, i've committed in revision 3606 a improvement to the trunk version of openser that uses the recently introduced extensions in the mysql lib. This could be easily backported to your version, take a look into the mysql documentation if this different timeouts are supported on your driver version.
Does that mean that I could compile the mysql module in the trunk version and replace the old mysql.so module by the new generated one from the trunk? Is it fully backward compatible?
Kind regards.
Hi Arturo Díaz Almagro,
(lets continue this discussion on the user list)
No, but this will not work at all. Even replacing the code and recompile will not work, the changes were to extensive. You need to backport the changes from the mentioned revision to the driver you use internally in your company. You could get the changes with 'svn diff' or search on the devel list for the commit message.
Cheers,
Henning
Hi all,
I am going to try to backport the changes in the trunk version of the db management to openser 1.2 branch. I have performed a diff and found new files and significant changes in some others. My main concern is related with the problem exposed so I only would like to modify the part of the code that fixes the problem.
I would be please if anyone could help me to locate that part of the code. After testing and confirmation from the people who mantains this portion of OpenSER I will share the changes.
Kind regards.
2008/2/25, Henning Westerholt henning.westerholt@1und1.de:
On Monday 25 February 2008, Arturo Díaz Almagro wrote:
Please, see my comments below.
[..]
For recent mysql driver versions this is not needed anymore, i've committed in revision 3606 a improvement to the trunk version of
openser
that uses the recently introduced extensions in the mysql lib. This
could
be easily backported to your version, take a look into the mysql documentation if this different timeouts are supported on your driver version.
Does that mean that I could compile the mysql module in the trunk
version
and replace the old mysql.so module by the new generated one from the trunk? Is it fully backward compatible?
Kind regards.
Hi Arturo Díaz Almagro,
(lets continue this discussion on the user list)
No, but this will not work at all. Even replacing the code and recompile will not work, the changes were to extensive. You need to backport the changes from the mentioned revision to the driver you use internally in your company. You could get the changes with 'svn diff' or search on the devel list for the commit message.
Cheers,
Henning
On Tuesday 26 February 2008, Arturo Díaz Almagro wrote:
I am going to try to backport the changes in the trunk version of the db management to openser 1.2 branch. I have performed a diff and found new files and significant changes in some others. My main concern is related with the problem exposed so I only would like to modify the part of the code that fixes the problem.
I would be please if anyone could help me to locate that part of the code. After testing and confirmation from the people who mantains this portion of OpenSER I will share the changes.
Hi Arturo Díaz Almagro,
as i stated in a previous mail, you only need to port the changes in revision 3606 of the trunk. I did also a few renames of variables and functions, but basically the only thing you will need is to add:
// set connect, read and write timeout, the value counts three times mysql_options(ptr->con, MYSQL_OPT_CONNECT_TIMEOUT, (const char *) &db_mysql_timeout_interval); mysql_options(ptr->con, MYSQL_OPT_READ_TIMEOUT, (const char *) &db_mysql_timeout_interval); mysql_options(ptr->con, MYSQL_OPT_WRITE_TIMEOUT, (const char *)&db_mysql_timeout_interval);
to the database driver initialization. Take a look at the changes in this revision to get an idea. Probably it will also work to just apply the changes in revision 3606 to the 1.3 mysql driver. I don't recommend to apply other/ more changes from the trunk.
Cheers,
Henning
-
Arturo Díaz Almagro -
Henning Westerholt