FW: Module TOPOH: Does not unmask CALL-ID on request BYE in one direction
Hi, We are setting up a Kamailio Proxy with the Topoh module in place masking everything including CALL-ID. It seems to be masking everything just fine except for CALL-ID in BYE requests (verified with PCAPs) when received from downstream. Upstream works fine. Looking at the source code for the module 4.1.2 we see the unmasking being done like this: if(dialog) { /* dialog request */ th_unmask_ruri(&msg); th_unmask_route(&msg); th_unmask_refer_to(&msg); if(direction==1) { th_unmask_callid(&msg); } } It only seems to be unmasking for one direction. From my understanding BYE can be initated from both directions? Might be something I don’t understand here how the source code works but I wanted to ask for any pointers of help here.. been troubleshooting this for a good while now. Kind regards, Samuel
Hello, the call-id is set by caller (upstream), thus is not masked when it is sent by that endpoint. When it is coming from callee (downstream), it is masked, so it has to be unmasked before sending to upstream. Am I appreciating something wrong here? direction=1 is set when the callee sends a request. Can you send the logs with debug=3 for such a BYE? Cheers, Daniel On 20/03/14 15:02, Samuel F. wrote:
Hi, We are setting up a Kamailio Proxy with the Topoh module in place masking everything including CALL-ID. It seems to be masking everything just fine except for CALL-ID in BYE requests (verified with PCAPs) when received from downstream. Upstream works fine. Looking at the source code for the module 4.1.2 we see the unmasking being done like this: if(dialog) { /* dialog request */ th_unmask_ruri(&msg); th_unmask_route(&msg); th_unmask_refer_to(&msg); if(direction==1) { th_unmask_callid(&msg); } } It only seems to be unmasking for one direction. From my understanding BYE can be initated from both directions? Might be something I don’t understand here how the source code works but I wanted to ask for any pointers of help here.. been troubleshooting this for a good while now. Kind regards, Samuel
_______________________________________________ SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list sr-users@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users
-- Daniel-Constantin Mierla - http://www.asipto.com http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda Kamailio World Conference - April 2-4, 2014, Berlin, Germany http://www.kamailioworld.com
I got the same issue, below modparam worked for me to manipulate the direction correctly, you need to add the following parameter modparam("rr", "append_fromtag", 1) which will add ftag param in the record-route header ----- Thanks Varadhan M -- View this message in context: http://sip-router.1086192.n5.nabble.com/FW-Module-TOPOH-Does-not-unmask-CALL... Sent from the Users mailing list archive at Nabble.com.
participants (3)
-
Daniel-Constantin Mierla -
Samuel F. -
Varadhan