On Thursday 07 March 2013 12:13:50 Alex Balashov wrote: That was the conclusion for my question with multiple calls to uac_replace* Both from and to may only be called once, else the results will be unpredictable.

Calling multiple times with msg_apply_changes() will still result in the stateful restoration of the original From in requests and replies going back to the originating side?

Daniel-Constantin Mierla <miconda(a)gmail.com> wrote: > On 3/11/13 11:37 AM, Daniel Tryba wrote: >> On Thursday 07 March 2013 12:13:50 Alex Balashov wrote: >>> I realise that one logical possibility is to store the desired value > in >>> a variable, manipulate it as needed throughout the request > processing >>> flow, and just call uac_replace_from() once, at the end. >> That was the conclusion for my question with multiple calls to > uac_replace* >> Both from and to may only be called once, else the results will be >> unpredictable. > Calling multiple times is ok with msg_apply_changes(), if you don-t > break something else. Otherwise, the safe way is to use variables and > update the header in branch route. > > Cheers, > Daniel

If you create dialog before and use the implementation that relies on dialog variables [1], it is safe to call uac_replace_from() multiple times on the same message, or even the same initial message but looped. The module will detect that uac_replace_from() was called multiple times on the same dialog by searching after the dialog vars it has stored and it will work correctly. This is the usage that we tested and is ok. With the old implementation based on RR param, I don't think it works right calling it multiple times on the same message.