23 Aug
2019
23 Aug
'19
6:53 p.m.
Hello!
I have notice some issues with lookup(aliases) since I upgraded to 5.2 from
5.1:
First with kamctl: If this default command is executed:
ctl_cmd_run ul.add "$USRLOC_TABLE" "$OSERUSER@$OSERDOMAIN"
"$2" \
"$UL_EXPIRES" "$DEFAULT_Q" "$UL_PATH" "$UL_FLAGS"
"$BR_FLAGS" "$ALL_METHODS"
as $ALL_METHODS is not defined, there is a huge value in methods and then
lookup(aliases) fails with -2.
I have to update kamctl script and put -1 ("-1") instead of the variable.
So, now, methods is a NULL value in DB and my alias is not ignored. But I
use to make my alias like this: sip:number@blabla_1.local
Which is no longer works: ERROR: registrar [common.c:62]: extract_aor():
failed to parse AoR [sip:number@blabla_1.local]
Any idea of the difference since 5.2 with this behaviour? Without the
underscore, the AoR seems to be valid but I need to support underscore as
before.
Regards,
Igor.
27 Aug
27 Aug
9:27 a.m.
Hello!
Any help on that matter? Sounds like the domain parsing have been updated.
Is it possible to back on the previous mode?
Regards,
Igor.
De : igor.potjevlesch(a)gmail.com <igor.potjevlesch(a)gmail.com>
Envoyé : vendredi 23 août 2019 18:53
À : 'Kamailio (SER) - Users Mailing List' <sr-users(a)lists.kamailio.org>
Objet : lookup(aliases) issues with 5.2
Hello!
I have notice some issues with lookup(aliases) since I upgraded to 5.2 from
5.1:
First with kamctl: If this default command is executed:
ctl_cmd_run ul.add "$USRLOC_TABLE" "$OSERUSER@$OSERDOMAIN"
"$2" \
"$UL_EXPIRES" "$DEFAULT_Q" "$UL_PATH" "$UL_FLAGS"
"$BR_FLAGS" "$ALL_METHODS"
as $ALL_METHODS is not defined, there is a huge value in methods and then
lookup(aliases) fails with -2.
I have to update kamctl script and put -1 ("-1") instead of the variable.
So, now, methods is a NULL value in DB and my alias is not ignored. But I
use to make my alias like this: sip:number@blabla_1.local
Which is no longer works: ERROR: registrar [common.c:62]: extract_aor():
failed to parse AoR [sip:number@blabla_1.local]
Any idea of the difference since 5.2 with this behaviour? Without the
underscore, the AoR seems to be valid but I need to support underscore as
before.
Regards,
Igor.
9:39 a.m.
Hello,
On 27.08.19 09:27, igor.potjevlesch(a)gmail.com wrote:
Hello!
Any help on that matter? Sounds like the domain parsing have been
updated. Is it possible to back on the previous mode?
did you mean backporting to older branches? If yes, it was done to
branch 5.2, have you tried with latest version in that branch?
Cheers,
Daniel
Regards,
Igor.
*De :*igor.potjevlesch@gmail.com <igor.potjevlesch(a)gmail.com>
*Envoyé :* vendredi 23 août 2019 18:53
*À :* 'Kamailio (SER) - Users Mailing List' <sr-users(a)lists.kamailio.org>
*Objet :* lookup(aliases) issues with 5.2
Hello!
I have notice some issues with lookup(aliases) since I upgraded to 5.2
from 5.1:
First with kamctl: If this default command is executed:
ctl_cmd_run ul.add "$USRLOC_TABLE" "$OSERUSER@$OSERDOMAIN"
"$2" \
"$UL_EXPIRES" "$DEFAULT_Q" "$UL_PATH" "$UL_FLAGS"
"$BR_FLAGS"
"$ALL_METHODS"
as $ALL_METHODS is not defined, there is a huge value in methods and
then lookup(aliases) fails with -2.
I have to update kamctl script and put -1 ("-1") instead of the
variable. So, now, methods is a NULL value in DB and my alias is not
ignored. But I use to make my alias like this: sip:number@blabla_1.local
Which is no longer works: ERROR: registrar [common.c:62]:
extract_aor(): failed to parse AoR [sip:number@blabla_1.local]
Any idea of the difference since 5.2 with this behaviour? Without the
underscore, the AoR seems to be valid but I need to support underscore
as before.
Regards,
Igor.
_______________________________________________
Kamailio (SER) - Users Mailing List
sr-users(a)lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users
--
Daniel-Constantin Mierla -- www.asipto.com
www.twitter.com/miconda -- www.linkedin.com/in/miconda
11:53 a.m.
Hello Daniel,
Thank you for getting back to me.
We will update with 5.2.4 and I'll let you know if it's solved.
Regards,
Igor.
De : Daniel-Constantin Mierla <miconda(a)gmail.com>
Envoyé : mardi 27 août 2019 09:39
À : Kamailio (SER) - Users Mailing List <sr-users(a)lists.kamailio.org>rg>;
igor.potjevlesch(a)gmail.com
Objet : Re: [SR-Users] lookup(aliases) issues with 5.2
Hello,
On 27.08.19 09:27, igor.potjevlesch(a)gmail.com
<mailto:igor.potjevlesch@gmail.com> wrote:
Hello!
Any help on that matter? Sounds like the domain parsing have been updated.
Is it possible to back on the previous mode?
did you mean backporting to older branches? If yes, it was done to branch
5.2, have you tried with latest version in that branch?
Cheers,
Daniel
Regards,
Igor.
De : igor.potjevlesch(a)gmail.com <mailto:igor.potjevlesch@gmail.com>
<mailto:igor.potjevlesch@gmail.com> <igor.potjevlesch(a)gmail.com>
Envoyé : vendredi 23 août 2019 18:53
À : 'Kamailio (SER) - Users Mailing List'
<mailto:sr-users@lists.kamailio.org> <sr-users(a)lists.kamailio.org>
Objet : lookup(aliases) issues with 5.2
Hello!
I have notice some issues with lookup(aliases) since I upgraded to 5.2 from
5.1:
First with kamctl: If this default command is executed:
ctl_cmd_run ul.add "$USRLOC_TABLE" "$OSERUSER@$OSERDOMAIN"
"$2" \
"$UL_EXPIRES" "$DEFAULT_Q" "$UL_PATH" "$UL_FLAGS"
"$BR_FLAGS" "$ALL_METHODS"
as $ALL_METHODS is not defined, there is a huge value in methods and then
lookup(aliases) fails with -2.
I have to update kamctl script and put -1 ("-1") instead of the variable.
So, now, methods is a NULL value in DB and my alias is not ignored. But I
use to make my alias like this: sip:number@blabla_1.local
Which is no longer works: ERROR: registrar [common.c:62]: extract_aor():
failed to parse AoR [sip:number@blabla_1.local]
Any idea of the difference since 5.2 with this behaviour? Without the
underscore, the AoR seems to be valid but I need to support underscore as
before.
Regards,
Igor.
_______________________________________________
Kamailio (SER) - Users Mailing List
sr-users(a)lists.kamailio.org <mailto:sr-users@lists.kamailio.org>
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users
--
Daniel-Constantin Mierla -- www.asipto.com <http://www.asipto.com>
www.twitter.com/miconda <http://www.twitter.com/miconda> --
www.linkedin.com/in/miconda <http://www.linkedin.com/in/miconda>
28 Aug
28 Aug
10:12 a.m.
Hello Daniel,
We moved to the latest 5.2.4 but hostname with underscore are still not
handle properly.
Is it a real design choice or a mistake somewhere in the code that handle
domain name?
Regards,
Igor.
De : igor.potjevlesch(a)gmail.com <igor.potjevlesch(a)gmail.com Envoyé : mardi 27 août 2019 11:53
À : miconda(a)gmail.com; 'Kamailio (SER) - Users Mailing List'
<sr-users(a)lists.kamailio.org>
Objet : RE: [SR-Users] lookup(aliases) issues with 5.2
Hello Daniel,
Thank you for getting back to me.
We will update with 5.2.4 and I'll let you know if it's solved.
Regards,
Igor.
De : Daniel-Constantin Mierla <miconda(a)gmail.com <mailto:miconda@gmail.com>
Envoyé : mardi 27 août 2019 09:39
À : Kamailio (SER) - Users Mailing List <sr-users(a)lists.kamailio.org
<mailto:sr-users@lists.kamailio.org> >; igor.potjevlesch(a)gmail.com
<mailto:igor.potjevlesch@gmail.com
Objet : Re: [SR-Users] lookup(aliases) issues with 5.2
Hello,
On 27.08.19 09:27, igor.potjevlesch(a)gmail.com
<mailto:igor.potjevlesch@gmail.com> wrote:
Hello!
Any help on that matter? Sounds like the domain parsing have been updated.
Is it possible to back on the previous mode?
did you mean backporting to older branches? If yes, it was done to branch
5.2, have you tried with latest version in that branch?
Cheers,
Daniel
Regards,
Igor.
De : igor.potjevlesch(a)gmail.com <mailto:igor.potjevlesch@gmail.com>
<mailto:igor.potjevlesch@gmail.com> <igor.potjevlesch(a)gmail.com Envoyé : vendredi 23 août 2019 18:53
À : 'Kamailio (SER) - Users Mailing List'
<mailto:sr-users@lists.kamailio.org> <sr-users(a)lists.kamailio.org>
Objet : lookup(aliases) issues with 5.2
Hello!
I have notice some issues with lookup(aliases) since I upgraded to 5.2 from
5.1:
First with kamctl: If this default command is executed:
ctl_cmd_run ul.add "$USRLOC_TABLE" "$OSERUSER@$OSERDOMAIN"
"$2" \
"$UL_EXPIRES" "$DEFAULT_Q" "$UL_PATH" "$UL_FLAGS"
"$BR_FLAGS" "$ALL_METHODS"
as $ALL_METHODS is not defined, there is a huge value in methods and then
lookup(aliases) fails with -2.
I have to update kamctl script and put -1 ("-1") instead of the variable.
So, now, methods is a NULL value in DB and my alias is not ignored. But I
use to make my alias like this: sip:number@blabla_1.local
Which is no longer works: ERROR: registrar [common.c:62]: extract_aor():
failed to parse AoR [sip:number@blabla_1.local]
Any idea of the difference since 5.2 with this behaviour? Without the
underscore, the AoR seems to be valid but I need to support underscore as
before.
Regards,
Igor.
_______________________________________________
Kamailio (SER) - Users Mailing List
sr-users(a)lists.kamailio.org <mailto:sr-users@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users
--
Daniel-Constantin Mierla -- www.asipto.com <http://www.asipto.com www.twitter.com/miconda
<http://www.twitter.com/miconda> --
www.linkedin.com/in/miconda <http://www.linkedin.com/in/miconda
10:25 a.m.
Hello,
reading again I see that the error with the host uri is printed from the
C code. I thought of another issue that was reported related to IPv6
addresses in the URI that kamctl rejected.
The problem is that the underscore is not allowed in hostname: the
relevant standard is RFC 1123, section 2.1 "Host Names and Numbers"
which limits host names to letters-digits-hyphen.
I checked the commits log and it seems this more strict verification was
added by next commit:
commit 4994960324d5353222b3de08515bed07802ab7bc
Author: Juha Heinanen <jh(a)tutpro.com>
Date: Wed Jan 10 08:39:48 2018 +0200
core/parser: more strict parsing of sip uri host
Regarding the $ALL_METHODS not being defined, iirc, you should set it to
. (or maybe -1 in this case).
Cheers,
Daniel
On 28.08.19 10:12, igor.potjevlesch(a)gmail.com wrote:
Hello Daniel,
We moved to the latest 5.2.4 but hostname with underscore are still
not handle properly.
Is it a real design choice or a mistake somewhere in the code that
handle domain name?
Regards,
Igor.
*De :*igor.potjevlesch@gmail.com <igor.potjevlesch(a)gmail.com>
*Envoyé :* mardi 27 août 2019 11:53
*À :* miconda(a)gmail.com; 'Kamailio (SER) - Users Mailing List'
<sr-users(a)lists.kamailio.org>
*Objet :* RE: [SR-Users] lookup(aliases) issues with 5.2
Hello Daniel,
Thank you for getting back to me.
We will update with 5.2.4 and I'll let you know if it's solved.
Regards,
Igor.
*De :*Daniel-Constantin Mierla <miconda(a)gmail.com
<mailto:miconda@gmail.com>>
*Envoyé :* mardi 27 août 2019 09:39
*À :* Kamailio (SER) - Users Mailing List <sr-users(a)lists.kamailio.org
<mailto:sr-users@lists.kamailio.org>>; igor.potjevlesch(a)gmail.com
<mailto:igor.potjevlesch@gmail.com>
*Objet :* Re: [SR-Users] lookup(aliases) issues with 5.2
Hello,
On 27.08.19 09:27, igor.potjevlesch(a)gmail.com
<mailto:igor.potjevlesch@gmail.com> wrote:
Hello!
Any help on that matter? Sounds like the domain parsing have been
updated. Is it possible to back on the previous mode?
did you mean backporting to older branches? If yes, it was done to
branch 5.2, have you tried with latest version in that branch?
Cheers,
Daniel
Regards,
Igor.
*De :*igor.potjevlesch@gmail.com
<mailto:igor.potjevlesch@gmail.com> <igor.potjevlesch(a)gmail.com>
<mailto:igor.potjevlesch@gmail.com>
*Envoyé :* vendredi 23 août 2019 18:53
*À :* 'Kamailio (SER) - Users Mailing List'
<sr-users(a)lists.kamailio.org> <mailto:sr-users@lists.kamailio.org>
*Objet :* lookup(aliases) issues with 5.2
Hello!
I have notice some issues with lookup(aliases) since I upgraded to
5.2 from 5.1:
First with kamctl: If this default command is executed:
ctl_cmd_run ul.add "$USRLOC_TABLE" "$OSERUSER@$OSERDOMAIN"
"$2" \
"$UL_EXPIRES" "$DEFAULT_Q" "$UL_PATH"
"$UL_FLAGS" "$BR_FLAGS"
"$ALL_METHODS"
as $ALL_METHODS is not defined, there is a huge value in methods
and then lookup(aliases) fails with -2.
I have to update kamctl script and put -1 ("-1") instead of the
variable. So, now, methods is a NULL value in DB and my alias is
not ignored. But I use to make my alias like this:
sip:number@blabla_1.local
Which is no longer works: ERROR: registrar [common.c:62]:
extract_aor(): failed to parse AoR [sip:number@blabla_1.local]
Any idea of the difference since 5.2 with this behaviour? Without
the underscore, the AoR seems to be valid but I need to support
underscore as before.
Regards,
Igor.
_______________________________________________
Kamailio (SER) - Users Mailing List
sr-users(a)lists.kamailio.org <mailto:sr-users@lists.kamailio.org>
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users
--
Daniel-Constantin Mierla -- www.asipto.com <http://www.asipto.com>
www.twitter.com/miconda <http://www.twitter.com/miconda> --
www.linkedin.com/in/miconda <http://www.linkedin.com/in/miconda>
--
Daniel-Constantin Mierla -- www.asipto.com
www.twitter.com/miconda -- www.linkedin.com/in/miconda
3:34 p.m.
Hello,
Hmm, ok. Saw it.
Is it possible to reconsider a less strict control?
Regards,
Igor.
De : Daniel-Constantin Mierla <miconda(a)gmail.com
Envoyé : mercredi 28 août 2019 10:25
À : igor.potjevlesch(a)gmail.com; 'Kamailio (SER) - Users Mailing List'
<sr-users(a)lists.kamailio.org>
Objet : Re: [SR-Users] lookup(aliases) issues with 5.2
Hello,
reading again I see that the error with the host uri is printed from the C
code. I thought of another issue that was reported related to IPv6 addresses
in the URI that kamctl rejected.
The problem is that the underscore is not allowed in hostname: the relevant
standard is RFC 1123, section 2.1 "Host Names and Numbers" which limits host
names to letters-digits-hyphen.
I checked the commits log and it seems this more strict verification was
added by next commit:
commit 4994960324d5353222b3de08515bed07802ab7bc
Author: Juha Heinanen <mailto:jh@tutpro.com> <jh(a)tutpro.com>
Date: Wed Jan 10 08:39:48 2018 +0200
core/parser: more strict parsing of sip uri host
Regarding the $ALL_METHODS not being defined, iirc, you should set it to .
(or maybe -1 in this case).
Cheers,
Daniel
On 28.08.19 10:12, igor.potjevlesch(a)gmail.com
<mailto:igor.potjevlesch@gmail.com> wrote:
Hello Daniel,
We moved to the latest 5.2.4 but hostname with underscore are still not
handle properly.
Is it a real design choice or a mistake somewhere in the code that handle
domain name?
Regards,
Igor.
De : igor.potjevlesch(a)gmail.com <mailto:igor.potjevlesch@gmail.com>
<mailto:igor.potjevlesch@gmail.com> <igor.potjevlesch(a)gmail.com Envoyé : mardi 27 août 2019 11:53
À : miconda(a)gmail.com <mailto:miconda@gmail.com> ; 'Kamailio (SER) - Users
Mailing List' <mailto:sr-users@lists.kamailio.org>
<sr-users(a)lists.kamailio.org>
Objet : RE: [SR-Users] lookup(aliases) issues with 5.2
Hello Daniel,
Thank you for getting back to me.
We will update with 5.2.4 and I'll let you know if it's solved.
Regards,
Igor.
De : Daniel-Constantin Mierla <miconda(a)gmail.com <mailto:miconda@gmail.com>
Envoyé : mardi 27 août 2019 09:39
À : Kamailio (SER) - Users Mailing List <sr-users(a)lists.kamailio.org
<mailto:sr-users@lists.kamailio.org> >; igor.potjevlesch(a)gmail.com
<mailto:igor.potjevlesch@gmail.com
Objet : Re: [SR-Users] lookup(aliases) issues with 5.2
Hello,
On 27.08.19 09:27, igor.potjevlesch(a)gmail.com
<mailto:igor.potjevlesch@gmail.com> wrote:
Hello!
Any help on that matter? Sounds like the domain parsing have been updated.
Is it possible to back on the previous mode?
did you mean backporting to older branches? If yes, it was done to branch
5.2, have you tried with latest version in that branch?
Cheers,
Daniel
Regards,
Igor.
De : igor.potjevlesch(a)gmail.com <mailto:igor.potjevlesch@gmail.com>
<mailto:igor.potjevlesch@gmail.com> <igor.potjevlesch(a)gmail.com Envoyé : vendredi 23 août 2019 18:53
À : 'Kamailio (SER) - Users Mailing List'
<mailto:sr-users@lists.kamailio.org> <sr-users(a)lists.kamailio.org>
Objet : lookup(aliases) issues with 5.2
Hello!
I have notice some issues with lookup(aliases) since I upgraded to 5.2 from
5.1:
First with kamctl: If this default command is executed:
ctl_cmd_run ul.add "$USRLOC_TABLE" "$OSERUSER@$OSERDOMAIN"
"$2" \
"$UL_EXPIRES" "$DEFAULT_Q" "$UL_PATH" "$UL_FLAGS"
"$BR_FLAGS" "$ALL_METHODS"
as $ALL_METHODS is not defined, there is a huge value in methods and then
lookup(aliases) fails with -2.
I have to update kamctl script and put -1 ("-1") instead of the variable.
So, now, methods is a NULL value in DB and my alias is not ignored. But I
use to make my alias like this: sip:number@blabla_1.local
Which is no longer works: ERROR: registrar [common.c:62]: extract_aor():
failed to parse AoR [sip:number@blabla_1.local]
Any idea of the difference since 5.2 with this behaviour? Without the
underscore, the AoR seems to be valid but I need to support underscore as
before.
Regards,
Igor.
_______________________________________________
Kamailio (SER) - Users Mailing List
sr-users(a)lists.kamailio.org <mailto:sr-users@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users
--
Daniel-Constantin Mierla -- www.asipto.com <http://www.asipto.com www.twitter.com/miconda
<http://www.twitter.com/miconda> --
www.linkedin.com/in/miconda <http://www.linkedin.com/in/miconda
--
Daniel-Constantin Mierla -- www.asipto.com <http://www.asipto.com www.twitter.com/miconda
<http://www.twitter.com/miconda> --
www.linkedin.com/in/miconda <http://www.linkedin.com/in/miconda
7:14 p.m.
Hello Igor,
the problem is that this code belongs to the core parser part, it is not something usrloc
module related.
If you need a workaround, probably the easist and fastest option would be to just build an
own kamailio without this change (e.g. apply the patch in reverse mode).
Cheers,
Henning
Am 28.08.19 um 15:34 schrieb
igor.potjevlesch@gmail.com<mailto:igor.potjevlesch@gmail.com>:
Hello,
Hmm, ok. Saw it.
Is it possible to reconsider a less strict control?
Regards,
Igor.
De : Daniel-Constantin Mierla <miconda@gmail.com><mailto:miconda@gmail.com>
Envoyé : mercredi 28 août 2019 10:25
À : igor.potjevlesch@gmail.com<mailto:igor.potjevlesch@gmail.com>; 'Kamailio
(SER) - Users Mailing List'
<sr-users@lists.kamailio.org><mailto:sr-users@lists.kamailio.org>
Objet : Re: [SR-Users] lookup(aliases) issues with 5.2
Hello,
reading again I see that the error with the host uri is printed from the C code. I thought
of another issue that was reported related to IPv6 addresses in the URI that kamctl
rejected.
The problem is that the underscore is not allowed in hostname: the relevant standard is
RFC 1123, section 2.1 "Host Names and Numbers" which limits host names to
letters-digits-hyphen.
I checked the commits log and it seems this more strict verification was added by next
commit:
commit 4994960324d5353222b3de08515bed07802ab7bc
Author: Juha Heinanen <jh@tutpro.com><mailto:jh@tutpro.com>
Date: Wed Jan 10 08:39:48 2018 +0200
core/parser: more strict parsing of sip uri host
Regarding the $ALL_METHODS not being defined, iirc, you should set it to . (or maybe -1 in
this case).
Cheers,
Daniel
On 28.08.19 10:12, igor.potjevlesch@gmail.com<mailto:igor.potjevlesch@gmail.com>
wrote:
Hello Daniel,
We moved to the latest 5.2.4 but hostname with underscore are still not handle properly.
Is it a real design choice or a mistake somewhere in the code that handle domain name?
Regards,
Igor.
De : igor.potjevlesch@gmail.com<mailto:igor.potjevlesch@gmail.com>
<igor.potjevlesch@gmail.com><mailto:igor.potjevlesch@gmail.com>
Envoyé : mardi 27 août 2019 11:53
À : miconda@gmail.com<mailto:miconda@gmail.com>; 'Kamailio (SER) - Users Mailing
List' <sr-users@lists.kamailio.org><mailto:sr-users@lists.kamailio.org>
Objet : RE: [SR-Users] lookup(aliases) issues with 5.2
Hello Daniel,
Thank you for getting back to me.
We will update with 5.2.4 and I'll let you know if it's solved.
Regards,
Igor.
De : Daniel-Constantin Mierla <miconda@gmail.com<mailto:miconda@gmail.com>>
Envoyé : mardi 27 août 2019 09:39
À : Kamailio (SER) - Users Mailing List
<sr-users@lists.kamailio.org<mailto:sr-users@lists.kamailio.org>>;
igor.potjevlesch@gmail.com<mailto:igor.potjevlesch@gmail.com>
Objet : Re: [SR-Users] lookup(aliases) issues with 5.2
Hello,
On 27.08.19 09:27, igor.potjevlesch@gmail.com<mailto:igor.potjevlesch@gmail.com>
wrote:
Hello!
Any help on that matter? Sounds like the domain parsing have been updated. Is it possible
to back on the previous mode?
did you mean backporting to older branches? If yes, it was done to branch 5.2, have you
tried with latest version in that branch?
Cheers,
Daniel
Regards,
Igor.
De : igor.potjevlesch@gmail.com<mailto:igor.potjevlesch@gmail.com>
<igor.potjevlesch@gmail.com><mailto:igor.potjevlesch@gmail.com>
Envoyé : vendredi 23 août 2019 18:53
À : 'Kamailio (SER) - Users Mailing List'
<sr-users@lists.kamailio.org><mailto:sr-users@lists.kamailio.org>
Objet : lookup(aliases) issues with 5.2
Hello!
I have notice some issues with lookup(aliases) since I upgraded to 5.2 from 5.1:
First with kamctl: If this default command is executed:
ctl_cmd_run ul.add "$USRLOC_TABLE" "$OSERUSER@$OSERDOMAIN"
"$2" \
"$UL_EXPIRES" "$DEFAULT_Q" "$UL_PATH" "$UL_FLAGS"
"$BR_FLAGS" "$ALL_METHODS"
as $ALL_METHODS is not defined, there is a huge value in methods and then lookup(aliases)
fails with -2.
I have to update kamctl script and put -1 ("-1") instead of the variable. So,
now, methods is a NULL value in DB and my alias is not ignored. But I use to make my alias
like this: sip:number@blabla_1.local
Which is no longer works: ERROR: registrar [common.c:62]: extract_aor(): failed to parse
AoR [sip:number@blabla_1.local]
Any idea of the difference since 5.2 with this behaviour? Without the underscore, the AoR
seems to be valid but I need to support underscore as before.
Regards,
Igor.
_______________________________________________
Kamailio (SER) - Users Mailing List
sr-users@lists.kamailio.org<mailto:sr-users@lists.kamailio.org>
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users
--
Daniel-Constantin Mierla -- www.asipto.com<http://www.asipto.com>
www.twitter.com/miconda<http://www.twitter.com/miconda> --
www.linkedin.com/in/miconda<http://www.linkedin.com/in/miconda>
--
Daniel-Constantin Mierla -- www.asipto.com<http://www.asipto.com>
www.twitter.com/miconda<http://www.twitter.com/miconda> --
www.linkedin.com/in/miconda<http://www.linkedin.com/in/miconda>
_______________________________________________
Kamailio (SER) - Users Mailing List
sr-users@lists.kamailio.org<mailto:sr-users@lists.kamailio.org>
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users
--
Henning Westerholt - https://skalatan.de/blog/
Kamailio services - https://skalatan.de/services
8:25 p.m.
Hello,
I haven't authored that patch and also never needed an underscore in
host part of the URI, but also it didn't affect me before that change. I
guess Juha wanted o be compliant with the RFC.
If people need to allow an extended set of chars in the host part, I am
fine to add some parameter to control that.
Cheers,
Daniel
On 28.08.19 15:34, igor.potjevlesch(a)gmail.com wrote:
Hello,
Hmm, ok. Saw it.
Is it possible to reconsider a less strict control?
Regards,
Igor.
*De :*Daniel-Constantin Mierla <miconda(a)gmail.com>
*Envoyé :* mercredi 28 août 2019 10:25
*À :* igor.potjevlesch(a)gmail.com; 'Kamailio (SER) - Users Mailing
List' <sr-users(a)lists.kamailio.org>
*Objet :* Re: [SR-Users] lookup(aliases) issues with 5.2
Hello,
reading again I see that the error with the host uri is printed from
the C code. I thought of another issue that was reported related to
IPv6 addresses in the URI that kamctl rejected.
The problem is that the underscore is not allowed in hostname: the
relevant standard is RFC 1123, section 2.1 "Host Names and Numbers"
which limits host names to letters-digits-hyphen.
I checked the commits log and it seems this more strict verification
was added by next commit:
commit 4994960324d5353222b3de08515bed07802ab7bc
Author: Juha Heinanen <jh(a)tutpro.com> <mailto:jh@tutpro.com>
Date: Wed Jan 10 08:39:48 2018 +0200
core/parser: more strict parsing of sip uri host
Regarding the $ALL_METHODS not being defined, iirc, you should set it
to . (or maybe -1 in this case).
Cheers,
Daniel
On 28.08.19 10:12, igor.potjevlesch(a)gmail.com
<mailto:igor.potjevlesch@gmail.com> wrote:
Hello Daniel,
We moved to the latest 5.2.4 but hostname with underscore are
still not handle properly.
Is it a real design choice or a mistake somewhere in the code that
handle domain name?
Regards,
Igor.
*De :*igor.potjevlesch@gmail.com
<mailto:igor.potjevlesch@gmail.com> <igor.potjevlesch(a)gmail.com>
<mailto:igor.potjevlesch@gmail.com>
*Envoyé :* mardi 27 août 2019 11:53
*À :* miconda(a)gmail.com <mailto:miconda@gmail.com>; 'Kamailio
(SER) - Users Mailing List' <sr-users(a)lists.kamailio.org>
<mailto:sr-users@lists.kamailio.org>
*Objet :* RE: [SR-Users] lookup(aliases) issues with 5.2
Hello Daniel,
Thank you for getting back to me.
We will update with 5.2.4 and I'll let you know if it's solved.
Regards,
Igor.
*De :*Daniel-Constantin Mierla <miconda(a)gmail.com
<mailto:miconda@gmail.com>>
*Envoyé :* mardi 27 août 2019 09:39
*À :* Kamailio (SER) - Users Mailing List
<sr-users(a)lists.kamailio.org
<mailto:sr-users@lists.kamailio.org>>; igor.potjevlesch(a)gmail.com
<mailto:igor.potjevlesch@gmail.com>
*Objet :* Re: [SR-Users] lookup(aliases) issues with 5.2
Hello,
On 27.08.19 09:27, igor.potjevlesch(a)gmail.com
<mailto:igor.potjevlesch@gmail.com> wrote:
Hello!
Any help on that matter? Sounds like the domain parsing have
been updated. Is it possible to back on the previous mode?
did you mean backporting to older branches? If yes, it was done to
branch 5.2, have you tried with latest version in that branch?
Cheers,
Daniel
Regards,
Igor.
*De :*igor.potjevlesch@gmail.com
<mailto:igor.potjevlesch@gmail.com>
<igor.potjevlesch(a)gmail.com> <mailto:igor.potjevlesch@gmail.com>
*Envoyé :* vendredi 23 août 2019 18:53
*À :* 'Kamailio (SER) - Users Mailing List'
<sr-users(a)lists.kamailio.org> <mailto:sr-users@lists.kamailio.org>
*Objet :* lookup(aliases) issues with 5.2
Hello!
I have notice some issues with lookup(aliases) since I
upgraded to 5.2 from 5.1:
First with kamctl: If this default command is executed:
ctl_cmd_run ul.add "$USRLOC_TABLE" "$OSERUSER@$OSERDOMAIN"
"$2" \
"$UL_EXPIRES" "$DEFAULT_Q" "$UL_PATH"
"$UL_FLAGS" "$BR_FLAGS"
"$ALL_METHODS"
as $ALL_METHODS is not defined, there is a huge value in
methods and then lookup(aliases) fails with -2.
I have to update kamctl script and put -1 ("-1") instead of
the variable. So, now, methods is a NULL value in DB and my
alias is not ignored. But I use to make my alias like this:
sip:number@blabla_1.local
Which is no longer works: ERROR: registrar [common.c:62]:
extract_aor(): failed to parse AoR [sip:number@blabla_1.local]
Any idea of the difference since 5.2 with this behaviour?
Without the underscore, the AoR seems to be valid but I need
to support underscore as before.
Regards,
Igor.
_______________________________________________
Kamailio (SER) - Users Mailing List
sr-users(a)lists.kamailio.org <mailto:sr-users@lists.kamailio.org>
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users
--
Daniel-Constantin Mierla -- www.asipto.com <http://www.asipto.com>
www.twitter.com/miconda <http://www.twitter.com/miconda> --
www.linkedin.com/in/miconda <http://www.linkedin.com/in/miconda>
--
Daniel-Constantin Mierla -- www.asipto.com <http://www.asipto.com>
www.twitter.com/miconda <http://www.twitter.com/miconda> --
www.linkedin.com/in/miconda <http://www.linkedin.com/in/miconda>
--
Daniel-Constantin Mierla -- www.asipto.com
www.twitter.com/miconda -- www.linkedin.com/in/miconda
29 Aug
29 Aug
10:21 a.m.
Hello Daniel, Henning,
I'd be interested, but if I'm the only one... Otherwise I can indeed remove
this patch as Henning suggests, but it embarrasses me to have a different
source code.
Tell me if it's possible to make it customizable. Otherwise I will consider
either removing the patch or finding another workaround.
Regards,
Igor.
De : Daniel-Constantin Mierla <miconda(a)gmail.com
Envoyé : mercredi 28 août 2019 20:26
À : igor.potjevlesch(a)gmail.com; 'Kamailio (SER) - Users Mailing List'
<sr-users(a)lists.kamailio.org>
Objet : Re: [SR-Users] lookup(aliases) issues with 5.2
Hello,
I haven't authored that patch and also never needed an underscore in host
part of the URI, but also it didn't affect me before that change. I guess
Juha wanted o be compliant with the RFC.
If people need to allow an extended set of chars in the host part, I am fine
to add some parameter to control that.
Cheers,
Daniel
On 28.08.19 15:34, igor.potjevlesch(a)gmail.com
<mailto:igor.potjevlesch@gmail.com> wrote:
Hello,
Hmm, ok. Saw it.
Is it possible to reconsider a less strict control?
Regards,
Igor.
De : Daniel-Constantin Mierla <mailto:miconda@gmail.com>
<miconda(a)gmail.com Envoyé : mercredi 28
août 2019 10:25
À : igor.potjevlesch(a)gmail.com <mailto:igor.potjevlesch@gmail.com> ;
'Kamailio (SER) - Users Mailing List' <mailto:sr-users@lists.kamailio.org>
<sr-users(a)lists.kamailio.org>
Objet : Re: [SR-Users] lookup(aliases) issues with 5.2
Hello,
reading again I see that the error with the host uri is printed from the C
code. I thought of another issue that was reported related to IPv6 addresses
in the URI that kamctl rejected.
The problem is that the underscore is not allowed in hostname: the relevant
standard is RFC 1123, section 2.1 "Host Names and Numbers" which limits host
names to letters-digits-hyphen.
I checked the commits log and it seems this more strict verification was
added by next commit:
commit 4994960324d5353222b3de08515bed07802ab7bc
Author: Juha Heinanen <mailto:jh@tutpro.com> <jh(a)tutpro.com>
Date: Wed Jan 10 08:39:48 2018 +0200
core/parser: more strict parsing of sip uri host
Regarding the $ALL_METHODS not being defined, iirc, you should set it to .
(or maybe -1 in this case).
Cheers,
Daniel
On 28.08.19 10:12, igor.potjevlesch(a)gmail.com
<mailto:igor.potjevlesch@gmail.com> wrote:
Hello Daniel,
We moved to the latest 5.2.4 but hostname with underscore are still not
handle properly.
Is it a real design choice or a mistake somewhere in the code that handle
domain name?
Regards,
Igor.
De : igor.potjevlesch(a)gmail.com <mailto:igor.potjevlesch@gmail.com>
<mailto:igor.potjevlesch@gmail.com> <igor.potjevlesch(a)gmail.com Envoyé : mardi 27 août 2019 11:53
À : miconda(a)gmail.com <mailto:miconda@gmail.com> ; 'Kamailio (SER) - Users
Mailing List' <mailto:sr-users@lists.kamailio.org>
<sr-users(a)lists.kamailio.org>
Objet : RE: [SR-Users] lookup(aliases) issues with 5.2
Hello Daniel,
Thank you for getting back to me.
We will update with 5.2.4 and I'll let you know if it's solved.
Regards,
Igor.
De : Daniel-Constantin Mierla <miconda(a)gmail.com <mailto:miconda@gmail.com>
Envoyé : mardi 27 août 2019 09:39
À : Kamailio (SER) - Users Mailing List <sr-users(a)lists.kamailio.org
<mailto:sr-users@lists.kamailio.org> >; igor.potjevlesch(a)gmail.com
<mailto:igor.potjevlesch@gmail.com
Objet : Re: [SR-Users] lookup(aliases) issues with 5.2
Hello,
On 27.08.19 09:27, igor.potjevlesch(a)gmail.com
<mailto:igor.potjevlesch@gmail.com> wrote:
Hello!
Any help on that matter? Sounds like the domain parsing have been updated.
Is it possible to back on the previous mode?
did you mean backporting to older branches? If yes, it was done to branch
5.2, have you tried with latest version in that branch?
Cheers,
Daniel
Regards,
Igor.
De : igor.potjevlesch(a)gmail.com <mailto:igor.potjevlesch@gmail.com>
<mailto:igor.potjevlesch@gmail.com> <igor.potjevlesch(a)gmail.com Envoyé : vendredi 23 août 2019 18:53
À : 'Kamailio (SER) - Users Mailing List'
<mailto:sr-users@lists.kamailio.org> <sr-users(a)lists.kamailio.org>
Objet : lookup(aliases) issues with 5.2
Hello!
I have notice some issues with lookup(aliases) since I upgraded to 5.2 from
5.1:
First with kamctl: If this default command is executed:
ctl_cmd_run ul.add "$USRLOC_TABLE" "$OSERUSER@$OSERDOMAIN"
"$2" \
"$UL_EXPIRES" "$DEFAULT_Q" "$UL_PATH" "$UL_FLAGS"
"$BR_FLAGS" "$ALL_METHODS"
as $ALL_METHODS is not defined, there is a huge value in methods and then
lookup(aliases) fails with -2.
I have to update kamctl script and put -1 ("-1") instead of the variable.
So, now, methods is a NULL value in DB and my alias is not ignored. But I
use to make my alias like this: sip:number@blabla_1.local
Which is no longer works: ERROR: registrar [common.c:62]: extract_aor():
failed to parse AoR [sip:number@blabla_1.local]
Any idea of the difference since 5.2 with this behaviour? Without the
underscore, the AoR seems to be valid but I need to support underscore as
before.
Regards,
Igor.
_______________________________________________
Kamailio (SER) - Users Mailing List
sr-users(a)lists.kamailio.org <mailto:sr-users@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users
--
Daniel-Constantin Mierla -- www.asipto.com <http://www.asipto.com www.twitter.com/miconda
<http://www.twitter.com/miconda> --
www.linkedin.com/in/miconda <http://www.linkedin.com/in/miconda
--
Daniel-Constantin Mierla -- www.asipto.com <http://www.asipto.com www.twitter.com/miconda
<http://www.twitter.com/miconda> --
www.linkedin.com/in/miconda <http://www.linkedin.com/in/miconda
--
Daniel-Constantin Mierla -- www.asipto.com <http://www.asipto.com www.twitter.com/miconda
<http://www.twitter.com/miconda> --
www.linkedin.com/in/miconda <http://www.linkedin.com/in/miconda
11 Sep
11 Sep
9:51 a.m.
Hello,
I will think what would be good ways to optimizie.
If you want to change the code, probably doesn't make sense to revert
the entire patch locally, just allow '_' -- you should change:
if(!isalnum(*p) && (*p != '.') && (*p != '-')) {
to
if(!isalnum(*p) && (*p != '.') && (*p != '-') &&
(*p != '_')) {
in src/core/parser/parse_uri.c -- see function parse_uri() and case
URI_HOST_P.
Cheers,
Daniel
On 29.08.19 10:21, igor.potjevlesch(a)gmail.com wrote:
Hello Daniel, Henning,
I'd be interested, but if I'm the only one... Otherwise I can indeed
remove this patch as Henning suggests, but it embarrasses me to have a
different source code.
Tell me if it's possible to make it customizable. Otherwise I will
consider either removing the patch or finding another workaround.
Regards,
Igor.
*De :*Daniel-Constantin Mierla <miconda(a)gmail.com>
*Envoyé :* mercredi 28 août 2019 20:26
*À :* igor.potjevlesch(a)gmail.com; 'Kamailio (SER) - Users Mailing
List' <sr-users(a)lists.kamailio.org>
*Objet :* Re: [SR-Users] lookup(aliases) issues with 5.2
Hello,
I haven't authored that patch and also never needed an underscore in
host part of the URI, but also it didn't affect me before that change.
I guess Juha wanted o be compliant with the RFC.
If people need to allow an extended set of chars in the host part, I
am fine to add some parameter to control that.
Cheers,
Daniel
On 28.08.19 15:34, igor.potjevlesch(a)gmail.com
<mailto:igor.potjevlesch@gmail.com> wrote:
Hello,
Hmm, ok. Saw it.
Is it possible to reconsider a less strict control?
Regards,
Igor.
*De :*Daniel-Constantin Mierla <miconda(a)gmail.com>
<mailto:miconda@gmail.com>
*Envoyé :* mercredi 28 août 2019 10:25
*À :* igor.potjevlesch(a)gmail.com
<mailto:igor.potjevlesch@gmail.com>; 'Kamailio (SER) - Users
Mailing List' <sr-users(a)lists.kamailio.org>
<mailto:sr-users@lists.kamailio.org>
*Objet :* Re: [SR-Users] lookup(aliases) issues with 5.2
Hello,
reading again I see that the error with the host uri is printed
from the C code. I thought of another issue that was reported
related to IPv6 addresses in the URI that kamctl rejected.
The problem is that the underscore is not allowed in hostname: the
relevant standard is RFC 1123, section 2.1 "Host Names and
Numbers" which limits host names to letters-digits-hyphen.
I checked the commits log and it seems this more strict
verification was added by next commit:
commit 4994960324d5353222b3de08515bed07802ab7bc
Author: Juha Heinanen <jh(a)tutpro.com> <mailto:jh@tutpro.com>
Date: Wed Jan 10 08:39:48 2018 +0200
core/parser: more strict parsing of sip uri host
Regarding the $ALL_METHODS not being defined, iirc, you should set
it to . (or maybe -1 in this case).
Cheers,
Daniel
On 28.08.19 10:12, igor.potjevlesch(a)gmail.com
<mailto:igor.potjevlesch@gmail.com> wrote:
Hello Daniel,
We moved to the latest 5.2.4 but hostname with underscore are
still not handle properly.
Is it a real design choice or a mistake somewhere in the code
that handle domain name?
Regards,
Igor.
*De :*igor.potjevlesch@gmail.com
<mailto:igor.potjevlesch@gmail.com>
<igor.potjevlesch(a)gmail.com> <mailto:igor.potjevlesch@gmail.com>
*Envoyé :* mardi 27 août 2019 11:53
*À :* miconda(a)gmail.com <mailto:miconda@gmail.com>; 'Kamailio
(SER) - Users Mailing List' <sr-users(a)lists.kamailio.org>
<mailto:sr-users@lists.kamailio.org>
*Objet :* RE: [SR-Users] lookup(aliases) issues with 5.2
Hello Daniel,
Thank you for getting back to me.
We will update with 5.2.4 and I'll let you know if it's solved.
Regards,
Igor.
*De :*Daniel-Constantin Mierla <miconda(a)gmail.com
<mailto:miconda@gmail.com>>
*Envoyé :* mardi 27 août 2019 09:39
*À :* Kamailio (SER) - Users Mailing List
<sr-users(a)lists.kamailio.org
<mailto:sr-users@lists.kamailio.org>>;
igor.potjevlesch(a)gmail.com <mailto:igor.potjevlesch@gmail.com>
*Objet :* Re: [SR-Users] lookup(aliases) issues with 5.2
Hello,
On 27.08.19 09:27, igor.potjevlesch(a)gmail.com
<mailto:igor.potjevlesch@gmail.com> wrote:
Hello!
Any help on that matter? Sounds like the domain parsing
have been updated. Is it possible to back on the previous
mode?
did you mean backporting to older branches? If yes, it was
done to branch 5.2, have you tried with latest version in that
branch?
Cheers,
Daniel
Regards,
Igor.
*De :*igor.potjevlesch@gmail.com
<mailto:igor.potjevlesch@gmail.com>
<igor.potjevlesch(a)gmail.com>
<mailto:igor.potjevlesch@gmail.com>
*Envoyé :* vendredi 23 août 2019 18:53
*À :* 'Kamailio (SER) - Users Mailing List'
<sr-users(a)lists.kamailio.org>
<mailto:sr-users@lists.kamailio.org>
*Objet :* lookup(aliases) issues with 5.2
Hello!
I have notice some issues with lookup(aliases) since I
upgraded to 5.2 from 5.1:
First with kamctl: If this default command is executed:
ctl_cmd_run ul.add "$USRLOC_TABLE"
"$OSERUSER@$OSERDOMAIN"
"$2" \
"$UL_EXPIRES" "$DEFAULT_Q" "$UL_PATH"
"$UL_FLAGS"
"$BR_FLAGS" "$ALL_METHODS"
as $ALL_METHODS is not defined, there is a huge value in
methods and then lookup(aliases) fails with -2.
I have to update kamctl script and put -1 ("-1") instead
of the variable. So, now, methods is a NULL value in DB
and my alias is not ignored. But I use to make my alias
like this: sip:number@blabla_1.local
Which is no longer works: ERROR: registrar [common.c:62]:
extract_aor(): failed to parse AoR [sip:number@blabla_1.local]
Any idea of the difference since 5.2 with this behaviour?
Without the underscore, the AoR seems to be valid but I
need to support underscore as before.
Regards,
Igor.
_______________________________________________
Kamailio (SER) - Users Mailing List
sr-users(a)lists.kamailio.org <mailto:sr-users@lists.kamailio.org>
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users
--
Daniel-Constantin Mierla -- www.asipto.com <http://www.asipto.com>
www.twitter.com/miconda <http://www.twitter.com/miconda> --
www.linkedin.com/in/miconda <http://www.linkedin.com/in/miconda>
--
Daniel-Constantin Mierla -- www.asipto.com <http://www.asipto.com>
www.twitter.com/miconda <http://www.twitter.com/miconda> --
www.linkedin.com/in/miconda <http://www.linkedin.com/in/miconda>
--
Daniel-Constantin Mierla -- www.asipto.com <http://www.asipto.com>
www.twitter.com/miconda <http://www.twitter.com/miconda> --
www.linkedin.com/in/miconda <http://www.linkedin.com/in/miconda>
--
Daniel-Constantin Mierla -- www.asipto.com
www.twitter.com/miconda -- www.linkedin.com/in/miconda
Kamailio Advanced Training, Oct 21-23, 2019, Berlin, Germany -- https://asipto.com/u/kat
4 Oct
4 Oct
10:08 a.m.
Hello Daniel,
I confirm that we did that indeed. Just added the support of "_" instead of
rollback on the whole code.
Thank you!
Regards,
Igor.
De : Daniel-Constantin Mierla <miconda(a)gmail.com
Envoyé : mercredi 11 septembre 2019 09:51
À : igor.potjevlesch(a)gmail.com; 'Kamailio (SER) - Users Mailing List'
<sr-users(a)lists.kamailio.org>
Objet : Re: [SR-Users] lookup(aliases) issues with 5.2
Hello,
I will think what would be good ways to optimizie.
If you want to change the code, probably doesn't make sense to revert the
entire patch locally, just allow '_' -- you should change:
if(!isalnum(*p) && (*p != '.') && (*p != '-')) {
to
if(!isalnum(*p) && (*p != '.') && (*p != '-') &&
(*p != '_')) {
in src/core/parser/parse_uri.c -- see function parse_uri() and case
URI_HOST_P.
Cheers,
Daniel
On 29.08.19 10:21, igor.potjevlesch(a)gmail.com
<mailto:igor.potjevlesch@gmail.com> wrote:
Hello Daniel, Henning,
I'd be interested, but if I'm the only one... Otherwise I can indeed remove
this patch as Henning suggests, but it embarrasses me to have a different
source code.
Tell me if it's possible to make it customizable. Otherwise I will consider
either removing the patch or finding another workaround.
Regards,
Igor.
De : Daniel-Constantin Mierla <mailto:miconda@gmail.com>
<miconda(a)gmail.com Envoyé : mercredi 28
août 2019 20:26
À : igor.potjevlesch(a)gmail.com <mailto:igor.potjevlesch@gmail.com> ;
'Kamailio (SER) - Users Mailing List' <mailto:sr-users@lists.kamailio.org>
<sr-users(a)lists.kamailio.org>
Objet : Re: [SR-Users] lookup(aliases) issues with 5.2
Hello,
I haven't authored that patch and also never needed an underscore in host
part of the URI, but also it didn't affect me before that change. I guess
Juha wanted o be compliant with the RFC.
If people need to allow an extended set of chars in the host part, I am fine
to add some parameter to control that.
Cheers,
Daniel
On 28.08.19 15:34, igor.potjevlesch(a)gmail.com
<mailto:igor.potjevlesch@gmail.com> wrote:
Hello,
Hmm, ok. Saw it.
Is it possible to reconsider a less strict control?
Regards,
Igor.
De : Daniel-Constantin Mierla <mailto:miconda@gmail.com>
<miconda(a)gmail.com Envoyé : mercredi 28
août 2019 10:25
À : igor.potjevlesch(a)gmail.com <mailto:igor.potjevlesch@gmail.com> ;
'Kamailio (SER) - Users Mailing List' <mailto:sr-users@lists.kamailio.org>
<sr-users(a)lists.kamailio.org>
Objet : Re: [SR-Users] lookup(aliases) issues with 5.2
Hello,
reading again I see that the error with the host uri is printed from the C
code. I thought of another issue that was reported related to IPv6 addresses
in the URI that kamctl rejected.
The problem is that the underscore is not allowed in hostname: the relevant
standard is RFC 1123, section 2.1 "Host Names and Numbers" which limits host
names to letters-digits-hyphen.
I checked the commits log and it seems this more strict verification was
added by next commit:
commit 4994960324d5353222b3de08515bed07802ab7bc
Author: Juha Heinanen <mailto:jh@tutpro.com> <jh(a)tutpro.com>
Date: Wed Jan 10 08:39:48 2018 +0200
core/parser: more strict parsing of sip uri host
Regarding the $ALL_METHODS not being defined, iirc, you should set it to .
(or maybe -1 in this case).
Cheers,
Daniel
On 28.08.19 10:12, igor.potjevlesch(a)gmail.com
<mailto:igor.potjevlesch@gmail.com> wrote:
Hello Daniel,
We moved to the latest 5.2.4 but hostname with underscore are still not
handle properly.
Is it a real design choice or a mistake somewhere in the code that handle
domain name?
Regards,
Igor.
De : igor.potjevlesch(a)gmail.com <mailto:igor.potjevlesch@gmail.com>
<mailto:igor.potjevlesch@gmail.com> <igor.potjevlesch(a)gmail.com Envoyé : mardi 27 août 2019 11:53
À : miconda(a)gmail.com <mailto:miconda@gmail.com> ; 'Kamailio (SER) - Users
Mailing List' <mailto:sr-users@lists.kamailio.org>
<sr-users(a)lists.kamailio.org>
Objet : RE: [SR-Users] lookup(aliases) issues with 5.2
Hello Daniel,
Thank you for getting back to me.
We will update with 5.2.4 and I'll let you know if it's solved.
Regards,
Igor.
De : Daniel-Constantin Mierla <miconda(a)gmail.com <mailto:miconda@gmail.com>
Envoyé : mardi 27 août 2019 09:39
À : Kamailio (SER) - Users Mailing List <sr-users(a)lists.kamailio.org
<mailto:sr-users@lists.kamailio.org> >; igor.potjevlesch(a)gmail.com
<mailto:igor.potjevlesch@gmail.com
Objet : Re: [SR-Users] lookup(aliases) issues with 5.2
Hello,
On 27.08.19 09:27, igor.potjevlesch(a)gmail.com
<mailto:igor.potjevlesch@gmail.com> wrote:
Hello!
Any help on that matter? Sounds like the domain parsing have been updated.
Is it possible to back on the previous mode?
did you mean backporting to older branches? If yes, it was done to branch
5.2, have you tried with latest version in that branch?
Cheers,
Daniel
Regards,
Igor.
De : igor.potjevlesch(a)gmail.com <mailto:igor.potjevlesch@gmail.com>
<mailto:igor.potjevlesch@gmail.com> <igor.potjevlesch(a)gmail.com Envoyé : vendredi 23 août 2019 18:53
À : 'Kamailio (SER) - Users Mailing List'
<mailto:sr-users@lists.kamailio.org> <sr-users(a)lists.kamailio.org>
Objet : lookup(aliases) issues with 5.2
Hello!
I have notice some issues with lookup(aliases) since I upgraded to 5.2 from
5.1:
First with kamctl: If this default command is executed:
ctl_cmd_run ul.add "$USRLOC_TABLE" "$OSERUSER@$OSERDOMAIN"
"$2" \
"$UL_EXPIRES" "$DEFAULT_Q" "$UL_PATH" "$UL_FLAGS"
"$BR_FLAGS" "$ALL_METHODS"
as $ALL_METHODS is not defined, there is a huge value in methods and then
lookup(aliases) fails with -2.
I have to update kamctl script and put -1 ("-1") instead of the variable.
So, now, methods is a NULL value in DB and my alias is not ignored. But I
use to make my alias like this: sip:number@blabla_1.local
Which is no longer works: ERROR: registrar [common.c:62]: extract_aor():
failed to parse AoR [sip:number@blabla_1.local]
Any idea of the difference since 5.2 with this behaviour? Without the
underscore, the AoR seems to be valid but I need to support underscore as
before.
Regards,
Igor.
_______________________________________________
Kamailio (SER) - Users Mailing List
sr-users(a)lists.kamailio.org <mailto:sr-users@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users
--
Daniel-Constantin Mierla -- www.asipto.com <http://www.asipto.com www.twitter.com/miconda
<http://www.twitter.com/miconda> --
www.linkedin.com/in/miconda <http://www.linkedin.com/in/miconda
--
Daniel-Constantin Mierla -- www.asipto.com <http://www.asipto.com www.twitter.com/miconda
<http://www.twitter.com/miconda> --
www.linkedin.com/in/miconda <http://www.linkedin.com/in/miconda
--
Daniel-Constantin Mierla -- www.asipto.com <http://www.asipto.com www.twitter.com/miconda
<http://www.twitter.com/miconda> --
www.linkedin.com/in/miconda <http://www.linkedin.com/in/miconda
--
Daniel-Constantin Mierla -- www.asipto.com <http://www.asipto.com www.twitter.com/miconda
<http://www.twitter.com/miconda> --
www.linkedin.com/in/miconda <http://www.linkedin.com/in/miconda Kamailio Advanced Training, Oct 21-23, 2019,
Berlin, Germany --
https://asipto.com/u/kat
10 Oct
10 Oct
2:39 p.m.
Hello,
I just pushed a commit adding a core parameter to allow specifying
additional character in the host part of URIs:
-
https://github.com/kamailio/kamailio/commit/038158c99da96933c26b11a919ed1cb…
It is in the master branch. Can you test it and report if works as expected?
Cheers,
Daniel
On 04.10.19 10:08, igor.potjevlesch(a)gmail.com wrote:
Hello Daniel,
I confirm that we did that indeed. Just added the support of "_"
instead of rollback on the whole code.
Thank you!
Regards,
Igor.
*De :*Daniel-Constantin Mierla <miconda(a)gmail.com>
*Envoyé :* mercredi 11 septembre 2019 09:51
*À :* igor.potjevlesch(a)gmail.com; 'Kamailio (SER) - Users Mailing
List' <sr-users(a)lists.kamailio.org>
*Objet :* Re: [SR-Users] lookup(aliases) issues with 5.2
Hello,
I will think what would be good ways to optimizie.
If you want to change the code, probably doesn't make sense to revert
the entire patch locally, just allow '_' -- you should change:
if(!isalnum(*p) && (*p != '.') && (*p != '-')) {
to
if(!isalnum(*p) && (*p != '.') && (*p != '-') &&
(*p != '_')) {
in src/core/parser/parse_uri.c -- see function parse_uri() and case
URI_HOST_P.
Cheers,
Daniel
On 29.08.19 10:21, igor.potjevlesch(a)gmail.com
<mailto:igor.potjevlesch@gmail.com> wrote:
Hello Daniel, Henning,
I'd be interested, but if I'm the only one... Otherwise I can
indeed remove this patch as Henning suggests, but it embarrasses
me to have a different source code.
Tell me if it's possible to make it customizable. Otherwise I will
consider either removing the patch or finding another workaround.
Regards,
Igor.
*De :*Daniel-Constantin Mierla <miconda(a)gmail.com>
<mailto:miconda@gmail.com>
*Envoyé :* mercredi 28 août 2019 20:26
*À :* igor.potjevlesch(a)gmail.com
<mailto:igor.potjevlesch@gmail.com>; 'Kamailio (SER) - Users
Mailing List' <sr-users(a)lists.kamailio.org>
<mailto:sr-users@lists.kamailio.org>
*Objet :* Re: [SR-Users] lookup(aliases) issues with 5.2
Hello,
I haven't authored that patch and also never needed an underscore
in host part of the URI, but also it didn't affect me before that
change. I guess Juha wanted o be compliant with the RFC.
If people need to allow an extended set of chars in the host part,
I am fine to add some parameter to control that.
Cheers,
Daniel
On 28.08.19 15:34, igor.potjevlesch(a)gmail.com
<mailto:igor.potjevlesch@gmail.com> wrote:
Hello,
Hmm, ok. Saw it.
Is it possible to reconsider a less strict control?
Regards,
Igor.
*De :*Daniel-Constantin Mierla <miconda(a)gmail.com>
<mailto:miconda@gmail.com>
*Envoyé :* mercredi 28 août 2019 10:25
*À :* igor.potjevlesch(a)gmail.com
<mailto:igor.potjevlesch@gmail.com>; 'Kamailio (SER) - Users
Mailing List' <sr-users(a)lists.kamailio.org>
<mailto:sr-users@lists.kamailio.org>
*Objet :* Re: [SR-Users] lookup(aliases) issues with 5.2
Hello,
reading again I see that the error with the host uri is
printed from the C code. I thought of another issue that was
reported related to IPv6 addresses in the URI that kamctl
rejected.
The problem is that the underscore is not allowed in hostname:
the relevant standard is RFC 1123, section 2.1 "Host Names and
Numbers" which limits host names to letters-digits-hyphen.
I checked the commits log and it seems this more strict
verification was added by next commit:
commit 4994960324d5353222b3de08515bed07802ab7bc
Author: Juha Heinanen <jh(a)tutpro.com> <mailto:jh@tutpro.com>
Date: Wed Jan 10 08:39:48 2018 +0200
core/parser: more strict parsing of sip uri host
Regarding the $ALL_METHODS not being defined, iirc, you should
set it to . (or maybe -1 in this case).
Cheers,
Daniel
On 28.08.19 10:12, igor.potjevlesch(a)gmail.com
<mailto:igor.potjevlesch@gmail.com> wrote:
Hello Daniel,
We moved to the latest 5.2.4 but hostname with underscore
are still not handle properly.
Is it a real design choice or a mistake somewhere in the
code that handle domain name?
Regards,
Igor.
*De :*igor.potjevlesch@gmail.com
<mailto:igor.potjevlesch@gmail.com>
<igor.potjevlesch(a)gmail.com>
<mailto:igor.potjevlesch@gmail.com>
*Envoyé :* mardi 27 août 2019 11:53
*À :* miconda(a)gmail.com <mailto:miconda@gmail.com>;
'Kamailio (SER) - Users Mailing List'
<sr-users(a)lists.kamailio.org>
<mailto:sr-users@lists.kamailio.org>
*Objet :* RE: [SR-Users] lookup(aliases) issues with 5.2
Hello Daniel,
Thank you for getting back to me.
We will update with 5.2.4 and I'll let you know if it's
solved.
Regards,
Igor.
*De :*Daniel-Constantin Mierla <miconda(a)gmail.com
<mailto:miconda@gmail.com>>
*Envoyé :* mardi 27 août 2019 09:39
*À :* Kamailio (SER) - Users Mailing List
<sr-users(a)lists.kamailio.org
<mailto:sr-users@lists.kamailio.org>>;
igor.potjevlesch(a)gmail.com <mailto:igor.potjevlesch@gmail.com>
*Objet :* Re: [SR-Users] lookup(aliases) issues with 5.2
Hello,
On 27.08.19 09:27, igor.potjevlesch(a)gmail.com
<mailto:igor.potjevlesch@gmail.com> wrote:
Hello!
Any help on that matter? Sounds like the domain
parsing have been updated. Is it possible to back on
the previous mode?
did you mean backporting to older branches? If yes, it was
done to branch 5.2, have you tried with latest version in
that branch?
Cheers,
Daniel
Regards,
Igor.
*De :*igor.potjevlesch@gmail.com
<mailto:igor.potjevlesch@gmail.com>
<igor.potjevlesch(a)gmail.com>
<mailto:igor.potjevlesch@gmail.com>
*Envoyé :* vendredi 23 août 2019 18:53
*À :* 'Kamailio (SER) - Users Mailing List'
<sr-users(a)lists.kamailio.org>
<mailto:sr-users@lists.kamailio.org>
*Objet :* lookup(aliases) issues with 5.2
Hello!
I have notice some issues with lookup(aliases) since I
upgraded to 5.2 from 5.1:
First with kamctl: If this default command is executed:
ctl_cmd_run ul.add "$USRLOC_TABLE"
"$OSERUSER@$OSERDOMAIN" "$2" \
"$UL_EXPIRES" "$DEFAULT_Q" "$UL_PATH"
"$UL_FLAGS"
"$BR_FLAGS" "$ALL_METHODS"
as $ALL_METHODS is not defined, there is a huge value
in methods and then lookup(aliases) fails with -2.
I have to update kamctl script and put -1 ("-1")
instead of the variable. So, now, methods is a NULL
value in DB and my alias is not ignored. But I use to
make my alias like this: sip:number@blabla_1.local
Which is no longer works: ERROR: registrar
[common.c:62]: extract_aor(): failed to parse AoR
[sip:number@blabla_1.local]
Any idea of the difference since 5.2 with this
behaviour? Without the underscore, the AoR seems to be
valid but I need to support underscore as before.
Regards,
Igor.
_______________________________________________
Kamailio (SER) - Users Mailing List
sr-users(a)lists.kamailio.org <mailto:sr-users@lists.kamailio.org>
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users
--
Daniel-Constantin Mierla -- www.asipto.com <http://www.asipto.com>
www.twitter.com/miconda <http://www.twitter.com/miconda> --
www.linkedin.com/in/miconda <http://www.linkedin.com/in/miconda>
--
Daniel-Constantin Mierla -- www.asipto.com <http://www.asipto.com>
www.twitter.com/miconda <http://www.twitter.com/miconda> --
www.linkedin.com/in/miconda <http://www.linkedin.com/in/miconda>
--
Daniel-Constantin Mierla -- www.asipto.com <http://www.asipto.com>
www.twitter.com/miconda <http://www.twitter.com/miconda> --
www.linkedin.com/in/miconda <http://www.linkedin.com/in/miconda>
--
Daniel-Constantin Mierla -- www.asipto.com <http://www.asipto.com>
www.twitter.com/miconda <http://www.twitter.com/miconda> --
www.linkedin.com/in/miconda <http://www.linkedin.com/in/miconda>
Kamailio Advanced Training, Oct 21-23, 2019, Berlin, Germany -- https://asipto.com/u/kat
--
Daniel-Constantin Mierla -- www.asipto.com
www.twitter.com/miconda -- www.linkedin.com/in/miconda
Kamailio Advanced Training, Oct 21-23, 2019, Berlin, Germany -- https://asipto.com/u/kat
28 Oct
28 Oct
7:13 p.m.
Hello Daniel,
Thank you!
Is it pushed in one of the latest release? Because we don't have a
connection to git on our server. We build from tar.
Regards,
Igor.
De : Daniel-Constantin Mierla <miconda(a)gmail.com
Envoyé : jeudi 10 octobre 2019 14:40
À : igor.potjevlesch(a)gmail.com; 'Kamailio (SER) - Users Mailing List'
<sr-users(a)lists.kamailio.org>
Objet : Re: [SR-Users] lookup(aliases) issues with 5.2
Hello,
I just pushed a commit adding a core parameter to allow specifying
additional character in the host part of URIs:
-
https://github.com/kamailio/kamailio/commit/038158c99da96933c26b11a919ed1cbe
29af9fab
It is in the master branch. Can you test it and report if works as expected?
Cheers,
Daniel
On 04.10.19 10:08, igor.potjevlesch(a)gmail.com
<mailto:igor.potjevlesch@gmail.com> wrote:
Hello Daniel,
I confirm that we did that indeed. Just added the support of "_" instead of
rollback on the whole code.
Thank you!
Regards,
Igor.
De : Daniel-Constantin Mierla <mailto:miconda@gmail.com>
<miconda(a)gmail.com Envoyé : mercredi 11
septembre 2019 09:51
À : igor.potjevlesch(a)gmail.com <mailto:igor.potjevlesch@gmail.com> ;
'Kamailio (SER) - Users Mailing List' <mailto:sr-users@lists.kamailio.org>
<sr-users(a)lists.kamailio.org>
Objet : Re: [SR-Users] lookup(aliases) issues with 5.2
Hello,
I will think what would be good ways to optimizie.
If you want to change the code, probably doesn't make sense to revert the
entire patch locally, just allow '_' -- you should change:
if(!isalnum(*p) && (*p != '.') && (*p != '-')) {
to
if(!isalnum(*p) && (*p != '.') && (*p != '-') &&
(*p != '_')) {
in src/core/parser/parse_uri.c -- see function parse_uri() and case
URI_HOST_P.
Cheers,
Daniel
On 29.08.19 10:21, igor.potjevlesch(a)gmail.com
<mailto:igor.potjevlesch@gmail.com> wrote:
Hello Daniel, Henning,
I'd be interested, but if I'm the only one... Otherwise I can indeed remove
this patch as Henning suggests, but it embarrasses me to have a different
source code.
Tell me if it's possible to make it customizable. Otherwise I will consider
either removing the patch or finding another workaround.
Regards,
Igor.
De : Daniel-Constantin Mierla <mailto:miconda@gmail.com>
<miconda(a)gmail.com Envoyé : mercredi 28
août 2019 20:26
À : igor.potjevlesch(a)gmail.com <mailto:igor.potjevlesch@gmail.com> ;
'Kamailio (SER) - Users Mailing List' <mailto:sr-users@lists.kamailio.org>
<sr-users(a)lists.kamailio.org>
Objet : Re: [SR-Users] lookup(aliases) issues with 5.2
Hello,
I haven't authored that patch and also never needed an underscore in host
part of the URI, but also it didn't affect me before that change. I guess
Juha wanted o be compliant with the RFC.
If people need to allow an extended set of chars in the host part, I am fine
to add some parameter to control that.
Cheers,
Daniel
On 28.08.19 15:34, igor.potjevlesch(a)gmail.com
<mailto:igor.potjevlesch@gmail.com> wrote:
Hello,
Hmm, ok. Saw it.
Is it possible to reconsider a less strict control?
Regards,
Igor.
De : Daniel-Constantin Mierla <mailto:miconda@gmail.com>
<miconda(a)gmail.com Envoyé : mercredi 28
août 2019 10:25
À : igor.potjevlesch(a)gmail.com <mailto:igor.potjevlesch@gmail.com> ;
'Kamailio (SER) - Users Mailing List' <mailto:sr-users@lists.kamailio.org>
<sr-users(a)lists.kamailio.org>
Objet : Re: [SR-Users] lookup(aliases) issues with 5.2
Hello,
reading again I see that the error with the host uri is printed from the C
code. I thought of another issue that was reported related to IPv6 addresses
in the URI that kamctl rejected.
The problem is that the underscore is not allowed in hostname: the relevant
standard is RFC 1123, section 2.1 "Host Names and Numbers" which limits host
names to letters-digits-hyphen.
I checked the commits log and it seems this more strict verification was
added by next commit:
commit 4994960324d5353222b3de08515bed07802ab7bc
Author: Juha Heinanen <mailto:jh@tutpro.com> <jh(a)tutpro.com>
Date: Wed Jan 10 08:39:48 2018 +0200
core/parser: more strict parsing of sip uri host
Regarding the $ALL_METHODS not being defined, iirc, you should set it to .
(or maybe -1 in this case).
Cheers,
Daniel
On 28.08.19 10:12, igor.potjevlesch(a)gmail.com
<mailto:igor.potjevlesch@gmail.com> wrote:
Hello Daniel,
We moved to the latest 5.2.4 but hostname with underscore are still not
handle properly.
Is it a real design choice or a mistake somewhere in the code that handle
domain name?
Regards,
Igor.
De : igor.potjevlesch(a)gmail.com <mailto:igor.potjevlesch@gmail.com>
<mailto:igor.potjevlesch@gmail.com> <igor.potjevlesch(a)gmail.com Envoyé : mardi 27 août 2019 11:53
À : miconda(a)gmail.com <mailto:miconda@gmail.com> ; 'Kamailio (SER) - Users
Mailing List' <mailto:sr-users@lists.kamailio.org>
<sr-users(a)lists.kamailio.org>
Objet : RE: [SR-Users] lookup(aliases) issues with 5.2
Hello Daniel,
Thank you for getting back to me.
We will update with 5.2.4 and I'll let you know if it's solved.
Regards,
Igor.
De : Daniel-Constantin Mierla <miconda(a)gmail.com <mailto:miconda@gmail.com>
Envoyé : mardi 27 août 2019 09:39
À : Kamailio (SER) - Users Mailing List <sr-users(a)lists.kamailio.org
<mailto:sr-users@lists.kamailio.org> >; igor.potjevlesch(a)gmail.com
<mailto:igor.potjevlesch@gmail.com
Objet : Re: [SR-Users] lookup(aliases) issues with 5.2
Hello,
On 27.08.19 09:27, igor.potjevlesch(a)gmail.com
<mailto:igor.potjevlesch@gmail.com> wrote:
Hello!
Any help on that matter? Sounds like the domain parsing have been updated.
Is it possible to back on the previous mode?
did you mean backporting to older branches? If yes, it was done to branch
5.2, have you tried with latest version in that branch?
Cheers,
Daniel
Regards,
Igor.
De : igor.potjevlesch(a)gmail.com <mailto:igor.potjevlesch@gmail.com>
<mailto:igor.potjevlesch@gmail.com> <igor.potjevlesch(a)gmail.com Envoyé : vendredi 23 août 2019 18:53
À : 'Kamailio (SER) - Users Mailing List'
<mailto:sr-users@lists.kamailio.org> <sr-users(a)lists.kamailio.org>
Objet : lookup(aliases) issues with 5.2
Hello!
I have notice some issues with lookup(aliases) since I upgraded to 5.2 from
5.1:
First with kamctl: If this default command is executed:
ctl_cmd_run ul.add "$USRLOC_TABLE" "$OSERUSER@$OSERDOMAIN"
"$2" \
"$UL_EXPIRES" "$DEFAULT_Q" "$UL_PATH" "$UL_FLAGS"
"$BR_FLAGS" "$ALL_METHODS"
as $ALL_METHODS is not defined, there is a huge value in methods and then
lookup(aliases) fails with -2.
I have to update kamctl script and put -1 ("-1") instead of the variable.
So, now, methods is a NULL value in DB and my alias is not ignored. But I
use to make my alias like this: sip:number@blabla_1.local
Which is no longer works: ERROR: registrar [common.c:62]: extract_aor():
failed to parse AoR [sip:number@blabla_1.local]
Any idea of the difference since 5.2 with this behaviour? Without the
underscore, the AoR seems to be valid but I need to support underscore as
before.
Regards,
Igor.
_______________________________________________
Kamailio (SER) - Users Mailing List
sr-users(a)lists.kamailio.org <mailto:sr-users@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users
--
Daniel-Constantin Mierla -- www.asipto.com <http://www.asipto.com www.twitter.com/miconda
<http://www.twitter.com/miconda> --
www.linkedin.com/in/miconda <http://www.linkedin.com/in/miconda
--
Daniel-Constantin Mierla -- www.asipto.com <http://www.asipto.com www.twitter.com/miconda
<http://www.twitter.com/miconda> --
www.linkedin.com/in/miconda <http://www.linkedin.com/in/miconda
--
Daniel-Constantin Mierla -- www.asipto.com <http://www.asipto.com www.twitter.com/miconda
<http://www.twitter.com/miconda> --
www.linkedin.com/in/miconda <http://www.linkedin.com/in/miconda
--
Daniel-Constantin Mierla -- www.asipto.com <http://www.asipto.com www.twitter.com/miconda
<http://www.twitter.com/miconda> --
www.linkedin.com/in/miconda <http://www.linkedin.com/in/miconda Kamailio Advanced Training, Oct 21-23, 2019,
Berlin, Germany --
https://asipto.com/u/kat
--
Daniel-Constantin Mierla -- www.asipto.com <http://www.asipto.com www.twitter.com/miconda
<http://www.twitter.com/miconda> --
www.linkedin.com/in/miconda <http://www.linkedin.com/in/miconda Kamailio Advanced Training, Oct 21-23, 2019,
Berlin, Germany --
https://asipto.com/u/kat
1 Nov
1 Nov
6:32 p.m.
Hello Igor,
functional extensions like this will be usually not be backported to older stable
releases.
But you should be able to easily apply the patch to your local copy, if you build from tar
anyway.
This is the patch, you can apply with the command "patch":
https://github.com/kamailio/kamailio/commit/038158c99da96933c26b11a919ed1cb…
Cheers,
Henning
Am 28.10.19 um 19:13 schrieb
igor.potjevlesch@gmail.com<mailto:igor.potjevlesch@gmail.com>:
Hello Daniel,
Thank you!
Is it pushed in one of the latest release? Because we don't have a connection to git
on our server. We build from tar.
Regards,
Igor.
De : Daniel-Constantin Mierla <miconda@gmail.com><mailto:miconda@gmail.com>
Envoyé : jeudi 10 octobre 2019 14:40
À : igor.potjevlesch@gmail.com<mailto:igor.potjevlesch@gmail.com>; 'Kamailio
(SER) - Users Mailing List'
<sr-users@lists.kamailio.org><mailto:sr-users@lists.kamailio.org>
Objet : Re: [SR-Users] lookup(aliases) issues with 5.2
Hello,
I just pushed a commit adding a core parameter to allow specifying additional character in
the host part of URIs:
- https://github.com/kamailio/kamailio/commit/038158c99da96933c26b11a919ed1cb…
It is in the master branch. Can you test it and report if works as expected?
Cheers,
Daniel
On 04.10.19 10:08, igor.potjevlesch@gmail.com<mailto:igor.potjevlesch@gmail.com>
wrote:
Hello Daniel,
I confirm that we did that indeed. Just added the support of "_" instead of
rollback on the whole code.
Thank you!
Regards,
Igor.
De : Daniel-Constantin Mierla <miconda@gmail.com><mailto:miconda@gmail.com>
Envoyé : mercredi 11 septembre 2019 09:51
À : igor.potjevlesch@gmail.com<mailto:igor.potjevlesch@gmail.com>; 'Kamailio
(SER) - Users Mailing List'
<sr-users@lists.kamailio.org><mailto:sr-users@lists.kamailio.org>
Objet : Re: [SR-Users] lookup(aliases) issues with 5.2
Hello,
I will think what would be good ways to optimizie.
If you want to change the code, probably doesn't make sense to revert the entire patch
locally, just allow '_' -- you should change:
if(!isalnum(*p) && (*p != '.') && (*p != '-')) {
to
if(!isalnum(*p) && (*p != '.') && (*p != '-') &&
(*p != '_')) {
in src/core/parser/parse_uri.c -- see function parse_uri() and case URI_HOST_P.
Cheers,
Daniel
On 29.08.19 10:21, igor.potjevlesch@gmail.com<mailto:igor.potjevlesch@gmail.com>
wrote:
Hello Daniel, Henning,
I'd be interested, but if I'm the only one... Otherwise I can indeed remove this
patch as Henning suggests, but it embarrasses me to have a different source code.
Tell me if it's possible to make it customizable. Otherwise I will consider either
removing the patch or finding another workaround.
Regards,
Igor.
De : Daniel-Constantin Mierla <miconda@gmail.com><mailto:miconda@gmail.com>
Envoyé : mercredi 28 août 2019 20:26
À : igor.potjevlesch@gmail.com<mailto:igor.potjevlesch@gmail.com>; 'Kamailio
(SER) - Users Mailing List'
<sr-users@lists.kamailio.org><mailto:sr-users@lists.kamailio.org>
Objet : Re: [SR-Users] lookup(aliases) issues with 5.2
Hello,
I haven't authored that patch and also never needed an underscore in host part of the
URI, but also it didn't affect me before that change. I guess Juha wanted o be
compliant with the RFC.
If people need to allow an extended set of chars in the host part, I am fine to add some
parameter to control that.
Cheers,
Daniel
On 28.08.19 15:34, igor.potjevlesch@gmail.com<mailto:igor.potjevlesch@gmail.com>
wrote:
Hello,
Hmm, ok. Saw it.
Is it possible to reconsider a less strict control?
Regards,
Igor.
De : Daniel-Constantin Mierla <miconda@gmail.com><mailto:miconda@gmail.com>
Envoyé : mercredi 28 août 2019 10:25
À : igor.potjevlesch@gmail.com<mailto:igor.potjevlesch@gmail.com>; 'Kamailio
(SER) - Users Mailing List'
<sr-users@lists.kamailio.org><mailto:sr-users@lists.kamailio.org>
Objet : Re: [SR-Users] lookup(aliases) issues with 5.2
Hello,
reading again I see that the error with the host uri is printed from the C code. I thought
of another issue that was reported related to IPv6 addresses in the URI that kamctl
rejected.
The problem is that the underscore is not allowed in hostname: the relevant standard is
RFC 1123, section 2.1 "Host Names and Numbers" which limits host names to
letters-digits-hyphen.
I checked the commits log and it seems this more strict verification was added by next
commit:
commit 4994960324d5353222b3de08515bed07802ab7bc
Author: Juha Heinanen <jh@tutpro.com><mailto:jh@tutpro.com>
Date: Wed Jan 10 08:39:48 2018 +0200
core/parser: more strict parsing of sip uri host
Regarding the $ALL_METHODS not being defined, iirc, you should set it to . (or maybe -1 in
this case).
Cheers,
Daniel
On 28.08.19 10:12, igor.potjevlesch@gmail.com<mailto:igor.potjevlesch@gmail.com>
wrote:
Hello Daniel,
We moved to the latest 5.2.4 but hostname with underscore are still not handle properly.
Is it a real design choice or a mistake somewhere in the code that handle domain name?
Regards,
Igor.
De : igor.potjevlesch@gmail.com<mailto:igor.potjevlesch@gmail.com>
<igor.potjevlesch@gmail.com><mailto:igor.potjevlesch@gmail.com>
Envoyé : mardi 27 août 2019 11:53
À : miconda@gmail.com<mailto:miconda@gmail.com>; 'Kamailio (SER) - Users Mailing
List' <sr-users@lists.kamailio.org><mailto:sr-users@lists.kamailio.org>
Objet : RE: [SR-Users] lookup(aliases) issues with 5.2
Hello Daniel,
Thank you for getting back to me.
We will update with 5.2.4 and I'll let you know if it's solved.
Regards,
Igor.
De : Daniel-Constantin Mierla <miconda@gmail.com<mailto:miconda@gmail.com>>
Envoyé : mardi 27 août 2019 09:39
À : Kamailio (SER) - Users Mailing List
<sr-users@lists.kamailio.org<mailto:sr-users@lists.kamailio.org>>;
igor.potjevlesch@gmail.com<mailto:igor.potjevlesch@gmail.com>
Objet : Re: [SR-Users] lookup(aliases) issues with 5.2
Hello,
On 27.08.19 09:27, igor.potjevlesch@gmail.com<mailto:igor.potjevlesch@gmail.com>
wrote:
Hello!
Any help on that matter? Sounds like the domain parsing have been updated. Is it possible
to back on the previous mode?
did you mean backporting to older branches? If yes, it was done to branch 5.2, have you
tried with latest version in that branch?
Cheers,
Daniel
Regards,
Igor.
De : igor.potjevlesch@gmail.com<mailto:igor.potjevlesch@gmail.com>
<igor.potjevlesch@gmail.com><mailto:igor.potjevlesch@gmail.com>
Envoyé : vendredi 23 août 2019 18:53
À : 'Kamailio (SER) - Users Mailing List'
<sr-users@lists.kamailio.org><mailto:sr-users@lists.kamailio.org>
Objet : lookup(aliases) issues with 5.2
Hello!
I have notice some issues with lookup(aliases) since I upgraded to 5.2 from 5.1:
First with kamctl: If this default command is executed:
ctl_cmd_run ul.add "$USRLOC_TABLE" "$OSERUSER@$OSERDOMAIN"
"$2" \
"$UL_EXPIRES" "$DEFAULT_Q" "$UL_PATH" "$UL_FLAGS"
"$BR_FLAGS" "$ALL_METHODS"
as $ALL_METHODS is not defined, there is a huge value in methods and then lookup(aliases)
fails with -2.
I have to update kamctl script and put -1 ("-1") instead of the variable. So,
now, methods is a NULL value in DB and my alias is not ignored. But I use to make my alias
like this: sip:number@blabla_1.local
Which is no longer works: ERROR: registrar [common.c:62]: extract_aor(): failed to parse
AoR [sip:number@blabla_1.local]
Any idea of the difference since 5.2 with this behaviour? Without the underscore, the AoR
seems to be valid but I need to support underscore as before.
Regards,
Igor.
_______________________________________________
Kamailio (SER) - Users Mailing List
sr-users@lists.kamailio.org<mailto:sr-users@lists.kamailio.org>
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users
--
Daniel-Constantin Mierla -- www.asipto.com<http://www.asipto.com>
www.twitter.com/miconda<http://www.twitter.com/miconda> --
www.linkedin.com/in/miconda<http://www.linkedin.com/in/miconda>
--
Daniel-Constantin Mierla -- www.asipto.com<http://www.asipto.com>
www.twitter.com/miconda<http://www.twitter.com/miconda> --
www.linkedin.com/in/miconda<http://www.linkedin.com/in/miconda>
--
Daniel-Constantin Mierla -- www.asipto.com<http://www.asipto.com>
www.twitter.com/miconda<http://www.twitter.com/miconda> --
www.linkedin.com/in/miconda<http://www.linkedin.com/in/miconda>
--
Daniel-Constantin Mierla -- www.asipto.com<http://www.asipto.com>
www.twitter.com/miconda<http://www.twitter.com/miconda> --
www.linkedin.com/in/miconda<http://www.linkedin.com/in/miconda>
Kamailio Advanced Training, Oct 21-23, 2019, Berlin, Germany -- https://asipto.com/u/kat
--
Daniel-Constantin Mierla -- www.asipto.com<http://www.asipto.com>
www.twitter.com/miconda<http://www.twitter.com/miconda> --
www.linkedin.com/in/miconda<http://www.linkedin.com/in/miconda>
Kamailio Advanced Training, Oct 21-23, 2019, Berlin, Germany -- https://asipto.com/u/kat
_______________________________________________
Kamailio (SER) - Users Mailing List
sr-users@lists.kamailio.org<mailto:sr-users@lists.kamailio.org>
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users
--
Kamailio Merchandising - https://skalatan.de/merchandising/
Kamailio services - https://skalatan.de/services
Henning Westerholt - https://skalatan.de/blog/
7 Nov
7 Nov
9:54 a.m.
Hello Henning,
Thank you!
Regards,
Igor.
De : Henning Westerholt <hw(a)skalatan.de
Envoyé : vendredi 1 novembre 2019 18:32
À : Kamailio (SER) - Users Mailing List <sr-users(a)lists.kamailio.org>rg>;
igor.potjevlesch(a)gmail.com; miconda(a)gmail.com
Objet : Re: [SR-Users] lookup(aliases) issues with 5.2
Hello Igor,
functional extensions like this will be usually not be backported to older
stable releases.
But you should be able to easily apply the patch to your local copy, if you
build from tar anyway.
This is the patch, you can apply with the command "patch":
https://github.com/kamailio/kamailio/commit/038158c99da96933c26b11a919ed1cbe
29af9fab.patch
Cheers,
Henning
Am 28.10.19 um 19:13 schrieb igor.potjevlesch(a)gmail.com
<mailto:igor.potjevlesch@gmail.com> :
Hello Daniel,
Thank you!
Is it pushed in one of the latest release? Because we don't have a
connection to git on our server. We build from tar.
Regards,
Igor.
De : Daniel-Constantin Mierla <mailto:miconda@gmail.com>
<miconda(a)gmail.com Envoyé : jeudi 10
octobre 2019 14:40
À : igor.potjevlesch(a)gmail.com <mailto:igor.potjevlesch@gmail.com> ;
'Kamailio (SER) - Users Mailing List' <mailto:sr-users@lists.kamailio.org>
<sr-users(a)lists.kamailio.org>
Objet : Re: [SR-Users] lookup(aliases) issues with 5.2
Hello,
I just pushed a commit adding a core parameter to allow specifying
additional character in the host part of URIs:
-
https://github.com/kamailio/kamailio/commit/038158c99da96933c26b11a919ed1cbe
29af9fab
It is in the master branch. Can you test it and report if works as expected?
Cheers,
Daniel
On 04.10.19 10:08, igor.potjevlesch(a)gmail.com
<mailto:igor.potjevlesch@gmail.com> wrote:
Hello Daniel,
I confirm that we did that indeed. Just added the support of "_" instead of
rollback on the whole code.
Thank you!
Regards,
Igor.
De : Daniel-Constantin Mierla <mailto:miconda@gmail.com>
<miconda(a)gmail.com Envoyé : mercredi 11
septembre 2019 09:51
À : igor.potjevlesch(a)gmail.com <mailto:igor.potjevlesch@gmail.com> ;
'Kamailio (SER) - Users Mailing List' <mailto:sr-users@lists.kamailio.org>
<sr-users(a)lists.kamailio.org>
Objet : Re: [SR-Users] lookup(aliases) issues with 5.2
Hello,
I will think what would be good ways to optimizie.
If you want to change the code, probably doesn't make sense to revert the
entire patch locally, just allow '_' -- you should change:
if(!isalnum(*p) && (*p != '.') && (*p != '-')) {
to
if(!isalnum(*p) && (*p != '.') && (*p != '-') &&
(*p != '_')) {
in src/core/parser/parse_uri.c -- see function parse_uri() and case
URI_HOST_P.
Cheers,
Daniel
On 29.08.19 10:21, igor.potjevlesch(a)gmail.com
<mailto:igor.potjevlesch@gmail.com> wrote:
Hello Daniel, Henning,
I'd be interested, but if I'm the only one... Otherwise I can indeed remove
this patch as Henning suggests, but it embarrasses me to have a different
source code.
Tell me if it's possible to make it customizable. Otherwise I will consider
either removing the patch or finding another workaround.
Regards,
Igor.
De : Daniel-Constantin Mierla <mailto:miconda@gmail.com>
<miconda(a)gmail.com Envoyé : mercredi 28
août 2019 20:26
À : igor.potjevlesch(a)gmail.com <mailto:igor.potjevlesch@gmail.com> ;
'Kamailio (SER) - Users Mailing List' <mailto:sr-users@lists.kamailio.org>
<sr-users(a)lists.kamailio.org>
Objet : Re: [SR-Users] lookup(aliases) issues with 5.2
Hello,
I haven't authored that patch and also never needed an underscore in host
part of the URI, but also it didn't affect me before that change. I guess
Juha wanted o be compliant with the RFC.
If people need to allow an extended set of chars in the host part, I am fine
to add some parameter to control that.
Cheers,
Daniel
On 28.08.19 15:34, igor.potjevlesch(a)gmail.com
<mailto:igor.potjevlesch@gmail.com> wrote:
Hello,
Hmm, ok. Saw it.
Is it possible to reconsider a less strict control?
Regards,
Igor.
De : Daniel-Constantin Mierla <mailto:miconda@gmail.com>
<miconda(a)gmail.com Envoyé : mercredi 28
août 2019 10:25
À : igor.potjevlesch(a)gmail.com <mailto:igor.potjevlesch@gmail.com> ;
'Kamailio (SER) - Users Mailing List' <mailto:sr-users@lists.kamailio.org>
<sr-users(a)lists.kamailio.org>
Objet : Re: [SR-Users] lookup(aliases) issues with 5.2
Hello,
reading again I see that the error with the host uri is printed from the C
code. I thought of another issue that was reported related to IPv6 addresses
in the URI that kamctl rejected.
The problem is that the underscore is not allowed in hostname: the relevant
standard is RFC 1123, section 2.1 "Host Names and Numbers" which limits host
names to letters-digits-hyphen.
I checked the commits log and it seems this more strict verification was
added by next commit:
commit 4994960324d5353222b3de08515bed07802ab7bc
Author: Juha Heinanen <mailto:jh@tutpro.com> <jh(a)tutpro.com>
Date: Wed Jan 10 08:39:48 2018 +0200
core/parser: more strict parsing of sip uri host
Regarding the $ALL_METHODS not being defined, iirc, you should set it to .
(or maybe -1 in this case).
Cheers,
Daniel
On 28.08.19 10:12, igor.potjevlesch(a)gmail.com
<mailto:igor.potjevlesch@gmail.com> wrote:
Hello Daniel,
We moved to the latest 5.2.4 but hostname with underscore are still not
handle properly.
Is it a real design choice or a mistake somewhere in the code that handle
domain name?
Regards,
Igor.
De : igor.potjevlesch(a)gmail.com <mailto:igor.potjevlesch@gmail.com>
<mailto:igor.potjevlesch@gmail.com> <igor.potjevlesch(a)gmail.com Envoyé : mardi 27 août 2019 11:53
À : miconda(a)gmail.com <mailto:miconda@gmail.com> ; 'Kamailio (SER) - Users
Mailing List' <mailto:sr-users@lists.kamailio.org>
<sr-users(a)lists.kamailio.org>
Objet : RE: [SR-Users] lookup(aliases) issues with 5.2
Hello Daniel,
Thank you for getting back to me.
We will update with 5.2.4 and I'll let you know if it's solved.
Regards,
Igor.
De : Daniel-Constantin Mierla <miconda(a)gmail.com <mailto:miconda@gmail.com>
Envoyé : mardi 27 août 2019 09:39
À : Kamailio (SER) - Users Mailing List <sr-users(a)lists.kamailio.org
<mailto:sr-users@lists.kamailio.org> >; igor.potjevlesch(a)gmail.com
<mailto:igor.potjevlesch@gmail.com
Objet : Re: [SR-Users] lookup(aliases) issues with 5.2
Hello,
On 27.08.19 09:27, igor.potjevlesch(a)gmail.com
<mailto:igor.potjevlesch@gmail.com> wrote:
Hello!
Any help on that matter? Sounds like the domain parsing have been updated.
Is it possible to back on the previous mode?
did you mean backporting to older branches? If yes, it was done to branch
5.2, have you tried with latest version in that branch?
Cheers,
Daniel
Regards,
Igor.
De : igor.potjevlesch(a)gmail.com <mailto:igor.potjevlesch@gmail.com>
<mailto:igor.potjevlesch@gmail.com> <igor.potjevlesch(a)gmail.com Envoyé : vendredi 23 août 2019 18:53
À : 'Kamailio (SER) - Users Mailing List'
<mailto:sr-users@lists.kamailio.org> <sr-users(a)lists.kamailio.org>
Objet : lookup(aliases) issues with 5.2
Hello!
I have notice some issues with lookup(aliases) since I upgraded to 5.2 from
5.1:
First with kamctl: If this default command is executed:
ctl_cmd_run ul.add "$USRLOC_TABLE" "$OSERUSER@$OSERDOMAIN"
"$2" \
"$UL_EXPIRES" "$DEFAULT_Q" "$UL_PATH" "$UL_FLAGS"
"$BR_FLAGS" "$ALL_METHODS"
as $ALL_METHODS is not defined, there is a huge value in methods and then
lookup(aliases) fails with -2.
I have to update kamctl script and put -1 ("-1") instead of the variable.
So, now, methods is a NULL value in DB and my alias is not ignored. But I
use to make my alias like this: sip:number@blabla_1.local
Which is no longer works: ERROR: registrar [common.c:62]: extract_aor():
failed to parse AoR [sip:number@blabla_1.local]
Any idea of the difference since 5.2 with this behaviour? Without the
underscore, the AoR seems to be valid but I need to support underscore as
before.
Regards,
Igor.
_______________________________________________
Kamailio (SER) - Users Mailing List
sr-users(a)lists.kamailio.org <mailto:sr-users@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users
--
Daniel-Constantin Mierla -- www.asipto.com <http://www.asipto.com www.twitter.com/miconda
<http://www.twitter.com/miconda> --
www.linkedin.com/in/miconda <http://www.linkedin.com/in/miconda
--
Daniel-Constantin Mierla -- www.asipto.com <http://www.asipto.com www.twitter.com/miconda
<http://www.twitter.com/miconda> --
www.linkedin.com/in/miconda <http://www.linkedin.com/in/miconda
--
Daniel-Constantin Mierla -- www.asipto.com <http://www.asipto.com www.twitter.com/miconda
<http://www.twitter.com/miconda> --
www.linkedin.com/in/miconda <http://www.linkedin.com/in/miconda
--
Daniel-Constantin Mierla -- www.asipto.com <http://www.asipto.com www.twitter.com/miconda
<http://www.twitter.com/miconda> --
www.linkedin.com/in/miconda <http://www.linkedin.com/in/miconda Kamailio Advanced Training, Oct 21-23, 2019,
Berlin, Germany --
https://asipto.com/u/kat
--
Daniel-Constantin Mierla -- www.asipto.com <http://www.asipto.com www.twitter.com/miconda
<http://www.twitter.com/miconda> --
www.linkedin.com/in/miconda <http://www.linkedin.com/in/miconda Kamailio Advanced Training, Oct 21-23, 2019,
Berlin, Germany --
https://asipto.com/u/kat
_______________________________________________
Kamailio (SER) - Users Mailing List
sr-users(a)lists.kamailio.org <mailto:sr-users@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users
--
Kamailio Merchandising - https://skalatan.de/merchandising/
Kamailio services - https://skalatan.de/services
Henning Westerholt - https://skalatan.de/blog/
13 Dec
13 Dec
3:03 p.m.
Hello,
Just to let you know that we have tested the patch and it works fine. Thank
you.
Regards,
Igor.
De : igor.potjevlesch(a)gmail.com <igor.potjevlesch(a)gmail.com Envoyé : jeudi 7 novembre 2019 09:54
À : 'Henning Westerholt' <hw(a)skalatan.de>de>; 'Kamailio (SER) - Users
Mailing
List' <sr-users(a)lists.kamailio.org>rg>; miconda(a)gmail.com
Objet : RE: [SR-Users] lookup(aliases) issues with 5.2
Hello Henning,
Thank you!
Regards,
Igor.
De : Henning Westerholt <hw(a)skalatan.de <mailto:hw@skalatan.de> Envoyé : vendredi 1 novembre 2019 18:32
À : Kamailio (SER) - Users Mailing List <sr-users(a)lists.kamailio.org
<mailto:sr-users@lists.kamailio.org> >; igor.potjevlesch(a)gmail.com
<mailto:igor.potjevlesch@gmail.com> ; miconda(a)gmail.com
<mailto:miconda@gmail.com Objet : Re:
[SR-Users] lookup(aliases) issues with 5.2
Hello Igor,
functional extensions like this will be usually not be backported to older
stable releases.
But you should be able to easily apply the patch to your local copy, if you
build from tar anyway.
This is the patch, you can apply with the command "patch":
https://github.com/kamailio/kamailio/commit/038158c99da96933c26b11a919ed1cbe
29af9fab.patch
Cheers,
Henning
Am 28.10.19 um 19:13 schrieb igor.potjevlesch(a)gmail.com
<mailto:igor.potjevlesch@gmail.com> :
Hello Daniel,
Thank you!
Is it pushed in one of the latest release? Because we don't have a
connection to git on our server. We build from tar.
Regards,
Igor.
De : Daniel-Constantin Mierla <mailto:miconda@gmail.com>
<miconda(a)gmail.com Envoyé : jeudi 10
octobre 2019 14:40
À : igor.potjevlesch(a)gmail.com <mailto:igor.potjevlesch@gmail.com> ;
'Kamailio (SER) - Users Mailing List' <mailto:sr-users@lists.kamailio.org>
<sr-users(a)lists.kamailio.org>
Objet : Re: [SR-Users] lookup(aliases) issues with 5.2
Hello,
I just pushed a commit adding a core parameter to allow specifying
additional character in the host part of URIs:
-
https://github.com/kamailio/kamailio/commit/038158c99da96933c26b11a919ed1cbe
29af9fab
It is in the master branch. Can you test it and report if works as expected?
Cheers,
Daniel
On 04.10.19 10:08, igor.potjevlesch(a)gmail.com
<mailto:igor.potjevlesch@gmail.com> wrote:
Hello Daniel,
I confirm that we did that indeed. Just added the support of "_" instead of
rollback on the whole code.
Thank you!
Regards,
Igor.
De : Daniel-Constantin Mierla <mailto:miconda@gmail.com>
<miconda(a)gmail.com Envoyé : mercredi 11
septembre 2019 09:51
À : igor.potjevlesch(a)gmail.com <mailto:igor.potjevlesch@gmail.com> ;
'Kamailio (SER) - Users Mailing List' <mailto:sr-users@lists.kamailio.org>
<sr-users(a)lists.kamailio.org>
Objet : Re: [SR-Users] lookup(aliases) issues with 5.2
Hello,
I will think what would be good ways to optimizie.
If you want to change the code, probably doesn't make sense to revert the
entire patch locally, just allow '_' -- you should change:
if(!isalnum(*p) && (*p != '.') && (*p != '-')) {
to
if(!isalnum(*p) && (*p != '.') && (*p != '-') &&
(*p != '_')) {
in src/core/parser/parse_uri.c -- see function parse_uri() and case
URI_HOST_P.
Cheers,
Daniel
On 29.08.19 10:21, igor.potjevlesch(a)gmail.com
<mailto:igor.potjevlesch@gmail.com> wrote:
Hello Daniel, Henning,
I'd be interested, but if I'm the only one... Otherwise I can indeed remove
this patch as Henning suggests, but it embarrasses me to have a different
source code.
Tell me if it's possible to make it customizable. Otherwise I will consider
either removing the patch or finding another workaround.
Regards,
Igor.
De : Daniel-Constantin Mierla <mailto:miconda@gmail.com>
<miconda(a)gmail.com Envoyé : mercredi 28
août 2019 20:26
À : igor.potjevlesch(a)gmail.com <mailto:igor.potjevlesch@gmail.com> ;
'Kamailio (SER) - Users Mailing List' <mailto:sr-users@lists.kamailio.org>
<sr-users(a)lists.kamailio.org>
Objet : Re: [SR-Users] lookup(aliases) issues with 5.2
Hello,
I haven't authored that patch and also never needed an underscore in host
part of the URI, but also it didn't affect me before that change. I guess
Juha wanted o be compliant with the RFC.
If people need to allow an extended set of chars in the host part, I am fine
to add some parameter to control that.
Cheers,
Daniel
On 28.08.19 15:34, igor.potjevlesch(a)gmail.com
<mailto:igor.potjevlesch@gmail.com> wrote:
Hello,
Hmm, ok. Saw it.
Is it possible to reconsider a less strict control?
Regards,
Igor.
De : Daniel-Constantin Mierla <mailto:miconda@gmail.com>
<miconda(a)gmail.com Envoyé : mercredi 28
août 2019 10:25
À : igor.potjevlesch(a)gmail.com <mailto:igor.potjevlesch@gmail.com> ;
'Kamailio (SER) - Users Mailing List' <mailto:sr-users@lists.kamailio.org>
<sr-users(a)lists.kamailio.org>
Objet : Re: [SR-Users] lookup(aliases) issues with 5.2
Hello,
reading again I see that the error with the host uri is printed from the C
code. I thought of another issue that was reported related to IPv6 addresses
in the URI that kamctl rejected.
The problem is that the underscore is not allowed in hostname: the relevant
standard is RFC 1123, section 2.1 "Host Names and Numbers" which limits host
names to letters-digits-hyphen.
I checked the commits log and it seems this more strict verification was
added by next commit:
commit 4994960324d5353222b3de08515bed07802ab7bc
Author: Juha Heinanen <mailto:jh@tutpro.com> <jh(a)tutpro.com>
Date: Wed Jan 10 08:39:48 2018 +0200
core/parser: more strict parsing of sip uri host
Regarding the $ALL_METHODS not being defined, iirc, you should set it to .
(or maybe -1 in this case).
Cheers,
Daniel
On 28.08.19 10:12, igor.potjevlesch(a)gmail.com
<mailto:igor.potjevlesch@gmail.com> wrote:
Hello Daniel,
We moved to the latest 5.2.4 but hostname with underscore are still not
handle properly.
Is it a real design choice or a mistake somewhere in the code that handle
domain name?
Regards,
Igor.
De : igor.potjevlesch(a)gmail.com <mailto:igor.potjevlesch@gmail.com>
<mailto:igor.potjevlesch@gmail.com> <igor.potjevlesch(a)gmail.com Envoyé : mardi 27 août 2019 11:53
À : miconda(a)gmail.com <mailto:miconda@gmail.com> ; 'Kamailio (SER) - Users
Mailing List' <mailto:sr-users@lists.kamailio.org>
<sr-users(a)lists.kamailio.org>
Objet : RE: [SR-Users] lookup(aliases) issues with 5.2
Hello Daniel,
Thank you for getting back to me.
We will update with 5.2.4 and I'll let you know if it's solved.
Regards,
Igor.
De : Daniel-Constantin Mierla <miconda(a)gmail.com <mailto:miconda@gmail.com>
Envoyé : mardi 27 août 2019 09:39
À : Kamailio (SER) - Users Mailing List <sr-users(a)lists.kamailio.org
<mailto:sr-users@lists.kamailio.org> >; igor.potjevlesch(a)gmail.com
<mailto:igor.potjevlesch@gmail.com
Objet : Re: [SR-Users] lookup(aliases) issues with 5.2
Hello,
On 27.08.19 09:27, igor.potjevlesch(a)gmail.com
<mailto:igor.potjevlesch@gmail.com> wrote:
Hello!
Any help on that matter? Sounds like the domain parsing have been updated.
Is it possible to back on the previous mode?
did you mean backporting to older branches? If yes, it was done to branch
5.2, have you tried with latest version in that branch?
Cheers,
Daniel
Regards,
Igor.
De : igor.potjevlesch(a)gmail.com <mailto:igor.potjevlesch@gmail.com>
<mailto:igor.potjevlesch@gmail.com> <igor.potjevlesch(a)gmail.com Envoyé : vendredi 23 août 2019 18:53
À : 'Kamailio (SER) - Users Mailing List'
<mailto:sr-users@lists.kamailio.org> <sr-users(a)lists.kamailio.org>
Objet : lookup(aliases) issues with 5.2
Hello!
I have notice some issues with lookup(aliases) since I upgraded to 5.2 from
5.1:
First with kamctl: If this default command is executed:
ctl_cmd_run ul.add "$USRLOC_TABLE" "$OSERUSER@$OSERDOMAIN"
"$2" \
"$UL_EXPIRES" "$DEFAULT_Q" "$UL_PATH" "$UL_FLAGS"
"$BR_FLAGS" "$ALL_METHODS"
as $ALL_METHODS is not defined, there is a huge value in methods and then
lookup(aliases) fails with -2.
I have to update kamctl script and put -1 ("-1") instead of the variable.
So, now, methods is a NULL value in DB and my alias is not ignored. But I
use to make my alias like this: sip:number@blabla_1.local
Which is no longer works: ERROR: registrar [common.c:62]: extract_aor():
failed to parse AoR [sip:number@blabla_1.local]
Any idea of the difference since 5.2 with this behaviour? Without the
underscore, the AoR seems to be valid but I need to support underscore as
before.
Regards,
Igor.
_______________________________________________
Kamailio (SER) - Users Mailing List
sr-users(a)lists.kamailio.org <mailto:sr-users@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users
--
Daniel-Constantin Mierla -- www.asipto.com <http://www.asipto.com www.twitter.com/miconda
<http://www.twitter.com/miconda> --
www.linkedin.com/in/miconda <http://www.linkedin.com/in/miconda
--
Daniel-Constantin Mierla -- www.asipto.com <http://www.asipto.com www.twitter.com/miconda
<http://www.twitter.com/miconda> --
www.linkedin.com/in/miconda <http://www.linkedin.com/in/miconda
--
Daniel-Constantin Mierla -- www.asipto.com <http://www.asipto.com www.twitter.com/miconda
<http://www.twitter.com/miconda> --
www.linkedin.com/in/miconda <http://www.linkedin.com/in/miconda
--
Daniel-Constantin Mierla -- www.asipto.com <http://www.asipto.com www.twitter.com/miconda
<http://www.twitter.com/miconda> --
www.linkedin.com/in/miconda <http://www.linkedin.com/in/miconda Kamailio Advanced Training, Oct 21-23, 2019,
Berlin, Germany --
https://asipto.com/u/kat
--
Daniel-Constantin Mierla -- www.asipto.com <http://www.asipto.com www.twitter.com/miconda
<http://www.twitter.com/miconda> --
www.linkedin.com/in/miconda <http://www.linkedin.com/in/miconda Kamailio Advanced Training, Oct 21-23, 2019,
Berlin, Germany --
https://asipto.com/u/kat
_______________________________________________
Kamailio (SER) - Users Mailing List
sr-users(a)lists.kamailio.org <mailto:sr-users@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users
--
Kamailio Merchandising - https://skalatan.de/merchandising/
Kamailio services - https://skalatan.de/services
Henning Westerholt - https://skalatan.de/blog/
1590
days inactive
1702
days old
16 comments
4 participants
participants (4)
-
Daniel-Constantin Mierla -
Henning Westerholt -
Igor Potjevlesh -
igor.potjevlesch＠gmail.com