record_route_advertised_address question - sr-users

Hugh Waite

17 Sep 17 Sep

11:34 a.m.

Hi, The record_route_advertised_address() function uses the COND_IF_DIFF_PROTO conditional to insert the outbound record route header if the protocol differs, and only when the enable_double_rr parameter is true (which it is by default) so it is a bug if this is not happening. This function was written because the "record_route_preset()" function did not create double record-routes and "record_route()" did not use the advertised address correctly. When Daniel implemented the feature to specify an advertised address per listen socket in March, it also fixed the standard "record_route()" function so that advertised addresses specified in the cfg file work correctly in a record route. I don't think that the record_route_advertised_address function is necessary anymore, but if record_route() with an advertised address does not provide the functionality you need, r_r_a_a() should be fixed. An issue on the bug tracker will allow a decision about fixing or obsoleting this function. Regards, Hugh On 17/09/2012 15:38, Juha Heinanen wrote:

...

rr readme on record_route_advertised_address function tells: Note: A second Record-Route will be inserted if the transport used on the inbound and outbound interfaces changes. that is not the case. i made call record_route_advertised_address("192.98.103.10:5060"); when request came over udp and went out over tcp and only one rr header was inserted: incoming: U 2012/09/17 17:30:17.467079 192.98.103.10:5060 -> 192.98.103.2:5070 INVITE sip:test@test.fi SIP/2.0. ... outgoing: T 2012/09/17 17:30:17.504631 192.98.103.10:5060 -> 192.98.103.10:38078 [AP] INVITE sip:0x20b7580@192.98.103.10:5050;transport=tcp SIP/2.0. Record-Route: <sip:192.98.103.10:5060;ftag=wumod;lr>. ... i have not set enable_double_rr param and default is 1. is this a bug that i should report on the tracker? -- juha _______________________________________________ SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list sr-users(a)lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users

-- Hugh Waite Principal Design Engineer Crocodile RCS Ltd.

Reply

Daniel-Constantin Mierla

4:58 p.m.

Hello, On 9/17/12 5:48 PM, Juha Heinanen wrote:

...

Hugh Waite writes:

This function was written because the "record_route_preset()" function did not create double record-routes and "record_route()" did not use the advertised address correctly. When Daniel implemented the feature to specify an advertised address per listen socket in March, it also fixed the standard "record_route()" function so that advertised addresses specified in the cfg file work correctly in a record route.

hugh, thanks for the explanation. it turned out that i cannot use "record_route_advertised_address()" anyhow, because i need to also have different ports on each side. so switched to "record_route_preset()", which does what i want. anyhow, i can add tracker item just in case someone later would need a working record_route_advertised_address().

as Hugh pointed, doesn't the 'advertise' attribute for listen do what you need? http://www.kamailio.org/wiki/cookbooks/3.3.x/core#listen If you add 'advertise' address to listen parameter, then you just have to use the classic record_route(). Cheers, Daniel -- Daniel-Constantin Mierla - http://www.asipto.com http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda Kamailio Advanced Training, Berlin, Nov 5-8, 2012 - http://asipto.com/u/kat Kamailio Advanced Training, Miami, USA, Nov 12-14, 2012 - http://asipto.com/u/katu

Reply

Daniel-Constantin Mierla

2:40 a.m.

On 9/18/12 7:17 AM, Juha Heinanen wrote:

...

Daniel-Constantin Mierla writes:

as Hugh pointed, doesn't the 'advertise' attribute for listen do what you need? http://www.kamailio.org/wiki/cookbooks/3.3.x/core#listen If you add 'advertise' address to listen parameter, then you just have to use the classic record_route().

i'll need to test if i "advertise" address does what i want, but i doubt it, because it changes also via address.

record_route_advertised_address() was supposed to do the same, use the value of the advertised_address in record-route header, otherwise the purpose of advertised_address is to be used in Via header Cheers, Daniel -- Daniel-Constantin Mierla - http://www.asipto.com http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda Kamailio Advanced Training, Berlin, Nov 5-8, 2012 - http://asipto.com/u/kat Kamailio Advanced Training, Miami, USA, Nov 12-14, 2012 - http://asipto.com/u/katu

Reply