Hello again,

I made a dedicated section for lcr module and mentioned the upgrade script. Please make any changes you want to improve it.

Thanks, Daniel

On 10/4/10 10:35 AM, Daniel-Constantin Mierla wrote:

Hello Juha,

On 10/4/10 10:33 AM, Juha Heinanen wrote:

...

Daniel-Constantin Mierla writes:

...

please take a moment and check the upgrade guidelines at: http://sip-router.org/wiki/install/3.0.x-to-3.1.x

daniel,

i checked lcr part of Database Structure section and it does not mention the upgrade script i have provided and which is mentioned and referenced in Modules section. so this statement is not true:

Beware that you will lose old data you had for lcr module since the new version requires new tables

if the upgrade script is run.

i don't know how to handle this in the document. should i copy the upgrade script to modules/lcr/utils dir?

right, this should be clarified. I saw the link to the migration script in the next section, which talks about the lcr module changes.

I will try to rephrase there, mentioning the migration script.

Thanks, Daniel

On 10/4/10 10:52 AM, Juha Heinanen wrote:

Daniel-Constantin Mierla writes:

...

I made a dedicated section for lcr module and mentioned the upgrade script. Please make any changes you want to improve it.

thanks,

another thing. i don't think this is valid anymore:

modules_k/auth_radius

Functions www_challenge()/proxy_challenge() are not anymore used to send 401/407 responses. See examples in README file on how to send those responses.

there might been some change after this text was written. at least in my script, those functions are sending the responses.

indeed, iirc, those functions no longer existed in modules_s/auth but now are back coming from module_k/auth because of the merge. Section has to be updated.

Anyhow, for reference, it should work without them as well, like the ser way of sending challenge.

Cheers, Daniel