[OpenSER-Users] Is it a bug? TM module is sending CANCEL request regardless what the script do with the From Header since 1.3.0
I'm not sure if it is a bug. Currently our set up need to do masquerading on the From header for all invite requests. It used to work okie when we process for the CANCEL request in the routing logic. But after upgrading to openser 1.3.0, the TM module is sending CANCEL out using local cached From info rather than the info processed by uac_replace_from. May I know is this by design or it is a bug?
Rgds,
BS
Hi Bai Shi,
you say that in 1.3 (opposite to 1.2), the forwarded CANCELs preserve the received FROM hdr instead of using the changed FROM, right?
Regards, Bogdan
Bai Shi wrote:
I’m not sure if it is a bug. Currently our set up need to do masquerading on the From header for all invite requests. It used to work okie when we process for the CANCEL request in the routing logic. But after upgrading to openser 1.3.0, the TM module is sending CANCEL out using local cached From info rather than the info processed by uac_replace_from. May I know is this by design or it is a bug?
Rgds,
BS
Users mailing list Users@lists.openser.org http://lists.openser.org/cgi-bin/mailman/listinfo/users
Exactly. In 1.2 the forwarded Cancels will preserve the modified attribute according to routing logic. However in 1.3, no matter what is in the routing block. The Cancel will derive information from the original request send by the UAC. Actually I guess it is not only the FROM, all the header fields are all sending out according to the original received information. No change will take effect.
I just saw the openser change log for 1.3.1, I wonder if it is the problem of message cloning. I'll update you after I test with 1.3.1.
-----Original Message----- From: Bogdan-Andrei Iancu [mailto:bogdan@voice-system.ro] Sent: 2008年3月12日 1:32 To: Bai Shi Cc: users@lists.openser.org Subject: Re: [OpenSER-Users] Is it a bug? TM module is sending CANCEL requestregardless what the script do with the From Header since 1.3.0
Hi Bai Shi,
you say that in 1.3 (opposite to 1.2), the forwarded CANCELs preserve the received FROM hdr instead of using the changed FROM, right?
Regards, Bogdan
Bai Shi wrote:
I’m not sure if it is a bug. Currently our set up need to do masquerading on the From header for all invite requests. It used to work okie when we process for the CANCEL request in the routing logic. But after upgrading to openser 1.3.0, the TM module is sending CANCEL out using local cached From info rather than the info processed by uac_replace_from. May I know is this by design or it is a bug?
Rgds,
BS
Users mailing list Users@lists.openser.org http://lists.openser.org/cgi-bin/mailman/listinfo/users
Hi Bogdan,
Confirmed. The phenomenon is still there in 1.3.1
I don't know whether this is by design or it is a bug. But I believe no matter why somebody modified something in the Invite, he'd like the Cancel will have the same attribute =).
BTW, the early ACK to negative Invite response has the same problem. It will not look for modified Invite headers but will send out according to UAC's request copy. Thanks for your time and effort on this.
Rgds, Bai Shi
-----Original Message----- From: Bogdan-Andrei Iancu [mailto:bogdan@voice-system.ro] Sent: 2008年3月12日 1:32 To: Bai Shi Cc: users@lists.openser.org Subject: Re: [OpenSER-Users] Is it a bug? TM module is sending CANCEL requestregardless what the script do with the From Header since 1.3.0
Hi Bai Shi,
you say that in 1.3 (opposite to 1.2), the forwarded CANCELs preserve the received FROM hdr instead of using the changed FROM, right?
Regards, Bogdan
Bai Shi wrote:
I’m not sure if it is a bug. Currently our set up need to do masquerading on the From header for all invite requests. It used to work okie when we process for the CANCEL request in the routing logic. But after upgrading to openser 1.3.0, the TM module is sending CANCEL out using local cached From info rather than the info processed by uac_replace_from. May I know is this by design or it is a bug?
Rgds,
BS
Users mailing list Users@lists.openser.org http://lists.openser.org/cgi-bin/mailman/listinfo/users
Hi Bogdan,
you say that in 1.3 (opposite to 1.2), the forwarded CANCELs preserve the received FROM hdr instead of using the changed FROM, right?
I use 1.2.2 and I face the same issue. I do change the From in the INVITE, but in CANCEL the unchanged header is sent out. Do I manually have to replace From in the CANCEL as well, or should OpenSER automatically take care of that?
Andreas
Regards, Bogdan
Bai Shi wrote:
I’m not sure if it is a bug. Currently our set up need to do masquerading on the From header for all invite requests. It used to work okie when we process for the CANCEL request in the routing logic. But after upgrading to openser 1.3.0, the TM module is sending CANCEL out using local cached From info rather than the info processed by uac_replace_from. May I know is this by design or it is a bug?
Rgds,
BS
Users mailing list Users@lists.openser.org http://lists.openser.org/cgi-bin/mailman/listinfo/users
Users mailing list Users@lists.openser.org http://lists.openser.org/cgi-bin/mailman/listinfo/users
Hi Andreas,
Actually it is different issue =P. You can manually change From in CANCEL in 1.2.2, however, in 1.3.0/1 even if you do manually modification, it won't work at all =).
I think since TM module will take care of the uri rewriting, it should smart enough up replace the From/To/Contact headers correct?
Rgds, Bai Shi
-----Original Message----- From: Andreas Granig [mailto:agranig@sipwise.com] Sent: 2008年3月12日 19:00 To: Bogdan-Andrei Iancu Cc: Bai Shi; users@lists.openser.org Subject: Re: [OpenSER-Users] Is it a bug? TM module is sending CANCEL requestregardless what the script do with the From Header since 1.3.0
Hi Bogdan,
you say that in 1.3 (opposite to 1.2), the forwarded CANCELs preserve the received FROM hdr instead of using the changed FROM, right?
I use 1.2.2 and I face the same issue. I do change the From in the INVITE, but in CANCEL the unchanged header is sent out. Do I manually have to replace From in the CANCEL as well, or should OpenSER automatically take care of that?
Andreas
Regards, Bogdan
Bai Shi wrote:
I’m not sure if it is a bug. Currently our set up need to do masquerading on the From header for all invite requests. It used to work okie when we process for the CANCEL request in the routing logic. But after upgrading to openser 1.3.0, the TM module is sending CANCEL out using local cached From info rather than the info processed by uac_replace_from. May I know is this by design or it is a bug?
Rgds,
BS
Users mailing list Users@lists.openser.org http://lists.openser.org/cgi-bin/mailman/listinfo/users
Users mailing list Users@lists.openser.org http://lists.openser.org/cgi-bin/mailman/listinfo/users
Hi,
Actually it is different issue =P. You can manually change From in CANCEL in 1.2.2, however, in 1.3.0/1 even if you do manually modification, it won't work at all =).
I see. Well, problem is that you normally do quite some processing in INVITE, loading stuff from DB and so on, which then can for example end up in the From header. So is there a way to preserve AVPs so they're available in the CANCEL as well? Or do I manually have to fetch all that stuff again for the CANCEL?
I think since TM module will take care of the uri rewriting, it should smart enough up replace the From/To/Contact headers correct?
Agreed.
Andreas
Rgds, Bai Shi
-----Original Message----- From: Andreas Granig [mailto:agranig@sipwise.com] Sent: 2008年3月12日 19:00 To: Bogdan-Andrei Iancu Cc: Bai Shi; users@lists.openser.org Subject: Re: [OpenSER-Users] Is it a bug? TM module is sending CANCEL requestregardless what the script do with the From Header since 1.3.0
Hi Bogdan,
you say that in 1.3 (opposite to 1.2), the forwarded CANCELs preserve the received FROM hdr instead of using the changed FROM, right?
I use 1.2.2 and I face the same issue. I do change the From in the INVITE, but in CANCEL the unchanged header is sent out. Do I manually have to replace From in the CANCEL as well, or should OpenSER automatically take care of that?
Andreas
Regards, Bogdan
Bai Shi wrote:
I’m not sure if it is a bug. Currently our set up need to do masquerading on the From header for all invite requests. It used to work okie when we process for the CANCEL request in the routing logic. But after upgrading to openser 1.3.0, the TM module is sending CANCEL out using local cached From info rather than the info processed by uac_replace_from. May I know is this by design or it is a bug?
Rgds,
BS
Users mailing list Users@lists.openser.org http://lists.openser.org/cgi-bin/mailman/listinfo/users
Users mailing list Users@lists.openser.org http://lists.openser.org/cgi-bin/mailman/listinfo/users
I think avp can be choose to preserve in the whole transaction by modparam of TM module. Try your luck at onreply_avp_mode (integer) But I do think if openser could take this over, it'll be a nice thing. Anyway openser has to store a copy of sip msg, then why not store the manipulated version? Just a piece of mind =) Rgds, Bai Shi
-----Original Message----- From: Andreas Granig [mailto:agranig@sipwise.com] Sent: 2008年3月12日 19:10 To: Bai Shi Cc: Bogdan-Andrei Iancu; users@lists.openser.org Subject: Re: [OpenSER-Users] Is it a bug? TM module is sending CANCEL requestregardlesswhat the script do with the From Header since 1.3.0
Hi,
Actually it is different issue =P. You can manually change From in CANCEL in 1.2.2, however, in 1.3.0/1 even if you do manually modification, it won't work at all =).
I see. Well, problem is that you normally do quite some processing in INVITE, loading stuff from DB and so on, which then can for example end up in the From header. So is there a way to preserve AVPs so they're available in the CANCEL as well? Or do I manually have to fetch all that stuff again for the CANCEL?
I think since TM module will take care of the uri rewriting, it should smart enough up replace the From/To/Contact headers correct?
Agreed.
Andreas
Rgds, Bai Shi
-----Original Message----- From: Andreas Granig [mailto:agranig@sipwise.com] Sent: 2008年3月12日 19:00 To: Bogdan-Andrei Iancu Cc: Bai Shi; users@lists.openser.org Subject: Re: [OpenSER-Users] Is it a bug? TM module is sending CANCEL requestregardless what the script do with the From Header since 1.3.0
Hi Bogdan,
you say that in 1.3 (opposite to 1.2), the forwarded CANCELs preserve the received FROM hdr instead of using the changed FROM, right?
I use 1.2.2 and I face the same issue. I do change the From in the INVITE, but in CANCEL the unchanged header is sent out. Do I manually have to replace From in the CANCEL as well, or should OpenSER automatically take care of that?
Andreas
Regards, Bogdan
Bai Shi wrote:
I’m not sure if it is a bug. Currently our set up need to do masquerading on the From header for all invite requests. It used to work okie when we process for the CANCEL request in the routing logic. But after upgrading to openser 1.3.0, the TM module is sending CANCEL out using local cached From info rather than the info processed by uac_replace_from. May I know is this by design or it is a bug?
Rgds,
BS
Users mailing list Users@lists.openser.org http://lists.openser.org/cgi-bin/mailman/listinfo/users
Users mailing list Users@lists.openser.org http://lists.openser.org/cgi-bin/mailman/listinfo/users
Bogdan,
Can you confirm that with onreply_avp_mode set to 1, the AVPs will also be available in CANCEL, or just in reply/branch/failure routes?
Thanks, Andreas
Bai Shi wrote:
I think avp can be choose to preserve in the whole transaction by modparam of TM module. Try your luck at onreply_avp_mode (integer) But I do think if openser could take this over, it'll be a nice thing. Anyway openser has to store a copy of sip msg, then why not store the manipulated version? Just a piece of mind =) Rgds, Bai Shi
-----Original Message----- From: Andreas Granig [mailto:agranig@sipwise.com] Sent: 2008年3月12日 19:10 To: Bai Shi Cc: Bogdan-Andrei Iancu; users@lists.openser.org Subject: Re: [OpenSER-Users] Is it a bug? TM module is sending CANCEL requestregardlesswhat the script do with the From Header since 1.3.0
Hi,
Actually it is different issue =P. You can manually change From in CANCEL in 1.2.2, however, in 1.3.0/1 even if you do manually modification, it won't work at all =).
I see. Well, problem is that you normally do quite some processing in INVITE, loading stuff from DB and so on, which then can for example end up in the From header. So is there a way to preserve AVPs so they're available in the CANCEL as well? Or do I manually have to fetch all that stuff again for the CANCEL?
I think since TM module will take care of the uri rewriting, it should smart enough up replace the From/To/Contact headers correct?
Agreed.
Andreas
Rgds, Bai Shi
-----Original Message----- From: Andreas Granig [mailto:agranig@sipwise.com] Sent: 2008年3月12日 19:00 To: Bogdan-Andrei Iancu Cc: Bai Shi; users@lists.openser.org Subject: Re: [OpenSER-Users] Is it a bug? TM module is sending CANCEL requestregardless what the script do with the From Header since 1.3.0
Hi Bogdan,
you say that in 1.3 (opposite to 1.2), the forwarded CANCELs preserve the received FROM hdr instead of using the changed FROM, right?
I use 1.2.2 and I face the same issue. I do change the From in the INVITE, but in CANCEL the unchanged header is sent out. Do I manually have to replace From in the CANCEL as well, or should OpenSER automatically take care of that?
Andreas
Regards, Bogdan
Bai Shi wrote:
I’m not sure if it is a bug. Currently our set up need to do masquerading on the From header for all invite requests. It used to work okie when we process for the CANCEL request in the routing logic. But after upgrading to openser 1.3.0, the TM module is sending CANCEL out using local cached From info rather than the info processed by uac_replace_from. May I know is this by design or it is a bug?
Rgds,
BS
Users mailing list Users@lists.openser.org http://lists.openser.org/cgi-bin/mailman/listinfo/users
Users mailing list Users@lists.openser.org http://lists.openser.org/cgi-bin/mailman/listinfo/users
Andreas,
No, it will not, as CANCEL forms a separate transaction than the INVITE and the AVPs are per transaction.
Regards, Bogdan
Andreas Granig wrote:
Bogdan,
Can you confirm that with onreply_avp_mode set to 1, the AVPs will also be available in CANCEL, or just in reply/branch/failure routes?
Thanks, Andreas
Bai Shi wrote:
I think avp can be choose to preserve in the whole transaction by modparam of TM module. Try your luck at onreply_avp_mode (integer) But I do think if openser could take this over, it'll be a nice thing. Anyway openser has to store a copy of sip msg, then why not store the manipulated version? Just a piece of mind =) Rgds, Bai Shi
-----Original Message----- From: Andreas Granig [mailto:agranig@sipwise.com] Sent: 2008年3月12日 19:10 To: Bai Shi Cc: Bogdan-Andrei Iancu; users@lists.openser.org Subject: Re: [OpenSER-Users] Is it a bug? TM module is sending CANCEL requestregardlesswhat the script do with the From Header since 1.3.0
Hi,
Actually it is different issue =P. You can manually change From in CANCEL in 1.2.2, however, in 1.3.0/1 even if you do manually modification, it won't work at all =).
I see. Well, problem is that you normally do quite some processing in INVITE, loading stuff from DB and so on, which then can for example end up in the From header. So is there a way to preserve AVPs so they're available in the CANCEL as well? Or do I manually have to fetch all that stuff again for the CANCEL?
I think since TM module will take care of the uri rewriting, it should smart enough up replace the From/To/Contact headers correct?
Agreed.
Andreas
Rgds, Bai Shi
-----Original Message----- From: Andreas Granig [mailto:agranig@sipwise.com] Sent: 2008年3月12日 19:00 To: Bogdan-Andrei Iancu Cc: Bai Shi; users@lists.openser.org Subject: Re: [OpenSER-Users] Is it a bug? TM module is sending CANCEL requestregardless what the script do with the From Header since 1.3.0
Hi Bogdan,
you say that in 1.3 (opposite to 1.2), the forwarded CANCELs preserve the received FROM hdr instead of using the changed FROM, right?
I use 1.2.2 and I face the same issue. I do change the From in the INVITE, but in CANCEL the unchanged header is sent out. Do I manually have to replace From in the CANCEL as well, or should OpenSER automatically take care of that?
Andreas
Regards, Bogdan
Bai Shi wrote:
I’m not sure if it is a bug. Currently our set up need to do masquerading on the From header for all invite requests. It used to work okie when we process for the CANCEL request in the routing logic. But after upgrading to openser 1.3.0, the TM module is sending CANCEL out using local cached From info rather than the info processed by uac_replace_from. May I know is this by design or it is a bug?
Rgds,
BS
Users mailing list Users@lists.openser.org http://lists.openser.org/cgi-bin/mailman/listinfo/users
Users mailing list Users@lists.openser.org http://lists.openser.org/cgi-bin/mailman/listinfo/users
Users mailing list Users@lists.openser.org http://lists.openser.org/cgi-bin/mailman/listinfo/users
Hi Andreas,
Just saw ur other thread regarding the PGW's 481 Call Leg does not exist. I think since the RFC requires the From number to be identical with the initial invite and the cancel. TM should take the modified version sent out rather than the original version received from the UAT. So that same db operation and algorithm need not to be redo. And the TM is anyway storing the SIP message, even if avp can be stored across the transaction, it will cause side effect on the performance. So store a copy of the modified message might be a good idea?
Plus the automatic ACK to negative Invite face the same problem also. And even worse, because the routing logic doesn't have any control of it. Though it shouldn't cause problem, but ACK to a non-existing call leg may cause UAS 487 retransmission, doesn't it?
Rgds, Bai Shi
-----Original Message----- From: Andreas Granig [mailto:agranig@sipwise.com] Sent: 2008年3月12日 19:10 To: Bai Shi Cc: Bogdan-Andrei Iancu; users@lists.openser.org Subject: Re: [OpenSER-Users] Is it a bug? TM module is sending CANCEL requestregardlesswhat the script do with the From Header since 1.3.0
Hi,
Actually it is different issue =P. You can manually change From in CANCEL in 1.2.2, however, in 1.3.0/1 even if you do manually modification, it won't work at all =).
I see. Well, problem is that you normally do quite some processing in INVITE, loading stuff from DB and so on, which then can for example end up in the From header. So is there a way to preserve AVPs so they're available in the CANCEL as well? Or do I manually have to fetch all that stuff again for the CANCEL?
I think since TM module will take care of the uri rewriting, it should smart enough up replace the From/To/Contact headers correct?
Agreed.
Andreas
Rgds, Bai Shi
-----Original Message----- From: Andreas Granig [mailto:agranig@sipwise.com] Sent: 2008年3月12日 19:00 To: Bogdan-Andrei Iancu Cc: Bai Shi; users@lists.openser.org Subject: Re: [OpenSER-Users] Is it a bug? TM module is sending CANCEL requestregardless what the script do with the From Header since 1.3.0
Hi Bogdan,
you say that in 1.3 (opposite to 1.2), the forwarded CANCELs preserve the received FROM hdr instead of using the changed FROM, right?
I use 1.2.2 and I face the same issue. I do change the From in the INVITE, but in CANCEL the unchanged header is sent out. Do I manually have to replace From in the CANCEL as well, or should OpenSER automatically take care of that?
Andreas
Regards, Bogdan
Bai Shi wrote:
I’m not sure if it is a bug. Currently our set up need to do masquerading on the From header for all invite requests. It used to work okie when we process for the CANCEL request in the routing logic. But after upgrading to openser 1.3.0, the TM module is sending CANCEL out using local cached From info rather than the info processed by uac_replace_from. May I know is this by design or it is a bug?
Rgds,
BS
Users mailing list Users@lists.openser.org http://lists.openser.org/cgi-bin/mailman/listinfo/users
Users mailing list Users@lists.openser.org http://lists.openser.org/cgi-bin/mailman/listinfo/users
Hi guys,
just some useful info:
in pre 1.3.0, TM was not implementing hop-by-hop cancel (as generating the requests), but it was doing just forward. In this case you had to manually mangle the CANCEL request also, similar to INVITE one.
starting with 1.3.0, TM implements hop-by-hop cancel - it construct a new CANCEL request instead of forwarding the received one. Here, the FROM hdr changes (from INVITE) should be automatically reflected in the newly generated CANCEL.....If not, it means two things: - your CANCEL does not match any INVITE request - it is a bug..
I will run some tests on trunk ....
Regards, Bogdan
Bai Shi wrote:
Hi Andreas,
Actually it is different issue =P. You can manually change From in CANCEL in 1.2.2, however, in 1.3.0/1 even if you do manually modification, it won't work at all =).
I think since TM module will take care of the uri rewriting, it should smart enough up replace the From/To/Contact headers correct?
Rgds, Bai Shi
-----Original Message----- From: Andreas Granig [mailto:agranig@sipwise.com] Sent: 2008年3月12日 19:00 To: Bogdan-Andrei Iancu Cc: Bai Shi; users@lists.openser.org Subject: Re: [OpenSER-Users] Is it a bug? TM module is sending CANCEL requestregardless what the script do with the From Header since 1.3.0
Hi Bogdan,
you say that in 1.3 (opposite to 1.2), the forwarded CANCELs preserve the received FROM hdr instead of using the changed FROM, right?
I use 1.2.2 and I face the same issue. I do change the From in the INVITE, but in CANCEL the unchanged header is sent out. Do I manually have to replace From in the CANCEL as well, or should OpenSER automatically take care of that?
Andreas
Regards, Bogdan
Bai Shi wrote:
I’m not sure if it is a bug. Currently our set up need to do masquerading on the From header for all invite requests. It used to work okie when we process for the CANCEL request in the routing logic. But after upgrading to openser 1.3.0, the TM module is sending CANCEL out using local cached From info rather than the info processed by uac_replace_from. May I know is this by design or it is a bug?
Rgds,
BS
Users mailing list Users@lists.openser.org http://lists.openser.org/cgi-bin/mailman/listinfo/users
Users mailing list Users@lists.openser.org http://lists.openser.org/cgi-bin/mailman/listinfo/users
Hi Bogdan,
Upon my test, at least uac_replace_from will do nothing to the automatically generated CANCEL. For my case I have to forward it manually through stateless forward. To be precise, no matter what is in the routing block, the CANCEL carries the same message =S
As I mentioned, I think the automatic early ACK to invite negative reply has the same problem. It will take the information in the pre-modified version. I think if possible, these two could be changed in the same time and will make life much easier =)
Rgds, Bai Shi
-----Original Message----- From: Bogdan-Andrei Iancu [mailto:bogdan@voice-system.ro] Sent: 2008年3月12日 19:12 To: Bai Shi Cc: Andreas Granig; users@lists.openser.org Subject: Re: [OpenSER-Users] Is it a bug? TM module is sending CANCEL requestregardlesswhat the script do with the From Header since 1.3.0
Hi guys,
just some useful info:
in pre 1.3.0, TM was not implementing hop-by-hop cancel (as generating the requests), but it was doing just forward. In this case you had to manually mangle the CANCEL request also, similar to INVITE one.
starting with 1.3.0, TM implements hop-by-hop cancel - it construct a new CANCEL request instead of forwarding the received one. Here, the FROM hdr changes (from INVITE) should be automatically reflected in the newly generated CANCEL.....If not, it means two things: - your CANCEL does not match any INVITE request - it is a bug..
I will run some tests on trunk ....
Regards, Bogdan
Bai Shi wrote:
Hi Andreas,
Actually it is different issue =P. You can manually change From in CANCEL in 1.2.2, however, in 1.3.0/1 even if you do manually modification, it won't work at all =).
I think since TM module will take care of the uri rewriting, it should smart enough up replace the From/To/Contact headers correct?
Rgds, Bai Shi
-----Original Message----- From: Andreas Granig [mailto:agranig@sipwise.com] Sent: 2008年3月12日 19:00 To: Bogdan-Andrei Iancu Cc: Bai Shi; users@lists.openser.org Subject: Re: [OpenSER-Users] Is it a bug? TM module is sending CANCEL requestregardless what the script do with the From Header since 1.3.0
Hi Bogdan,
you say that in 1.3 (opposite to 1.2), the forwarded CANCELs preserve the received FROM hdr instead of using the changed FROM, right?
I use 1.2.2 and I face the same issue. I do change the From in the INVITE, but in CANCEL the unchanged header is sent out. Do I manually have to replace From in the CANCEL as well, or should OpenSER automatically take care of that?
Andreas
Regards, Bogdan
Bai Shi wrote:
I’m not sure if it is a bug. Currently our set up need to do masquerading on the From header for all invite requests. It used to work okie when we process for the CANCEL request in the routing logic. But after upgrading to openser 1.3.0, the TM module is sending CANCEL out using local cached From info rather than the info processed by uac_replace_from. May I know is this by design or it is a bug?
Rgds,
BS
Users mailing list Users@lists.openser.org http://lists.openser.org/cgi-bin/mailman/listinfo/users
Users mailing list Users@lists.openser.org http://lists.openser.org/cgi-bin/mailman/listinfo/users
-
Andreas Granig -
Bai Shi -
Bogdan-Andrei Iancu