Hello Kamailio list!
I've been working with the LCR module and I wanted to use the lcr_id to match some ID's I have somewhere else. However, due to the lcr_count my lcr_ids must be less than the lcr_count. I understand the reason behind the lcr_count, what I think is a mistake is to have the lcr_id dependent of the lcr_count. Ideally we should be able to use any lcr_id value, just observing that the total amount of lcr groups should not exceed the lcr_count. The problem is this if that appears in the load_gws, to_gw and from_gw functions in lcr_mod.c: if ((lcr_id < 1) || (lcr_id > lcr_count_param)) { LM_ERR("invalid lcr_id parameter value %d\n", lcr_id); return -1; }
I ended up using another table to make the conversion of ids, but this is horrible.... Any other reason to force the lcr_id to be less than the lcr_count?
Best Regards, Patrick Wakano
There is a strong reason to have lcr_count variable - it actually represents the size of in-memory table that is created to store all lcr_id's on module loading, I don't think there is a way to avoid that, unless you rewrite lcr module to not load lcr in-memory, but query database (which IMO is a terrible idea). If you need to dynamically assign kamailio lcr_id you can use event_route[core:worker-one-init] and write lcr_id inside $shv(). ________________________________ Alexandru Covalschi VoIP Engineer and System Administrator tel: +373 673 98 493
29 нояб. 2017 г., в 8:54, Patrick Wakano pwakano@gmail.com написал(а):
Hello Kamailio list!
I've been working with the LCR module and I wanted to use the lcr_id to match some ID's I have somewhere else. However, due to the lcr_count my lcr_ids must be less than the lcr_count. I understand the reason behind the lcr_count, what I think is a mistake is to have the lcr_id dependent of the lcr_count. Ideally we should be able to use any lcr_id value, just observing that the total amount of lcr groups should not exceed the lcr_count. The problem is this if that appears in the load_gws, to_gw and from_gw functions in lcr_mod.c: if ((lcr_id < 1) || (lcr_id > lcr_count_param)) { LM_ERR("invalid lcr_id parameter value %d\n", lcr_id); return -1; }
I ended up using another table to make the conversion of ids, but this is horrible.... Any other reason to force the lcr_id to be less than the lcr_count?
Best Regards, Patrick Wakano _______________________________________________ Kamailio (SER) - Users Mailing List sr-users@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users
Hi Alexandru! I aggre with the lcr_count purpose and its usage for in-memory data. However the problem I mentioned is that I cannot have an lcr_id of 1000 eventough I have only one entry because my lcr_count is 50... It is not about having a huge amount of lcr_ids but being able to have id numbers greater than the lcr_count, which is not possible at the moment... Cheers Patrick Wakano
On 29 Nov. 2017 18:05, "Alexandru Covalschi" 568691@gmail.com wrote:
There is a strong reason to have lcr_count variable - it actually represents the size of in-memory table that is created to store all lcr_id's on module loading, I don't think there is a way to avoid that, unless you rewrite lcr module to not load lcr in-memory, but query database (which IMO is a terrible idea). If you need to dynamically assign kamailio lcr_id you can use event_route[core:worker-one-init] and write lcr_id inside $shv(). ________________________________ Alexandru Covalschi VoIP Engineer and System Administrator tel: +373 673 98 493 <+373%20673%2098%20493>
29 нояб. 2017 г., в 8:54, Patrick Wakano pwakano@gmail.com написал(а):
Hello Kamailio list!
I've been working with the LCR module and I wanted to use the lcr_id to match some ID's I have somewhere else. However, due to the lcr_count my lcr_ids must be less than the lcr_count. I understand the reason behind the lcr_count, what I think is a mistake is to have the lcr_id dependent of the lcr_count. Ideally we should be able to use any lcr_id value, just observing that the total amount of lcr groups should not exceed the lcr_count. The problem is this if that appears in the load_gws, to_gw and from_gw functions in lcr_mod.c: if ((lcr_id < 1) || (lcr_id > lcr_count_param)) { LM_ERR("invalid lcr_id parameter value %d\n", lcr_id); return -1; }
I ended up using another table to make the conversion of ids, but this is horrible.... Any other reason to force the lcr_id to be less than the lcr_count?
Best Regards, Patrick Wakano _______________________________________________ Kamailio (SER) - Users Mailing List sr-users@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users
_______________________________________________ Kamailio (SER) - Users Mailing List sr-users@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users
Patrick Wakano writes:
I aggre with the lcr_count purpose and its usage for in-memory data. However the problem I mentioned is that I cannot have an lcr_id of 1000 eventough I have only one entry because my lcr_count is 50... It is not about having a huge amount of lcr_ids but being able to have id numbers greater than the lcr_count, which is not possible at the moment...
you need to do the mapping in your config, for example, using a htable.
-- juha
-
Alexandru Covalschi -
Juha Heinanen -
Patrick Wakano