Hi,
Two questions about the uac_redirect module:
1. If I extract contacts from a 302 with two contacts having the same q-value by using get_redirects("1:1"), which one of the contacts is selected? The first one? The last one?
2. If I apply a filter rule like: modparam("uac_redirect", "default_filter", "deny") modparam("uac_redirect", "accept_filter", "sip:.+@foo.bar.com") and I get a 302 with a Contact, say, "sip:foo@some.other.tld", then the module logs this error: "ERROR:uac_redirect:get_redirects: get contact from shm_reply branch 0 failed". I'd say if zero contacts are extracted from branches due to filters, it's not really an error. Any suggestions for a better error handling?
Andy
Hi Andreas,
Andreas Granig wrote:
Hi,
Two questions about the uac_redirect module:
- If I extract contacts from a 302 with two contacts having the same
q-value by using get_redirects("1:1"), which one of the contacts is selected? The first one? The last one?
the insert condition is strict, contacts with the same q will get in the reverted order..can you double check this?
- If I apply a filter rule like:
modparam("uac_redirect", "default_filter", "deny") modparam("uac_redirect", "accept_filter", "sip:.+@foo.bar.com") and I get a 302 with a Contact, say, "sip:foo@some.other.tld", then the module logs this error: "ERROR:uac_redirect:get_redirects: get contact from shm_reply branch 0 failed". I'd say if zero contacts are extracted from branches due to filters, it's not really an error. Any suggestions for a better error handling?
yes....looks like not adding any of the contacts from a branch leads to an err message. Please post a bug on the tracker and I will take care of it.
regards, bogdan
Andy
Users mailing list Users@openser.org http://openser.org/cgi-bin/mailman/listinfo/users
Bogdan-Andrei Iancu wrote:
Andreas Granig wrote:
- If I extract contacts from a 302 with two contacts having the same
q-value by using get_redirects("1:1"), which one of the contacts is selected? The first one? The last one?
the insert condition is strict, contacts with the same q will get in the reverted order..can you double check this?
Well, I've no client in place which behaves like this, so I wanted to ask how the expected behaviour would be if this would be the case. So the last contact should be selected? I'll check this with some sipp testcase.
- If I apply a filter rule like:
<snipped uac_redirect error>
yes....looks like not adding any of the contacts from a branch leads to an err message. Please post a bug on the tracker and I will take care of it.
Done.
Cheers, Andy
-
Andreas Granig -
Bogdan-Andrei Iancu