Re: [SR-Users] Kamailio vulnerable to header smuggling possible due to bypass of remove_hf

Hello Maxim, thank you for the clarification, appreciated. Just one clarification, my comment regarding the advisory from 2018 was not meant as advertisement etc.. One suggestion to objectify the whole discussion, there exists a well-known and accepted metric for vulnerabilities: CVSS [1] If I calculate the CVSS score for this issue, it results in a medium level with score 5.8. But this is of course again (at least somewhat) influenced from my point of view to this bug. Some projects have a policy to only do a security announcement for vulnerabilities with score high and critical. For Kamailio this is not yet defined in a detailed way, due to the size of the project and other factors. So, If people in this discussion (or other people on the list) are interested in improving the project security processes – this wiki page with the current process might be a good starting point: https://www.kamailio.org/wiki/security/policy Please suggest your improvements to the existing process (preferable in a new discussion thread) on the sr-dev list. If you want to do it in private, feel free contact the management list. Best regards, Henning [1] https://en.wikipedia.org/wiki/Common_Vulnerability_Scoring_System -- Henning Westerholt – https://skalatan.de/blog/ Kamailio services – https://gilawa.com<https://gilawa.com/> From: Maxim Sobolev &lt;sobomax(a)sippysoft.com&gt; Sent: Wednesday, September 2, 2020 7:27 PM To: Daniel-Constantin Mierla &lt;miconda(a)gmail.com&gt;om>; Henning Westerholt &lt;hw(a)skalatan.de&gt;de>; yufei.tao(a)gmail.com; Olle E. Johansson &lt;oej(a)edvina.net&gt; Cc: Gerry | Rigatta &lt;gjacobsen(a)rigatta.com&gt;om>; Kamailio (SER) - Users Mailing List &lt;sr-users(a)lists.kamailio.org&gt; Subject: Re: [SR-Users] Kamailio vulnerable to header smuggling possible due to bypass of remove_hf Hey Daniel, Henning, Tao, Thanks for commenting out. There are a lot of opinions for me to address individually, so I will just clarify my opinion. The only substantial difference I think is whether the issue at hand warrants a security advisory to be issued by the Kamailio project or not. I totally think that it does, but it looks like I am in the minority here. Why do I think this way? Well, the first argument is a bit empirical. It is hard to generalize out of sample size 1, but in like 90% engagements where I had to use SIP Proxy element and integrate it with different SIP elements I ended up using "private headers" for passing information between elements within that setup. So the task of cleaning up those headers at the edge of the network is very relevant at least to some users. It also matches Sandro's assessment, which gives it at least some credibility. Second, a more general one. Not only I have some experience in software development field, but also I got a chance to participate in much bigger and older open source projects (i.e. FreeBSD Project, 400+ active developers, 1,000+ contributors) so I have seen how security is dealt with properly in a mature open source project. You guys might fancy the fact that Kamailio issued the last security advisory in 2018 as a "code quality" indicator, but to me that shows a total lack of proper security process. With the code base of its size, I'd expect at least several security issues of various criticality being found per year. I frankly don't understand the pushback I am getting. It almost looks like issuing such advisory is viewed as harmful and damaging on project "spotless" reputation or something. However in my view it would show respect to users and understanding that many of those users might be using it in a way that differs from its creators. It might come as a surprise to some of you, but 95% of Kamailio users are not reading this and those lists or following Sandro's work in general. However, if there were a section "Security Advisories" on kamailio.org<http://kamailio.org> that would be the place to go. And those users are often not individuals, but companies building their products and solutions atop of Kamailio. Also properly issued security advisory helps package maintainers, any linux distro of decent size has its own process to handle and disseminate those among their own users to update package ASAP. But if Kamailio chooses to not issue any it basically cuts itself out of that process. And last but not least, to the remark that I need to step in and fix things, well I am hardly a person to do that. Too many projects and too little time, however I also don't think I cannot voice my opinion, or can I? By the way I know at least one person in the Kamailio community that might be more fit as a "Kamailio Security Officer": Olle E. Johansson. Olle, what's your take on this? Does this problem warrants security advisory? -Max