3 Aug
2010
3 Aug
'10
2:24 a.m.
Hello,
the dialplan module seems to be loaded ok, the last message is related
to uac module..
On 8/2/10 9:26 AM, Ernest Mavrel wrote:
Is something wrong with table? I insert into
dialplan:
mysql> select * from dialplan;
+----+------+----+----------+-----------+-----------+-----------+----------+-------+
| id | dpid | pr | match_op | match_exp | match_len | subst_exp |
repl_exp | attrs |
+----+------+----+----------+-----------+-----------+-----------+----------+-------+
| 1 | 0 | 0 | 0 | | 0 |
| | |
| 9 | 0 | 0 | 0 | 0 | 0 |
| | |
| 10 | 0 | 0 | 0 | 0 | 0 |
| | |
+----+------+----+----------+-----------+-----------+-----------+----------+-------+
3 rows in set (0.00 sec)
and get output (kamailio is started!):
so kamailio is running? To say if it is something wrong you have to
describe what rules you wanted there. I would avoid dpid=0, then
match_exp values look a bit strange from my point of view, what do you
want to match?
Cheers,
Daniel
0(5524) DEBUG: <core> [sr_module.c:871]: DEBUG: init_mod: dialplan
0(5524) DEBUG: dialplan [dialplan.c:128]:
db_url=mysql://kamailio:violinarw@10.60.10.102/kamailio/48/0x89a268
0(5524) DEBUG: <core> [usr_avp.c:890]: Parsing 's:dest'
0(5524) DEBUG: dialplan [dp_db.c:162]: trying to initialize data from db
0(5524) DEBUG: <core> [sr_module.c:506]: find_export_record: found
<db_bind_api> in module db_mysql
[/usr/local/lib/kamailio/modules/db_mysql.so]
0(5524) DEBUG: <core> [db.c:202]: using db bind api for db_mysql
0(5524) DEBUG: <core> [db.c:285]: connection 0x95ee00 not found in pool
0(5524) DEBUG: db_mysql [km_my_con.c:94]: opening connection:
mysql://xxxx:xxxx@10.60.10.102/kamailio
0(5524) DEBUG: db_mysql [km_my_con.c:119]: connection type is
10.60.10.102 via TCP/IP
0(5524) DEBUG: db_mysql [km_my_con.c:120]: protocol version is 10
0(5524) DEBUG: db_mysql [km_my_con.c:121]: server version is
5.1.41-3ubuntu12.3
0(5524) DEBUG: <core> [db_res.c:118]: allocate 48 bytes for result
set at 0x95ef28
0(5524) DEBUG: db_mysql [km_res.c:68]: 1 columns returned from the query
0(5524) DEBUG: <core> [db_res.c:155]: allocate 8 bytes for result
names at 0x95ef68
0(5524) DEBUG: <core> [db_res.c:165]: allocate 4 bytes for result
types at 0x95f318
0(5524) DEBUG: db_mysql [km_res.c:85]: allocate 16 bytes for
RES_NAMES[0] at 0x95f2f8
0(5524) DEBUG: db_mysql [km_res.c:92]:
RES_NAMES(0x95f2f8)[0]=[table_version]
0(5524) DEBUG: db_mysql [km_res.c:100]: use DB1_INT result type
0(5524) DEBUG: <core> [db_res.c:184]: allocate 16 bytes for rows at
0x95f2d8
0(5524) DEBUG: <core> [db_row.c:119]: allocate 32 bytes for row
values at 0x95f0e0
0(5524) DEBUG: <core> [db_val.c:73]: converting INT [1]
0(5524) DEBUG: <core> [db_res.c:81]: freeing 1 columns
0(5524) DEBUG: <core> [db_res.c:85]: freeing RES_NAMES[0] at 0x95f2f8
0(5524) DEBUG: <core> [db_res.c:94]: freeing result names at 0x95ef68
0(5524) DEBUG: <core> [db_res.c:99]: freeing result types at 0x95f318
0(5524) DEBUG: <core> [db_res.c:54]: freeing 1 rows
0(5524) DEBUG: <core> [db_row.c:97]: freeing row values at 0x95f0e0
0(5524) DEBUG: <core> [db_res.c:62]: freeing rows at 0x95f2d8
0(5524) DEBUG: <core> [db_res.c:136]: freeing result set at 0x95ef28
0(5524) DEBUG: dialplan [dp_db.c:200]: init
0(5524) DEBUG: <core> [db_res.c:118]: allocate 48 bytes for result
set at 0x95ef28
0(5524) DEBUG: db_mysql [km_res.c:68]: 8 columns returned from the query
0(5524) DEBUG: <core> [db_res.c:155]: allocate 64 bytes for result
names at 0x95eff0
0(5524) DEBUG: <core> [db_res.c:165]: allocate 32 bytes for result
types at 0x95f0e0
0(5524) DEBUG: db_mysql [km_res.c:85]: allocate 16 bytes for
RES_NAMES[0] at 0x95f2d8
0(5524) DEBUG: db_mysql [km_res.c:92]: RES_NAMES(0x95f2d8)[0]=[dpid]
0(5524) DEBUG: db_mysql [km_res.c:100]: use DB1_INT result type
0(5524) DEBUG: db_mysql [km_res.c:85]: allocate 16 bytes for
RES_NAMES[1] at 0x95f318
0(5524) DEBUG: db_mysql [km_res.c:92]: RES_NAMES(0x95f318)[1]=[pr]
0(5524) DEBUG: db_mysql [km_res.c:100]: use DB1_INT result type
0(5524) DEBUG: db_mysql [km_res.c:85]: allocate 16 bytes for
RES_NAMES[2] at 0x95f2f8
0(5524) DEBUG: db_mysql [km_res.c:92]: RES_NAMES(0x95f2f8)[2]=[match_op]
0(5524) DEBUG: db_mysql [km_res.c:100]: use DB1_INT result type
0(5524) DEBUG: db_mysql [km_res.c:85]: allocate 16 bytes for
RES_NAMES[3] at 0x95ede0
0(5524) DEBUG: db_mysql [km_res.c:92]:
RES_NAMES(0x95ede0)[3]=[match_exp]
0(5524) DEBUG: db_mysql [km_res.c:136]: use DB1_STRING result type
0(5524) DEBUG: db_mysql [km_res.c:85]: allocate 16 bytes for
RES_NAMES[4] at 0x95f2b8
0(5524) DEBUG: db_mysql [km_res.c:92]:
RES_NAMES(0x95f2b8)[4]=[match_len]
0(5524) DEBUG: db_mysql [km_res.c:100]: use DB1_INT result type
0(5524) DEBUG: db_mysql [km_res.c:85]: allocate 16 bytes for
RES_NAMES[5] at 0x95f298
0(5524) DEBUG: db_mysql [km_res.c:92]:
RES_NAMES(0x95f298)[5]=[subst_exp]
0(5524) DEBUG: db_mysql [km_res.c:136]: use DB1_STRING result type
0(5524) DEBUG: db_mysql [km_res.c:85]: allocate 16 bytes for
RES_NAMES[6] at 0x95f278
0(5524) DEBUG: db_mysql [km_res.c:92]: RES_NAMES(0x95f278)[6]=[repl_exp]
0(5524) DEBUG: db_mysql [km_res.c:136]: use DB1_STRING result type
0(5524) DEBUG: db_mysql [km_res.c:85]: allocate 16 bytes for
RES_NAMES[7] at 0x95f258
0(5524) DEBUG: db_mysql [km_res.c:92]: RES_NAMES(0x95f258)[7]=[attrs]
0(5524) DEBUG: db_mysql [km_res.c:136]: use DB1_STRING result type
0(5524) DEBUG: db_mysql [km_dbase.c:342]: converting row 0 of 3 count 3
0(5524) DEBUG: <core> [db_row.c:119]: allocate 256 bytes for row
values at 0x95f338
0(5524) DEBUG: <core> [db_val.c:73]: converting INT [0]
0(5524) DEBUG: <core> [db_val.c:73]: converting INT [0]
0(5524) DEBUG: <core> [db_val.c:73]: converting INT [0]
0(5524) DEBUG: <core> [db_val.c:117]: converting STRING []
0(5524) DEBUG: <core> [db_val.c:73]: converting INT [0]
0(5524) DEBUG: <core> [db_val.c:117]: converting STRING []
0(5524) DEBUG: <core> [db_val.c:117]: converting STRING []
0(5524) DEBUG: <core> [db_val.c:117]: converting STRING []
0(5524) DEBUG: <core> [db_row.c:119]: allocate 256 bytes for row
values at 0x95f4f8
0(5524) DEBUG: <core> [db_val.c:73]: converting INT [0]
0(5524) DEBUG: <core> [db_val.c:73]: converting INT [0]
0(5524) DEBUG: <core> [db_val.c:73]: converting INT [0]
0(5524) DEBUG: <core> [db_val.c:117]: converting STRING [0]
0(5524) DEBUG: <core> [db_val.c:73]: converting INT [0]
0(5524) DEBUG: <core> [db_val.c:117]: converting STRING []
0(5524) DEBUG: <core> [db_val.c:117]: converting STRING []
0(5524) DEBUG: <core> [db_val.c:117]: converting STRING []
0(5524) DEBUG: <core> [db_row.c:119]: allocate 256 bytes for row
values at 0x95f608
0(5524) DEBUG: <core> [db_val.c:73]: converting INT [0]
0(5524) DEBUG: <core> [db_val.c:73]: converting INT [0]
0(5524) DEBUG: <core> [db_val.c:73]: converting INT [0]
0(5524) DEBUG: <core> [db_val.c:117]: converting STRING [0]
0(5524) DEBUG: <core> [db_val.c:73]: converting INT [0]
0(5524) DEBUG: <core> [db_val.c:117]: converting STRING []
0(5524) DEBUG: <core> [db_val.c:117]: converting STRING []
0(5524) DEBUG: <core> [db_val.c:117]: converting STRING []
0(5524) DEBUG: dialplan [dp_db.c:374]: build_rule
0(5524) DEBUG: dialplan [dp_db.c:434]: attrs are
0(5524) DEBUG: dialplan [dp_db.c:480]: new dpl_id 0
0(5524) DEBUG: dialplan [dp_db.c:493]: new index , len 0
0(5524) DEBUG: dialplan [dp_db.c:529]: added the rule id 0 index 0 pr
0 next (nil) to the index with 0 len
0(5524) DEBUG: dialplan [dp_db.c:374]: build_rule
0(5524) DEBUG: dialplan [dp_db.c:434]: attrs are
0(5524) DEBUG: dialplan [dp_db.c:529]: added the rule id 0 index 0 pr
0 next (nil) to the index with 0 len
0(5524) DEBUG: dialplan [dp_db.c:374]: build_rule
0(5524) DEBUG: dialplan [dp_db.c:434]: attrs are
0(5524) DEBUG: dialplan [dp_db.c:529]: added the rule id 0 index 0 pr
0 next (nil) to the index with 0 len
0(5524) DEBUG: <core> [db_res.c:54]: freeing 3 rows
0(5524) DEBUG: <core> [db_row.c:97]: freeing row values at 0x95f338
0(5524) DEBUG: <core> [db_row.c:97]: freeing row values at 0x95f4f8
0(5524) DEBUG: <core> [db_row.c:97]: freeing row values at 0x95f608
0(5524) DEBUG: <core> [db_res.c:62]: freeing rows at 0x95eee0
0(5524) DEBUG: dialplan [dp_db.c:638]: DPID: 0, pointer 0x7f8beb9c0020
0(5524) DEBUG: dialplan [dp_db.c:640]: INDEX LEN: 0
0(5524) DEBUG: dialplan [dp_db.c:657]: RULE 0x7f8beb9bffa0: pr 0 next
0x7f8beb9c0078 match_exp , subst_exp , repl_exp and attrs
0(5524) DEBUG: dialplan [dp_db.c:657]: RULE 0x7f8beb9c0078: pr 0 next
0x7f8beb9c0110 match_exp 0, subst_exp , repl_exp and attrs
0(5524) DEBUG: dialplan [dp_db.c:657]: RULE 0x7f8beb9c0110: pr 0 next
(nil) match_exp 0, subst_exp , repl_exp and attrs
0(5524) DEBUG: <core> [db_res.c:81]: freeing 8 columns
0(5524) DEBUG: <core> [db_res.c:85]: freeing RES_NAMES[0] at 0x95f2d8
0(5524) DEBUG: <core> [db_res.c:85]: freeing RES_NAMES[1] at 0x95f318
0(5524) DEBUG: <core> [db_res.c:85]: freeing RES_NAMES[2] at 0x95f2f8
0(5524) DEBUG: <core> [db_res.c:85]: freeing RES_NAMES[3] at 0x95ede0
0(5524) DEBUG: <core> [db_res.c:85]: freeing RES_NAMES[4] at 0x95f2b8
0(5524) DEBUG: <core> [db_res.c:85]: freeing RES_NAMES[5] at 0x95f298
0(5524) DEBUG: <core> [db_res.c:85]: freeing RES_NAMES[6] at 0x95f278
0(5524) DEBUG: <core> [db_res.c:85]: freeing RES_NAMES[7] at 0x95f258
0(5524) DEBUG: <core> [db_res.c:94]: freeing result names at 0x95eff0
0(5524) DEBUG: <core> [db_res.c:99]: freeing result types at 0x95f0e0
0(5524) DEBUG: <core> [db_res.c:136]: freeing result set at 0x95ef28
0(5524) DEBUG: <core> [db_pool.c:102]: removing connection from the pool
0(5524) DEBUG: <core> [sr_module.c:871]: DEBUG: init_mod: alias_db
0(5524) DEBUG: <core> [sr_module.c:506]: find_export_record: found
<db_bind_api> in module db_mysql
[/usr/local/lib/kamailio/modules/db_mysql.so]
0(5524) DEBUG: <core> [db.c:202]: using db bind api for db_mysql
0(5524) DEBUG: <core> [sr_module.c:871]: DEBUG: init_mod: uac
In cfg I have:
loadmodule "dialplan.so"
modparam("dialplan", "table_name", "dialplan")
modparam("dialplan", "dpid_col", "dpid")
modparam("dialplan", "pr_col", "pr")
modparam("dialplan", "match_op_col", "match_op")
modparam("dialplan", "match_exp_col", "match_exp")
modparam("dialplan", "match_len_col", "match_len")
modparam("dialplan", "subst_exp_col", "subst_exp")
modparam("dialplan", "repl_exp_col", "repl_exp")
modparam("dialplan", "attrs_col", "attrs")
modparam("dialplan", "attrs_pvar", "$avp(s:dest)")
modparam("dialplan", "fetch_rows", 1000)
Thank you
Ernest
On 02. 08. 2010 09:09, Ernest Mavrel wrote:
--
Daniel-Constantin Mierla
http://www.asipto.com/
Hi
If I turn on !define WITH_DEBUG.
The output:
0(4311) DEBUG: <core> [sr_module.c:871]: DEBUG: init_mod: dialplan
0(4311) DEBUG: dialplan [dialplan.c:128]:
db_url=mysql://xxxx:xxxx@10.60.10.102/kamailio/48/0x89a268
0(4311) DEBUG: <core> [usr_avp.c:890]: Parsing 's:dest'
0(4311) DEBUG: dialplan [dp_db.c:162]: trying to initialize data
from db
0(4311) DEBUG: <core> [sr_module.c:506]: find_export_record: found
<db_bind_api> in module db_mysql
[/usr/local/lib/kamailio/modules/db_mysql.so]
0(4311) DEBUG: <core> [db.c:202]: using db bind api for db_mysql
0(4311) DEBUG: <core> [db.c:285]: connection 0x95ee00 not found in pool
0(4311) DEBUG: db_mysql [km_my_con.c:94]: opening connection:
mysql://xxxx:xxxx@10.60.10.102/kamailio
0(4311) DEBUG: db_mysql [km_my_con.c:119]: connection type is
10.60.10.102 via TCP/IP
0(4311) DEBUG: db_mysql [km_my_con.c:120]: protocol version is 10
0(4311) DEBUG: db_mysql [km_my_con.c:121]: server version is
5.1.41-3ubuntu12.3
0(4311) DEBUG: <core> [db_res.c:118]: allocate 48 bytes for result
set at 0x95ef28
0(4311) DEBUG: db_mysql [km_res.c:68]: 1 columns returned from the
query
0(4311) DEBUG: <core> [db_res.c:155]: allocate 8 bytes for result
names at 0x95ef68
0(4311) DEBUG: <core> [db_res.c:165]: allocate 4 bytes for result
types at 0x95f318
0(4311) DEBUG: db_mysql [km_res.c:85]: allocate 16 bytes for
RES_NAMES[0] at 0x95f2f8
0(4311) DEBUG: db_mysql [km_res.c:92]:
RES_NAMES(0x95f2f8)[0]=[table_version]
0(4311) DEBUG: db_mysql [km_res.c:100]: use DB1_INT result type
0(4311) DEBUG: <core> [db_res.c:184]: allocate 16 bytes for rows at
0x95f2d8
0(4311) DEBUG: <core> [db_row.c:119]: allocate 32 bytes for row
values at 0x95f0e0
0(4311) DEBUG: <core> [db_val.c:73]: converting INT [1]
0(4311) DEBUG: <core> [db_res.c:81]: freeing 1 columns
0(4311) DEBUG: <core> [db_res.c:85]: freeing RES_NAMES[0] at 0x95f2f8
0(4311) DEBUG: <core> [db_res.c:94]: freeing result names at 0x95ef68
0(4311) DEBUG: <core> [db_res.c:99]: freeing result types at 0x95f318
0(4311) DEBUG: <core> [db_res.c:54]: freeing 1 rows
0(4311) DEBUG: <core> [db_row.c:97]: freeing row values at 0x95f0e0
0(4311) DEBUG: <core> [db_res.c:62]: freeing rows at 0x95f2d8
0(4311) DEBUG: <core> [db_res.c:136]: freeing result set at 0x95ef28
0(4311) DEBUG: dialplan [dp_db.c:200]: init
0(4311) DEBUG: <core> [db_res.c:118]: allocate 48 bytes for result
set at 0x95ef28
0(4311) DEBUG: db_mysql [km_res.c:68]: 8 columns returned from the
query
0(4311) DEBUG: <core> [db_res.c:155]: allocate 64 bytes for result
names at 0x95eff0
0(4311) DEBUG: <core> [db_res.c:165]: allocate 32 bytes for result
types at 0x95f0e0
0(4311) DEBUG: db_mysql [km_res.c:85]: allocate 16 bytes for
RES_NAMES[0] at 0x95f2d8
0(4311) DEBUG: db_mysql [km_res.c:92]: RES_NAMES(0x95f2d8)[0]=[dpid]
0(4311) DEBUG: db_mysql [km_res.c:100]: use DB1_INT result type
0(4311) DEBUG: db_mysql [km_res.c:85]: allocate 16 bytes for
RES_NAMES[1] at 0x95f318
0(4311) DEBUG: db_mysql [km_res.c:92]: RES_NAMES(0x95f318)[1]=[pr]
0(4311) DEBUG: db_mysql [km_res.c:100]: use DB1_INT result type
0(4311) DEBUG: db_mysql [km_res.c:85]: allocate 16 bytes for
RES_NAMES[2] at 0x95f2f8
0(4311) DEBUG: db_mysql [km_res.c:92]:
RES_NAMES(0x95f2f8)[2]=[match_op]
0(4311) DEBUG: db_mysql [km_res.c:100]: use DB1_INT result type
0(4311) DEBUG: db_mysql [km_res.c:85]: allocate 16 bytes for
RES_NAMES[3] at 0x95ede0
0(4311) DEBUG: db_mysql [km_res.c:92]:
RES_NAMES(0x95ede0)[3]=[match_exp]
0(4311) DEBUG: db_mysql [km_res.c:136]: use DB1_STRING result type
0(4311) DEBUG: db_mysql [km_res.c:85]: allocate 16 bytes for
RES_NAMES[4] at 0x95f2b8
0(4311) DEBUG: db_mysql [km_res.c:92]:
RES_NAMES(0x95f2b8)[4]=[match_len]
0(4311) DEBUG: db_mysql [km_res.c:100]: use DB1_INT result type
0(4311) DEBUG: db_mysql [km_res.c:85]: allocate 16 bytes for
RES_NAMES[5] at 0x95f298
0(4311) DEBUG: db_mysql [km_res.c:92]:
RES_NAMES(0x95f298)[5]=[subst_exp]
0(4311) DEBUG: db_mysql [km_res.c:136]: use DB1_STRING result type
0(4311) DEBUG: db_mysql [km_res.c:85]: allocate 16 bytes for
RES_NAMES[6] at 0x95f278
0(4311) DEBUG: db_mysql [km_res.c:92]:
RES_NAMES(0x95f278)[6]=[repl_exp]
0(4311) DEBUG: db_mysql [km_res.c:136]: use DB1_STRING result type
0(4311) DEBUG: db_mysql [km_res.c:85]: allocate 16 bytes for
RES_NAMES[7] at 0x95f258
0(4311) DEBUG: db_mysql [km_res.c:92]: RES_NAMES(0x95f258)[7]=[attrs]
0(4311) DEBUG: db_mysql [km_res.c:136]: use DB1_STRING result type
0(4311) DEBUG: db_mysql [km_dbase.c:342]: converting row 0 of 1 count 1
0(4311) DEBUG: <core> [db_row.c:119]: allocate 256 bytes for row
values at 0x95f338
0(4311) DEBUG: <core> [db_val.c:73]: converting INT [1]
0(4311) DEBUG: <core> [db_val.c:73]: converting INT [100]
0(4311) DEBUG: <core> [db_val.c:73]: converting INT [1]
0(4311) DEBUG: <core> [db_val.c:117]: converting STRING [ ^123+]
0(4311) DEBUG: <core> [db_val.c:73]: converting INT [0]
0(4311) DEBUG: <core> [db_val.c:117]: converting STRING [^(123.+)]
0(4311) DEBUG: <core> [db_val.c:117]: converting STRING [0030\1]
0(4311) DEBUG: <core> [db_val.c:117]: converting STRING []
0(4311) DEBUG: dialplan [dp_db.c:374]: build_rule
and kamailio is not started!
Without !define WITH_DEBUG, and starting kamailio with command
"kamailio -E -dd" the output is:
Aug 2 08:20:23 ubuntu kamailio: WARNING: <core> [socket_info.c:896]:
WARNING: fix_hostname: could not rev. resolve 10.50.11.103
Aug 2 08:20:23 ubuntu kamailio: WARNING: <core> [socket_info.c:896]:
WARNING: fix_hostname: could not rev. resolve 10.60.10.103
Aug 2 08:20:23 ubuntu kamailio: WARNING: <core> [socket_info.c:896]:
WARNING: fix_hostname: could not rev. resolve 10.60.11.103
Aug 2 08:20:23 ubuntu kamailio: WARNING: <core> [daemonize.c:150]:
pid file contains old pid, replacing pid
Aug 2 08:20:23 ubuntu /usr/local/sbin/kamailio[3845]: INFO: usrloc
[hslot.c:53]: locks array size 512
But kamailio is not started.
Any help, I realy need dialplan module.
Ernest
On 22. 07. 2010 21:51, Daniel-Constantin Mierla wrote:
_______________________________________________
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
sr-users(a)lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users
On 7/22/10 8:48 PM, Iñaki Baz Castillo wrote:
_______________________________________________
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
sr-users(a)lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users 2010/7/22 Ernest
Mavrel<ernest.mavrel(a)novatel.si>si>:
> Hi
>
> This is what i get:
>
> kamailio -E -dd
[...]
> 0(15033) WARNING:<core> [socket_info.c:896]: WARNING:
> fix_hostname: could
> not rev. resolve 10.50.11.103
> 0(15033) WARNING:<core> [socket_info.c:896]: WARNING:
> fix_hostname: could
> not rev. resolve 10.60.10.103
> 0(15033) WARNING:<core> [socket_info.c:896]: WARNING:
> fix_hostname: could
> not rev. resolve 10.60.11.103
> Listening on
> udp: 127.0.0.1:5060
> udp: 10.50.11.103:5060
> udp: 10.60.10.103:5060
> udp: 10.60.11.103:5060
> Aliases:
> udp: localhost:5060
>
> root@ubuntu:~# 0(15035) INFO: usrloc [hslot.c:53]: locks array
> size 512
It seems it has started, right?
the output still looks incomplete, but more
strange is that DEBUG
messages must have not been printed. So I am not sure the output is
the right one.
Parameter -dd must set the threshold to INFO messages -- I wanted to
spot quickly eventual errors.
Ernest, can you doublecheck if you pasted the right output?
Cheers,
Daniel