30 Sep
2013
30 Sep
'13
9:36 a.m.
Hello,
thanks for digging further, I will check it and commit if all looks good.
Cheers,
Daniel
On 9/29/13 5:55 PM, Øyvind Kolbu wrote:
On 2013-09-27 at 13:42, Øyvind Kolbu wrote:
--
Daniel-Constantin Mierla - http://www.asipto.com
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
Kamailio Advanced Trainings - Berlin, Nov 25-28; Miami, Nov 18-20, 2013
- more details about Kamailio trainings at http://www.asipto.com -
On 2013-09-27 at 11:49, Daniel-Constantin Mierla
wrote:
The patch attached
fixes the no NAPTR and no UDP case, but only when
use_dns_failover is set to off. We usually have it on, but I can't recall
why..
Anyhow the patch is rather trivial, just store *proto before overwriting it
and restore it before calling no_naptr_srv_sip_resolvehost.
_______________________________________________
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
sr-users(a)lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users Haven't got time to get back to it -- hope to
happen soon.
I've taken a small peak and think I at least found some of the
problem, but
also got quite confused.
What is the relationship between
dns_cache.c:dns_srv_sip_resolvehost() and
dns_cache.c:dns_srv_sip_resolve()? They look very much copy and paste, with
the same error in them. Both will only search for UDP records if *proto is
not set. They also mangle the *proto value as they both set it to
PROTO_UDP if it is unset, and the leaves it that way instead of resetting
it to 0.
In resolve.c:no_naptr_srv_sip_resolvehost() a proper SRV lookup function is
defined, but not used at least for the t_relay() case. Perhaps change both
functions in dns_cache.c to use no_naptr_srv_sip_resolvehost?