23 Apr
2005
23 Apr
'05
12:10 p.m.
Jan,
please see the inline comments.
bogdan
Jan Janak wrote:
Hello,
I think Juha has a point. Those changes are not backwards compatible, it's
more than just a bug fix. Even I am not sure that everything works as
expected because I did not test it properly. I was hoping that backporting
them would not introduce any troubles, but this does not seem to be true.
I had a private chat with Juha and the backward compatibility is solved
via a small correction - Juha already tested, so I guess from this point
of view shouldn't be any issues.
Bogdan, please revert the changes and we will stick to
the original
version. I think we should not be doing backwards incopatible changes
within that release.
As we privately both agreed one month ago, the old code for auth* wasn't
up to a release level. Personally, I wouldn't make the revert since it
will mean I accept wicker code into the official release .
But of course you are the maintainer of these modules and you have the
liberty to revert the changes if you consider it the best solution.
I will commit the backward compatibility fix, since Juha really needs it
to cop with his Radius configuration.
After that it's your decision to revert all or not.