24 Jun
2022
24 Jun
'22
10:05 a.m.
Hello,
thanks for these details!
I am actually writing about the git submodule and I think we have decide
on a good/common practice should such need comes more often in the future.
I noticed that many project have a dedicated folder like vendor/ or
external/ where they place the 3rd party submodules. That makes it
easier to know the external dependencies and figure out also better the
impact on license, etc...
It is also better if another module needs the same submodule, for
example now we have crypto module that uses libssl. I do not know if
wolfssl has also those functions used by crypto module, if yes, maybe
someone wants to add a replace module for crypto with wolftls as well,
to not have to install libssl at all.
In my opinion, this approach would be better than have inside module
directory. I would propose to place them inside a folder like
misc/vendor or misc/external or another subfolder of misc/, given that
we do not want to add again (and grow) to the root folder like in the past.
I am going to open an issue on tracker about this and get the feedback
from other devs. But if any of community members can share best
practices out there, maybe from similar projects, then just reply to
mailing list.
Cheers,
Daniel
On 23.06.22 09:57, Anthony Alba wrote:
On Fri, Jun 17, 2022 at 6:54 PM Daniel-Constantin
Mierla
<miconda(a)gmail.com> wrote:
--
Daniel-Constantin Mierla -- www.asipto.com
www.twitter.com/miconda -- www.linkedin.com/in/miconda
Kamailio Advanced Training - Online: June 20-23, 2022
* https://www.asipto.com/sw/kamailio-advanced-training-online/
For the moment just adding that Ubuntu 20.04 has
libwolfssl-dev 4.30, so
the module does not compile there.
Cheers,
Daniel
Hello Daniel and sr-users,
To facilitate testing of tls_wolfssl I have pushed a commit that
contains a submodule; at the early
stages of this module this will help avoid having to deal with
different versions of the library. You may
test as follows:
cd kamailio/;
git submodule init src/modules/tls_wolfssl/lib/wolfssl;
git submodule update src/modules/tls_wolfssl/lib/wolfssl;
make cfg; # other make commands
make -C src module_group_tls=tls_wolfssl group_include=tls every-module
Happy testing!
S-P
__________________________________________________________
Kamailio - Users Mailing List - Non Commercial Discussions
* sr-users(a)lists.kamailio.org
Important: keep the mailing list in the recipients, do not reply only to the sender!
Edit mailing list options or unsubscribe:
* https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users