11 jul 2012 kl. 18:06 skrev Daniel-Constantin Mierla:
On 7/11/12 5:58 PM, Olle E. Johansson wrote:
11 jul 2012 kl. 17:57 skrev Iñaki Baz Castillo:
2012/7/11 Olle E. Johansson oej@edvina.net:
I see that the gruu_enabled() parameter enables gruu if there's an instance ID in the contact.
The requirement is also that there has to be a supported: gruu
The instance ID is used without GRUU (like in OUTBOUND), so just checking that is not a good indication that you have GRUU support in the UA.
" When a UA compliant to this specification generates a REGISTER request (initial or refresh), it MUST include the Supported header field in the request. The value of that header field MUST include "gruu" as one of the option tags. This alerts the registrar for the domain that the UA supports the GRUU mechanism."
From RFC 5627.
I agree that checking "gruu" option tag in the Supported/Require header of the REGISTER is needed.
Remember that I might have missed that part of the code. I will try to test :-) It might just be a documentation error.
gruu addresses are built for REGISTER reply only if the gruu tag is in supported header, see code at:
modules_k/registrar/reply.c +190
Ok! Great!
So I will file a documentation bug, assign that to myself for not noticing this and try to commit and cause work for the rest of you :-)
Thanks for your patience, Daniel!
/O