[Serusers] Re: bug in last changes for "rport-received" tags

On Apr 05, 2003 at 18:38, Sergio Miguel Garcia sergio@cooltechintl.com wrote:

I have been testing the last changes about the "rport-received" tags, and I have found the next bug:

[...]

I've been checking other pairs of ports sent and received like 1667-33542, 1507-58117, 1509-58629, 1511-59141 and the second is the network address order of the first ( 1667 = ntohs(33542) ) .

I think that you forget to make a htons() of the port received in host format before sending the packet back to network.

Yes you're right (well almost, I did an extra htons -- the port was kept in network byte order).

Please, let me know when this issue is solved in the CVS.

It should be fixed, however I haven't tested it. I hope I didn't miss anything :-)

Thanks, Andrei