Hello,
On 5/22/12 12:33 PM, Timo Teras wrote:
On Tue, 22 May 2012 13:11:04 +0300 Timo Teras timo.teras@iki.fi wrote:
On Tue, 22 May 2012 10:46:34 +0200 Daniel-Constantin Mierla miconda@gmail.com wrote:
Hello,
On 5/19/12 10:39 PM, Timo Teräs wrote:
Search for keywords case insensitively instead of using strstr(). SQlite stores decltype as-is, and does the affinity type testing case insensitively too.
Perhaps you should push it asap, so it gets some testing before 3.3.0 is released.
I have few minor fixes. Will push within an hour.
Ok. Pushed the immediate fix.
I would also like to push the following change:
--- a/doc/stylesheets/dbschema_k/xsl/db_sqlite.xsl +++ b/doc/stylesheets/dbschema_k/xsl/db_sqlite.xsl @@ -87,7 +87,7 @@ </xsl:when> <xsl:when test="$type='binary' or $type='largebinary'">
<xsl:text>BYTEA</xsl:text>
<xsl:text>BLOB</xsl:text> <xsl:call-template name="column.size"/> <xsl:call-template name="column.trailing"/> </xsl:when>This ensures that the binary stuff is put properly in to the database. We really need to change the schema mapping, as otherwise the column gets wrong affinity in sqlite.
This probably means binary breakage. And after "make dbschema" I got some tables versions changed, even though it's only the sqlite that changed.
Could someone do this change, and regenerate the necessary files?
I regenerated the db creation scripts with existing schema -- new lcr_rule table version was not taken in consideration, indeed.
Now you should be able to apply your patch and regenerate dbschema creation scripts with no other interferences. I can do it if it is not convenient for you.
Cheers, Daniel