On 10/22/12 8:36 PM, Juha Heinanen wrote:
Daniel-Constantin Mierla writes:
I gave the link to show the ipv4 representation.
Square brackets are
commonly used in ipv6 representations, specially in url/uri -- wikipedia
link you provided mentions that..
yes, but when they are used in url, square
brackets are not part of the
address. they just delimiting the address.
that's why I said ipv6 address representation.
Being a code read by machine and being required
to support them in
kamailio (as we get ipv6 from headers/uri), I see no problem in being
flexible enough to deal with both cases.
are you sure that kamailio lcr and
permissions modules are able handle
all those non-canonical ipv6 addresses (including square brackets that
are not part of the address) when tables are reloaded?
to me it would make sense to canonize user given addresses before
management system stores them to database.
many times the management system sits between chair and keyboard :-) ,
being able to read/add human representation is really crucial in this case.
The fact is that canonical format works just fine, it's all ok if you
want to use it always.
All modules should support all variants if they use the ipv6 address
parser from core. The functionality related to address checking from
permissions module does it for sure, I have no idea if lcr implements
custom parser. I think trusted from permissions has an issue, iirc,
because the comparison was done via string comparison --not using it I
am not sure if anyone change it.
Cheers,
Daniel
--
Daniel-Constantin Mierla -
http://www.asipto.com
http://twitter.com/#!/miconda -
http://www.linkedin.com/in/miconda
Kamailio Advanced Training, Berlin, Nov 5-8, 2012 -
http://asipto.com/u/kat
Kamailio Advanced Training, Miami, USA, Nov 12-14, 2012 -
http://asipto.com/u/katu