Hello,
db_fetch_rows is about setting the value of how many rows to be loaded at once. 0 is a special value meaning that this limit is not set and all rows are loaded at once. db_fetch_rows is common parameter for other modules (e.g., usrloc) with same kind of behaviour, so I would not change the behaviour of db_fetch_rows.
For what you need, maybe db_mode should get a new value -- this is the parameter that controls the relation with database. However, if the write modes provided by db_mode are something that worth combining with the "no-read" mode, then a new parameter can be added, like db_skip_load.
Cheers, Daniel
On 24/08/15 02:25, jay binks wrote:
Further to this, I have created a pull request that I think should behave better.
https://github.com/kamailio/kamailio/pull/295
On 24 August 2015 at 10:06, jay binks <jaybinks@gmail.com mailto:jaybinks@gmail.com> wrote:
Hey All, Im just after someone else thoughts on if this is a bug. After reading : http://kamailio.org/docs/modules/3.3.x/modules_k/dialog.html#idp148408 Im lead to understand that setting /modparam("dialog", "db_fetch_rows", 0)/ should instruct the dialog module to write dialogs to the DB, but not bother loading them on startup. This sounds like what I'm after. However ever time I set the value to 0, dialogs are still loaded from the DB. a quick dig in the source takes me to the function select_entire_dialog_table in dlg_db_handler.c this chunk of code does not appear to properly implement " if fetch_num_rows == 0 then do nothing " Im after a couple of things from you guys. a) validation that my understanding of what SHOULD happen is correct b) possibly validating that I'm not crazy, and this is actually a bug :) -- Sincerely Jay-- Sincerely
Jay
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list sr-users@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users