Applied your patch and renamed the attribute in geoip module to be contc.
Cheers, Daniel
On 11/03/15 22:50, Sergey Okhapkin wrote:
I'd prefer contc (as I implemented in geoip2) to be consistent with existing names like cc, regc.
On Wednesday 11 March 2015 22:46:38 you wrote:
As I had a short spare time and code it, my first idea went for cont[inent] id, to be suggestive and rather short that using full words.
On the other hand, I can rename it in the old module if people prefer other variant.
Cheers, Daniel
On 11/03/15 19:14, Sergey Okhapkin wrote:
Why the pvar name is contid when the entity name is continent code?
On Wednesday 11 March 2015 19:06:39 Daniel-Constantin Mierla wrote:
Hello,
no, it is in the master branch.
If you installed from git repo, you can pick the patch with:
git pull origin git cherry-pick 1ace8a167b9a6515be2b9f4a79786909c9ffce37
You can see the diff at:
https://github.com/kamailio/kamailio/commit/1ace8a167b9a6515be2b9f4a79786 909 c9ffce37
Cheers, Daniel
On 11/03/15 17:23, Rene Montilva wrote:
Hi Daniel
was the patch for v1 geoip module to kamailio 4.2 , i got the doubt
On Wed, Mar 11, 2015 at 11:39 AM, Daniel-Constantin Mierla
<miconda@gmail.com mailto:miconda@gmail.com> wrote: I will apply the patch, but I will change to use same attribute name for continent id as for geoip module, to be coherent.
Cheers, Daniel On 11/03/15 15:34, Sergey Okhapkin wrote: > The patch to return continent code in geoip2 module attached. Daniel, please > apply the diff to the master, I have bad luck fighting with > github. > > On Wednesday 11 March 2015 11:08:12 Daniel-Constantin Mierlawrote:
>> I pushed a path to geoip module in master branch to return continent id >> via 'contid' attribute of the geoip variable. No testing here though, >> therefore I appreciate if you report back it works or not. >> >> Would be good to get it in geoip2 as well -- hopefully Sergey has the >> time for it. >> >> Cheers, >> Daniel >> >> On 11/03/15 01:08, Rene Montilva wrote: >>> I am trying to separate from continent to have rtp more dynamic >>> to >>> simplify the assignment, the geoip i'm working on v1 >>> >>> On Tue, Mar 10, 2015 at 7:22 PM, Sergey Okhapkin >>> >>> <sos@sokhapkin.dyndns.org <mailto:sos@sokhapkin.dyndns.org> <mailto:sos@sokhapkin.dyndns.org <mailto:sos@sokhapkin.dyndns.org>>> wrote: >>> Hmm, I can add continent code pvar to geoip2 module in kamailio >>> trunk. Is it >>> really useful instead of country code? >>> >>> On Tuesday 10 March 2015 19:03:35 Rene Montilva wrote: >>> > Hi list >>> > >>> > i'm trying to configure rtp engine routing by source ip, >>> > i'd >>> >>> like divide it >>> >>> > by continent code, is there any pseudo-variables or possibilites >>> to handle >>> >>> > continent code. >>> > >>> > Team, any idea about it? >>> >>> _______________________________________________ >>> SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing >>> list >>> sr-users@lists.sip-router.org <mailto:sr-users@lists.sip-router.org> <mailto:sr-users@lists.sip-router.org <mailto:sr-users@lists.sip-router.org>> >>> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-user >>> s >>> >>> _______________________________________________ >>> SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list >>> sr-users@lists.sip-router.org <mailto:sr-users@lists.sip-router.org> >>> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users -- Daniel-Constantin Mierla http://twitter.com/#!/miconda <http://twitter.com/#%21/miconda> - http://www.linkedin.com/in/miconda Kamailio World Conference, May 27-29, 2015 Berlin, Germany - http://www.kamailioworld.com _______________________________________________ SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list sr-users@lists.sip-router.org <mailto:sr-users@lists.sip-router.org> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users