<!-- Kamailio Project uses GitHub Issues only for bugs in the code or feature requests. Please use this template only for bug reports.
If you have questions about using Kamailio or related to its configuration file, ask on sr-users mailing list:
* http://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users
If you have questions about developing extensions to Kamailio or its existing C code, ask on sr-dev mailing list:
* http://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Please try to fill this template as much as possible for any issue. It helps the developers to troubleshoot the issue.
If there is no content to be filled in a section, the entire section can be removed.
You can delete the comments from the template sections when filling.
You can delete next line and everything above before submitting (it is a comment). -->
### Description
Kamailio's ims_usrloc_pcscf module fetches all contact informations from location table at startup. I noticed that it fails to fetch protocol information. I checked the function which reads the contact row:
https://github.com/kamailio/kamailio/blob/c3629f877500373028d2c7cdefd976cddd...
I saw that it is read the value as INT. Then checked database table and saw that protocol field is CHAR(5). https://github.com/kamailio/kamailio/blob/master/utils/kamctl/mysql/ims_usrl...
``` CREATE TABLE `location` ( ... `protocol` char(5) DEFAULT NULL, ... ); ```
The protocol fields needs to be INT in location table as well.
This bug leads to other bugs because protocol information is used in aor_hash calculation.
Best regards Erhan Sendag
### Troubleshooting
#### Reproduction
Put a record in location table with protocol value as 1. Set ims_usrloc_pcscf module parameter db_mode as 1. After kamailio startup, on debug log, protocol information will be seen as a big integer value.
#### Debugging Data
<!-- If you got a core dump, use gdb to extract troubleshooting data - full backtrace, local variables and the list of the code at the issue location.
gdb /path/to/kamailio /path/to/corefile bt full info locals list
If you are familiar with gdb, feel free to attach more of what you consider to be relevant. -->
``` (paste your debugging data here) ```
#### Log Messages
<!-- Check the syslog file and if there are relevant log messages printed by Kamailio, add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site). -->
``` (paste your log messages here) ```
#### SIP Traffic
<!-- If the issue is exposed by processing specific SIP messages, grab them with ngrep or save in a pcap file, then add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site). -->
``` (paste your sip traffic here) ```
### Possible Solutions
<!-- If you found a solution or workaround for the issue, describe it. Ideally, provide a pull request with a fix. -->
The protocol fields can be defined as INT in location table.
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
``` (paste your output here) ```
* **Operating System**:
<!-- Details about the operating system, the type: Linux (e.g.,: Debian 8.4, Ubuntu 16.04, CentOS 7.1, ...), MacOS, xBSD, Solaris, ...; Kernel details (output of `lsb_release -a` and `uname -a`) -->
``` (paste your output here) ```
Hi,
There is one more issue. ims_usrloc_pcscf's db_insert_pcontact function is not able to write protocol value into database.
https://github.com/kamailio/kamailio/blob/c3629f877500373028d2c7cdefd976cddd...
In db_insert_pcontact function, Value array's length is 16, but while inserting, this value is given as 15. So contact's protocol value which is the last item of the array is not being written to the database.
``` int db_insert_pcontact(struct pcontact* _c) { .... db_key_t keys[16] = { &domain_col, &aor_col, &received_col, &received_port_col, &received_proto_col, &path_col, &rinstance_col, &rx_session_id_col, ®_state_col, &expires_col, &service_routes_col, &socket_col, &public_ids_col, &host_col, &port_col, &protocol_col }; db_val_t values[16]; ... ... if (ul_dbf.insert(ul_dbh, keys, values, 15) < 0) { LM_ERR("inserting contact in db failed\n"); return -1; }
return 0; } ```
You can propose changes to the code via pull requests, the ims modules are not used by many developers, so your contribution could help.
Hi, I have proposed the changes via pull request.
This issue is stale because it has been open 6 weeks with no activity. Remove stale label or comment or this will be closed in 2 weeks.
Closed #2871 as not planned.