sr-dev

sr-dev@lists.kamailio.org

6 participants
44991 discussions

git:master:2492b92e: dialog: use defined tockens for is_set field of local cseq structure for keepalives
by Daniel-Constantin Mierla 06 Jun '25

06 Jun '25

Module: kamailio Branch: master Commit: 2492b92e49cfcd5f6828007b6a289b3f881dba69 URL: https://github.com/kamailio/kamailio/commit/2492b92e49cfcd5f6828007b6a289b3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-06T10:15:02+02:00 dialog: use defined tockens for is_set field of local cseq structure for keepalives --- Modified: src/modules/dialog/dlg_req_within.c --- Diff: https://github.com/kamailio/kamailio/commit/2492b92e49cfcd5f6828007b6a289b3… Patch: https://github.com/kamailio/kamailio/commit/2492b92e49cfcd5f6828007b6a289b3… --- diff --git a/src/modules/dialog/dlg_req_within.c b/src/modules/dialog/dlg_req_within.c index 52e492d2074..48494bef428 100644 --- a/src/modules/dialog/dlg_req_within.c +++ b/src/modules/dialog/dlg_req_within.c @@ -790,10 +790,11 @@ int dlg_send_ka(dlg_cell_t *dlg, int dir) * - dialog is ended on timeout (408) or C/L does not exist (481) */ if(di->loc_seq.value > 1) { di->loc_seq.value -= 2; + di->loc_seq.is_set = DLG_SEQ_VALSET; } else { di->loc_seq.value = 0; + di->loc_seq.is_set = DLG_SEQ_VALNEW; } - di->loc_seq.is_set = 1; LM_DBG("sending OPTIONS to %s\n", (dir == DLG_CALLER_LEG) ? "caller" : "callee");

1 0

git:master:73c8316b: tm: add defines for dlg cseq is_self field
by Daniel-Constantin Mierla 06 Jun '25

06 Jun '25

Module: kamailio Branch: master Commit: 73c8316bf89703156f241886554919339ac270d0 URL: https://github.com/kamailio/kamailio/commit/73c8316bf89703156f2418865549193… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-06T10:08:12+02:00 tm: add defines for dlg cseq is_self field - DLG_SEQ_VALINIT (should be initialized), DLG_SEQ_VALSET (is set, but can be updated for requests within dialog), DLG_SEQ_VALNEW (is set, and ready to be used as new cseq number in generated request) --- Modified: src/modules/tm/dlg.c Modified: src/modules/tm/dlg.h Modified: src/modules/tm/rpc_uac.c Modified: src/modules/tm/uac.c --- Diff: https://github.com/kamailio/kamailio/commit/73c8316bf89703156f2418865549193… Patch: https://github.com/kamailio/kamailio/commit/73c8316bf89703156f2418865549193… --- diff --git a/src/modules/tm/dlg.c b/src/modules/tm/dlg.c index b99065a94c2..6c97db622af 100644 --- a/src/modules/tm/dlg.c +++ b/src/modules/tm/dlg.c @@ -357,7 +357,7 @@ int new_dlg_uac(str *_cid, str *_ltag, unsigned int _lseq, str *_luri, /* Make a copy of local sequence (usually CSeq) */ res->loc_seq.value = _lseq; /* And mark it as set */ - res->loc_seq.is_set = 1; + res->loc_seq.is_set = DLG_SEQ_VALSET; *_d = res; @@ -979,7 +979,7 @@ static inline int request2dlg(struct sip_msg *_m, dlg_t *_d) if(get_cseq_value(_m, &_d->rem_seq.value) < 0) goto err3; - _d->rem_seq.is_set = 1; + _d->rem_seq.is_set = DLG_SEQ_VALSET; if(get_dlg_uri(_m->from, &_d->rem_uri) < 0) goto err3; @@ -1149,7 +1149,7 @@ int dlg_request_uas( /* Neither out of order nor retransmission -> update */ _d->rem_seq.value = cseq; - _d->rem_seq.is_set = 1; + _d->rem_seq.is_set = DLG_SEQ_VALSET; /* We will als update remote target URI if the message * is target refresher diff --git a/src/modules/tm/dlg.h b/src/modules/tm/dlg.h index 732ba970bc0..ff37bc4bd9a 100644 --- a/src/modules/tm/dlg.h +++ b/src/modules/tm/dlg.h @@ -52,6 +52,10 @@ #endif /* DIALOG_CALLBACKS */ +#define DLG_SEQ_VALINIT 0 +#define DLG_SEQ_VALSET 1 +#define DLG_SEQ_VALNEW 2 + /* * Dialog sequence */ diff --git a/src/modules/tm/rpc_uac.c b/src/modules/tm/rpc_uac.c index 285f3c7e9eb..3cd99a4d9c6 100644 --- a/src/modules/tm/rpc_uac.c +++ b/src/modules/tm/rpc_uac.c @@ -757,7 +757,7 @@ static void rpc_t_uac(rpc_t *rpc, void *c, int reply_wait, int cbflags) dlg.loc_seq.value = cseq; else dlg.loc_seq.value = DEFAULT_CSEQ; - dlg.loc_seq.is_set = 1; + dlg.loc_seq.is_set = DLG_SEQ_VALSET; dlg.loc_uri = get_from(&faked_msg)->uri; dlg.rem_uri = get_to(&faked_msg)->uri; @@ -1077,7 +1077,7 @@ int t_uac_send(str *method, str *ruri, str *nexthop, str *send_socket, dlg.loc_seq.value = cseq; else dlg.loc_seq.value = DEFAULT_CSEQ; - dlg.loc_seq.is_set = 1; + dlg.loc_seq.is_set = DLG_SEQ_VALSET; dlg.loc_uri = get_from(&faked_msg)->uri; dlg.rem_uri = get_to(&faked_msg)->uri; diff --git a/src/modules/tm/uac.c b/src/modules/tm/uac.c index a9a327745ec..26748f4570c 100644 --- a/src/modules/tm/uac.c +++ b/src/modules/tm/uac.c @@ -451,11 +451,11 @@ static inline int t_uac_prepare( /* if err's returned, the message is incorrect */ goto error3; - if(!uac_r->dialog->loc_seq.is_set) { + if(uac_r->dialog->loc_seq.is_set == DLG_SEQ_VALINIT) { /* this is the first request in the dialog, set cseq to default value now - Miklos */ uac_r->dialog->loc_seq.value = DEFAULT_CSEQ; - uac_r->dialog->loc_seq.is_set = 1; + uac_r->dialog->loc_seq.is_set = DLG_SEQ_VALSET; } /* build cell sets X/AVP lists to new transaction structure @@ -677,7 +677,9 @@ int prepare_req_within(uac_req_t *uac_r, struct retr_buf **dst_req) goto send; if((uac_r->method->len == 6) && (!memcmp("CANCEL", uac_r->method->s, 6))) goto send; - uac_r->dialog->loc_seq.value++; /* Increment CSeq */ + if(uac_r->dialog->loc_seq.is_set != DLG_SEQ_VALNEW) { + uac_r->dialog->loc_seq.value++; /* Increment CSeq */ + } send: ret = t_uac_prepare(uac_r, dst_req, 0);

1 0

[kamailio/kamailio] Frequent hangs in Kamailio probably related due to lock contention in xhttp_prom module with high concurrency (Issue #4209)
by Henning Westerholt 06 Jun '25

06 Jun '25

henningw created an issue (kamailio/kamailio#4209) Frequent hangs in Kamailio probably related due to lock contention in xhttp_prom module. ### Environment: The systems are using 32 Kamailio worker processes for the relevant network interface, Its also using Prometheus counter increment operations more than 30 times in the cfg during INVITE processing. The Kamailio uses otherwise no database or other IO related services. Kamailio version 5.8.3, but no relevant changes in the xhttp_prom module could be found. ### Quick summary of the findings: Multiple systems showed frequent hangs in their Kamailio servers on a customer setup. It happens usually after a few hours that all Kamailio processes gets blocked, and no more traffic can be processed on the respective system. I have analysed three stack traces of the Kamailio on one of the system that showed the behaviour. Two without problems and one that was created from during a period where the server had problems. ### Details: Here some details of the stack traces from a problematic case. The relevant processes are from PID 494551 to 494582. The majority of all of these processes are blocked in paths related to the Prometheus module (PID 494551 to 494576): #### PID 494551: ``` #1 0x00007fc69ea5f053 in futex_get (lock=0x7fc4a147acd0) at ../../core/mem/../futexlock.h:108 v = 2 i = 1024 #2 0x00007fc69ea70f99 in prom_counter_inc (s_name=0x7fffe339ffa0, number=1, l1=0x7fffe339ff90, l2=0x0, l3=0x0) at prom_metric.c:1154 p = 0x6b __func__ = "prom_counter_inc" […] #14 0x00000000005ab179 in receive_msg (buf=0x9f47e0 <buf> "INVITE [sip:+1YYYYYYY737@10.XXX.XXX107](sip:+1YYYYYYYYYY737@10.XXX.XX.107) SIP/2.0\r\nRecord-Route: [sip:10.1XXX.XXX.104;lr=on;ftag=HK507HSy55p9F;dlgcor=62b91.985c3](sip:10.XXX.XXX.104;lr=on;ftag=HK507HSy55p9F;dlgcor=62b91.985c3)\r\nRecord-Route: [sip:10.XXX.XXX.117;r2=on;lr;ftag=HK507HSy55p9F](sip:10.XXX.XXX.117;r2=on;lr;ftag=HK507HSy55p9F)\r\nRecord-R"..., len=2819, rcv_info=0x7fffe33a28d0) at core/receive.c:518 ``` Most of the worker processes are in the same state as shown above. Some of the processes are also working in other Prometheus related operations: #### PID 494554: ``` #0 prom_metric_timeout_delete (p_m=0x7fc49ea102f0) at prom_metric.c:646 current = 0x7fc4a2810fd0 ts = 1744143945433 __func__ = "prom_metric_timeout_delete" l = 0x7fc4abffc808 #1 0x00007fc69ea676ce in prom_metric_list_timeout_delete () at prom_metric.c:668 p = 0x7fc49ea102f0 ``` ### Problem hypothesis: My hypothesis is that the hang is caused from lock contention around the Prometheus module. The relevant code uses only one lock, and this together with the extensive usage of the increment counters probably causes this issues under high load. The majority of the worker processed are occupied in the Prometheus path and are not working on SIP packets. This will cause of course an increase of the UDP queue and the described problems. In order to test this hypothesis we removed temporarily the Prometheus logic in the kamailio cfg and see if the issue still persists. The issue did not showed up again after two days of testing, when before it was observed after a few hours. ### Possible solutions: The Prometheus module probably needs some improvements to support better high-load and concurrency situations. On common approach is to split the locks, e.g. using a per process lock array and then combining the individual values in a second pass when read from outside. Alternatively the xhttp_prom module should be used only carefully in situations with a high concurrency setup. I have the full backtrace available, if helpful just let me know. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4209 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4209(a)github.com>

2 2

Kamailio Deployment in AWS
by gcampos＠momenta.network 05 Jun '25

05 Jun '25

Hi community, I'm not sure if anyone has ever tried that before, but I'm trying to run Kamailio in AWS with RTPengine. I successfully installed both Kamailio and RTPengine on my EC2 instance and I'm able to make my devices register to it. However, when I make a call from one of my devices, the call is muted. As I analyze my kamailio.cfg file, I see that the "route[NATMANAGE]" is likely the cause of the mute call. I think that none of the conditions below are met, therefore, the flags are not set. Because of that, the last condition is met, thus triggering the "return" and exiting from the route[NATMANAGE] prematurely without even reaching the section where I define the RTPengine modifications. Not only that, but if I remove/comment out the "return", then the RTPengine is triggered, but there call doesn't connect. I wonder why this is happening and if there's any known workaround. # RTP relaying management and signaling updates for NAT traversal route[NATMANAGE] { xlog("L_INFO", "NATMANAGE path was followed\n"); #!ifdef WITH_NAT xlog("L_INFO", "WITH_NAT Triggered\n"); if (is_request()) { xlog("L_INFO", "is_request path was followed\n"); if (has_totag()) { xlog("L_INFO", "has_totag path was followed\n"); if (check_route_param("nat=yes")) { xlog("L_INFO", "nat=yes param detected, setting FLB_NATB\n"); setbflag(FLB_NATB); } } if (nat_uac_test("3")) { xlog("L_INFO", "nat_uac_test(3) matched, setting FLT_NATS + FLB_NATB\n"); setflag(FLT_NATS); setbflag(FLB_NATB); } } if (!(isflagset(FLT_NATS) || isbflagset(FLB_NATB))) { xlog("L_INFO", "No NAT flags set, skipping NAT handling\n"); return; } #!ifdef WITH_RTPENGINE xlog("L_INFO", "WITH_RTPENGINE Path followed\n"); if (has_body("application/sdp")) { if (is_method("INVITE")) { xlog("L_INFO", "IS_METHOD_INVITE Path Followed\n"); rtpengine_manage("replace-origin replace-session-connection trust-address direction=internal"); } else if (is_reply()) { xlog("L_INFO", "IS_Reply Path Followed\n"); rtpengine_manage("replace-origin replace-session-connection trust-address direction=internal"); } } #!else if(nat_uac_test("8")) { rtpproxy_manage("co"); } else { rtpproxy_manage("cor"); } #!endif if (is_request()) { if (!has_totag()) { if(t_is_branch_route()) { add_rr_param(";nat=yes"); } } } if (is_reply()) { if(isbflagset(FLB_NATB)) { if(is_first_hop()) set_contact_alias(); } } if(isbflagset(FLB_NATB)) { # no connect message in a dialog involving NAT traversal if (is_request()) { if(has_totag()) { set_forward_no_connect(); } } } #!endif return; }

3 2

[kamailio/kamailio] tm: invoke tm:local-request on generated ACK messages (PR #4250)
by tsearle 05 Jun '25

05 Jun '25

#### Pre-Submission Checklist    - [*] Commit message has the format required by CONTRIBUTING guide - [*] Commits are split per component (core, individual modules, libs, utils, ...) - [*] Each component has a single commit (if not, squash them into one commit) - [*] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [*] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [*] PR should be backported to stable branches - [*] Tested changes locally - [*] Related to issue #4249 #### Description When sending an INVITE using t_uac_send, the transaction layer automatically generates ACK on final response. However this ack doesn't invoke the tm:local-request callback. This patch adds this functionality You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4250 -- Commit Summary -- * tm: invoke tm:local-request on generated ACK messages -- File Changes -- M src/modules/tm/uac.c (127) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4250.patch https://github.com/kamailio/kamailio/pull/4250.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4250 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4250(a)github.com>

3 5

git:5.8:6c71d5e7: core: sdp - removed invalid condition
by Daniel-Constantin Mierla 05 Jun '25

05 Jun '25

Module: kamailio Branch: 5.8 Commit: 6c71d5e7364e169373a38d899793c78ae4f93835 URL: https://github.com/kamailio/kamailio/commit/6c71d5e7364e169373a38d899793c78… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-05T14:46:57+02:00 core: sdp - removed invalid condition - introduced in commit 3198b66 - GH #4229 (cherry picked from commit 444fef809c21b250402cfdbd48de65926ac6286a) (cherry picked from commit 21c944e4a8c04d6f1a4c66897021e01a5ea6f22b) --- Modified: src/core/parser/sdp/sdp_helpr_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/6c71d5e7364e169373a38d899793c78… Patch: https://github.com/kamailio/kamailio/commit/6c71d5e7364e169373a38d899793c78… --- diff --git a/src/core/parser/sdp/sdp_helpr_funcs.c b/src/core/parser/sdp/sdp_helpr_funcs.c index a22e64cb1e6..02f72d77521 100644 --- a/src/core/parser/sdp/sdp_helpr_funcs.c +++ b/src/core/parser/sdp/sdp_helpr_funcs.c @@ -332,10 +332,7 @@ int extract_candidate(str *body, sdp_stream_cell_t *stream) start = space + 1; len = len - (space - start + 1); - if(start + len > body->s + body->len) { - LM_ERR("no component in `a=candidate'\n"); - return -1; - } + space = memchr(start, 32, len); if(space == NULL) { LM_ERR("no component in `a=candidate'\n");

1 0

git:6.0:a37a57c2: dialog: bump cseq for generated byes also for caller side
by Daniel-Constantin Mierla 05 Jun '25

05 Jun '25

Module: kamailio Branch: 6.0 Commit: a37a57c2b4db73b4963d3af5e733ea8fe5c5833d URL: https://github.com/kamailio/kamailio/commit/a37a57c2b4db73b4963d3af5e733ea8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-05T13:10:49+02:00 dialog: bump cseq for generated byes also for caller side - do it always, they are the last requests within dialog (cherry picked from commit 43e64af9bade5fedf34e847f662b97ce94c041bc) --- Modified: src/modules/dialog/dlg_req_within.c --- Diff: https://github.com/kamailio/kamailio/commit/a37a57c2b4db73b4963d3af5e733ea8… Patch: https://github.com/kamailio/kamailio/commit/a37a57c2b4db73b4963d3af5e733ea8… --- diff --git a/src/modules/dialog/dlg_req_within.c b/src/modules/dialog/dlg_req_within.c index 6349e88c1f8..773ae788e3b 100644 --- a/src/modules/dialog/dlg_req_within.c +++ b/src/modules/dialog/dlg_req_within.c @@ -425,10 +425,9 @@ static inline int send_bye( goto err; } - /* safety bump of cseq if prack was involved in call setup */ - if(cell->iflags & DLG_IFLAG_PRACK) { - dialog_info->loc_seq.value += 80; - } + /* safety bump of cseq for callee side if prack was involved in call setup + * or keepalives were sent to caller side */ + dialog_info->loc_seq.value += 100; LM_DBG("sending BYE to %s\n", (dir == DLG_CALLER_LEG) ? "caller" : "callee");

1 0

git:master:43e64af9: dialog: bump cseq for generated byes also for caller side
by Daniel-Constantin Mierla 05 Jun '25

05 Jun '25

Module: kamailio Branch: master Commit: 43e64af9bade5fedf34e847f662b97ce94c041bc URL: https://github.com/kamailio/kamailio/commit/43e64af9bade5fedf34e847f662b97c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-05T13:07:59+02:00 dialog: bump cseq for generated byes also for caller side - do it always, they are the last requests within dialog --- Modified: src/modules/dialog/dlg_req_within.c --- Diff: https://github.com/kamailio/kamailio/commit/43e64af9bade5fedf34e847f662b97c… Patch: https://github.com/kamailio/kamailio/commit/43e64af9bade5fedf34e847f662b97c… --- diff --git a/src/modules/dialog/dlg_req_within.c b/src/modules/dialog/dlg_req_within.c index 6467b32b349..52e492d2074 100644 --- a/src/modules/dialog/dlg_req_within.c +++ b/src/modules/dialog/dlg_req_within.c @@ -425,10 +425,9 @@ static inline int send_bye( goto err; } - /* safety bump of cseq if prack was involved in call setup */ - if(cell->iflags & DLG_IFLAG_PRACK) { - dialog_info->loc_seq.value += 80; - } + /* safety bump of cseq for callee side if prack was involved in call setup + * or keepalives were sent to caller side */ + dialog_info->loc_seq.value += 100; LM_DBG("sending BYE to %s\n", (dir == DLG_CALLER_LEG) ? "caller" : "callee");

1 0

git:6.0:b293f206: dialog: set cseq is_set for keepalive
by Daniel-Constantin Mierla 05 Jun '25

05 Jun '25

Module: kamailio Branch: 6.0 Commit: b293f20620c3396130f6409ddf30b69499bb482f URL: https://github.com/kamailio/kamailio/commit/b293f20620c3396130f6409ddf30b69… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-05T11:33:15+02:00 dialog: set cseq is_set for keepalive (cherry picked from commit b5d4c20172bdcaf0e63b15b4e23d205125398a42) --- Modified: src/modules/dialog/dlg_req_within.c --- Diff: https://github.com/kamailio/kamailio/commit/b293f20620c3396130f6409ddf30b69… Patch: https://github.com/kamailio/kamailio/commit/b293f20620c3396130f6409ddf30b69… --- diff --git a/src/modules/dialog/dlg_req_within.c b/src/modules/dialog/dlg_req_within.c index 7645ebeca37..6349e88c1f8 100644 --- a/src/modules/dialog/dlg_req_within.c +++ b/src/modules/dialog/dlg_req_within.c @@ -784,10 +784,12 @@ int dlg_send_ka(dlg_cell_t *dlg, int dir) /* tm increases cseq value, decrease it no to make it invalid * - dialog is ended on timeout (408) or C/L does not exist (481) */ - if(di->loc_seq.value > 1) + if(di->loc_seq.value > 1) { di->loc_seq.value -= 2; - else + } else { di->loc_seq.value = 0; + } + di->loc_seq.is_set = 1; LM_DBG("sending OPTIONS to %s\n", (dir == DLG_CALLER_LEG) ? "caller" : "callee");

1 0

git:6.0:21c944e4: core: sdp - removed invalid condition
by Daniel-Constantin Mierla 05 Jun '25

05 Jun '25

Module: kamailio Branch: 6.0 Commit: 21c944e4a8c04d6f1a4c66897021e01a5ea6f22b URL: https://github.com/kamailio/kamailio/commit/21c944e4a8c04d6f1a4c66897021e01… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-05T11:33:03+02:00 core: sdp - removed invalid condition - introduced in commit 3198b66 - GH #4229 (cherry picked from commit 444fef809c21b250402cfdbd48de65926ac6286a) --- Modified: src/core/parser/sdp/sdp_helpr_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/21c944e4a8c04d6f1a4c66897021e01… Patch: https://github.com/kamailio/kamailio/commit/21c944e4a8c04d6f1a4c66897021e01… --- diff --git a/src/core/parser/sdp/sdp_helpr_funcs.c b/src/core/parser/sdp/sdp_helpr_funcs.c index 5e9b3f121ab..2e7d996bc54 100644 --- a/src/core/parser/sdp/sdp_helpr_funcs.c +++ b/src/core/parser/sdp/sdp_helpr_funcs.c @@ -332,10 +332,7 @@ int extract_candidate(str *body, sdp_stream_cell_t *stream) start = space + 1; len = len - (space - start + 1); - if(start + len > body->s + body->len) { - LM_ERR("no component in `a=candidate'\n"); - return -1; - } + space = memchr(start, 32, len); if(space == NULL) { LM_ERR("no component in `a=candidate'\n");

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev