sr-dev December 2024

sr-dev@lists.kamailio.org

17 participants
342 discussions

[kamailio/kamailio] app_python3: evaluate LIBS variable imediately in Makefile (PR #4085)

by sergey-safarov

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description latest `make` version does not evaluate variables immediately. PR explicitly evaluates the LIBS makefile variable. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4085 -- Commit Summary -- * app_python3: evaluate LIBS variable imediately in Makefile -- File Changes -- M src/modules/app_python3/Makefile (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4085.patch https://github.com/kamailio/kamailio/pull/4085.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4085 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4085(a)github.com>

2 days, 2 hours

[kamailio/kamailio] cmake - make clean deletes readme files from modules source folders (Issue #4084)

by Daniel-Constantin Mierla

Executing `make clean` in the `build` folder deletes the `README` files from the modules folders. This is probably because the README is an output of a `cmake-make` command. What would be the best option to skip this removing? I found: - https://stackoverflow.com/questions/6259372/cmake-preventing-make-clean-fro… Which indicates adding: ``` SET_DIRECTORY_PROPERTIES(PROPERTIES CLEAN_NO_CUSTOM 1) ``` In the CMakeLists.txt inside the module folders. But maybe it is another place where it can be done once for all modules, or another option... -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4084 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4084(a)github.com>

4 days, 1 hour

[kamailio/kamailio] cmake: should we use >= 3.13, i.e., "more modern cmake" generation? (Issue #4078)

by space88man

### Description From the cmake timeline 3.0(2014) is called "modern cmake" and ~3.12/3.13(2018) is "more modern cmake" : https://www.youtube.com/watch?v=y7ndUhdQuU8 Since we are doing a major renovation on the kamailio build system should we target the "more modern" generation (that is already > 5 years old). This will encourage the project to follow cmake best practices. Ping @xkaraman @miconda Versions in debian: buster(3.13) bullseye(3.25) bookworm/trixie(3.30) -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4078 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4078(a)github.com>

4 days, 14 hours

[kamailio/kamailio] secfilter‌: support remove rule in Whitelist and Blacklist (PR #4089)

by AsedMorteza

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description ##### **Summary** This update introduces new functionality to the `secfilter` module, enabling the removal of entries from both the Blacklist and Whitelist. It also includes automatic detection and removal of duplicate values from these lists. ##### **Details** * Users can now remove specific entries from the Blacklist or Whitelist based on type (e.g., IP, domain, user) and a given value. * Supports removal of single or multiple matching entries in one operation. ##### **Benefits** - Improves the usability and flexibility of the `secfilter` module by allowing fine-grained control over list management. - Ensures that the Blacklist and Whitelist are kept clean and free from redundant entries. - Enhances performance by reducing unnecessary duplication in the lists. ##### Testing This feature was tested using `kmcmd` commands in various scenarios: - Removing the **first element** in the list. - Removing an element from the **middle** of the list. - Removing the **last element** in the list. - Removing **all matching elements** in the list. In all cases, the commands worked correctly, and the lists were updated and cleaned as expected. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4089 -- Commit Summary -- * secfilter‌: support remove rule in Whitelist and Blacklist -- File Changes -- M src/modules/secfilter/secfilter.c (8) M src/modules/secfilter/secfilter.h (3) M src/modules/secfilter/secfilter_db.c (106) M src/modules/secfilter/secfilter_rpc.c (95) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4089.patch https://github.com/kamailio/kamailio/pull/4089.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4089 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4089(a)github.com>

4 days, 18 hours

[kamailio/kamailio] Handling Duplicate Values in secfilter Module's kamcmd Commands (Issue #4091)

by AsedMorteza

**Description** The `secfilter` module in `kamcmd` currently allows duplicate entries when adding values to certain lists (e.g., blacklists, whitelists). This can lead to unexpected behavior and potential inconsistencies. Could you clarify the reason behind accepting duplicate values? Recently, I submitted a pull request to add delete commands to the `secfilter` module #4089. When a user, for example, executes: `kamcmd secfilter.del_bl user 1005` I iterate through the entire list to ensure all occurrences of `1005` are removed, as I realized duplicates might exist. This is inefficient and could be avoided by preventing duplicates in the first place. **Proposed Solutions** 1. **Prevent Duplicates in Existing `add` Commands:** * I can modify existing `add` commands to directly prevent the addition of duplicate values. This would simplify future operations and improve performance. 2. **Introduce New `add_unique` Commands:** * I can maintain the current `add` commands for backward compatibility. * I can introduce new `add_unique` commands (e.g., `secfilter.add_bl_unique`) that explicitly reject duplicate entries. **Recommendation** I recommend implementing the first solution (preventing duplicates in existing `add` commands) as it provides the most straightforward and efficient approach. **Further Considerations** * Consider adding a check for duplicates during the `add` operation and returning an appropriate error message if a duplicate is encountered. * Document the behavior of duplicate values in the `secfilter` module's documentation. **I would appreciate your feedback and guidance on the best course of action.** -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4091 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4091(a)github.com>

4 days, 18 hours

[kamailio/kamailio] Module dispatcher: ds_is_active() return incorrect. (Issue #4001)

by Minh Vũ

#### Kamailo 5.8 ### Description I use ```ds_is_active function()``` in ```dispatcher``` module. ``` $var(sip_url) = $sht(conf_fs=>$var(conf_id)); # sip:192.168.1.44:5060 if(ds_is_active("1", "$var(sip_url)")){ #### is allways run } ``` or ```ds_is_active("1", $var(sip_url))``` #### Debugging Data When I check dispatcher: ``` "DEST": { "URI": "sip:192.168.1.44:5060", "FLAGS": "IP", "PRIORITY": 0, "ATTRS": { "BODY": "rweight=50;weight=50;cc=1", "DUID": null, "MAXLOAD": 0, "WEIGHT": 50, "RWEIGHT": 50, "SOCKET": null, "SOCKNAME": null, "OBPROXY": null } } ``` Why is the flag set to ```IP```, but ```ds_is_active()``` returns true? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4001 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4001(a)github.com>

5 days, 6 hours

[kamailio/kamailio] cmake: switching deb rules (Issue #4053)

by Victor Seva

Opening this generic issue to track issues when trying to switch deb package generation to cmake: -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4053 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4053(a)github.com>

1 week, 2 days

[kamailio/kamailio] topos:added get_callid_mask/get_callid_unmask funtion for handeling Refer-To header (PR #3872)

by Harish S

Topos: Added get_callid_mask functin which will give the masked callID if actual callID is given and get_callid_unmask function which will unmask the given call-ID. This funtion is useful when the client sends a refer methord with refer-to header containing call-id  #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3872 -- Commit Summary -- * add funtion to mask/unmask callID * get_callid_mask /get_callid_unmask Document Update -- File Changes -- M src/modules/topos/doc/topos_admin.xml (87) M src/modules/topos/topos_mod.c (183) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3872.patch https://github.com/kamailio/kamailio/pull/3872.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3872 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3872(a)github.com>

1 week, 2 days

[kamailio/kamailio] topos: add enable_register_publish (PR #3766)

by Harish S

Added enable_register_publish parameter to enable REGISTER and PUBLISH method for topos If set to 1 REGISTER and PUBLISH will be enabled for topos Currently only via header will be applied for topos and if mask_callid is set to 1 call-ID will be masked. Other headers should be manged by the user as required.   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3766 -- Commit Summary -- * add enable_register_publish -- File Changes -- M src/modules/topos/topos_mod.c (2) M src/modules/topos/tps_msg.c (132) M src/modules/topos/tps_msg.h (2) M src/modules/topos/tps_storage.c (6) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3766.patch https://github.com/kamailio/kamailio/pull/3766.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3766 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3766(a)github.com>

1 week, 2 days

[kamailio/kamailio] xhttp_prom: new xhttp_prom_tags paramete (PR #4073)

by Christian Berger

- allows custom tags to be added to prometheus metrics - Addresses GH issue #4021   #### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [X] PR should be backported to stable branches - [X] Tested changes locally - [X] Related to issue #4021 #### Description  This change adds a new parameter `xhttp_prom_tags`. It allows the user to append tags to the prometheus metrics. This makes those metrics a lot more useful when having multiple kamailio instances running on a single host. This is done by 2 shared memory helper variables which contain the parameter in different formats. This way it is easy to print them out with minimal changes. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4073 -- Commit Summary -- * xhttp_prom: new xhttp_prom_tags paramete -- File Changes -- M src/modules/xhttp_prom/doc/xhttp_prom_admin.xml (25) M src/modules/xhttp_prom/prom.c (30) M src/modules/xhttp_prom/xhttp_prom.c (50) M src/modules/xhttp_prom/xhttp_prom.h (15) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4073.patch https://github.com/kamailio/kamailio/pull/4073.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4073 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4073(a)github.com>

1 week, 2 days

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev December 2024