sr-dev April 2009

sr-dev@lists.kamailio.org

13 participants
230 discussions

by Jan Janak

Hello, Here is a brief git crash course for those who are used to CVS or SVN. The purpose of this crash course is to get you started, it describes basic operations that you will need to do simple changes in the sip-router git repository. You can find links to more documentation at the end. First of all, you'll need to install git. The name of the corresponding Debian package is git-core. Debian Lenny contains version 1.5.6.5 which is sufficient. Newer git versions or packages for other distributions or architectures can be obtained from http://git-scm.com/. As the second step you need to configure the git client. I have attached configuration files to this email for your convenience, save files .gitconfig and .gitignore in your home directory. File sip-router.org_CA.pem is optional, you will only need the file if you plan on accessing the repository over https (that's not the case for developers with write access). Edit file ~/.gitconfig and configure your name and email address there. This is the name and email address that will be visible in git commits. Unlike CVS or SVN commits, git commits contain full name and email address of the commiter, this is the name and email that will be visible in git history. Note that the email address to be used in From header of commit logs sent to the development mailing list is configured separately on the server (there are technical reasons for this). Here is how I configured my name in email address in ~/.gitconfig: [user] name = Jan Janak email = jan(a)iptel.org The git configuration file in your home directory sets up a bunch of short aliases for most common git commands, so you do not have to type $ git checkout every time you are checking out a branch, you can just type 'git co' instead, and if you alias git to 'g' in your ~/.bashrc then it becomes just 'g co' which is much more convenient. Another setting that is particular to our repository is the number of characters used for tabs in the git pager. Git uses less as the default pager and less is configured to use 8 spaces for tabs by default. We use 4 spaces in our sources and thus you might want to re-configure the git pager in your ~/.bashrc. The following setting makes the output of 'git diff' and friends look prettier: export GIT_PAGER="less --tabs=4" Now you can start working with git. The first command that you need to run is 'git clone', this is the command that is used to retrieve the sip-router repository from the server: $ git clone ssh://<username>@git.sip-router.org/sip-router Replace <username> with your real username. The contents of the repository will be stored in 'sip-router' subdirectory of your current working directory. This command is the git equivalent of cvs/svn checkout. Like cvs/svn it will make the most recent version of the sources available in the subdirectory. UNLIKE cvs/svn, this command does not retrieve just the latest version of the sources, it copies the whole history of the project to your local hard drive, not just the latest revision, but all revisions that are stored in the repository, since tday 1. You do not have to be worried about the size of the repository, the full history of SER takes about 40MB only. Also, you will need to run the command only once (or occassionally if you wipe your local copy out entirely). There are other git commands (covered later) that can be used to keep your local copy up-to-date. Those commands can figure out the difference between your local version of the repository and the version on the server and they will transfer only the data that has changed. In other words, 'git clone' is similar to the scp command, it creates a local identical copy of the remote repository by copying the whole remote repository to the local machine. Once you have a local copy of the sip-router repository, you can try to see what is in there: $ cd sip-router $ git branch The command above shows a list of branches that are present in your local copy of the repository. Most likely you will see just one branch called 'master' marked with an asterisk. This means that your local repository contains only one branch called 'master' and the asterisk tells you that this is the branch that is currently checked out. So the sources that you see in that directory come from the master branch. The local master branch is an exact copy of the 'master' branch from the remote repository at git.sip-router.org and it contains latest sip-router sources. Typically, the branch with the most up-to-date code is called 'master' in git. It is the git equivalent of CVS HEAD branch and SVN trunk branch. NOTE: Branches are sometimes called 'heads' in git documentation, but you can just remember that 'branch' and 'head' refers to the same thing. If you look at the remote version of the repository with gitweb at http://git.sip-router.org/cgi-bin/gitweb.cgi?p=sip-router;a=heads you will notice that there are more branches than the 'master' branch which was created by 'git clone' in the local copy of the repository. The command 'git clone' only makes the master branch directly available in the local copy of the repository. For other branches it merely records the fact that the branches exist in the remote repository. To display branches from both the local and the remote repository you can run: $ git branch -a The output should look roughly like this: * master origin/HEAD origin/MAIN origin/Maintainer origin/andrei/cvshead origin/andrei/sctp origin/andrei/sctp_fixes origin/andrei/sctp_one_to_one origin/andrei_sctp origin/cancel_fix origin/cvs-head origin/janakj/cvshead origin/janakj/doxygen origin/master Branches that start with "origin/" are branches that exist in the remote repository. The string origin is just a short alias for the full URI of the remote repository, such as ssh://git.sip-router.org/sip-router. It is a convention that the repository you cloned from initially is called the origin. Once you have the local repository, you can start making changes in it. Modifying the code on the master branch directly is really easy, because git clone already created the master branch for you in local repository and it checked out the master branch by default. Here is how can you make a simple change in one file and commit the result: $ edit main.c $ git add main.c $ git commit As you can see above you need to call 'git add' before you call 'git commit'. 'git add' marks your changes to be commited during the next commit, this is useful, for example, if you want to leave some local changes uncommited while you make the commit. Unlike CVS or SVN, git does not assume that all local changes should be commited during the next commit. It lets you explicitly select a set of changes to be commited. You can avoid the need to call two commands with 'git commit -a', see the git documentation for more details. When you are done with the commit, you can display the list of changes in the repository with 'git log'. The command displays the history of changes in the whole repository, if you want to limit the list to main.c only then you can run 'git log main.c'. If you look closely at the output of 'git log' then you will notice strange lines starting with "commit" followed by a long string of characters: commit 0253726f99ac151f748712a5d39d71f42d9defc6 The long string is how commits in git are represented. This string is a SHA1 checksum of the commit and it is the git equivalent SVN revision numbers. Like SVN revision numbers and UNLIKE CVS versions, this identifier represents the state of the whole repository, not just individual files. Because such long identifier are tedious to type, git supports abbreviated format, you can type just the beginning of the string as long as the beginning of the string is unique. In other words, there must be at most one commit in the database of all commits with this prefix. For example the following two commands refer to the same commit: $ git diff b0f6ec8784712e4c1436fc9a4a3b54296e94ba5c $ git diff b0f6e If somebody creates another commit with an SHA1 id starting with b0f6e later then 'git diff b0f6e' would not longer work and git would complain that the prefix is ambiguous. All changes, such as the commit above, that you do affect the local repository only. There is absolutely no communication with the the remote repository in any of the commands above (git add, git commit, git log). This is possible because we created a full copy of the remote repository with 'git clone'. This is also the reason why all the commands are so fast, unlike their equivalents in CVS or SVN. The fact that you perform all actions/modifications on the local repository only and then you instruct git to do its black magic and synchronize your local changes with the remote repository is probably the biggest difference from CVS/SVN and one of the things that is hard to understand for people who are used to CVS/SVN. This is also why git falls into the category of distributed revision control systems. When you are satisfied with your local changes/commits, you can decide to make them available to others. This can be done by uploading your local changes to the remote repository (the one you initially cloned from). In git terminology this operation is called 'push', so you can push your local changes to the remote repository with 'git push': $ git push origin master:master The first parameter is the name of the remote repository, the second parameter is the name of the local branch and the name of the remote branch, delimited by ':'. You can omit the 2nd parameter: $ git push origin and then 'git push' will upload all local branches to the remote repository. You can also omit the first parameter: $ git push and in that case repository 'origin' is used. The opposite of 'git push' is 'git pull'. This is the operation that you can use to synchronize your local repository with the remote repository. 'git pull' downloads all changes (made by others) from the remote repository that are not yet in your local repository and integrates them into your local repository. You can run 'git pull' whenever you are online to fetch latest changes and keep your local copy of the repository up-to-date. 'git push' and 'git pull' are similar to rsync, they update either the local or the remote copy of the repository by tranferring only what is missing. 'git push' is the git equivalent of 'cvs ci' and 'svn ci'. 'git pull' is the git equivalent of 'cvs update' or 'svn update'. If you make only small changes to the repository then you can modify the master branch directly, as described above. This approach is suitable only for small, trivial changes. If are working on a change which takes longer to implement, consists of many commits, then it is better to create a separate branch and do the development on a separate branch. Branches in git are cheap, remember that all operations, including branch creation, are local operations. You do not even have to push your local branches into the remote repository, you can just keep them in the local copy for your own purposes. You can create a new branch in your local repository with 'git checkout': $ git checkout --track -b mybranch master This command creates a new branch called 'mybranch', configures the branch to track the master branch and checks the new branch out. The word 'track' in this context means that the newly created branch will receive all updates from the master branch whenever you run 'git pull' with this branch checked out. In other words, the branch tracks another branch (master in this case) by merging all changes from the original branch. Command line option -b instructs git to to create a new branch. If this option was omitted then git would assume that 'mybranch' is an existing branch and it would try to check the branch out. The newly created branch exists in the local repository only. If you want to push the branch to the remote repository then you can use 'git push' again: $ git push origin mybranch:janakj/mybranch Because mybranch is a private topic branch of mine, I am pushing it as janakj/mybranch to the remote repository at git.sip-router.org. The remote repository only permits new "username" branches. In other words their name must start with your username. If you try: $ git push origin mybranch:mybranch then git will report an error. The main reason why we have this restriction in place is because we wanted to make sure that people do not push all local branches to the remote repository by accident. This can easily happen if you run 'git push' without any parameters. You can also delete a local branch that is no longer needed by running $ git branch -D mybranch This will delete the local branch only. If you pushed the branch to the remote repository then you might also want to delete the branch in the remote repository with 'git push': $ git push :janakj/mybranch This is a special syntax of 'git push', if you omit the name of the local branch then 'git push' deletes the remote branch whose name follows ':'. Test Repository =============== We have a test repository at git.sip-router.org which you can use to test various git operations. Clone the repository with: $ git clone ssh://username@git.sip-router.org/test and there you can test whatever you want. The repository can also be browsed with gitweb at http://git.sip-router.org/cgi-bin/gitweb.cgi?p=test;a=summary Further Reading =============== [1] Git related pages in the wiki: http://sip-router.org/wiki/git [2] http://eagain.net/articles/git-for-computer-scientists/ [3] Git SVN Crashcourse: http://git.or.cz/course/svn.html [4] http://git-scm.com/documentation

13 years, 10 months

TLS merge

by Jan Janak

Hello, If we want to make the sip-router core usable in both projects, we would also need to merge both tls implementations. In SER we moved the the TLS implementation into tls module. In Kamailio it appears that the tls implementation is in tls subdirectory in the core and then there is tlsops module which contains pseudovariables used to retrieve information from TLS certificates. Unless somebody has a better idea, I would propose that we merge the tls implementation from kamailio core into ser tls module. In addition to that we could merge the implementation of tls related pseudovariables from tlsops into the tls module and then put the tls module into the sip-router repository. What do you think? I volunteer to do this if nobody objects. Jan.

14 years, 8 months

git:master: kex: documentation for km_append_branch()

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 5b04225bf842ce2354ce17cd50ca3c808617bbdb URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=5b04225… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Apr 28 19:34:29 2009 +0200 kex: documentation for km_append_branch() --- modules_k/kex/README | 22 ++++++++++++++++++++++ modules_k/kex/doc/kex_admin.xml | 30 ++++++++++++++++++++++++++++++ 2 files changed, 52 insertions(+), 0 deletions(-) diff --git a/modules_k/kex/README b/modules_k/kex/README index 104ca84..b5e1986 100644 --- a/modules_k/kex/README +++ b/modules_k/kex/README @@ -32,6 +32,7 @@ Daniel-Constantin Mierla 3.4. setbflag(flag [, branch]) 3.5. isbflagset(flag [, branch]) 3.6. resetsflag(flag [, branch]) + 3.7. km_append_branch([uri]) 4. Exported MI Functions @@ -50,6 +51,7 @@ Daniel-Constantin Mierla 1.4. setbflag usage 1.5. setbflag usage 1.6. resetsflag usage + 1.7. km_append_branch usage Chapter 1. Admin Guide @@ -69,6 +71,7 @@ Chapter 1. Admin Guide 3.4. setbflag(flag [, branch]) 3.5. isbflagset(flag [, branch]) 3.6. resetsflag(flag [, branch]) + 3.7. km_append_branch([uri]) 4. Exported MI Functions @@ -109,6 +112,7 @@ Chapter 1. Admin Guide 3.4. setbflag(flag [, branch]) 3.5. isbflagset(flag [, branch]) 3.6. resetsflag(flag [, branch]) + 3.7. km_append_branch([uri]) 3.1. setsflag(flag) @@ -221,6 +225,24 @@ if(isbflagset("1")) resetbflag("1"); ... +3.7. km_append_branch([uri]) + + Append a new branch to SIP request. + + Meaning of the parameters is as follows: + * uri - SIP URI of the new destination. If omitted then the R-URI is + used. It can be static string or a string with pseudo-variables + that will be evaluated at runtime. + + This function can be used from REQUEST_ROUTE and FAILURE_ROUTE. + + Example 1.7. km_append_branch usage +... +km_append_branch(); +... +km_append_branch("sip:alice@sip-router.org"); +... + 4. Exported MI Functions 4.1. arg diff --git a/modules_k/kex/doc/kex_admin.xml b/modules_k/kex/doc/kex_admin.xml index 9bd4298..7fff6a3 100644 --- a/modules_k/kex/doc/kex_admin.xml +++ b/modules_k/kex/doc/kex_admin.xml @@ -247,6 +247,36 @@ resetbflag("1"); </programlisting> </example> </section> + <section> + <title><function moreinfo="none">km_append_branch([uri])</function></title> + <para> + Append a new branch to SIP request. + </para> + <para>Meaning of the parameters is as follows:</para> + <itemizedlist> + <listitem> + <para> + <emphasis>uri</emphasis> - SIP URI of the new destination. If + omitted then the R-URI is used. It can be static string or + a string with pseudo-variables that will be evaluated at + runtime. + </para> + </listitem> + </itemizedlist> + <para> + This function can be used from REQUEST_ROUTE and FAILURE_ROUTE. + </para> + <example> + <title><function>km_append_branch</function> usage</title> + <programlisting format="linespecific"> +... +km_append_branch(); +... +km_append_branch("sip:alice@sip-router.org"); +... +</programlisting> + </example> + </section> </section> <section>

14 years, 11 months

module startup: Process limit of 36 exceeded.

by Henning Westerholt

Hi, i've tried to run some of my tests written for kamailio on kamailio-3.0 in order to check if the modules can be load. With test/2.cfg i've run into this error: BUG: <core> [pt.c:283]: ERROR: fork_process(): Process limit of 36 exceeded. Will simulate fork fail. Is this something critical? Why is there a limit on the process number and how can i extend this? Thanks, Henning

14 years, 11 months

new operators & if($v) behaviour

by Andrei Pelinescu-Onciul

Right now we have a problem with old scripts that use things like if ($v) (where $v could be avp, pseudovar or select). $v can evaluate to a int, a string or undefined. Now for string and undefined the if will evaluate to false (string being an error) and an error will be logged. If the type of $v can be found prior to runtime (e.g. @select is always string) you'll even get a parse error. I plan to add some new operators, to properly deal with these cases: defined($v) strempty($v) strlen($v) but the question still remains if we should preserve compatibility and still support things like if (@to.tag), instead of if (!strempty((a)to.tag)) or if (@to.tag!=""). What's trickier is that if we allow strings in int expressions then we have 2 problems: - "" evaluates to 1 or 0? - how to evaluate a string in an integer context: is "abc" 1 or 3 (strlen)? How about "123" ? - $v is 0 if v is not defined? Note that if we do this it will work in all types of expressions, e.g. if string evaluates to strlen(string) in interger context then: 3+"abc" = 6 ; 3+ ""=3 ; 3+"9"=4 3+"0"=4. Andrei

14 years, 11 months

git:master: fix lib/binrpc compilation (include path, s/modules/modules_s/)

by Henning Westerholt

Module: sip-router Branch: master Commit: 443ec921ff1a6a6a42bb0267d24c8267773afd24 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=443ec92… Author: Henning Westerholt <henning.westerholt(a)1und1.de> Committer: Henning Westerholt <henning.westerholt(a)1und1.de> Date: Thu Apr 30 11:15:05 2009 +0200 fix lib/binrpc compilation (include path, s/modules/modules_s/) --- lib/binrpc/binrpc_api.c | 6 +++--- lib/binrpc/binrpc_api.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/binrpc/binrpc_api.c b/lib/binrpc/binrpc_api.c index faf82d1..c76267c 100644 --- a/lib/binrpc/binrpc_api.c +++ b/lib/binrpc/binrpc_api.c @@ -44,9 +44,9 @@ #include <time.h> /* time */ /* #include <stropts.h> - is this really needed? --andrei */ -#include "../../modules/ctl/ctl_defaults.h" /* default socket & port */ -#include "../../modules/ctl/init_socks.h" -#include "../../modules/ctl/binrpc.c" /* ugly hack */ +#include "../../modules_s/ctl/ctl_defaults.h" /* default socket & port */ +#include "../../modules_s/ctl/init_socks.h" +#include "../../modules_s/ctl/binrpc.c" /* ugly hack */ #include "binrpc_api.h" diff --git a/lib/binrpc/binrpc_api.h b/lib/binrpc/binrpc_api.h index b7a41ed..ef8dfe8 100644 --- a/lib/binrpc/binrpc_api.h +++ b/lib/binrpc/binrpc_api.h @@ -34,7 +34,7 @@ #ifndef BINRPC_API_H_ #define BINRPC_API_H_ -#include "../../modules/ctl/binrpc.h" +#include "../../modules_s/ctl/binrpc.h" struct binrpc_handle { int socket;

14 years, 11 months

source ip address as int

by jh＠tutpro.com

in radius dictionary SIP-Source-IP-Address is of type ipaddr, which is a four byte integer. in order to get source address accounted, $si cannot be used because it is a string and i haven't found a transformation from ip address string to int. is there a solution that i have missed? if not, what would be the best way to solve this: add a new transformation or a new int valued pv for source ip address? -- juha

14 years, 11 months

Suggestions for SR Projects

by Jan Janak

Hello, I have created a new page in the wiki with suggestions for some interesting sip-router related development projects. The list is here: http://sip-router.org/wiki/tbd These are mostly my personal suggestions, things that I consider nice-to-have or interesting (and which I kept on my todo lists for far too long). Most of them would make nice projects for students. If you are a student, or if you supervise students, or if you are interested in working on some of the topics then, please let me know. I'd be happy to help you get started and provide some initial implementation guidance. If you have some suggestions for additional work topics or an itch to scrach then feel free to add them to the list. It would be great if we could collect a list of ideas of non-critical and experimental nature there. The list currently contains: * Integration With User and Group Database in UNIX/Linux * Dynamically Configured Mass Virtual Hosting * Generic RADIUS Driver * Syntax Highlighting of SER Configuration in Dokuwiki * Internalization of Reason Phrases * Multiplexing of SIP and RTP on One Socket * Database Driver for Sqlite * Overload Control for sip-router * MAC Address Authentication and Authorization * Python Integration * SOCKS Support * SIP and RTP Multiplexing (The overload was suggested by Victor Pascual Avila, contact Victor if you want more information). Jan.

14 years, 11 months

git:master: sms(k): sms_report_type & tmb declared in multiple places

by Andrei Pelinescu-Onciul

Module: sip-router Branch: master Commit: a3088112a2f689d240be1506a5d6a3499e8703b5 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=a308811… Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Wed Apr 29 17:33:19 2009 +0200 sms(k): sms_report_type & tmb declared in multiple places --- modules_k/sms/libsms_putsms.c | 1 - modules_k/sms/sms.c | 1 - modules_k/sms/sms_funcs.c | 1 - 3 files changed, 0 insertions(+), 3 deletions(-) diff --git a/modules_k/sms/libsms_putsms.c b/modules_k/sms/libsms_putsms.c index 89b2d41..8223f0d 100644 --- a/modules_k/sms/libsms_putsms.c +++ b/modules_k/sms/libsms_putsms.c @@ -25,7 +25,6 @@ mailto:s.frings@mail.isis.de #include "libsms_modem.h" -int sms_report_type; static char hexa[16] = { '0','1','2','3','4','5','6','7', diff --git a/modules_k/sms/sms.c b/modules_k/sms/sms.c index 4d96c80..e482267 100644 --- a/modules_k/sms/sms.c +++ b/modules_k/sms/sms.c @@ -76,7 +76,6 @@ str domain; int *queued_msgs = 0; int use_contact = 0; int sms_report_type = NO_REPORT; -struct tm_binds tmb; static proc_export_t sms_procs[] = { diff --git a/modules_k/sms/sms_funcs.c b/modules_k/sms/sms_funcs.c index 4b48a46..b4fd322 100644 --- a/modules_k/sms/sms_funcs.c +++ b/modules_k/sms/sms_funcs.c @@ -61,7 +61,6 @@ int nr_of_modems; int max_sms_parts; int *queued_msgs; int use_contact; -int sms_report_type; struct tm_binds tmb;

14 years, 11 months

git:master: sms(s): sms_report_type & tmb declared in multiple places

by Andrei Pelinescu-Onciul

Module: sip-router Branch: master Commit: cb247f058a2c5617edcecb57d111431716dfb4c7 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=cb247f0… Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Wed Apr 29 17:35:39 2009 +0200 sms(s): sms_report_type & tmb declared in multiple places --- modules_s/sms/libsms_putsms.c | 1 - modules_s/sms/sms.c | 1 - modules_s/sms/sms_funcs.c | 1 - 3 files changed, 0 insertions(+), 3 deletions(-) diff --git a/modules_s/sms/libsms_putsms.c b/modules_s/sms/libsms_putsms.c index 468da0d..efd619d 100644 --- a/modules_s/sms/libsms_putsms.c +++ b/modules_s/sms/libsms_putsms.c @@ -25,7 +25,6 @@ mailto:s.frings@mail.isis.de #include "libsms_modem.h" -int sms_report_type; static char hexa[16] = { '0','1','2','3','4','5','6','7', diff --git a/modules_s/sms/sms.c b/modules_s/sms/sms.c index e7beb64..db4ea66 100644 --- a/modules_s/sms/sms.c +++ b/modules_s/sms/sms.c @@ -84,7 +84,6 @@ str domain; int *queued_msgs = 0; int use_contact = 0; int sms_report_type = NO_REPORT; -struct tm_binds tmb; static cmd_export_t cmds[]={ diff --git a/modules_s/sms/sms_funcs.c b/modules_s/sms/sms_funcs.c index 1f4f18e..51696f7 100644 --- a/modules_s/sms/sms_funcs.c +++ b/modules_s/sms/sms_funcs.c @@ -68,7 +68,6 @@ int nr_of_modems; int max_sms_parts; int *queued_msgs; int use_contact; -int sms_report_type; struct tm_binds tmb;

14 years, 11 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev April 2009