Description

Kamailio's ims_usrloc_pcscf module fetches all contact informations from location table at startup.
I noticed that it fails to fetch protocol information. I checked the function which reads the contact row:

https://github.com/kamailio/kamailio/blob/c3629f877500373028d2c7cdefd976cddda31c15/src/modules/ims_usrloc_pcscf/udomain.c#L831

I saw that it is read the value as INT. Then checked database table and saw that protocol field is CHAR(5).
https://github.com/kamailio/kamailio/blob/master/utils/kamctl/mysql/ims_usrloc_pcscf-create.sql

CREATE TABLE `location` (
...
  `protocol` char(5) DEFAULT NULL,
...
);

The protocol fields needs to be INT in location table as well.

This bug leads to other bugs because protocol information is used in aor_hash calculation.

Best regards
Erhan Sendag

Troubleshooting

Reproduction

Put a record in location table with protocol value as 1.
Set ims_usrloc_pcscf module parameter db_mode as 1.
After kamailio startup, on debug log, protocol information will be seen as a big integer value.

Debugging Data

(paste your debugging data here)

Log Messages

(paste your log messages here)

SIP Traffic

(paste your sip traffic here)

Possible Solutions

The protocol fields can be defined as INT in location table.

Additional Information

(paste your output here)

(paste your output here)

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.