7 Feb
2017
7 Feb
'17
10:39 a.m.
During init, the kazoo module performs forking for "AMQP Consumer Worker".
The ranks for all this process are incremented one by one, starting with value 1.
Value 1 is defined as PROC_SIPINIT and has a special meaning for most of the regular
modules.
One side effect of this is that the registration records are loaded from the db twice!
One simple fix would be to fork all the workers with a PROC_NOCHLDINIT ranking.
Proposed patch:
````
--- a/src/modules/kazoo/kazoo.c
+++ b/src/modules/kazoo/kazoo.c
@@ -369,7 +369,7 @@ static int mod_child_init(int rank)
*/
for(i=0; i < dbk_consumer_workers; i++) {
- pid=fork_process(i+1, "AMQP Consumer Worker", 1);
+ pid=fork_process(PROC_NOCHLDINIT, "AMQP Consumer
Worker", 1);
if (pid<0)
return -1; /* error */
if(pid==0){
````
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/972
7 Feb
7 Feb
10:59 a.m.
New subject: [kamailio/kamailio] kazoo: improper init for ampq consumer worker procs (#972)
@ovidiusas thanks. fixed in master and 4.4
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/972#issuecomment-278044110
10:59 a.m.
New subject: [kamailio/kamailio] kazoo: improper init for ampq consumer worker procs (#972)
Closed #972.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/972#event-952311004
8 Feb
8 Feb
11:52 a.m.
New subject: [kamailio/kamailio] kazoo: improper init for ampq consumer worker procs (#972)
Reopened #972.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/972#event-954169118
11:54 a.m.
New subject: [kamailio/kamailio] kazoo: improper init for ampq consumer worker procs (#972)
your fix does not work, the consumer workers need db initialization.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/972#issuecomment-278387588
1:29 p.m.
New subject: [kamailio/kamailio] kazoo: improper init for ampq consumer worker procs (#972)
Maybe they should be started with PROC_RPC or PROC_SIPINIT+1+i.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/972#issuecomment-278418431
2:20 p.m.
New subject: [kamailio/kamailio] kazoo: improper init for ampq consumer worker procs (#972)
Just like we have PROC_SIPRPC, maybe we should have PROC_GENERICWORKER.
The PROC_GENERICWORKER could be an alias to PROC_SIPRPC and then all workers should be
initialized with the same rank and there will be no hard coding (the +1).
I tested this and it's working.
My initial test was done with modparam("kazoo", "pua_mode", 0) and it
didn't catch the db non initialization issue of the "AMQP Consumer Worker"
.
Also, having the new PROC_GENERICWORKER would solve all the other hardcoded places in
other modules.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/972#issuecomment-278432817
2:23 p.m.
New subject: [kamailio/kamailio] kazoo: improper init for ampq consumer worker procs (#972)
that's what i ended up doing :)
thanks for the confirmation & testing
On Wed, Feb 8, 2017 at 7:20 PM, Ovidiu Sas <notifications(a)github.com> wrote:
Just like we have PROC_SIPRPC, maybe we should have
PROC_GENERICWORKER.
The PROC_GENERICWORKER could be an alias to PROC_SIPRPC and then all
workers should be initialized with the same rank and there will be no hard
coding (the +1).
I tested this and it's working.
My initial test was done with modparam("kazoo", "pua_mode", 0) and
it
didn't catch the db non initialization issue of the "AMQP Consumer Worker"
.
Also, having the new PROC_GENERICWORKER would solve all the other
hardcoded places in other modules.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<https://github.com/kamailio/kamailio/issues/972#issuecomment-278432817>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAvDrHh5Z5o-Es7FjnTx0FR0blDPUVAOks5rahVzgaJpZM4L5phZ>
.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/972#issuecomment-278433548
9 Feb
9 Feb
5:53 a.m.
New subject: [kamailio/kamailio] kazoo: improper init for ampq consumer worker procs (#972)
I added PROC_SIPWORKER with value 2 which should allow checking if a sip worker is special
(like SIPINIT) or just normal one.
I am fine adding another one like proposed above, just use a shorter name, like
PROC_GENWORKER or maybe PROC_XWORKER or PROC_EXTWORKER, coming from 'eXtension'
worker, more suggestive for its purpose used by kamailio extensions. Generic is too
generic :-)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/972#issuecomment-278609228
3:39 p.m.
New subject: [kamailio/kamailio] kazoo: improper init for ampq consumer worker procs (#972)
Closed #972.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/972#event-956274106
3:39 p.m.
New subject: [kamailio/kamailio] kazoo: improper init for ampq consumer worker procs (#972)
Fixed in trunk via commit b66df87adde282c3eaa7ab793c598bfe67f8f9a1
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/972#issuecomment-278766392
2887
days inactive
2889
days old
10 comments
3 participants
participants (3)
-
Daniel-Constantin Mierla -
lazedo
-
Ovidiu Sas