sr-dev April 2025

sr-dev@lists.kamailio.org

5 participants
49 discussions

git:master:26aeb724: siputils: function to encode contact with alias
by Daniel-Constantin Mierla 02 Apr '25

02 Apr '25

Module: kamailio Branch: master Commit: 26aeb724afb434d641600a1dd57c8298adea3dab URL: https://github.com/kamailio/kamailio/commit/26aeb724afb434d641600a1dd57c829… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-04-02T16:01:27+02:00 siputils: function to encode contact with alias --- Modified: src/modules/siputils/contact_ops.c Modified: src/modules/siputils/contact_ops.h Modified: src/modules/siputils/siputils.c --- Diff: https://github.com/kamailio/kamailio/commit/26aeb724afb434d641600a1dd57c829… Patch: https://github.com/kamailio/kamailio/commit/26aeb724afb434d641600a1dd57c829…

1 0

[kamailio/kamailio] DMQ improvements related to node status (PR #4182)
by Stefan Mititelu 02 Apr '25

02 Apr '25

#### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Some improvements related to DMQ node status: 1. Allow other modules that use DMQ to detect NOT_ACTIVE nodes via default response callback. Note that only internal dmq ping mechanism can set them back to DMQ_NODE_ACTIVE status. 2. Simplify node status and merge DMQ_NODE_PENDING + DMQ_NODE_TIMEOUT into DMQ_NODE_NOT_ACTIVE since those specific states were never used to be compared against. 3. Add new mod parameters which will control after how many fails the node should be moved to DMQ_NODE_NOT_ACTIVE state. Under testing currently. Will update if any bugs found. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4182 -- Commit Summary -- * dmq: add default response callback * dmq: simplify node status * dmq: add two new modparams -- File Changes -- M src/modules/dialog/dlg_dmq.c (16) M src/modules/dialog/dlg_dmq.h (3) M src/modules/dmq/dmq.c (4) M src/modules/dmq/dmq.h (2) M src/modules/dmq/dmq_funcs.c (6) M src/modules/dmq/dmqnode.c (70) M src/modules/dmq/dmqnode.h (9) M src/modules/dmq/doc/dmq_admin.xml (64) M src/modules/dmq/notification_peer.c (80) M src/modules/dmq/notification_peer.h (3) M src/modules/dmq_usrloc/usrloc_sync.c (12) M src/modules/dmq_usrloc/usrloc_sync.h (2) M src/modules/htable/ht_dmq.c (15) M src/modules/htable/ht_dmq.h (3) M src/modules/presence/presence_dmq.c (16) M src/modules/presence/presence_dmq.h (3) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4182.patch https://github.com/kamailio/kamailio/pull/4182.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4182 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4182(a)github.com>

3 7

[kamailio/kamailio] kafka_send in event_route not work (Issue #4198)
by wangduanduan 02 Apr '25

02 Apr '25

wangduanduan created an issue (kamailio/kamailio#4198)  ### Description kafka_send in event_route like tcp:timeout, tcp:closed not work ``` event_route[tcp:closed] { if (kafka_send("my_topic", "tcp:closed")) { xlog("L_INFO", "send success tcp:closed"); } } event_route[tcp:timeout] { if (kafka_send("my_topic", "tcp:timeout")) { xlog("L_INFO", "send success tcp:timeout"); } } ``` in log, its show "send success tcp:closed", "send success tcp:timeout", but in kafka web ui, in the **my_topic**, can't find the "tcp:closed" or " tcp:timeout" message. --- but if the kafka_send in onreply_route, message will be send ok, in the kafka web ui, the "some_route" can be find. ``` onreplay_route[some_route]{ if (kafka_send("my_topic", "some_routet")) { xlog("L_INFO", "send success some_routet"); } } ```  ### Troubleshooting #### Reproduction  #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic i use tcpdump to capture the traffic between kamailio and kafka. - when use kafka_send in event_route, no packages captured.  ``` ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` 5.6.1 ``` * **Operating System**: centos7  ``` (paste your output here) ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4198 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4198(a)github.com>

4 8

git:master:c532a67d: parser/sdp: check if value is exceeded when looking for o= version field
by Daniel-Constantin Mierla 02 Apr '25

02 Apr '25

Module: kamailio Branch: master Commit: c532a67db654efb21f81e058b7e3a86229766a40 URL: https://github.com/kamailio/kamailio/commit/c532a67db654efb21f81e058b7e3a86… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-04-02T09:38:03+02:00 parser/sdp: check if value is exceeded when looking for o= version field --- Modified: src/core/parser/sdp/sdp_helpr_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/c532a67db654efb21f81e058b7e3a86… Patch: https://github.com/kamailio/kamailio/commit/c532a67db654efb21f81e058b7e3a86… --- diff --git a/src/core/parser/sdp/sdp_helpr_funcs.c b/src/core/parser/sdp/sdp_helpr_funcs.c index 893ef0e58a4..5e9b3f121ab 100644 --- a/src/core/parser/sdp/sdp_helpr_funcs.c +++ b/src/core/parser/sdp/sdp_helpr_funcs.c @@ -735,7 +735,12 @@ int extract_sess_version(str *oline, str *sess_version) } i++; - } while(len < oline->len && i < 3); + } while((cp < oline->s + oline->len) && i < 3); + + if(cp >= oline->s + oline->len) { + LM_ERR("broken o= line - version field not found\n"); + return -1; + } len = cp - cp0 - 1; LM_DBG("end %d: >%.*s<\n", len, len, cp0);

1 0

[kamailio/kamailio] kex: add KDMQ to request statistic (PR #4197)
by vlitvinov 02 Apr '25

02 Apr '25

2 3

git:master:7314fbcc: kex: add KDMQ to request statistic
by Victor Seva 02 Apr '25

02 Apr '25

Module: kamailio Branch: master Commit: 7314fbcc6fb7c211817d1660b98deaf9db1ea504 URL: https://github.com/kamailio/kamailio/commit/7314fbcc6fb7c211817d1660b98deaf… Author: vlitvinov <litvvitya92(a)gmail.com> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-04-02T07:42:38+02:00 kex: add KDMQ to request statistic --- Modified: src/modules/kex/core_stats.c Modified: src/modules/kex/core_stats.h --- Diff: https://github.com/kamailio/kamailio/commit/7314fbcc6fb7c211817d1660b98deaf… Patch: https://github.com/kamailio/kamailio/commit/7314fbcc6fb7c211817d1660b98deaf… --- diff --git a/src/modules/kex/core_stats.c b/src/modules/kex/core_stats.c index cded47ffc94..ac0c177bf83 100644 --- a/src/modules/kex/core_stats.c +++ b/src/modules/kex/core_stats.c @@ -70,6 +70,7 @@ stat_var *rcv_reqs_prack; stat_var *rcv_reqs_update; stat_var *rcv_reqs_refer; stat_var *rcv_reqs_publish; +stat_var *rcv_reqs_kdmq; /*! extended received replies */ stat_var *rcv_rpls_1xx; stat_var *rcv_rpls_18x; @@ -148,7 +149,8 @@ stat_export_t core_stats[] = {{"rcv_requests", 0, &rcv_reqs}, {"rcv_requests_update", 0, &rcv_reqs_update}, {"rcv_requests_refer", 0, &rcv_reqs_refer}, {"rcv_requests_publish", 0, &rcv_reqs_publish}, - {"rcv_replies", 0, &rcv_rpls}, {"rcv_replies_1xx", 0, &rcv_rpls_1xx}, + {"rcv_requests_kdmq", 0, &rcv_reqs_kdmq}, {"rcv_replies", 0, &rcv_rpls}, + {"rcv_replies_1xx", 0, &rcv_rpls_1xx}, {"rcv_replies_18x", 0, &rcv_rpls_18x}, {"rcv_replies_2xx", 0, &rcv_rpls_2xx}, {"rcv_replies_3xx", 0, &rcv_rpls_3xx}, @@ -259,6 +261,9 @@ static int km_cb_req_stats(struct sip_msg *msg, unsigned int flags, void *param) case METHOD_PUBLISH: update_stat(rcv_reqs_publish, 1); break; + case METHOD_KDMQ: + update_stat(rcv_reqs_kdmq, 1); + break; case METHOD_OTHER: update_stat(unsupported_methods, 1); break; diff --git a/src/modules/kex/core_stats.h b/src/modules/kex/core_stats.h index a1ee018ba18..433747473d0 100644 --- a/src/modules/kex/core_stats.h +++ b/src/modules/kex/core_stats.h @@ -54,6 +54,7 @@ extern stat_var *rcv_reqs_prack; extern stat_var *rcv_reqs_update; extern stat_var *rcv_reqs_refer; extern stat_var *rcv_reqs_publish; +extern stat_var *rcv_reqs_kdmq; /*! \brief received replies */ extern stat_var *rcv_rpls;

1 0

[kamailio/kamailio] tcp_timer_check_connections() logs on CRITICAL and is not caught by event_route[tcp:timeout] (Issue #3995)
by Fritjof Höst 02 Apr '25

02 Apr '25

### Description Hi! We are in the progress of upgrading from Kamailio 5.5 to 5.8. During our testing we have noticed a new error being reported from Kamailio. We don’t see any other errors following it. ```jsx /usr/sbin/kamailio[201]: CRITICAL: <core> [core/tcp_main.c:5544]: tcp_timer_check_connections(): message processing timeout on connection id: 67896 (state: 3) - closing ``` It does seem to be [new code](https://github.com/kamailio/kamailio/blob/master/src/core/tcp_main.c#… in Kamailio reporting this issue. Given that this is a fairly expected thing, cleaning up a connection which receives no traffic within the given time, is there a need for it to be reported on CRITICAL? I’d also expect it to be caught by ``` event_route[tcp:timeout] { xlog("L_INFO","connection $conid timeouts (unanswered keepalives)"); } ``` given that [the description](https://www.kamailio.org/docs/modules/stable/modules/tcpops.ht… of this one is `Called for connection timeouts (unanswered keepalives).`. ### Troubleshooting We don't have any way to reproduce it, we are still investigating it to figure out the cause. It happens around every 2 hours, so we think there might some some scheduled test or job running in our test system causing this. ### Additional Information * **Kamailio Version** - 5.8.3 * **Operating System**: Debian 12 AMI from the AWS Marketplace. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3995 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3995(a)github.com>

5 7

[kamailio/kamailio] tls: Create one shared context and reuse it. (PR #3972)
by Xenofon Karamanos 01 Apr '25

01 Apr '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #3823 #### Description  This PR aims to implement what was discussed in [mailing list](https://lists.kamailio.org/mailman3/hyperkitty/list/sr-dev@lists.kama… regarding some `tls.reload` and increasing memory usage. It adds a new parameter `enable_shared_ctx` in `tls` module that if set to 0, preserves the old behavior and if set to 1 (other than 0 tbh), it creates a single SSL context that is being shared. This have the effect of using way less memory when initialized as well, but also minimizes (can't say it fixes the problem) the `tls.reload` memory increase. I have also added a small markdown (comparison.md) file, where some comparisons where made between enabled/disabled shared context and with/without CA file (where the initial problem was occurring by the reporter). Feedback would be necessary to verify whether this patch, acts as expected and kamailio works as intented. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3972 -- Commit Summary -- * tls: Add parameter for shared contexts * tls: Comparison for enable_shared_ctx -- File Changes -- A comparison.md (15) M src/modules/tls/tls_domain.c (172) M src/modules/tls/tls_mod.c (11) M src/modules/tls/tls_mod.h (1) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3972.patch https://github.com/kamailio/kamailio/pull/3972.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3972 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3972(a)github.com>

4 9

[kamailio/kamailio] core: local TCP socket is bound on listening address (PR #3925)
by sergey-safarov 01 Apr '25

01 Apr '25

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description As a local IP address for TCP sending operation the Kamailio service is taking the same network_interface/IP_address, which is used by the service for TCP listening. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3925 -- Commit Summary -- * core: local TCP socket is bound on listening address -- File Changes -- M src/core/tcp_main.c (24) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3925.patch https://github.com/kamailio/kamailio/pull/3925.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3925 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3925(a)github.com>

5 14

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev April 2025