sr-dev April 2025

sr-dev@lists.kamailio.org

5 participants
49 discussions

[kamailio/kamailio] tm: Update docs of fr_timer to match the implementation (PR #4207)
by Xenofon Karamanos 07 Apr '25

07 Apr '25

- Use description found in https://sip-router.org/wiki/ref_manual/timers   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [ ] Tested changes locally - [x] Related to issue #3939 #### Description  Fix documentation according to the description found in https://sip-router.org/wiki/ref_manual/timers. They better reflect the actual procedure. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4207 -- Commit Summary -- * tm: Update docs of fr_timer to match the implementation -- File Changes -- M src/modules/tm/doc/params.xml (8) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4207.patch https://github.com/kamailio/kamailio/pull/4207.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4207 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4207(a)github.com>

1 0

[kamailio/kamailio] cmake_format all files (PR #4192)
by Xenofon Karamanos 07 Apr '25

07 Apr '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4192 -- Commit Summary -- * cmake: Alter some of cmake-format options * cmake: Fix formatting according to cmake-format config file. -- File Changes -- M CMakeLists.txt (18) M cmake/BuildType.cmake (8) M cmake/cmake-format.py (4) M cmake/compiler-specific.cmake (24) M cmake/defs.cmake (29) M cmake/groups.cmake (45) M cmake/modules-docs.cmake (94) M cmake/modules/FindBerkeleyDB.cmake (60) M cmake/modules/FindErlang.cmake (52) M cmake/modules/FindLdap.cmake (32) M cmake/modules/FindLibev.cmake (4) M cmake/modules/FindLibfreeradiusClient.cmake (21) M cmake/modules/FindMariaDBClient.cmake (3) M cmake/modules/FindMySQL.cmake (114) M cmake/modules/FindNETSNMP.cmake (15) M cmake/modules/FindOracle.cmake (11) M cmake/modules/FindRadius.cmake (6) M cmake/os-specific/darwin.cmake (38) M cmake/os-specific/dragonfly.cmake (9) M cmake/os-specific/freebsd.cmake (3) M cmake/os-specific/linux.cmake (9) M src/CMakeLists.txt (44) M src/core/CMakeLists.txt (16) M src/modules/CMakeLists.txt (55) M src/modules/app_perl/CMakeLists.txt (17) M src/modules/auth_radius/CMakeLists.txt (7) M src/modules/db2_ldap/CMakeLists.txt (3) M src/modules/db_berkeley/CMakeLists.txt (3) M src/modules/dnssec/CMakeLists.txt (5) M src/modules/kazoo/CMakeLists.txt (3) M src/modules/nghttp2/CMakeLists.txt (5) M src/modules/nsq/CMakeLists.txt (5) M src/modules/phonenum/CMakeLists.txt (16) M src/modules/ruxc/CMakeLists.txt (3) M src/modules/sctp/CMakeLists.txt (6) M src/modules/secsipid_proc/CMakeLists.txt (3) M src/modules/snmpstats/CMakeLists.txt (3) M src/modules/tls/CMakeLists.txt (29) M src/modules/tlsa/CMakeLists.txt (11) M src/modules/xhttp_pi/CMakeLists.txt (7) M utils/CMakeLists.txt (6) M utils/db_berkeley/CMakeLists.txt (3) M utils/kamcmd/CMakeLists.txt (26) M utils/kamctl/CMakeLists.txt (161) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4192.patch https://github.com/kamailio/kamailio/pull/4192.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4192 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4192(a)github.com>

3 16

git:master:e9852eff: github: fix check-cmake-format.sh script [skip ci]
by Victor Seva 07 Apr '25

07 Apr '25

Module: kamailio Branch: master Commit: e9852eff76091e1e7b2035d79ff083e760146011 URL: https://github.com/kamailio/kamailio/commit/e9852eff76091e1e7b2035d79ff083e… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-04-07T15:43:41+02:00 github: fix check-cmake-format.sh script [skip ci] * add missing die/fail functions * missing actual checkout of review *before* checking the files * use '--config-files=' instead of '-c'. It was not checking anything --- Modified: .github/scripts/check-cmake-format.sh --- Diff: https://github.com/kamailio/kamailio/commit/e9852eff76091e1e7b2035d79ff083e… Patch: https://github.com/kamailio/kamailio/commit/e9852eff76091e1e7b2035d79ff083e… --- diff --git a/.github/scripts/check-cmake-format.sh b/.github/scripts/check-cmake-format.sh index 582e0324714..a09d0fb8a5a 100755 --- a/.github/scripts/check-cmake-format.sh +++ b/.github/scripts/check-cmake-format.sh @@ -5,6 +5,9 @@ set -eu res=0 +die() { echo "$@" >&2; exit 1; } +fail() { echo "*** $@ ***" >&2; res=1; } + git_log_format() { local pattern="$1" local reference="$2" @@ -17,8 +20,13 @@ check_cmake-format() { continue fi if [[ "${file}" =~ CMakeLists.txt$ ]] || [[ "${file}" =~ \.cmake$ ]] ; then - echo "Checking ${file}" - cmake-format --check -c cmake/cmake-format.py "${file}" || res=1 + printf "Checking %s" "${file}" + if cmake-format --check --config-files=cmake/cmake-format.py "${file}" ; then + printf ". OK\n" + else + printf ". Fail\n" + res=1 + fi fi done < <(git diff-tree --no-commit-id --name-only -r "${1}") } @@ -46,6 +54,7 @@ echo "Checking $(git rev-list --count "${src_sha}" "^${target_sha}") commits sin for commit in $(git rev-list --reverse "${src_sha}" "^${target_sha}"); do commit_msg=$(git_log_format "${COMMIT_MESSAGE_SUBJECT_FORMAT}" "${commit}") echo "[${commit}] ${commit_msg}" + git checkout --progress --force "${commit}" check_cmake-format "${commit}" echo "===================== done ========= " done

1 0

git:master:eff0a5d9: snmpstats: mibs/KAMAILIO-MIB relocated DEFVAL after DESCRIPTION
by Daniel-Constantin Mierla 07 Apr '25

07 Apr '25

Module: kamailio Branch: master Commit: eff0a5d9b39b371c2fdea0378a1f52002cba1e7f URL: https://github.com/kamailio/kamailio/commit/eff0a5d9b39b371c2fdea0378a1f520… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-04-07T13:20:32+02:00 snmpstats: mibs/KAMAILIO-MIB relocated DEFVAL after DESCRIPTION - follow better the definition specs - some tools complain otherwise --- Modified: src/modules/snmpstats/mibs/KAMAILIO-MIB --- Diff: https://github.com/kamailio/kamailio/commit/eff0a5d9b39b371c2fdea0378a1f520… Patch: https://github.com/kamailio/kamailio/commit/eff0a5d9b39b371c2fdea0378a1f520…

1 0

[kamailio/kamailio] topoh: fix bug in hiding record routes in reply messages (PR #4170)
by Farzaneh Soltanzadeh 07 Apr '25

07 Apr '25

2 3

[kamailio/kamailio] dispatcher: added ping socket configuration (PR #4186)
by Michael Furmur 07 Apr '25

07 Apr '25

- add dispatcher modparam `ds_ping_socket` - add gateway param `ping_socket`   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description could be useful for HA use cases where multiple kamailio nodes share a common Virtual IP (e.g.: managed by the VRRP). we need to route requests using Virtual IP socket configured with `ds_default_sockname`/`socket` and to perform destinations probing using self-IP socket configured with `ds_ping_socket`/`ping_socket`. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4186 -- Commit Summary -- * dispatcher: added ping socket configuration -- File Changes -- M src/modules/dispatcher/dispatch.c (32) M src/modules/dispatcher/dispatch.h (2) M src/modules/dispatcher/dispatcher.c (25) M src/modules/dispatcher/doc/dispatcher_admin.xml (20) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4186.patch https://github.com/kamailio/kamailio/pull/4186.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4186 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4186(a)github.com>

2 3

Info: Donating To Kamailio Project
by Daniel-Constantin Mierla 07 Apr '25

07 Apr '25

Hello! Over the years, there have been discussions about what options could be made available to donate to Kamailio project in order to support its required infrastructure, administrative or development of complex components. Creating a foundation or using a crowdfunding platform have been explored, trying to take in consideration the needed man power and overhead, the transparency and accountability. To move forward on this matter, the Kamailio management team has decided to use Open Collective, with the fiscal host Open Collective Europe, as the platform for accepting and managing donations, more details, including the link where donations can be made, are published at: - https://www.kamailio.org/w/donations/ The donations should target either the support of project administration or the development of new feature, therefore before donating it is recommend to email to <management [at] lists.kamailio.org> providing some details about the scope of your donation. We also plan to discuss about it at the next Kamailio World Conference: May 12-13, 2025, organized again in Berlin, Germany, where many developers and members of the management board and our community get together, being a good opportunity to clarify and decide how to use the donations. More details about the event at: - https://www.kamailioworld.com Thanks for flying Kamailio! Cheers, Daniel -- Daniel-Constantin Mierla (@ asipto.com) twitter.com/miconda -- linkedin.com/in/miconda Kamailio Consultancy, Training and Development Services -- asipto.com Kamailio World Conference, May 12-13, 2025, Berlin -- kamailioworld.com

1 0

git:master:9bf0bb20: modules: readme files regenerated - tm ... [skip ci]
by Kamailio Dev 07 Apr '25

07 Apr '25

Module: kamailio Branch: master Commit: 9bf0bb20bcfe6409b6c02aea83175172914135b5 URL: https://github.com/kamailio/kamailio/commit/9bf0bb20bcfe6409b6c02aea8317517… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-04-07T09:46:10+02:00 modules: readme files regenerated - tm ... [skip ci] --- Modified: src/modules/tm/README --- Diff: https://github.com/kamailio/kamailio/commit/9bf0bb20bcfe6409b6c02aea8317517… Patch: https://github.com/kamailio/kamailio/commit/9bf0bb20bcfe6409b6c02aea8317517… --- diff --git a/src/modules/tm/README b/src/modules/tm/README index c0385295106..4821b265a91 100644 --- a/src/modules/tm/README +++ b/src/modules/tm/README @@ -164,8 +164,9 @@ Daniel-Constantin Mierla 5.10. tm.reply 5.11. tm.reply_callid 5.12. tm.retransmit_reply - 5.13. tm.clean - 5.14. tm.stats + 5.13. tm.retransmit_reply_callid + 5.14. tm.clean + 5.15. tm.stats 6. Event Routes @@ -305,9 +306,10 @@ Daniel-Constantin Mierla 1.110. t_exists usage 1.111. t_cell_append_branches usage 1.112. Using “tm.retransmit_reply” - 1.113. event_route[tm:branch-failure:id] usage - 1.114. event_route[tm:local-request] usage - 1.115. event_route[tm:local-response] usage + 1.113. Using “tm.retransmit_reply_callid” + 1.114. event_route[tm:branch-failure:id] usage + 1.115. event_route[tm:local-request] usage + 1.116. event_route[tm:local-response] usage Chapter 1. Admin Guide @@ -452,8 +454,9 @@ Chapter 1. Admin Guide 5.10. tm.reply 5.11. tm.reply_callid 5.12. tm.retransmit_reply - 5.13. tm.clean - 5.14. tm.stats + 5.13. tm.retransmit_reply_callid + 5.14. tm.clean + 5.15. tm.stats 6. Event Routes @@ -3198,8 +3201,9 @@ reply_route { 5.10. tm.reply 5.11. tm.reply_callid 5.12. tm.retransmit_reply - 5.13. tm.clean - 5.14. tm.stats + 5.13. tm.retransmit_reply_callid + 5.14. tm.clean + 5.15. tm.stats 5.1. tm.list @@ -3306,14 +3310,27 @@ reply_route { kamcli rpc tm.retransmit_reply 1234:5678 ... -5.13. tm.clean +5.13. tm.retransmit_reply_callid + + Retransmit the reply for an existing SIP transaction. + + Parameters: + * callid - SIP Call-ID header + * cseq - SIP CSeq header + + Example 1.113. Using “tm.retransmit_reply_callid” +... +kamcli rpc tm.retransmit_reply_callid "abc-xyz" "10 INVITE" +... + +5.14. tm.clean Trigger a hard clean of expired transactions. Parameters: * none -5.14. tm.stats +5.15. tm.stats Gets information about current and past TM transaction handling. @@ -3336,7 +3353,7 @@ kamcli rpc tm.retransmit_reply 1234:5678 enabled with the t_on_branch_failure function. This event_route uses the BRANCH_FAILURE_ROUTE route type. - Example 1.113. event_route[tm:branch-failure:id] usage + Example 1.114. event_route[tm:branch-failure:id] usage ... request_route { ... @@ -3362,7 +3379,7 @@ event_route[tm:branch-failure:myroute] { The request can still be updated, i.e., changes are possible to R-URI ($ru), destination URI ($du) or the send socket ($fs). - Example 1.114. event_route[tm:local-request] usage + Example 1.115. event_route[tm:local-request] usage ... event_route [tm:local-request] { xlog("L_INFO", "Routing locally generated $rm to $ru\n"); @@ -3375,7 +3392,7 @@ event_route [tm:local-request] { Executed after the tm module sent a local generated, transaction stateful response. - Example 1.115. event_route[tm:local-response] usage + Example 1.116. event_route[tm:local-response] usage ... event_route[tm:local-response] { xlog("tm:local-response replied locally\n");

1 0

git:master:31e939a4: tm: docs for rpc tm.retransmit_reply_callid command
by Daniel-Constantin Mierla 07 Apr '25

07 Apr '25

Module: kamailio Branch: master Commit: 31e939a454b90bb6004073b8ad9e13fbcde2f8ca URL: https://github.com/kamailio/kamailio/commit/31e939a454b90bb6004073b8ad9e13f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-04-07T08:17:01+02:00 tm: docs for rpc tm.retransmit_reply_callid command --- Modified: src/modules/tm/doc/rpc.xml --- Diff: https://github.com/kamailio/kamailio/commit/31e939a454b90bb6004073b8ad9e13f… Patch: https://github.com/kamailio/kamailio/commit/31e939a454b90bb6004073b8ad9e13f… --- diff --git a/src/modules/tm/doc/rpc.xml b/src/modules/tm/doc/rpc.xml index 726c5aa2df4..358b9eec683 100644 --- a/src/modules/tm/doc/rpc.xml +++ b/src/modules/tm/doc/rpc.xml @@ -244,6 +244,32 @@ kamcli rpc tm.retransmit_reply 1234:5678 </example> </section> + <section id="tm.rpc.retransmit_reply_callid"> + <title> + <function moreinfo="none">tm.retransmit_reply_callid</function> + </title> + <para> + Retransmit the reply for an existing SIP transaction. + </para> + <para>Parameters: </para> + <itemizedlist> + <listitem><para> + <emphasis>callid</emphasis> - SIP Call-ID header + </para></listitem> + <listitem><para> + <emphasis>cseq</emphasis> - SIP CSeq header + </para></listitem> + </itemizedlist> + <example> + <title>Using <quote>tm.retransmit_reply_callid</quote></title> + <programlisting format="linespecific"> +... +kamcli rpc tm.retransmit_reply_callid "abc-xyz" "10 INVITE" +... +</programlisting> + </example> + </section> + <section id="tm.rpc.clean"> <title> <function moreinfo="none">tm.clean</function>

1 0

git:master:ba662a50: tm: added rpc command tm.retransmit_reply_callid
by Daniel-Constantin Mierla 07 Apr '25

07 Apr '25

Module: kamailio Branch: master Commit: ba662a50013a84e2d492460c3ae5cf80fc85c6f0 URL: https://github.com/kamailio/kamailio/commit/ba662a50013a84e2d492460c3ae5cf8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-04-07T08:17:01+02:00 tm: added rpc command tm.retransmit_reply_callid --- Modified: src/modules/tm/t_reply.c Modified: src/modules/tm/t_reply.h Modified: src/modules/tm/tm.c --- Diff: https://github.com/kamailio/kamailio/commit/ba662a50013a84e2d492460c3ae5cf8… Patch: https://github.com/kamailio/kamailio/commit/ba662a50013a84e2d492460c3ae5cf8… --- diff --git a/src/modules/tm/t_reply.c b/src/modules/tm/t_reply.c index 670260d93e8..7f3e70ae7cb 100644 --- a/src/modules/tm/t_reply.c +++ b/src/modules/tm/t_reply.c @@ -3123,6 +3123,50 @@ void rpc_reply_callid(rpc_t *rpc, void *c) } } +/* + * Syntax: + * + * ":tm.retransmit_reply:[response file]\n + * callid + * cseq + * \n" + */ +void rpc_retransmit_reply_callid(rpc_t *rpc, void *c) +{ + int ret; + tm_cell_t *trans; + tm_cell_t *orig_t = NULL; + int orig_branch; + str callid = {0, 0}; + str cseq = {0, 0}; + + if(rpc->scan(c, "S", &callid) < 1) { + rpc->fault(c, 400, "Call-ID expected"); + return; + } + + if(rpc->scan(c, "S", &cseq) < 1) { + rpc->fault(c, 400, "CSeq expected"); + return; + } + + tm_get_tb(&orig_t, &orig_branch); + if(t_lookup_callid(&trans, callid, cseq) < 0) { + rpc->fault(c, 404, "Transaction not found"); + return; + } + /* it is refcounted now */ + ret = t_retransmit_reply(trans); + UNREF(trans); + tm_set_tb(orig_t, orig_branch); + + if(ret < 0) { + LM_ERR("Reply retransmission failed\n"); + rpc->fault(c, 500, "Reply retransmission failed"); + return; + } +} + /* * Syntax: * diff --git a/src/modules/tm/t_reply.h b/src/modules/tm/t_reply.h index 0fe1c09eb81..5e3d0451768 100644 --- a/src/modules/tm/t_reply.h +++ b/src/modules/tm/t_reply.h @@ -227,6 +227,7 @@ void t_drop_replies(int v); void rpc_reply(rpc_t *rpc, void *c); void rpc_reply_callid(rpc_t *rpc, void *c); void rpc_retransmit_reply(rpc_t *rpc, void *c); +void rpc_retransmit_reply_callid(rpc_t *rpc, void *c); int faked_env(struct cell *t, struct sip_msg *msg, int is_async_env); struct sip_msg *fake_req(struct sip_msg *shmem_msg, int extra_flags, diff --git a/src/modules/tm/tm.c b/src/modules/tm/tm.c index 0df18a8bd1b..b33c66f63fc 100644 --- a/src/modules/tm/tm.c +++ b/src/modules/tm/tm.c @@ -2869,6 +2869,11 @@ static const char *rpc_retransmit_reply_doc[2] = { 0 }; +static const char *rpc_retransmit_reply_callid_doc[2] = { + "Retransmit the transaction reply by call-id", + 0 +}; + static const char *rpc_reply_callid_doc[2] = { "Reply transaction by call-id", 0 @@ -2943,6 +2948,8 @@ static rpc_export_t tm_rpc[] = { {"tm.cancel", rpc_cancel, rpc_cancel_doc, 0}, {"tm.reply", rpc_reply, rpc_reply_doc, 0}, {"tm.retransmit_reply", rpc_retransmit_reply, rpc_retransmit_reply_doc, 0}, + {"tm.retransmit_reply_callid", rpc_retransmit_reply_callid, + rpc_retransmit_reply_callid_doc, 0}, {"tm.reply_callid", rpc_reply_callid, rpc_reply_callid_doc, 0}, {"tm.stats", tm_rpc_stats, tm_rpc_stats_doc, 0}, {"tm.hash_stats", tm_rpc_hash_stats, tm_rpc_hash_stats_doc, 0},

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev April 2025