sr-dev April 2025

sr-dev@lists.kamailio.org

5 participants
43 discussions

[kamailio/kamailio] Problems with ims_ipsec_pcscf and closed tcp connections (Issue #4138)
by Atanas Bakalov 05 Apr '25

05 Apr '25

### Description Let's assume we have a MO call from UE to P-CSCF that's over ipsec. Let's assume the picked ports are like UE(6101) -> P-CSCF(6100) We have also set tcp_connection_lifetime to be 20 sec. 20 sec after INVITE connection is RST from Kamailio as expected. Then ( > 20sec later) an INVITE response comes from B side, and must be delivered to the UE. Kamailio opens a new connection and tries to establish a connection from 5060 (standard port)->6101 instead of 6100(P-CSCF) -> 6101(UE). IPSEC associations are not engaged and UE does not handle the request properly. ### Troubleshooting #### Reproduction #### Debugging Data #### Log Messages #### SIP Traffic ### Possible Solutions The IPSEC module should re-open the tcp connection if it sees it's been dropped as core module has no awareness of IPSEC. * **Operating System**: All -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4138 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4138(a)github.com>

3 3

[kamailio/kamailio] rtpengine: fix race condn (same ip:port) in parallel forks due to gencookie (PR #4139)
by Souradeep Bera 05 Apr '25

05 Apr '25

- avoid parallel calls to gencookie from generating the same cookie for rtpengine #### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4139 -- Commit Summary -- * rtpengine: fix race condn assigning same ip:port due to gencookie in parallel forks -- File Changes -- M src/modules/rtpengine/rtpengine.c (3) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4139.patch https://github.com/kamailio/kamailio/pull/4139.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4139 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4139(a)github.com>

4 4

[kamailio/kamailio] fr_timer documentation mistake (Issue #3939)
by Dmitry Sinina 05 Apr '25

05 Apr '25

Documentation https://www.kamailio.org/docs/modules/devel/modules/tm.html#tm.p.fr_timer says: >Timer which hits if no **final reply** for a request or ACK for a negative INVITE reply arrives (in milliseconds). Looks like it is not correct description - fr_timer value works until 1xx(not **final**) response received and then timer restarted with fr_inv_timer value there: https://github.com/kamailio/kamailio/blob/master/src/modules/tm/t_reply.c#L… Looks like old doc from sip router https://sip-router.org/wiki/ref_manual/timers explains it correctly: > fr_timer This timer is used for all SIP requests. It hits if no reply for an INVITE request or other request has been received (F in milliseconds). If a provisional reply is received for an INVITE (any 1xx), then the fr_inv_timer will be used instead. And if no replies (at all) for an INVITE are received before `fr_timer` hits, the transaction is terminated with a 408 in failure route. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3939 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3939(a)github.com>

3 8

[kamailio/kamailio] Corrupted output with log-engine json (Issue #4203)
by Matteo 04 Apr '25

04 Apr '25

xadhoom created an issue (kamailio/kamailio#4203)  ### Description Enabled json logging engine, with the following setup: - kam cmd line params: `--log-engine=json:Mp` - prefix: `log_prefix=", \"callid\": \"$ci\",\"srcip\": \"$si\", \"ts\": $TV(Sn), \"method\": \"$rm\", \"mt\": $mt, \"ua\": \"$(ua{s.escape.common})\", \"cseq\": \"$hdr(CSeq)\", \"status\": $rs "` - another prefix (same result): `log_prefix=", \"callid\": \"$ci\", \"ts\": $TV(Sn) "` What I see that certain json lines are truncated, for example - one line is interrupted by another json entry - one line starts "truncated" ### Troubleshooting What I can observe is that seems to happens always with same "kind" of line, usually internal logs, which don't have callid etc. #### Log Messages  The following first 3 lines are ok, then the latest is corrupted: ``` { "time": "2025-04-04T15:51:44.448427533Z", "idx": 193, "pid": 200, "level": "DEBUG", "module": "core", "file": "core/receive.c", "line": 128, "function": "sip_check_fline", "message": "first line indicates a SIP reply" } { "time": "2025-04-04T15:51:44.448682606Z", "idx": 194, "pid": 201, "level": "DEBUG", "module": "core", "file": "core/receive.c", "line": 128, "function": "sip_check_fline", "message": "first line indicates a SIP reply" } { "time": "2025-04-04T15:52:14.448279053Z", "idx": 195, "pid": 202, "level": "DEBUG", "module": "core", "file": "core/receive.c", "line": 128, "function": "sip_check_fline", "message": "first line indicates a SIP reply" } { "time": "2025-04-04T15:52:14.448505797Z", "idx": 196, "pid": 203, "level": "DEBUG", "module": "core", "file": "core/receive.c"{ "time": "2025-04-04T15:52:14.448508084Z", "idx": 195, "pid": 202, "level": "DEBUG", "module": "core", "file": "core/parser/msg, "line": 128, "function": "sip_check_fline", "message": "first line indicates a SIP reply" } ``` or (notice 2nd line or 5th one) ``` { "time": "2025-04-04T16:13:33.789641936Z", "idx": 221, "pid": 228, "level": "DEBUG", "module": "core", "file": "core/receive.c"{ "time": "2025-04-04T16:13:33.789642978Z", "idx": 222, "pid": 229, "level": "DEBUG", "module": "core", "file": "core/xavp.c", ", "line": 265, "function": "ksr_evrt_pre_routing", "callid": "5715efe40e9b7721-264(a)127.0.0.1", "ts": 1743783213.789640 , "message": "event route core:pre-routing not defined" } line": 630, "function": "xavp_destroy_list", "callid": "5715efe40e9b7720-264(a)127.0.0.1", "ts": 1743783213.789527 , "message": "destroying xavp list (nil)" } { "time": "2025-04-04T16:13:33.789646470Z", "idx": 222, "pid": 229, "level": "DEBUG", "module": "core", "file": "core/xavp.c", "line": 630, "function": "xavp_destroy_list", "callid": "5715efe40e9b7720-264(a)127.0.0.1", "ts": 1743783213.789527 , "message": "destroying xavp list (nil)" } { "time": "2025-04-04T16:13:33.789648201Z", "idx": 221, "pid": 228, "level": "DEBUG", "module": "tm", "file": "t_lookup.c", "line": 1579, "function": "t_check_msg", "callid": "5715efe40e9b7721-264(a)127.0.0.1", "ts": 1743783213.789640 , "message": "msg (0x7f{ "time": "2025-04-04T16:13:33.789649346Z", "idx": 222, "pid": 229, "level": "DEBUG", "module": "core", "file": "core/receive.c"8f7a693c50) id=2/228 global id=1/228 T start=0xffffffffffffffff" } , "line": 637, "function": "receive_msg", "callid": "5715efe40e9b7720-264(a)127.0.0.1", "ts": 1743783213.789527 , "message": "cleaning up" } { "time": "2025-04-04T16:13:33.789652839Z", "idx": 221, "pid": 228, "level": "DEBUG", "module": "tm", "file": "t_lookup.c", "line": 1424, "function": "t_reply_matching", "callid": "5715efe40e9b7721-264(a)127.0.0.1", "ts": 1743783213.789640 , "message": "t_reply_matching: hash 26404 label 0 branch 0" } ``` ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` 6.0.1 ``` happens also with 5.8.x * **Operating System**:  ``` Debian noble, docker container ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4203 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4203(a)github.com>

1 1

[kamailio/kamailio] dispatcher: weight documentation and workaround for limitations (PR #4158)
by Christian Berger 04 Apr '25

04 Apr '25

- describe limitation of weight parameter - describe a potential workaround against those limitations  #### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [X] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  We had problems understanding the weight parameter of the dispatcher module and wrote a little workaround against the problems we have found. This workaround in the configuration file improves behavior for setups with many dispatcher targets at the cost of more CPU load. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4158 -- Commit Summary -- * dispatcher: weight documentation and workaround for limitations -- File Changes -- M src/modules/dispatcher/doc/dispatcher_admin.xml (28) A src/modules/dispatcher/doc/weights.cfg (49) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4158.patch https://github.com/kamailio/kamailio/pull/4158.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4158 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4158(a)github.com>

3 2

[kamailio/kamailio] pua_json : add support for as-feature-event (PR #4195)
by ThomasSevestre 04 Apr '25

04 Apr '25

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description This PR allow usage of the new presence_dfks module with pua_json You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4195 -- Commit Summary -- * pua_json: add support for as-feature-event -- File Changes -- M src/modules/pua_json/defs.h (16) M src/modules/pua_json/pua_json_publish.c (55) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4195.patch https://github.com/kamailio/kamailio/pull/4195.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4195 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4195(a)github.com>

2 9

git:master:c858cecb: pua_json: add support for as-feature-event
by Henning Westerholt 04 Apr '25

04 Apr '25

Module: kamailio Branch: master Commit: c858cecb4d6589bc53c474b0520a5d060bd3c55b URL: https://github.com/kamailio/kamailio/commit/c858cecb4d6589bc53c474b0520a5d0… Author: Thomas <1258170+ThomasSevestre(a)users.noreply.github.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-04-04T18:04:27+02:00 pua_json: add support for as-feature-event --- Modified: src/modules/pua_json/defs.h Modified: src/modules/pua_json/pua_json_publish.c --- Diff: https://github.com/kamailio/kamailio/commit/c858cecb4d6589bc53c474b0520a5d0… Patch: https://github.com/kamailio/kamailio/commit/c858cecb4d6589bc53c474b0520a5d0… --- diff --git a/src/modules/pua_json/defs.h b/src/modules/pua_json/defs.h index ebf0ba4a0b9..ad5a8eb1eb0 100644 --- a/src/modules/pua_json/defs.h +++ b/src/modules/pua_json/defs.h @@ -68,12 +68,20 @@ #define MWI_JSON_FROM "From" #define MWI_JSON_TO "To" +#define AS_FEATURE_JSON_CALLID "Call-ID" +#define AS_FEATURE_JSON_FROM "From" +#define AS_FEATURE_JSON_FROM_USER "From-User" +#define AS_FEATURE_JSON_FROM_REALM "From-Realm" +#define AS_FEATURE_JSON_DND_STATUS "DND-Status" +#define AS_FEATURE_JSON_EXPIRES "Expires" + #define TO_TAG_BUFFER_SIZE 128 #define FROM_TAG_BUFFER_SIZE 128 #define SENDER_BUFFER_SIZE 1024 #define DIALOGINFO_BODY_BUFFER_SIZE 8192 #define MWI_BODY_BUFFER_SIZE 2048 #define PRESENCE_BODY_BUFFER_SIZE 4096 +#define AS_FEATURE_BODY_BUFFER_SIZE 4096 #define MWI_BODY_VOICE_MESSAGE \ "Messages-Waiting: %.*s\r\nMessage-Account: %.*s\r\nVoice-Message: " \ @@ -139,4 +147,12 @@ </dialog>\ </dialog-info>" +#define AS_FEATURE_BODY \ + "<?xml version=\"1.0\" encoding=\"ISO-8859-1\"?>\ +<DoNotDisturbEvent xmlns=\"http://www.ecma-international.org/standards/ecma-323/csta/ed3\">\ +<device>%.*s</device>\ +<doNotDisturbOn>%.*s</doNotDisturbOn>\ +</DoNotDisturbEvent>\ +" + #endif /* _PUA_JSON_DEFS_H_ */ diff --git a/src/modules/pua_json/pua_json_publish.c b/src/modules/pua_json/pua_json_publish.c index 359c5071858..3444210f39f 100644 --- a/src/modules/pua_json/pua_json_publish.c +++ b/src/modules/pua_json/pua_json_publish.c @@ -38,6 +38,7 @@ extern int pua_include_entity; str str_event_message_summary = str_init("message-summary"); str str_event_dialog = str_init("dialog"); str str_event_presence = str_init("presence"); +str str_event_as_feature_event = str_init("as-feature-event"); str str_username_col = str_init("username"); str str_domain_col = str_init("domain"); @@ -359,6 +360,62 @@ int pua_json_publish_dialoginfo_to_presentity(struct json_object *json_obj) return ret; } +int pua_json_publish_as_feature_to_presentity(struct json_object *json_obj) +{ + int ret = 1; + int len; + str event = str_init("as-feature-event"); + str from = {0, 0}; + str from_user = {0, 0}; + str from_realm = {0, 0}; + str callid = {0, 0}; + str dnd_status = {0, 0}; + int expires = 0; + str as_feature_body = {0, 0}; + + char *body = (char *)pkg_malloc(AS_FEATURE_BODY_BUFFER_SIZE); + + if(body == NULL) { + LM_ERR("Error allocating buffer for publish\n"); + ret = -1; + goto error; + } + + json_api.extract_field(json_obj, AS_FEATURE_JSON_CALLID, &callid); + + json_api.extract_field(json_obj, AS_FEATURE_JSON_FROM, &from); + json_api.extract_field(json_obj, AS_FEATURE_JSON_FROM_USER, &from_user); + json_api.extract_field(json_obj, AS_FEATURE_JSON_FROM_REALM, &from_realm); + + json_api.extract_field(json_obj, AS_FEATURE_JSON_DND_STATUS, &dnd_status); + + struct json_object *ExpiresObj = + json_api.get_object(json_obj, AS_FEATURE_JSON_EXPIRES); + if(ExpiresObj != NULL) { + expires = json_object_get_int(ExpiresObj); + } + + if(!from_user.len || !dnd_status.len) { + LM_ERR("missing one of From-User / DND-Status\n"); + goto error; + } + + len = snprintf(body, AS_FEATURE_BODY_BUFFER_SIZE, AS_FEATURE_BODY, + from_user.len, from_user.s, dnd_status.len, dnd_status.s); + + as_feature_body.s = body; + as_feature_body.len = len; + + pua_json_update_presentity(&event, &from_realm, &from_user, &callid, &from, + &as_feature_body, expires, 1, 1); + +error: + + if(body) + pkg_free(body); + + return ret; +} int pua_json_publish(struct sip_msg *msg, char *json) { @@ -391,6 +448,11 @@ int pua_json_publish(struct sip_msg *msg, char *json) event_package.len) == 0) { ret = pua_json_publish_presence_to_presentity(json_obj); + } else if(event_package.len == str_event_as_feature_event.len + && strncmp(event_package.s, str_event_as_feature_event.s, + event_package.len) + == 0) { + ret = pua_json_publish_as_feature_to_presentity(json_obj); } }

1 0

[kamailio/kamailio] stirshaken: removed repeated x509 certification path check (PR #4202)
by Felipe Cuadra Plaza 04 Apr '25

04 Apr '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description Currently `stirshaken` module performs x509 certificate path check twice (when enabled): - first by calling `stir_shaken_verify_cert_path` directly from the [`stirshaken_mod.c`](https://github.com/kamailio/kamailio/blob/330543f46cbb6bf815ebf77c98378314091197ce/src/modules/stirshaken/stirshaken_mod.c#L626) - second time from the [`libstirshaken`](https://github.com/signalwire/libstirshaken/blame/cb6ede40b3ce12ab76e370186a14dc141839ef07/src/stir_shaken_verify.c#L445) `libstirshaken` had the path check built in since approx 2020 ([last commit mentioning it as TODO](https://github.com/signalwire/libstirshaken/blame/552650e31e3dc668069… before the `stir_shaken_verify_cert_path` function was introduced). This shouldn't be an issue since `stirshaken` module was added to Kamailio in 2021. This PR removes the x509 certificate path check from the `stirshaken_mod.c` by passing the responsibility to perform certificate path check to the `libstirshaken`. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4202 -- Commit Summary -- * stirshaken: removed repeated x509 certification path check -- File Changes -- M src/modules/stirshaken/doc/stirshaken_admin.xml (4) M src/modules/stirshaken/stirshaken_mod.c (17) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4202.patch https://github.com/kamailio/kamailio/pull/4202.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4202 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4202(a)github.com>

1 0

[kamailio/kamailio] docs discrepancies for modules (in 6.0.x) (Issue #4201)
by Paul Donald 04 Apr '25

04 Apr '25

systemcrash created an issue (kamailio/kamailio#4201) https://github.com/kamailio/kamailio/blob/330543f46cbb6bf815ebf77c983783140… This smells of a dependency. Shouldn't these be listed here?: https://www.kamailio.org/docs/modules/6.0.x/modules/cdp.html#idm68 -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4201 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4201(a)github.com>

1 0

git:master:330543f4: github: pull_request, always use scripts from master [skip ci]
by Victor Seva 03 Apr '25

03 Apr '25

Module: kamailio Branch: master Commit: 330543f46cbb6bf815ebf77c98378314091197ce URL: https://github.com/kamailio/kamailio/commit/330543f46cbb6bf815ebf77c9837831… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-04-03T14:37:14+02:00 github: pull_request, always use scripts from master [skip ci] --- Modified: .github/workflows/pull_request.yml --- Diff: https://github.com/kamailio/kamailio/commit/330543f46cbb6bf815ebf77c9837831… Patch: https://github.com/kamailio/kamailio/commit/330543f46cbb6bf815ebf77c9837831… --- diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml index cdfd9f3a3fd..35dda521756 100644 --- a/.github/workflows/pull_request.yml +++ b/.github/workflows/pull_request.yml @@ -23,15 +23,25 @@ jobs: permissions: contents: read # to fetch code (actions/checkout) steps: + - name: Check out scripts folder to the runner + uses: actions/checkout@v4 + with: + ref: master + path: actions + sparse-checkout: | + .github/scripts/check-cmake-format.sh + sparse-checkout-cone-mode: false - name: Check out the repository to the runner uses: actions/checkout@v4 with: + path: source ref: ${{ github.event.pull_request.head.sha }} - uses: awalsh128/cache-apt-pkgs-action(a)v1.5.0 with: packages: cmake-format - name: Run scripts/check-cmake-format.sh - run: ./.github/scripts/check-cmake-format.sh + run: ${{ github.workspace }}/actions/.github/scripts/check-cmake-format.sh + working-directory: ${{ github.workspace }}/source env: ref: ${{ github.event.pull_request.head.sha }} FETCH_DEPTH: 50 @@ -40,12 +50,22 @@ jobs: permissions: contents: read # to fetch code (actions/checkout) steps: + - name: Check out scripts folder to the runner + uses: actions/checkout@v4 + with: + ref: master + path: actions + sparse-checkout: | + .github/scripts/check-commit.sh + sparse-checkout-cone-mode: false - name: Check out the repository to the runner uses: actions/checkout@v4 with: + path: source ref: ${{ github.event.pull_request.head.sha }} - name: Run scripts/check-commit.sh - run: ./.github/scripts/check-commit.sh + run: ${{ github.workspace }}/actions/.github/scripts/check-commit.sh + working-directory: ${{ github.workspace }}/source env: ref: ${{ github.event.pull_request.head.sha }} FETCH_DEPTH: 50

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev April 2025