Module: kamailio
Branch: 6.0
Commit: f540d97e3f0be21cb6abc61ac701c8fd437b4371
URL: https://github.com/kamailio/kamailio/commit/f540d97e3f0be21cb6abc61ac701c8f…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2025-01-29T11:34:17+01:00
ims_qos_npn: small docs updates
(cherry picked from commit dcdcee0d9f2326e079f905632af9db3b898330ab)
---
Modified: src/modules/ims_qos_npn/doc/ims_qos_npn.xml
Modified: src/modules/ims_qos_npn/doc/ims_qos_npn_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/f540d97e3f0be21cb6abc61ac701c8f…
Patch: https://github.com/kamailio/kamailio/commit/f540d97e3f0be21cb6abc61ac701c8f…
---
diff --git a/src/modules/ims_qos_npn/doc/ims_qos_npn.xml b/src/modules/ims_qos_npn/doc/ims_qos_npn.xml
index 0cd99dcd0c7..fa9d03eb003 100644
--- a/src/modules/ims_qos_npn/doc/ims_qos_npn.xml
+++ b/src/modules/ims_qos_npn/doc/ims_qos_npn.xml
@@ -7,7 +7,7 @@
]>
<book>
<bookinfo>
- <title>The IMS QoS Module - Neat Path Networks "branch"</title>
+ <title>The IMS QoS NPN Module</title>
<authorgroup>
<author>
diff --git a/src/modules/ims_qos_npn/doc/ims_qos_npn_admin.xml b/src/modules/ims_qos_npn/doc/ims_qos_npn_admin.xml
index dfb6ea9ed15..70459b65801 100644
--- a/src/modules/ims_qos_npn/doc/ims_qos_npn_admin.xml
+++ b/src/modules/ims_qos_npn/doc/ims_qos_npn_admin.xml
@@ -16,7 +16,7 @@
charging control functions performed by an Application Function (e.g.
P-CSCF) over the Rx interface. This module is dependent on the CDP (C
Diameter Peer) modules for communicating with PCRF as specified in 3GPP
- specification TS 29.214.</para>
+ specification TS 29.214. It is an enhaced variant of ims_qos.</para>
</section>
<section>
@@ -548,7 +548,7 @@ modparam("ims_qos", "dialog_direction", 1)
If set to 1 it will trust the bottom Via as the UE IP/port/transport when doing client identification.
</para>
<para>
- Normally, the UE identification should be done on IPsec SPIs and source IP/port of the packets.
+ Normally, the UE identification should be done on IPsec SPIs and source IP/port of the packets.
In some cases the ims_* modules trust the top Via on requests and the bottom Via on responses. In some (better)
cases this trusts the received-from IP (or the alias in the Contact header).
</para>
@@ -707,7 +707,7 @@ modparam("ims_qos", "af_signaling_port_ps", "5063")
<para><emphasis>Note:</emphasis> this is executed asynchronously. See example on how to
retrieve return value</para>
- <para><emphasis>Note:</emphasis> this authorization session triggers
+ <para><emphasis>Note:</emphasis> this authorization session triggers
event_route[qos:asr_registration], event_route[qos:rar_access_network] and event_route[qos:terminate_dialog].</para>
<example>
@@ -785,7 +785,7 @@ route[REGISTER_AAR_REPLY]
<para><emphasis>Note:</emphasis> this is executed asynchronously. See example on how to
retrieve return value</para>
- <para><emphasis>Note:</emphasis> this authorization session triggers
+ <para><emphasis>Note:</emphasis> this authorization session triggers
event_route[qos:asr_call], event_route[qos:rar_access_network] and event_route[qos:terminate_dialog].</para>
Module: kamailio
Branch: master
Commit: dcdcee0d9f2326e079f905632af9db3b898330ab
URL: https://github.com/kamailio/kamailio/commit/dcdcee0d9f2326e079f905632af9db3…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2025-01-29T11:34:01+01:00
ims_qos_npn: small docs updates
---
Modified: src/modules/ims_qos_npn/doc/ims_qos_npn.xml
Modified: src/modules/ims_qos_npn/doc/ims_qos_npn_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/dcdcee0d9f2326e079f905632af9db3…
Patch: https://github.com/kamailio/kamailio/commit/dcdcee0d9f2326e079f905632af9db3…
---
diff --git a/src/modules/ims_qos_npn/doc/ims_qos_npn.xml b/src/modules/ims_qos_npn/doc/ims_qos_npn.xml
index 0cd99dcd0c7..fa9d03eb003 100644
--- a/src/modules/ims_qos_npn/doc/ims_qos_npn.xml
+++ b/src/modules/ims_qos_npn/doc/ims_qos_npn.xml
@@ -7,7 +7,7 @@
]>
<book>
<bookinfo>
- <title>The IMS QoS Module - Neat Path Networks "branch"</title>
+ <title>The IMS QoS NPN Module</title>
<authorgroup>
<author>
diff --git a/src/modules/ims_qos_npn/doc/ims_qos_npn_admin.xml b/src/modules/ims_qos_npn/doc/ims_qos_npn_admin.xml
index dfb6ea9ed15..70459b65801 100644
--- a/src/modules/ims_qos_npn/doc/ims_qos_npn_admin.xml
+++ b/src/modules/ims_qos_npn/doc/ims_qos_npn_admin.xml
@@ -16,7 +16,7 @@
charging control functions performed by an Application Function (e.g.
P-CSCF) over the Rx interface. This module is dependent on the CDP (C
Diameter Peer) modules for communicating with PCRF as specified in 3GPP
- specification TS 29.214.</para>
+ specification TS 29.214. It is an enhaced variant of ims_qos.</para>
</section>
<section>
@@ -548,7 +548,7 @@ modparam("ims_qos", "dialog_direction", 1)
If set to 1 it will trust the bottom Via as the UE IP/port/transport when doing client identification.
</para>
<para>
- Normally, the UE identification should be done on IPsec SPIs and source IP/port of the packets.
+ Normally, the UE identification should be done on IPsec SPIs and source IP/port of the packets.
In some cases the ims_* modules trust the top Via on requests and the bottom Via on responses. In some (better)
cases this trusts the received-from IP (or the alias in the Contact header).
</para>
@@ -707,7 +707,7 @@ modparam("ims_qos", "af_signaling_port_ps", "5063")
<para><emphasis>Note:</emphasis> this is executed asynchronously. See example on how to
retrieve return value</para>
- <para><emphasis>Note:</emphasis> this authorization session triggers
+ <para><emphasis>Note:</emphasis> this authorization session triggers
event_route[qos:asr_registration], event_route[qos:rar_access_network] and event_route[qos:terminate_dialog].</para>
<example>
@@ -785,7 +785,7 @@ route[REGISTER_AAR_REPLY]
<para><emphasis>Note:</emphasis> this is executed asynchronously. See example on how to
retrieve return value</para>
- <para><emphasis>Note:</emphasis> this authorization session triggers
+ <para><emphasis>Note:</emphasis> this authorization session triggers
event_route[qos:asr_call], event_route[qos:rar_access_network] and event_route[qos:terminate_dialog].</para>
Module: kamailio
Branch: 6.0
Commit: 1efa133244bbca0c9c35b76f936cce2b0a5864d3
URL: https://github.com/kamailio/kamailio/commit/1efa133244bbca0c9c35b76f936cce2…
Author: Xenofon Karamanos <xk(a)gilawa.com>
Committer: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com>
Date: 2025-01-29T10:28:40Z
cmake: Use pkg-config instead for json-c dev package.
(cherry picked from commit 8ebae54cff261b95fcece3be3719da511cc35084)
---
Modified: src/modules/nsq/CMakeLists.txt
---
Diff: https://github.com/kamailio/kamailio/commit/1efa133244bbca0c9c35b76f936cce2…
Patch: https://github.com/kamailio/kamailio/commit/1efa133244bbca0c9c35b76f936cce2…
---
diff --git a/src/modules/nsq/CMakeLists.txt b/src/modules/nsq/CMakeLists.txt
index b4a482c2a47..e6acfa9a2f7 100644
--- a/src/modules/nsq/CMakeLists.txt
+++ b/src/modules/nsq/CMakeLists.txt
@@ -4,13 +4,19 @@ add_library(${module_name} SHARED ${MODULE_SOURCES})
find_package(Libev REQUIRED)
-find_package(json-c QUIET)
-if(NOT json-c_FOUND)
- message(STATUS "json-c not found. looking with pkg-config")
- find_package(PkgConfig REQUIRED)
- pkg_check_modules(json-c REQUIRED IMPORTED_TARGET json-c)
- add_library(json-c::json-c ALIAS PkgConfig::json-c)
-endif()
+# TODO: When we have a proper cmake config file for json-c for most OS, we can
+# use that instead of pkg-config.
+# json-c v 0.14 and 0.15 have wrong include directories in their cmake config
+# files. uncomment the following line when we have a proper cmake config file
+# for json-c for most OS.
+# find_package(json-c 0.16 CONFIG)
+
+# if(NOT json-c_FOUND)
+# message(STATUS "json-c not found. looking with pkg-config")
+find_package(PkgConfig REQUIRED)
+pkg_check_modules(json-c REQUIRED IMPORTED_TARGET json-c)
+add_library(json-c::json-c ALIAS PkgConfig::json-c)
+# endif()
find_package(CURL REQUIRED)
Module: kamailio
Branch: 6.0
Commit: d0360fbb8e622c786f3d8791b67f06d1eb6e0ae4
URL: https://github.com/kamailio/kamailio/commit/d0360fbb8e622c786f3d8791b67f06d…
Author: Xenofon Karamanos <xk(a)gilawa.com>
Committer: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com>
Date: 2025-01-29T10:28:03Z
cmake/json: Remove find_package call. Use pkg-config instead.
(cherry picked from commit 99d36df0a15bbb960b2d7ee5916d65a55b9b26cd)
---
Modified: src/modules/json/CMakeLists.txt
---
Diff: https://github.com/kamailio/kamailio/commit/d0360fbb8e622c786f3d8791b67f06d…
Patch: https://github.com/kamailio/kamailio/commit/d0360fbb8e622c786f3d8791b67f06d…
---
diff --git a/src/modules/json/CMakeLists.txt b/src/modules/json/CMakeLists.txt
index 72df4d390f5..5d791dbd03d 100644
--- a/src/modules/json/CMakeLists.txt
+++ b/src/modules/json/CMakeLists.txt
@@ -2,13 +2,18 @@ file(GLOB MODULE_SOURCES "*.c")
add_library(${module_name} SHARED ${MODULE_SOURCES})
-find_package(json-c CONFIG)
-
-if(NOT json-c_FOUND)
- message(STATUS "json-c not found. looking with pkg-config")
- find_package(PkgConfig REQUIRED)
- pkg_check_modules(json-c REQUIRED IMPORTED_TARGET json-c)
- add_library(json-c::json-c ALIAS PkgConfig::json-c)
-endif()
+# TODO: When we have a proper cmake config file for json-c for most OS, we can
+# use that instead of pkg-config.
+# json-c v 0.14 and 0.15 have wrong include directories in their cmake config
+# files. uncomment the following line when we have a proper cmake config file
+# for json-c for most OS.
+# find_package(json-c 0.16 CONFIG)
+
+# if(NOT json-c_FOUND)
+message(STATUS "json-c not found. looking with pkg-config")
+find_package(PkgConfig REQUIRED)
+pkg_check_modules(json-c REQUIRED IMPORTED_TARGET json-c)
+add_library(json-c::json-c ALIAS PkgConfig::json-c)
+# endif()
target_link_libraries(${module_name} PRIVATE json-c::json-c)