sr-dev January 2025

sr-dev@lists.kamailio.org

21 participants
301 discussions

[kamailio/kamailio] Kamailio passive instance tries to send dialog keepalives after service restart (Issue #4077)
by akabihno 12 Feb '25

12 Feb '25

### Description Kamailio is running on 2 nodes using DMQ for HA. Following DMQ parameters are set: ``` modparam("dmq", "server_address", "sip:LOCAL_IP:DMQ_PORT") modparam("dmq", "notification_address", "sip:OTHER_NODE_IP:DMQ_PORT") modparam("dmq", "multi_notify", 0) modparam("dmq_usrloc", "enable", 1) modparam("dmq_usrloc", "sync", 1) modparam("dmq_usrloc", "replicate_socket_info", 1) modparam("dmq_usrloc", "batch_msg_contacts", 50) modparam("dmq_usrloc", "batch_size", 10000) modparam("dmq_usrloc", "batch_usleep", 500000) ``` If kamailio is restarted on passive instance, it tries to send keepalives for DMQ replicated dialog, producing errors ### Troubleshooting #### Reproduction - Have set dialog properties "ka-src", "ka-dst": ``` if (is_method("INVITE")) { setflag(FLT_ACC); #!ifdef WITH_DIALOG dlg_manage(); dlg_set_property("ka-src"); dlg_set_property("ka-dst"); #!endif } ``` - Have calls on active instance and DMQ replicated dialogs on passive instance ``` kamcmd dlg.list { h_entry: 936 h_id: 7534 ref: 2 call-id: inds188n38bjr7tsa2hb from_uri: sip:90123@10.1.2.3 to_uri: sip:0012345@10.1.2.3 state: 4 start_ts: 1734441148 init_ts: 1734441142 end_ts: 0 duration: 119 timeout: 1734484347 lifetime: 43200 dflags: 0 sflags: 0 iflags: 64 caller: { tag: c91qu93uc5 contact: sip:hp3405ho@iacvttr6b897.invalid;transport=ws;ob;alias=10.5.6.7~39402~6 cseq: 2 route_set: socket: <null string> } callee: { tag: 32fd1f16-2fd3-4924-9423-4267871f4ea8 contact: sip:10.2.3.4:5060 cseq: 0 route_set: socket: <null string> } profiles: { } variables: { } } ``` - Restart kamailio service on passive instance #### Debugging Data #### Log Messages ``` Dec 17 13:15:34 hostname.redacted.com docker[31099]: 45(53) WARNING: <core> [core/msg_translator.c:3024]: via_builder(): TCP/TLS connection (id: 0) for WebSocket could not be found Dec 17 13:15:34 hostname.redacted.com docker[31099]: 45(53) ERROR: tm [t_msgbuilder.c:1423]: assemble_via(): via building failed Dec 17 13:15:34 hostname.redacted.com docker[31099]: 45(53) ERROR: tm [t_msgbuilder.c:1614]: build_uac_req(): error while assembling Via Dec 17 13:15:34 hostname.redacted.com docker[31099]: 45(53) ERROR: tm [uac.c:552]: t_uac_prepare(): Error while building message Dec 17 13:15:34 hostname.redacted.com docker[31099]: 45(53) ERROR: dialog [dlg_req_within.c:810]: dlg_send_ka(): failed to send the OPTIONS request Dec 17 13:15:34 hostname.redacted.com docker[31099]: 45(53) ERROR: <core> [core/udp_server.c:810]: udp_send(): sendto(sock, buf: 0x7f3736a421b0, len: 329, 0, dst: (10.5.2.192:5060), tolen: 16) - err: Invalid argument (22) Dec 17 13:15:34 hostname.redacted.com docker[31099]: 45(53) CRITICAL: <core> [core/udp_server.c:817]: udp_send(): invalid sendtoparameters Dec 17 13:15:34 hostname.redacted.com docker[31099]: one possible reason is the server is bound to localhost and Dec 17 13:15:34 hostname.redacted.com docker[31099]: attempts to send to the net Dec 17 13:15:34 hostname.redacted.com docker[31099]: 45(53) ERROR: tm [../../core/forward.h:245]: msg_send_buffer(): udp_send failed Dec 17 13:15:34 hostname.redacted.com docker[31099]: 45(53) ERROR: tm [uac.c:708]: send_prepared_request_impl(): Attempt to send to precreated request failed Dec 17 13:15:34 hostname.redacted.com docker[31099]: 34(42) ERROR: <core> [core/udp_server.c:810]: udp_send(): sendto(sock, buf: 0x7f3736a42000, len: 329, 0, dst: (10.5.2.192:5060), tolen: 16) - err: Invalid argument (22) Dec 17 13:15:34 hostname.redacted.com docker[31099]: 34(42) CRITICAL: <core> [core/udp_server.c:817]: udp_send(): invalid sendtoparameters Dec 17 13:15:34 hostname.redacted.com docker[31099]: one possible reason is the server is bound to localhost and Dec 17 13:15:34 hostname.redacted.com docker[31099]: attempts to send to the net Dec 17 13:15:34 hostname.redacted.com docker[31099]: 34(42) ERROR: tm [../../core/forward.h:245]: msg_send_buffer(): udp_send failed ``` #### SIP Traffic ### Possible Solutions ### Additional Information ``` version: kamailio 5.8.4 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled on 13:38:04 Nov 12 2024 with gcc 13.2.1 ``` * **Operating System**: Running https://ghcr.io/kamailio/kamailio-ci:5.8.4-alpine in docker as systemd service ``` Host system: lsb_release -a No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 16.04.3 LTS Release: 16.04 Codename: xenial uname -a Linux _hostname redacted_ 4.4.0-1052-aws #61-Ubuntu SMP Mon Feb 12 23:05:58 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux docker -v Docker version 20.10.7, build f0df350 ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4077 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4077(a)github.com>

2 2

[kamailio/kamailio] xhttp_prom module with custom tags (Issue #4021)
by Christian Berger 11 Feb '25

11 Feb '25

### Description In Prometheus there is the possibility to tag values with tags. Those tags can then be used provide context to those values, for example to filter them. ### Expected behavior It would be great if there was a way to provide custom tags to the metrics. These would essentially just be a static string between the name of the metric and its value. Example: `system_load15{host="wurst23.dev.sipgate.net",hostname_short="wurst32"} 0.4` This could probably be achieved by having an `xhttp_prom_ending` parameter similar to the `xhttp_prom_beginning` as we essentially just want to append a static string right after the metric name. #### Actual observed behavior `kamailio_sip_lb_de_core_rcv_replies_1xx_invite 1773 1731419851663` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4021 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4021(a)github.com>

4 7

[kamailio/kamailio] app_python3: evaluate LIBS variable imediately in Makefile (PR #4085)
by sergey-safarov 08 Feb '25

08 Feb '25

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description latest `make` version does not evaluate variables immediately. PR explicitly evaluates the LIBS makefile variable. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4085 -- Commit Summary -- * app_python3: evaluate LIBS variable imediately in Makefile -- File Changes -- M src/modules/app_python3/Makefile (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4085.patch https://github.com/kamailio/kamailio/pull/4085.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4085 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4085(a)github.com>

5 96

[kamailio/kamailio] Module nghttp2 fails to compile with gcc 14 (Issue #4135)
by Ben Kaufman 05 Feb '25

05 Feb '25

### Description Compiling nghttp2 is failing for me in Alpine 3.21, which uses gcc 14 (14.2.0). It looks like the issue is that the header file `nghttp2.h` need to be explicitly included in the `nghttp2_mod.c` files. This is the error when running `make` inside of `src/modules/nghttp2` (after compiling kamailio as normal): ``` /home/builder/kamailio_src/src/modules/nghttp2 # make make: --libs: No such file or directory make: --libs: No such file or directory make: --libs: No such file or directory make: --libs: No such file or directory CC (gcc) [M nghttp2.so] nghttp2_mod.o nghttp2_mod.c: In function 'ksr_nghttp2_send_reply': nghttp2_mod.c:317:22: error: implicit declaration of function 'nghttp2_submit_response'; did you mean 'nghttp2_submit_response2'? [-Wimplicit-function-declaration] 317 | rv = nghttp2_submit_response(_ksr_nghttp2_ctx.session, | ^~~~~~~~~~~~~~~~~~~~~~~ | nghttp2_submit_response2 make: *** [../../Makefile.rules:100: nghttp2_mod.o] Error 1 ``` ### Troubleshooting Compilation works on Debian 12, so checked difference in `make` and `gcc` versions. Note that the `make: --libs: No such file or directory` appear to be from a different issue with `make` 4.4 not recursively expanding variables. From gcc's documentation it looks like implicit function declarations are no longer possible https://gcc.gnu.org/gcc-14/porting_to.html #### Reproduction Compile Kamailio 6.0.0 (with default config), then compile the nghttp2 module ### Possible Solutions Explicitly import `nghttp2.h` in `nghttp2_mod.c` and `nghttp2_server.c`. This is outside of my normal wheelhouse, but I was able to do this and successfully compile the module: ##### Diff for `nghttp2_mod.c`: ``` @@ -25,6 +25,7 @@ #include <stdlib.h> #include <string.h> #include <arpa/inet.h> +#include <nghttp2/nghttp2.h> #include "../../core/sr_module.h" #include "../../core/dprint.h" ``` ##### Diff for `nghttp2_server.c`: ``` @@ -23,6 +23,7 @@ * WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. */ +#include <nghttp2/nghttp2.h> #include "nghttp2_server.h" #define OUTPUT_WOULDBLOCK_THRESHOLD (1 << 16) ```  ### Additional Information Kamailio 6.0.0 with gcc 14.2.0 * **Operating System**:  ``` /home/builder/kamailio_src/src/modules/nghttp2 # lsb_release -a No LSB modules are available. Distributor ID: Alpine Description: Alpine Linux v3.21 Release: 3.21.2 Codename: n/a /home/builder/kamailio_src/src/modules/nghttp2 # uname -a Linux 89562285153f 5.15.167.4-microsoft-standard-WSL2 #1 SMP Tue Nov 5 00:21:55 UTC 2024 x86_64 Linux ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4135 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4135(a)github.com>

2 3

[kamailio/kamailio] nghttp2: compilation with gcc 14 (PR #4136)
by Ben Kaufman 05 Feb '25

05 Feb '25

- Explicitly include nghttp2.h file GH #4135   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #4135 #### Description  Explicitly include nghttp2.h file in `src/modules/nghttp2/nghttp2_mod.c` and `src/modules/nghttp2/nghttp2_server.c` You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4136 -- Commit Summary -- * nghttp2: compilation with gcc 14 -- File Changes -- M src/modules/nghttp2/nghttp2_mod.c (1) M src/modules/nghttp2/nghttp2_server.c (1) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4136.patch https://github.com/kamailio/kamailio/pull/4136.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4136 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4136(a)github.com>

2 2

[kamailio/kamailio] geoip: module relocated to archive (PR #3978)
by Victor Seva 05 Feb '25

05 Feb '25

related #3886 You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3978 -- Commit Summary -- * geoip: module relocated to archive -- File Changes -- M src/Makefile.groups (8) D src/modules/geoip/Makefile (9) D src/modules/geoip/README (166) D src/modules/geoip/doc/Makefile (4) D src/modules/geoip/doc/geoip.xml (42) D src/modules/geoip/doc/geoip_admin.xml (199) D src/modules/geoip/geoip_mod.c (157) D src/modules/geoip/geoip_pv.c (421) D src/modules/geoip/geoip_pv.h (40) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3978.patch https://github.com/kamailio/kamailio/pull/3978.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3978 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3978(a)github.com>

4 6

[kamailio/kamailio] APKBUILD missing modules (Issue #4131)
by Ben Kaufman 03 Feb '25

03 Feb '25

### Description The Alpine Linux APKBUILD file is a bit old and some of the modules added over the last few years are missing. I compile my own .apk files with an updated APKBUILD file which I can provide in a pull request. These modules are: - app_python3s - app_ruby_proc - call_obj - dlgs - ims_qos_npn - jwt - kafka - keepalive - kemix - lost - lrkproxy - math - mqtt - nghttp2 - posops - presence_dfks - pv_headers - pvtpl - secfilter - slack - ss7ops - sworker - topos_htable - xhttp_prom #### Reproduction The modules simply aren't listed in the APKBUILD file ### Possible Solutions Update APKBUILD file. ### Additional Information * **Operating System**: * Alpine Linux, 3.20, 3.21 -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4131 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4131(a)github.com>

2 3

git:master:833bb437: dialog: use internal function to get 4-byte time value
by Daniel-Constantin Mierla 31 Jan '25

31 Jan '25

Module: kamailio Branch: master Commit: 833bb437750ee3c9403f91eb13a607ceede0be5d URL: https://github.com/kamailio/kamailio/commit/833bb437750ee3c9403f91eb13a607c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-01-31T20:23:11+01:00 dialog: use internal function to get 4-byte time value --- Modified: src/modules/dialog/dlg_handlers.c --- Diff: https://github.com/kamailio/kamailio/commit/833bb437750ee3c9403f91eb13a607c… Patch: https://github.com/kamailio/kamailio/commit/833bb437750ee3c9403f91eb13a607c… --- diff --git a/src/modules/dialog/dlg_handlers.c b/src/modules/dialog/dlg_handlers.c index c05da0378fb..822175eb829 100644 --- a/src/modules/dialog/dlg_handlers.c +++ b/src/modules/dialog/dlg_handlers.c @@ -494,7 +494,7 @@ static void dlg_onreply(struct cell *t, int type, struct tmcb_params *param) next_state_dlg(dlg, event, &old_state, &new_state, &unref); if(new_state == DLG_STATE_DELETED && old_state != DLG_STATE_DELETED) { /* set end time */ - dlg->end_ts = (unsigned int)(time(0)); + dlg->end_ts = ksr_time_uint(NULL, NULL); } if(dlg_run_event_route( dlg, (rpl == FAKED_REPLY) ? NULL : rpl, old_state, new_state) @@ -540,7 +540,7 @@ static void dlg_onreply(struct cell *t, int type, struct tmcb_params *param) } /* set start time */ - dlg->start_ts = (unsigned int)(time(0)); + dlg->start_ts = ksr_time_uint(NULL, NULL); /* save the settings to the database, * if realtime saving mode configured- save dialog now @@ -1431,7 +1431,7 @@ void dlg_onroute(struct sip_msg *req, str *route_params, void *param) next_state_dlg(dlg, event, &old_state, &new_state, &unref); CURR_DLG_ID = req->id; - CURR_DLG_LIFETIME = (unsigned int)(time(0)) - dlg->start_ts; + CURR_DLG_LIFETIME = ksr_time_uint(NULL, NULL) - dlg->start_ts; CURR_DLG_STATUS = new_state; if(dlg_run_event_route(dlg, req, old_state, new_state) < 0) { @@ -1443,7 +1443,7 @@ void dlg_onroute(struct sip_msg *req, str *route_params, void *param) * to absorb in-air messages */ if(new_state == DLG_STATE_DELETED && old_state != DLG_STATE_DELETED) { /* set end time */ - dlg->end_ts = (unsigned int)(time(0)); + dlg->end_ts = ksr_time_uint(NULL, NULL); iuid = dlg_get_iuid_shm_clone(dlg); if(iuid != NULL) { if(d_tmb.register_tmcb(req, NULL, TMCB_DESTROY, unref_dlg_from_cb, @@ -1681,7 +1681,7 @@ void dlg_ontimeout(struct dlg_tl *tl) dlg->tag[DLG_CALLEE_LEG].s, old_state); /* set end time */ - dlg->end_ts = (unsigned int)(time(0)); + dlg->end_ts = ksr_time_uint(NULL, NULL); /* dialog timeout */ run_dlg_callbacks( @@ -1923,8 +1923,8 @@ int dlg_set_state(sip_msg_t *msg, int istate) /* updates for terminated dialogs */ if(ostate == DLG_STATE_CONFIRMED && istate == DLG_STATE_DELETED) { /* updating timestamps, flags, dialog stats */ - dlg->init_ts = (unsigned int)(time(0)); - dlg->end_ts = (unsigned int)(time(0)); + dlg->init_ts = ksr_time_uint(NULL, NULL); + dlg->end_ts = ksr_time_uint(NULL, NULL); } dlg->dflags |= DLG_FLAG_CHANGED; dlg_release(dlg);

1 0

git:master:5283bf62: core: ut.h - function to split time_t in lower and upper 4 bytes
by Daniel-Constantin Mierla 31 Jan '25

31 Jan '25

Module: kamailio Branch: master Commit: 5283bf6288a6b86bdc405883d6995f03cc373256 URL: https://github.com/kamailio/kamailio/commit/5283bf6288a6b86bdc405883d6995f0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-01-31T20:23:11+01:00 core: ut.h - function to split time_t in lower and upper 4 bytes - lower 4 bytes are returned, upper 4 bytes can be stored in output parameter - if pointer to time value is not give, time(0) is used --- Modified: src/core/ut.h --- Diff: https://github.com/kamailio/kamailio/commit/5283bf6288a6b86bdc405883d6995f0… Patch: https://github.com/kamailio/kamailio/commit/5283bf6288a6b86bdc405883d6995f0… --- diff --git a/src/core/ut.h b/src/core/ut.h index 31b45fe5b4d..29faca83fc2 100644 --- a/src/core/ut.h +++ b/src/core/ut.h @@ -1155,6 +1155,27 @@ static inline int strno2int(str *val, unsigned int *mask) } } +static inline unsigned int ksr_time_uint(time_t *tv, unsigned int *tu) +{ + unsigned int tl; /* lower 4 bytes */ + unsigned long long v64; + time_t t; + + if(tv != NULL) { + t = *tv; + } else { + t = time(NULL); + } + v64 = (unsigned long long)t; + tl = (unsigned int)(v64 & 0xFFFFFFFFULL); + if(tu != NULL) { + /* upper 4 bytes */ + *tu = (unsigned int)((v64 >> 32) & 0xFFFFFFFFULL); + } + + return tl; +} + /* converts a username into uid:gid, * returns -1 on error & 0 on success */ int user2uid(int *uid, int *gid, char *user);

1 0

git:master:478310c5: pv: small reworking of pointer conditions
by Daniel-Constantin Mierla 31 Jan '25

31 Jan '25

Module: kamailio Branch: master Commit: 478310c56f0eb060c5f31b2ee8febbb6204d37e7 URL: https://github.com/kamailio/kamailio/commit/478310c56f0eb060c5f31b2ee8febbb… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-01-31T20:23:11+01:00 pv: small reworking of pointer conditions --- Modified: src/modules/pv/pv_core.c --- Diff: https://github.com/kamailio/kamailio/commit/478310c56f0eb060c5f31b2ee8febbb… Patch: https://github.com/kamailio/kamailio/commit/478310c56f0eb060c5f31b2ee8febbb… --- diff --git a/src/modules/pv/pv_core.c b/src/modules/pv/pv_core.c index 3963ead97f9..38d46c01dba 100644 --- a/src/modules/pv/pv_core.c +++ b/src/modules/pv/pv_core.c @@ -3654,7 +3654,7 @@ int pv_set_xto_attr(struct sip_msg *msg, pv_param_t *param, int op, } buf.s = pkg_malloc(val->rs.len); - if(buf.s == 0) { + if(buf.s == NULL) { LM_ERR("no more pkg mem\n"); goto error; } @@ -3681,7 +3681,7 @@ int pv_set_xto_attr(struct sip_msg *msg, pv_param_t *param, int op, return -1; } buf.s = pkg_malloc(val->rs.len + 1); - if(buf.s == 0) { + if(buf.s == NULL) { LM_ERR("no more pkg mem\n"); goto error; } @@ -3708,7 +3708,7 @@ int pv_set_xto_attr(struct sip_msg *msg, pv_param_t *param, int op, return -1; } buf.s = pkg_malloc(val->rs.len); - if(buf.s == 0) { + if(buf.s == NULL) { PKG_MEM_ERROR; goto error; } @@ -3735,7 +3735,7 @@ int pv_set_xto_attr(struct sip_msg *msg, pv_param_t *param, int op, return -1; } buf.s = pkg_malloc(val->rs.len + 1); - if(buf.s == 0) { + if(buf.s == NULL) { LM_ERR("no more pkg mem\n"); goto error; } @@ -3790,7 +3790,7 @@ int pv_set_xto_attr(struct sip_msg *msg, pv_param_t *param, int op, goto error; } } else { - if(buf.s != 0) { + if(buf.s != NULL) { pkg_free(buf.s); buf.s = NULL; } @@ -3817,8 +3817,9 @@ int pv_set_xto_attr(struct sip_msg *msg, pv_param_t *param, int op, return 0; error: - if(buf.s != 0) + if(buf.s != NULL) { pkg_free(buf.s); + } return -1; }

1 0

← Newer
1
2
3
4
5
6
7
8
...
31
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev January 2025