sr-dev January 2025

sr-dev@lists.kamailio.org

8 participants
25 discussions

[kamailio/kamailio] auto_bind_ipv6 prevents listening also on ipv4 if system has no ipv6 (Issue #4098)

by Matteo

### Description When `auto_bind_ipv6` is enabled on a system without ipv6, kamailio starts, enumerates all interfaces but does not perform no listening at all. In addition, no errors are reported, see below from final part of boot log, no other infos are logged. While this can be worked around by putting that config value behind a definition and autodetection by an external script, should not it work and just start on ipv4 if ipv6 is not available? ### Troubleshooting #### Reproduction  Just start Kam as root, with no `listen` directives (to let it listen on all ipv4) and `auto_bind_ipv6` set to 1. #### Log Messages  ``` 0(1) DEBUG: <core> [core/socket_info.c:1764]: add_interfaces(): If: lo Fam: 2 Flg: 10049 Adr: 127.0.0.1 0(1) DEBUG: <core> [core/socket_info.c:1764]: add_interfaces(): If: enp81s0u1u4 Fam: 2 Flg: 11043 Adr: 192.168.1.222 0(1) DEBUG: <core> [core/socket_info.c:1764]: add_interfaces(): If: wlp0s20f3 Fam: 2 Flg: 11043 Adr: 192.168.1.196 0(1) DEBUG: <core> [core/socket_info.c:1764]: add_interfaces(): If: br-65b842ff8266 Fam: 2 Flg: 1003 Adr: 192.168.49.1 0(1) DEBUG: <core> [core/socket_info.c:1764]: add_interfaces(): If: br-kamnet Fam: 2 Flg: 11043 Adr: 172.23.42.1 0(1) DEBUG: <core> [core/socket_info.c:1764]: add_interfaces(): If: br-f1829eb65bac Fam: 2 Flg: 1003 Adr: 172.18.0.1 0(1) DEBUG: <core> [core/socket_info.c:1764]: add_interfaces(): If: br-f521fee918b4 Fam: 2 Flg: 1003 Adr: 172.19.0.1 0(1) DEBUG: <core> [core/socket_info.c:1764]: add_interfaces(): If: docker0 Fam: 2 Flg: 1003 Adr: 172.17.0.1 0(1) DEBUG: <core> [core/socket_info.c:1507]: build_iface_list(): received 728 byles 0(1) DEBUG: <core> [core/socket_info.c:1507]: build_iface_list(): received 20 byles 0(1) DEBUG: <core> [core/socket_info.c:1510]: build_iface_list(): done receiving netlink info 0(1) DEBUG: <core> [core/socket_info.c:1542]: build_iface_list(): trying network interface index: 1 (n: 0) 0(1) DEBUG: <core> [core/socket_info.c:1559]: build_iface_list(): iface <IFA_ADDRESS> address is '127.0.0.1' 0(1) DEBUG: <core> [core/socket_info.c:1569]: build_iface_list(): iface <IFA_LOCAL> address is '127.0.0.1' 0(1) DEBUG: <core> [core/socket_info.c:1573]: build_iface_list(): iface name is lo 0(1) DEBUG: <core> [core/socket_info.c:1542]: build_iface_list(): trying network interface index: 3 (n: 1) 0(1) DEBUG: <core> [core/socket_info.c:1559]: build_iface_list(): iface <IFA_ADDRESS> address is '192.168.1.222' 0(1) DEBUG: <core> [core/socket_info.c:1569]: build_iface_list(): iface <IFA_LOCAL> address is '192.168.1.222' 0(1) DEBUG: <core> [core/socket_info.c:1573]: build_iface_list(): iface name is enp81s0u1u4 0(1) DEBUG: <core> [core/socket_info.c:1542]: build_iface_list(): trying network interface index: 4 (n: 2) 0(1) DEBUG: <core> [core/socket_info.c:1559]: build_iface_list(): iface <IFA_ADDRESS> address is '192.168.1.196' 0(1) DEBUG: <core> [core/socket_info.c:1569]: build_iface_list(): iface <IFA_LOCAL> address is '192.168.1.196' 0(1) DEBUG: <core> [core/socket_info.c:1573]: build_iface_list(): iface name is wlp0s20f3 0(1) DEBUG: <core> [core/socket_info.c:1542]: build_iface_list(): trying network interface index: 5 (n: 3) 0(1) DEBUG: <core> [core/socket_info.c:1559]: build_iface_list(): iface <IFA_ADDRESS> address is '192.168.49.1' 0(1) DEBUG: <core> [core/socket_info.c:1569]: build_iface_list(): iface <IFA_LOCAL> address is '192.168.49.1' 0(1) DEBUG: <core> [core/socket_info.c:1573]: build_iface_list(): iface name is br-65b842ff8266 0(1) DEBUG: <core> [core/socket_info.c:1542]: build_iface_list(): trying network interface index: 6 (n: 4) 0(1) DEBUG: <core> [core/socket_info.c:1559]: build_iface_list(): iface <IFA_ADDRESS> address is '172.23.42.1' 0(1) DEBUG: <core> [core/socket_info.c:1569]: build_iface_list(): iface <IFA_LOCAL> address is '172.23.42.1' 0(1) DEBUG: <core> [core/socket_info.c:1573]: build_iface_list(): iface name is br-kamnet 0(1) DEBUG: <core> [core/socket_info.c:1542]: build_iface_list(): trying network interface index: 7 (n: 5) 0(1) DEBUG: <core> [core/socket_info.c:1559]: build_iface_list(): iface <IFA_ADDRESS> address is '172.18.0.1' 0(1) DEBUG: <core> [core/socket_info.c:1569]: build_iface_list(): iface <IFA_LOCAL> address is '172.18.0.1' 0(1) DEBUG: <core> [core/socket_info.c:1573]: build_iface_list(): iface name is br-f1829eb65bac 0(1) DEBUG: <core> [core/socket_info.c:1542]: build_iface_list(): trying network interface index: 8 (n: 6) 0(1) DEBUG: <core> [core/socket_info.c:1559]: build_iface_list(): iface <IFA_ADDRESS> address is '172.19.0.1' 0(1) DEBUG: <core> [core/socket_info.c:1569]: build_iface_list(): iface <IFA_LOCAL> address is '172.19.0.1' 0(1) DEBUG: <core> [core/socket_info.c:1573]: build_iface_list(): iface name is br-f521fee918b4 0(1) DEBUG: <core> [core/socket_info.c:1542]: build_iface_list(): trying network interface index: 9 (n: 7) 0(1) DEBUG: <core> [core/socket_info.c:1559]: build_iface_list(): iface <IFA_ADDRESS> address is '172.17.0.1' 0(1) DEBUG: <core> [core/socket_info.c:1569]: build_iface_list(): iface <IFA_LOCAL> address is '172.17.0.1' 0(1) DEBUG: <core> [core/socket_info.c:1573]: build_iface_list(): iface name is docker0 0(1) DEBUG: <core> [core/socket_info.c:1507]: build_iface_list(): received 1740 byles ``` ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` head of 5.8 branch as of today ``` * **Operating System**:  ``` ubuntu noble (in a docker container) ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4098 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4098(a)github.com>

0 minutes

[kamailio/kamailio] tcp_timer_check_connections() logs on CRITICAL and is not caught by event_route[tcp:timeout] (Issue #3995)

by Fritjof Höst

### Description Hi! We are in the progress of upgrading from Kamailio 5.5 to 5.8. During our testing we have noticed a new error being reported from Kamailio. We don’t see any other errors following it. ```jsx /usr/sbin/kamailio[201]: CRITICAL: <core> [core/tcp_main.c:5544]: tcp_timer_check_connections(): message processing timeout on connection id: 67896 (state: 3) - closing ``` It does seem to be [new code](https://github.com/kamailio/kamailio/blob/master/src/core/tcp_main.c#… in Kamailio reporting this issue. Given that this is a fairly expected thing, cleaning up a connection which receives no traffic within the given time, is there a need for it to be reported on CRITICAL? I’d also expect it to be caught by ``` event_route[tcp:timeout] { xlog("L_INFO","connection $conid timeouts (unanswered keepalives)"); } ``` given that [the description](https://www.kamailio.org/docs/modules/stable/modules/tcpops.ht… of this one is `Called for connection timeouts (unanswered keepalives).`. ### Troubleshooting We don't have any way to reproduce it, we are still investigating it to figure out the cause. It happens around every 2 hours, so we think there might some some scheduled test or job running in our test system causing this. ### Additional Information * **Kamailio Version** - 5.8.3 * **Operating System**: Debian 12 AMI from the AWS Marketplace. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3995 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3995(a)github.com>

2 hours, 55 minutes

[kamailio/kamailio] examples: fix kamailio ims cfg file for basic volte call (PR #4090)

by Supreeth Herle

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4090 -- Commit Summary -- * examples: fix kamailio ims cfg file for basic volte call -- File Changes -- M misc/examples/ims/icscf/icscf.cfg.sample (12) M misc/examples/ims/icscf/icscf.xml.sample (6) M misc/examples/ims/icscf/kamailio.cfg (32) M misc/examples/ims/pcscf/kamailio.cfg (182) M misc/examples/ims/pcscf/pcscf.cfg.sample (55) M misc/examples/ims/pcscf/pcscf.xml.sample (6) M misc/examples/ims/pcscf/route/mo.cfg (99) M misc/examples/ims/pcscf/route/mt.cfg (101) M misc/examples/ims/pcscf/route/register.cfg (198) M misc/examples/ims/pcscf/route/rtp.cfg (90) M misc/examples/ims/scscf/kamailio.cfg (115) M misc/examples/ims/scscf/scscf.cfg.sample (24) M misc/examples/ims/scscf/scscf.xml.sample (6) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4090.patch https://github.com/kamailio/kamailio/pull/4090.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4090 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4090(a)github.com>

16 hours, 2 minutes

[kamailio/kamailio] In function ksr_tm_event_response_sent(evname), header and body modifications are not applied (Issue #3997)

by JuanPascual2

Hello In the function ksr_tm_event_response_sent(evname), header and body modifications are not applied. **Example of modification:** KSR.textops.set_body("application/test", "teststbody") KSR.textops.remove_hf("Contact") KSR.hdr.append("X-My-Hdr: testhdrappend \r\n") In the Kamailio logs, we can see that the changes have been processed, but the response sent does not contain the changes. BR Juan **Configuration kamailio.cfg** modparam("tm", "event_callback_lres_sent", "ksr_tm_event_response_sent") **Configuration kamailio.lua** ----------------------- --Function ksr_tm_event_response_sent bug ----------------------- function ksr_tm_event_response_sent(evname) log.debug("\27[36m --> Sending reply: $rs $rr \27[0m") log.debug("\27[35m Reply sent ",evname,"\27[0m") KSR.textops.set_body("application/test", "teststbody") KSR.textops.remove_hf("Contact") KSR.hdr.append("X-My-Hdr: testhdrappend \r\n") end **Traces debug KAMAILIO** 4(260) DEBUG: app_lua [app_lua_api.c:1023]: sr_kemi_lua_exec_func_ex(): param[0] for: xinfo is str: 2024-10-10 10-18-10 [debug] /opt/kamailio/kamailio.lua:96: --> Sending reply: $rs $rr 4(260) DEBUG: <core> [core/pvapi.c:502]: pv_spec_lookup(): PV <$rs> is not in cache 4(260) DEBUG: <core> [core/pvapi.c:386]: pv_cache_add(): pvar [$rs] added in cache 4(260) DEBUG: <core> [core/pvapi.c:502]: pv_spec_lookup(): PV <$rr> is not in cache 4(260) DEBUG: <core> [core/pvapi.c:386]: pv_cache_add(): pvar [$rr] added in cache 4(260) INFO: <script>: 2024-10-10 10-18-10 [debug] /opt/kamailio/kamailio.lua:96: --> Sending reply: 200 OK 4(260) DEBUG: app_lua [app_lua_api.c:1023]: sr_kemi_lua_exec_func_ex(): param[0] for: xinfo is str: 2024-10-10 10-18-10 [debug] /opt/kamailio/kamailio.lua:97: Reply sent tm:local-response-sent 4(260) INFO: <script>: 2024-10-10 10-18-10 [debug] /opt/kamailio/kamailio.lua:97: Reply sent tm:local-response-sent 4(260) DEBUG: app_lua [app_lua_api.c:1023]: sr_kemi_lua_exec_func_ex(): param[0] for: set_body is str: application/test 4(260) DEBUG: app_lua [app_lua_api.c:1023]: sr_kemi_lua_exec_func_ex(): param[1] for: set_body is str: teststbody 4(260) DEBUG: <core> [core/parser/parse_hname2.c:315]: parse_sip_header_name(): parsed header name [To] type 3 4(260) DEBUG: <core> [core/parser/parse_addr_spec.c:185]: parse_to_param(): add param: tag=bb3c24ed793eec883784ff522b4e48d0 4(260) DEBUG: <core> [core/parser/parse_addr_spec.c:904]: parse_addr_spec(): end of header reached, state=29 4(260) DEBUG: <core> [core/parser/msg_parser.c:172]: get_hdr_field(): <To> [61]; uri=[sip:1234@sip.osp.com] 4(260) DEBUG: <core> [core/parser/msg_parser.c:174]: get_hdr_field(): to body (22)[<sip:1234@sip.osp.com>], to tag (32)[bb3c24ed793eec883784ff522b4e48d0] 4(260) DEBUG: <core> [core/parser/parse_hname2.c:315]: parse_sip_header_name(): parsed header name [From] type 4 4(260) DEBUG: <core> [core/parser/parse_hname2.c:315]: parse_sip_header_name(): parsed header name [CSeq] type 5 4(260) DEBUG: <core> [core/parser/msg_parser.c:152]: get_hdr_field(): cseq <CSeq>: <63723> <REGISTER> 4(260) DEBUG: <core> [core/parser/parse_hname2.c:315]: parse_sip_header_name(): parsed header name [Call-ID] type 6 4(260) DEBUG: <core> [core/parser/parse_hname2.c:315]: parse_sip_header_name(): parsed header name [Content-Type] type 11 4(260) DEBUG: <core> [core/parser/parse_hname2.c:315]: parse_sip_header_name(): parsed header name [Contact] type 7 4(260) DEBUG: <core> [core/parser/parse_hname2.c:315]: parse_sip_header_name(): parsed header name [Content-Length] type 12 4(260) DEBUG: <core> [core/parser/msg_parser.c:187]: get_hdr_field(): content_length=6 4(260) DEBUG: <core> [core/parser/msg_parser.c:91]: get_hdr_field(): found end of header 4(260) DEBUG: textops [textops.c:2597]: ki_set_body(): new body: [application/test] 4(260) DEBUG: app_lua [app_lua_api.c:1023]: sr_kemi_lua_exec_func_ex(): param[0] for: remove_hf is str: Contact 4(260) DEBUG: <core> [core/parser/parse_hname2.c:315]: parse_sip_header_name(): parsed header name [Contact] type 7 4(260) DEBUG: <core> [core/kemi.c:2350]: sr_kemi_hdr_remove(): remove hf: Contact 4(260) DEBUG: app_lua [app_lua_api.c:1023]: sr_kemi_lua_exec_func_ex(): param[0] for: append is str: X-My-Hdr: testhdrappend 4(260) DEBUG: <core> [core/kemi.c:2224]: sr_kemi_hdr_append(): append hf: X-My-Hdr: testhdrappend 4(260) DEBUG: app_lua [app_lua_mod.c:166]: sr_kemi_config_engine_lua(): execution of route type 513 with name [ksr_tm_event_response_sent] returned 1 4(260) DEBUG: tm [t_reply.c:634]: _reply_light(): reply sent out - buf=0x786b611bb9e0: SIP/2.0 200 OK Via:... shmem=0x786b58ceea80: SIP/2.0 200 OK Via: 4(260) DEBUG: tm [t_funcs.c:133]: put_on_wait(): put T [0x786b58ceb770] on wait 4(260) DEBUG: tm [t_reply.c:650]: _reply_light(): finished 4(260) DEBUG: jsonrpcs [jsonrpcs_mod.c:443]: jsonrpc_send_mode(): sending response with body: (nil) - 200 OK 4(260) DEBUG: app_lua [app_lua_api.c:1023]: sr_kemi_lua_exec_func_ex(): param[0] for: xinfo is str: 2024-10-10 10-18-10 [debug] /opt/kamailio/kamailio.lua:36: ksr_request_route: 23.11 ms 4(260) INFO: <script>: 2024-10-10 10-18-10 [debug] /opt/kamailio/kamailio.lua:36: ksr_request_route: 23.11 ms 4(260) DEBUG: app_lua [app_lua_mod.c:169]: sr_kemi_config_engine_lua(): execution of route type 1 with no name returned 1 4(260) DEBUG: <core> [core/receive.c:531]: receive_msg(): request-route executed in: 23343 usec 4(260) DEBUG: <core> [core/usr_avp.c:654]: destroy_avp_list(): destroying list (nil) 4(260) DEBUG: <core> [core/usr_avp.c:654]: destroy_avp_list(): destroying list (nil) 4(260) DEBUG: <core> [core/usr_avp.c:654]: destroy_avp_list(): destroying list (nil) 4(260) DEBUG: <core> [core/usr_avp.c:654]: destroy_avp_list(): destroying list (nil) 4(260) DEBUG: <core> [core/usr_avp.c:654]: destroy_avp_list(): destroying list (nil) 4(260) DEBUG: <core> [core/usr_avp.c:654]: destroy_avp_list(): destroying list (nil) 4(260) DEBUG: <core> [core/xavp.c:630]: xavp_destroy_list(): destroying xavp list (nil) 4(260) DEBUG: <core> [core/xavp.c:630]: xavp_destroy_list(): destroying xavp list (nil) 4(260) DEBUG: <core> [core/xavp.c:630]: xavp_destroy_list(): destroying xavp list (nil) 4(260) DEBUG: <core> [core/receive.c:635]: receive_msg(): cleaning up 18(274) DEBUG: tm [timer.c:642]: wait_handler(): finished transaction: 0x786b58ce81a0 (p:0x786b58baa3c0/n:0x786b58baa3c0) 18(274) DEBUG: tm [h_table.c:133]: free_cell_helper(): freeing transaction 0x786b58ce81a0 from timer.c:651 18(274) DEBUG: tm [timer.c:642]: wait_handler(): finished transaction: 0x786b58ceb770 (p:0x786b58b729c0/n:0x786b58b729c0) 18(274) DEBUG: tm [h_table.c:133]: free_cell_helper(): freeing transaction 0x786b58ceb770 from timer.c:651 -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3997 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3997(a)github.com>

16 hours, 5 minutes

[kamailio/kamailio] rtpengine: bug fix, add comments and clean the codes (PR #4097)

by Farzaneh Soltanzadeh

#### Pre-Submission Checklist    - [ * ] Commit message has the format required by CONTRIBUTING guide - [ * ] Commits are split per component (core, individual modules, libs, utils, ...) - [ * ] Each component has a single commit (if not, squash them into one commit) - [ * ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ * ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Detailed comments for functions related to subscription are added. Bug fixed. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4097 -- Commit Summary -- * bug fix, add comments and clean codes -- File Changes -- M src/modules/rtpengine/rtpengine.c (219) M src/modules/rtpengine/rtpengine.h (26) D src/modules/rtpengine/rtpengine_common.h (28) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4097.patch https://github.com/kamailio/kamailio/pull/4097.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4097 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4097(a)github.com>

20 hours, 13 minutes

[kamailio/kamailio] t_uac_send() Adding Extra Via Header (Issue #4096)

by Fateme Pardakhti

I am trying to send a SIP CANCEL message using the t_uac_send() function from the tm module to cancel an INVITE message that was sent previously. `$var(requestHeaders) = "Via: " + $var(via) +"\r\n" "To: sip:1010@172.16.100.76:6060;tag="+$var(tt)+"\r\n" "From: sip:rvrbt@172.16.100.76:6060;tag="+$var(ft)+"\r\n" "Call-ID: " + $ci + "\r\n" "CSeq: 1 CANCEL\r\n" "Max-Forwards: 62\r\n"; t_uac_send("CANCEL", "sip:1010@172.16.100.76:6060", "", "", "$var(requestHeaders)", "");` I am encountering an issue where an additional Via header with a newly generated branch parameter is being added to the top of the headers. This behavior causes the CANCEL request to not be recognized as part of the existing transaction and I get "SIP/2.0 481 Call/Transaction Does Not Exist" Logs and Debugging Information: Include relevant logs here, such as the generated CANCEL request and the 481 response. [cancleWithExtraViaHeader.zip](https://github.com/user-attachments/files/183… -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4096 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4096(a)github.com>

21 hours, 38 minutes

git:master:fbed7b5b: modules: readme files regenerated - outbound ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: fbed7b5b6ef30842ee65d76bb2fca11b3246368d URL: https://github.com/kamailio/kamailio/commit/fbed7b5b6ef30842ee65d76bb2fca11… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-01-06T13:31:10+01:00 modules: readme files regenerated - outbound ... [skip ci] --- Modified: src/modules/outbound/README --- Diff: https://github.com/kamailio/kamailio/commit/fbed7b5b6ef30842ee65d76bb2fca11… Patch: https://github.com/kamailio/kamailio/commit/fbed7b5b6ef30842ee65d76bb2fca11… --- diff --git a/src/modules/outbound/README b/src/modules/outbound/README index 8e65a606dc6..d452dfc991a 100644 --- a/src/modules/outbound/README +++ b/src/modules/outbound/README @@ -256,7 +256,7 @@ onreply_route { } failure_route[FAIL_OUTBOUND] { - if (t_branch_timeout() || !t_branch_replied()) { + if (t_branch_timeout() && !t_branch_replied()) { send_reply("430", "Flow Failed"); } }

22 hours, 33 minutes

[kamailio/kamailio] htable: Fix de-/increment w/ auto expire (PR #4079)

by Bastian Triller

Update item expiration value during de-/incrementation for htables that are configured with autoexpire and updateexpire disabled. Otherwise an item cannot be used until timer cleaned it up.   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description Using following configuration ``` #!KAMAILIO listen=udp:127.0.0.1:9999 log_stderror=yes loadmodule "xlog.so" loadmodule "pv.so" loadmodule "sl.so" loadmodule "htable.so" modparam("htable", "htable", "foo=>autoexpire=1;updateexpire=0") request_route { if ($sht(foo=>bar) == $null) { $sht(foo=>bar) = 0; } $var(foo) = $shtdec(foo=>bar); xlog("$Ts single value $sht(foo=>bar)\texpire $shtex(foo=>bar)\n"); sl_send_reply("200", "Hello"); } ``` running ``` while true; do sleep 0.3; sipsak -vs sip:localhost:9999 ; done ``` produces following output ``` 0(1414153) ERROR: <script>: 1734539304 single value -1 expire 1 0(1414153) ERROR: <script>: 1734539305 single value -2 expire 0 0(1414153) ERROR: <script>: 1734539305 single value -3 expire 0 0(1414153) ERROR: <script>: 1734539305 single value -4 expire 0 0(1414153) ERROR: <script>: 1734539306 single value <null> expire 4294967295 0(1414153) ERROR: <script>: 1734539306 single value <null> expire 4294967295 0(1414153) ERROR: <script>: 1734539306 single value <null> expire 4294967295 0(1414153) ERROR: <script>: 1734539306 single value <null> expire 4294967295 0(1414153) ERROR: <script>: 1734539307 single value <null> expire 4294967294 0(1414153) ERROR: <script>: 1734539307 single value <null> expire 4294967294 0(1414153) ERROR: <script>: 1734539307 single value <null> expire 4294967294 0(1414153) ERROR: <script>: 1734539308 single value <null> expire 4294967293 0(1414153) ERROR: <script>: 1734539308 single value <null> expire 4294967293 0(1414153) ERROR: <script>: 1734539308 single value <null> expire 4294967293 0(1414153) ERROR: <script>: 1734539309 single value <null> expire 4294967292 0(1414153) ERROR: <script>: 1734539309 single value <null> expire 4294967292 0(1414153) ERROR: <script>: 1734539309 single value <null> expire 4294967292 0(1414153) ERROR: <script>: 1734539310 single value <null> expire 4294967291 0(1414153) ERROR: <script>: 1734539310 single value <null> expire 4294967291 0(1414153) ERROR: <script>: 1734539310 single value <null> expire 4294967291 0(1414153) ERROR: <script>: 1734539311 single value <null> expire 4294967290 0(1414153) ERROR: <script>: 1734539311 single value <null> expire 4294967290 0(1414153) ERROR: <script>: 1734539311 single value <null> expire 4294967290 0(1414153) ERROR: <script>: 1734539312 single value <null> expire 4294967289 0(1414153) ERROR: <script>: 1734539312 single value <null> expire 4294967289 0(1414153) ERROR: <script>: 1734539312 single value <null> expire 4294967289 0(1414153) ERROR: <script>: 1734539313 single value <null> expire 4294967288 0(1414153) ERROR: <script>: 1734539313 single value <null> expire 4294967288 0(1414153) ERROR: <script>: 1734539313 single value <null> expire 4294967288 0(1414153) ERROR: <script>: 1734539314 single value <null> expire 4294967287 0(1414153) ERROR: <script>: 1734539314 single value <null> expire 4294967287 0(1414153) ERROR: <script>: 1734539314 single value <null> expire 4294967287 0(1414153) ERROR: <script>: 1734539315 single value <null> expire 4294967286 0(1414153) ERROR: <script>: 1734539315 single value <null> expire 4294967286 0(1414153) ERROR: <script>: 1734539315 single value <null> expire 4294967286 0(1414153) ERROR: <script>: 1734539316 single value <null> expire 4294967285 0(1414153) ERROR: <script>: 1734539316 single value <null> expire 4294967285 0(1414153) ERROR: <script>: 1734539316 single value <null> expire 4294967285 0(1414153) ERROR: <script>: 1734539316 single value <null> expire 4294967285 0(1414153) ERROR: <script>: 1734539317 single value <null> expire 4294967284 0(1414153) ERROR: <script>: 1734539317 single value <null> expire 4294967284 0(1414153) ERROR: <script>: 1734539317 single value <null> expire 4294967284 0(1414153) ERROR: <script>: 1734539318 single value <null> expire 4294967283 0(1414153) ERROR: <script>: 1734539318 single value <null> expire 4294967283 0(1414153) ERROR: <script>: 1734539318 single value <null> expire 4294967283 0(1414153) ERROR: <script>: 1734539319 single value <null> expire 4294967282 0(1414153) ERROR: <script>: 1734539319 single value <null> expire 4294967282 0(1414153) ERROR: <script>: 1734539319 single value <null> expire 4294967282 0(1414153) ERROR: <script>: 1734539320 single value <null> expire 4294967281 0(1414153) ERROR: <script>: 1734539320 single value <null> expire 4294967281 0(1414153) ERROR: <script>: 1734539320 single value <null> expire 4294967281 0(1414153) ERROR: <script>: 1734539321 single value <null> expire 4294967280 0(1414153) ERROR: <script>: 1734539321 single value <null> expire 4294967280 0(1414153) ERROR: <script>: 1734539321 single value <null> expire 4294967280 0(1414153) ERROR: <script>: 1734539322 single value <null> expire 4294967279 0(1414153) ERROR: <script>: 1734539322 single value <null> expire 4294967279 0(1414153) ERROR: <script>: 1734539322 single value <null> expire 4294967279 0(1414153) ERROR: <script>: 1734539323 single value <null> expire 4294967278 0(1414153) ERROR: <script>: 1734539323 single value <null> expire 4294967278 0(1414153) ERROR: <script>: 1734539323 single value <null> expire 4294967278 0(1414153) ERROR: <script>: 1734539324 single value <null> expire 4294967277 0(1414153) ERROR: <script>: 1734539324 single value <null> expire 4294967277 0(1414153) ERROR: <script>: 1734539324 single value -1 expire 1 0(1414153) ERROR: <script>: 1734539325 single value -2 expire 0 0(1414153) ERROR: <script>: 1734539325 single value -3 expire 0 0(1414153) ERROR: <script>: 1734539325 single value -4 expire 0 ``` When adding `initval=0` to `htable` configuration log output changes `<null>` to `0` You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4079 -- Commit Summary -- * htable: Fix de-/increment w/ auto expire -- File Changes -- M src/modules/htable/ht_api.c (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4079.patch https://github.com/kamailio/kamailio/pull/4079.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4079 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4079(a)github.com>

22 hours, 45 minutes

git:master:b8062321: htable: Fix de-/increment w/ auto expire

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: b8062321572e1523bb9478fd2421c5a8bc8314af URL: https://github.com/kamailio/kamailio/commit/b8062321572e1523bb9478fd2421c5a… Author: Bastian Triller <bastian.triller(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-01-06T13:18:45+01:00 htable: Fix de-/increment w/ auto expire Update item expiration value during de-/incrementation for htables that are configured with autoexpire and updateexpire disabled. Otherwise an item cannot be used until timer cleaned it up. --- Modified: src/modules/htable/ht_api.c --- Diff: https://github.com/kamailio/kamailio/commit/b8062321572e1523bb9478fd2421c5a… Patch: https://github.com/kamailio/kamailio/commit/b8062321572e1523bb9478fd2421c5a… --- diff --git a/src/modules/htable/ht_api.c b/src/modules/htable/ht_api.c index 559ee9784d2..9190dd310ff 100644 --- a/src/modules/htable/ht_api.c +++ b/src/modules/htable/ht_api.c @@ -743,6 +743,10 @@ ht_cell_t *ht_cell_value_add(ht_t *ht, str *name, int val, ht_cell_t *old) if(now > 0 && it->expire != 0 && it->expire < now) { /* entry has expired */ + it->expire = ht->htexpire; + if(it->expire) { + it->expire += now; + } if(ht->flags == PV_VAL_INT) { /* initval is integer, use it to create a fresh entry */ it->flags &= ~AVP_VAL_STR;

22 hours, 45 minutes

[kamailio/kamailio] outbound/doc: Fix logic error (PR #4087)

by Xenofon Karamanos

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  This PR fixes a logic error where "flow failed" could also be triggered, when the call was ringing and has not been answered... (according to https://www.kamailio.org/docs/modules/stable/modules/tm.html#tm.f.t_branch_… ) You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4087 -- Commit Summary -- * outbound/doc: Fix logic error -- File Changes -- M src/modules/outbound/doc/outbound_admin.xml (3) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4087.patch https://github.com/kamailio/kamailio/pull/4087.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4087 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4087(a)github.com>

22 hours, 47 minutes

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev January 2025