sr-dev January 2025

sr-dev@lists.kamailio.org

21 participants
301 discussions

git:master:9daea6c0: ims_qos_npn/doc/Makefile: proper xml file name
by Daniel-Constantin Mierla 28 Jan '25

28 Jan '25

Module: kamailio Branch: master Commit: 9daea6c00dc5b613d9e4b7ffd711ee7999e31ad5 URL: https://github.com/kamailio/kamailio/commit/9daea6c00dc5b613d9e4b7ffd711ee7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-01-28T17:58:46+01:00 ims_qos_npn/doc/Makefile: proper xml file name --- Modified: src/modules/ims_qos_npn/doc/Makefile --- Diff: https://github.com/kamailio/kamailio/commit/9daea6c00dc5b613d9e4b7ffd711ee7… Patch: https://github.com/kamailio/kamailio/commit/9daea6c00dc5b613d9e4b7ffd711ee7… --- diff --git a/src/modules/ims_qos_npn/doc/Makefile b/src/modules/ims_qos_npn/doc/Makefile index 4ab9c620042..6517aef6b72 100644 --- a/src/modules/ims_qos_npn/doc/Makefile +++ b/src/modules/ims_qos_npn/doc/Makefile @@ -1,4 +1,4 @@ -docs = ims_qos.xml +docs = ims_qos_npn.xml docbook_dir = ../../../../doc/docbook include $(docbook_dir)/Makefile.module

1 0

[kamailio/kamailio] ERROR: Creating extra tables failed at ims_icscf! (Issue #4124)
by Luke Escudé 28 Jan '25

28 Jan '25

### Description Installing Kamailio 5.8.5 on Debian 12, running kamdbctl create kamailio continually fails with error "ERROR: Creating extra tables failed at ims_icscf!" ### Troubleshooting #### Reproduction Create a brand new VM with Debian 12, clone Kamailio from git tag 5.8.5, and follow the steps: make include_modules="db_mysql crypto http_async_client http_client jansson janssonrpcc json jsonrpcc lcr presence presence_dialoginfo presence_mwi presence_reginfo presence_xml tls utils uuid xmlops" cfg make all make install # Installs Kamailio in /usr/local/sbin make install-systemd-debian sed -i 's/^# DBENGINE/DBENGINE/' /usr/local/etc/kamailio/kamctlrc kamdbctl create kamailio Will result in the error occurring. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4124 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4124(a)github.com>

2 2

git:5.8:1b4aa300: kamctl: renegenerate db creation files
by Daniel-Constantin Mierla 28 Jan '25

28 Jan '25

Module: kamailio Branch: 5.8 Commit: 1b4aa300292dd6bdd64e174111939293fbbd76ed URL: https://github.com/kamailio/kamailio/commit/1b4aa300292dd6bdd64e17411193929… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-01-28T17:47:11+01:00 kamctl: renegenerate db creation files - GH #4124 --- Added: utils/kamctl/db_berkeley/kamailio/nds_trusted_domains Added: utils/kamctl/db_berkeley/kamailio/s_cscf Added: utils/kamctl/db_berkeley/kamailio/s_cscf_capabilities Added: utils/kamctl/db_redis/kamailio/nds_trusted_domains Added: utils/kamctl/db_redis/kamailio/s_cscf Added: utils/kamctl/db_redis/kamailio/s_cscf_capabilities Added: utils/kamctl/db_sqlite/ims_icscf-create.sql Added: utils/kamctl/dbtext/kamailio/nds_trusted_domains Added: utils/kamctl/dbtext/kamailio/s_cscf Added: utils/kamctl/dbtext/kamailio/s_cscf_capabilities Added: utils/kamctl/mongodb/kamailio/nds_trusted_domains.json Added: utils/kamctl/mongodb/kamailio/s_cscf.json Added: utils/kamctl/mongodb/kamailio/s_cscf_capabilities.json Added: utils/kamctl/mysql/ims_icscf-create.sql Added: utils/kamctl/oracle/ims_icscf-create.sql Added: utils/kamctl/postgres/ims_icscf-create.sql Added: utils/kamctl/xhttp_pi/ims_icscf-mod Added: utils/kamctl/xhttp_pi/ims_icscf-table Modified: utils/kamctl/xhttp_pi/acc-mod Modified: utils/kamctl/xhttp_pi/alias_db-mod Modified: utils/kamctl/xhttp_pi/auth_db-mod Modified: utils/kamctl/xhttp_pi/avpops-mod Modified: utils/kamctl/xhttp_pi/carrierroute-mod Modified: utils/kamctl/xhttp_pi/cpl-mod Modified: utils/kamctl/xhttp_pi/dialog-mod Modified: utils/kamctl/xhttp_pi/dialplan-mod Modified: utils/kamctl/xhttp_pi/dispatcher-mod Modified: utils/kamctl/xhttp_pi/domain-mod Modified: utils/kamctl/xhttp_pi/domainpolicy-mod Modified: utils/kamctl/xhttp_pi/drouting-mod Modified: utils/kamctl/xhttp_pi/group-mod Modified: utils/kamctl/xhttp_pi/htable-mod Modified: utils/kamctl/xhttp_pi/imc-mod Modified: utils/kamctl/xhttp_pi/lcr-mod Modified: utils/kamctl/xhttp_pi/matrix-mod Modified: utils/kamctl/xhttp_pi/mohqueue-mod Modified: utils/kamctl/xhttp_pi/msilo-mod Modified: utils/kamctl/xhttp_pi/mtree-mod Modified: utils/kamctl/xhttp_pi/pdt-mod Modified: utils/kamctl/xhttp_pi/permissions-mod Modified: utils/kamctl/xhttp_pi/pi_framework.xml Modified: utils/kamctl/xhttp_pi/pipelimit-mod Modified: utils/kamctl/xhttp_pi/presence-mod Modified: utils/kamctl/xhttp_pi/purple-mod Modified: utils/kamctl/xhttp_pi/registrar-mod Modified: utils/kamctl/xhttp_pi/rls-mod Modified: utils/kamctl/xhttp_pi/rtpengine-mod Modified: utils/kamctl/xhttp_pi/rtpproxy-mod Modified: utils/kamctl/xhttp_pi/sca-mod Modified: utils/kamctl/xhttp_pi/secfilter-mod Modified: utils/kamctl/xhttp_pi/siptrace-mod Modified: utils/kamctl/xhttp_pi/speeddial-mod Modified: utils/kamctl/xhttp_pi/standard-mod Modified: utils/kamctl/xhttp_pi/topos-mod Modified: utils/kamctl/xhttp_pi/uac-mod Modified: utils/kamctl/xhttp_pi/uid_auth_db-mod Modified: utils/kamctl/xhttp_pi/uid_avp_db-mod Modified: utils/kamctl/xhttp_pi/uid_domain-mod Modified: utils/kamctl/xhttp_pi/uid_gflags-mod Modified: utils/kamctl/xhttp_pi/uid_uri_db-mod Modified: utils/kamctl/xhttp_pi/uri_db-mod Modified: utils/kamctl/xhttp_pi/userblocklist-mod Modified: utils/kamctl/xhttp_pi/usrloc-mod --- Diff: https://github.com/kamailio/kamailio/commit/1b4aa300292dd6bdd64e17411193929… Patch: https://github.com/kamailio/kamailio/commit/1b4aa300292dd6bdd64e17411193929…

1 0

git:6.0:be2c68f8: outbound: Fix flow_token_secret bug
by Henning Westerholt 28 Jan '25

28 Jan '25

Module: kamailio Branch: 6.0 Commit: be2c68f86fcf84dac24501a6b24a6573917894aa URL: https://github.com/kamailio/kamailio/commit/be2c68f86fcf84dac24501a6b24a657… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-01-28T16:33:55Z outbound: Fix flow_token_secret bug - flow_token_secret is of type str and not char* - check the length of the string instead of memory for initialization (cherry picked from commit 046ba41e431fec7fad0c82a9091ea9e27d9f677d) --- Modified: src/modules/outbound/outbound_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/be2c68f86fcf84dac24501a6b24a657… Patch: https://github.com/kamailio/kamailio/commit/be2c68f86fcf84dac24501a6b24a657… --- diff --git a/src/modules/outbound/outbound_mod.c b/src/modules/outbound/outbound_mod.c index f3c80f18c15..f2e0c7dbc3d 100644 --- a/src/modules/outbound/outbound_mod.c +++ b/src/modules/outbound/outbound_mod.c @@ -66,7 +66,7 @@ static cmd_export_t cmds[] = { static param_export_t params[] = { {"force_outbound_flag", PARAM_INT, &ob_force_flag}, {"force_no_outbound_flag", PARAM_INT, &ob_force_no_flag}, - {"flow_token_secret", PARAM_STRING, &flow_token_secret}, + {"flow_token_secret", PARAM_STR, &flow_token_secret}, {0, 0, 0} }; @@ -86,7 +86,7 @@ struct module_exports exports = { static void mod_init_openssl(void) { - if(flow_token_secret.s) { + if(flow_token_secret.s && flow_token_secret.len > 0) { assert(ob_key.len == SHA_DIGEST_LENGTH); LM_DBG("flow_token_secret mod param set. use persistent ob_key"); #if OPENSSL_VERSION_NUMBER < 0x030000000L

1 0

git:master:360bccbc: kamctl: regenerated db creation files
by Daniel-Constantin Mierla 28 Jan '25

28 Jan '25

Module: kamailio Branch: master Commit: 360bccbca1fe7515384065651034374be303bab3 URL: https://github.com/kamailio/kamailio/commit/360bccbca1fe7515384065651034374… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-01-28T17:28:19+01:00 kamctl: regenerated db creation files --- Added: utils/kamctl/db_berkeley/kamailio/pcscf_location Added: utils/kamctl/db_redis/kamailio/pcscf_location Added: utils/kamctl/dbtext/kamailio/pcscf_location Added: utils/kamctl/mongodb/kamailio/pcscf_location.json Modified: utils/kamctl/db_sqlite/ims_usrloc_pcscf-create.sql Modified: utils/kamctl/mysql/ims_usrloc_pcscf-create.sql Modified: utils/kamctl/oracle/ims_usrloc_pcscf-create.sql Modified: utils/kamctl/postgres/ims_usrloc_pcscf-create.sql Modified: utils/kamctl/xhttp_pi/ims_usrloc_pcscf-mod Modified: utils/kamctl/xhttp_pi/ims_usrloc_pcscf-table Modified: utils/kamctl/xhttp_pi/pi_framework.xml --- Diff: https://github.com/kamailio/kamailio/commit/360bccbca1fe7515384065651034374… Patch: https://github.com/kamailio/kamailio/commit/360bccbca1fe7515384065651034374…

1 0

git:master:fc02c3ca: srdb1/schema/location_pcscf.xml: table location renamed to pcscf_location
by Daniel-Constantin Mierla 28 Jan '25

28 Jan '25

Module: kamailio Branch: master Commit: fc02c3ca46bd96e50cbb6903a2efe48cb134377b URL: https://github.com/kamailio/kamailio/commit/fc02c3ca46bd96e50cbb6903a2efe48… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-01-28T17:28:19+01:00 srdb1/schema/location_pcscf.xml: table location renamed to pcscf_location - fix conflict with default table for registrar/usrloc - GH #4124 --- Modified: src/lib/srdb1/schema/location_pcscf.xml --- Diff: https://github.com/kamailio/kamailio/commit/fc02c3ca46bd96e50cbb6903a2efe48… Patch: https://github.com/kamailio/kamailio/commit/fc02c3ca46bd96e50cbb6903a2efe48… --- diff --git a/src/lib/srdb1/schema/location_pcscf.xml b/src/lib/srdb1/schema/location_pcscf.xml index a85f07bf75b..8538bf72ed6 100644 --- a/src/lib/srdb1/schema/location_pcscf.xml +++ b/src/lib/srdb1/schema/location_pcscf.xml @@ -7,8 +7,8 @@ ]> -<table id="location" xmlns:db="http://docbook.org/ns/docbook"> - <name>location</name> +<table id="pcscf_location" xmlns:db="http://docbook.org/ns/docbook"> + <name>pcscf_location</name> <version>7</version> <type db="mysql">&MYSQL_TABLE_TYPE;</type> <description>

1 0

[kamailio/kamailio] cmake: should we use >= 3.13, i.e., "more modern cmake" generation? (Issue #4078)
by space88man 28 Jan '25

28 Jan '25

### Description From the cmake timeline 3.0(2014) is called "modern cmake" and ~3.12/3.13(2018) is "more modern cmake" : https://www.youtube.com/watch?v=y7ndUhdQuU8 Since we are doing a major renovation on the kamailio build system should we target the "more modern" generation (that is already > 5 years old). This will encourage the project to follow cmake best practices. Ping @xkaraman @miconda Versions in debian: buster(3.13) bullseye(3.25) bookworm/trixie(3.30) -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4078 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4078(a)github.com>

8 25

[kamailio/kamailio] outbound: Fix flow_token_secret bug (PR #4125)
by Xenofon Karamanos 28 Jan '25

28 Jan '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  This PR fixes a bug where when `flow_token_secret` was provided, it was not initialized properly and always set to an empty string. - flow_token_secret is of type str and not char* - check the length of the string instead of memory for initialization You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4125 -- Commit Summary -- * outbound: Fix flow_token_secret bug -- File Changes -- M src/modules/outbound/outbound_mod.c (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4125.patch https://github.com/kamailio/kamailio/pull/4125.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4125 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4125(a)github.com>

3 4

git:master:046ba41e: outbound: Fix flow_token_secret bug
by Henning Westerholt 28 Jan '25

28 Jan '25

Module: kamailio Branch: master Commit: 046ba41e431fec7fad0c82a9091ea9e27d9f677d URL: https://github.com/kamailio/kamailio/commit/046ba41e431fec7fad0c82a9091ea9e… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2025-01-28T17:11:49+01:00 outbound: Fix flow_token_secret bug - flow_token_secret is of type str and not char* - check the length of the string instead of memory for initialization --- Modified: src/modules/outbound/outbound_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/046ba41e431fec7fad0c82a9091ea9e… Patch: https://github.com/kamailio/kamailio/commit/046ba41e431fec7fad0c82a9091ea9e… --- diff --git a/src/modules/outbound/outbound_mod.c b/src/modules/outbound/outbound_mod.c index f3c80f18c15..f2e0c7dbc3d 100644 --- a/src/modules/outbound/outbound_mod.c +++ b/src/modules/outbound/outbound_mod.c @@ -66,7 +66,7 @@ static cmd_export_t cmds[] = { static param_export_t params[] = { {"force_outbound_flag", PARAM_INT, &ob_force_flag}, {"force_no_outbound_flag", PARAM_INT, &ob_force_no_flag}, - {"flow_token_secret", PARAM_STRING, &flow_token_secret}, + {"flow_token_secret", PARAM_STR, &flow_token_secret}, {0, 0, 0} }; @@ -86,7 +86,7 @@ struct module_exports exports = { static void mod_init_openssl(void) { - if(flow_token_secret.s) { + if(flow_token_secret.s && flow_token_secret.len > 0) { assert(ob_key.len == SHA_DIGEST_LENGTH); LM_DBG("flow_token_secret mod param set. use persistent ob_key"); #if OPENSSL_VERSION_NUMBER < 0x030000000L

1 0

git:master:99d36df0: cmake/json: Remove find_package call. Use pkg-config instead.
by Xenofon Karamanos 28 Jan '25

28 Jan '25

Module: kamailio Branch: master Commit: 99d36df0a15bbb960b2d7ee5916d65a55b9b26cd URL: https://github.com/kamailio/kamailio/commit/99d36df0a15bbb960b2d7ee5916d65a… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xk(a)gilawa.com> Date: 2025-01-28T14:05:25Z cmake/json: Remove find_package call. Use pkg-config instead. --- Modified: src/modules/json/CMakeLists.txt --- Diff: https://github.com/kamailio/kamailio/commit/99d36df0a15bbb960b2d7ee5916d65a… Patch: https://github.com/kamailio/kamailio/commit/99d36df0a15bbb960b2d7ee5916d65a… --- diff --git a/src/modules/json/CMakeLists.txt b/src/modules/json/CMakeLists.txt index 72df4d390f5..5d791dbd03d 100644 --- a/src/modules/json/CMakeLists.txt +++ b/src/modules/json/CMakeLists.txt @@ -2,13 +2,18 @@ file(GLOB MODULE_SOURCES "*.c") add_library(${module_name} SHARED ${MODULE_SOURCES}) -find_package(json-c CONFIG) - -if(NOT json-c_FOUND) - message(STATUS "json-c not found. looking with pkg-config") - find_package(PkgConfig REQUIRED) - pkg_check_modules(json-c REQUIRED IMPORTED_TARGET json-c) - add_library(json-c::json-c ALIAS PkgConfig::json-c) -endif() +# TODO: When we have a proper cmake config file for json-c for most OS, we can +# use that instead of pkg-config. +# json-c v 0.14 and 0.15 have wrong include directories in their cmake config +# files. uncomment the following line when we have a proper cmake config file +# for json-c for most OS. +# find_package(json-c 0.16 CONFIG) + +# if(NOT json-c_FOUND) +message(STATUS "json-c not found. looking with pkg-config") +find_package(PkgConfig REQUIRED) +pkg_check_modules(json-c REQUIRED IMPORTED_TARGET json-c) +add_library(json-c::json-c ALIAS PkgConfig::json-c) +# endif() target_link_libraries(${module_name} PRIVATE json-c::json-c)

1 0

← Newer
1
...
11
12
13
14
15
16
17
...
31
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev January 2025