sr-dev January 2025

sr-dev@lists.kamailio.org

19 participants
184 discussions

Start a nNew thread

[kamailio/kamailio] lib/srdb1/schema: ims_charging definitions (PR #4111)

by Victor Seva

2 weeks, 6 days

[kamailio/kamailio] cmake: Add Windows support (Issue #4109)

by soroshsabz

ITNOA I suggest port Kamailio to windows, if you agree with me, I can try to port that -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4109 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4109(a)github.com>

2 weeks, 6 days

[kamailio/kamailio] Fix Makefile.defs and influxdbc for build on FreeBSD (PR #4099)

by Boris Korzun

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Not related to issues #### Description `Makefile.defs` is incorrect (`man_dir` should contain `share`) and `influxdbc` is not built (`sockaddr_in` is undefined) on FreeBSD environment. The proposed patch fixes it and makes the module is consistent with the rest of modules. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4099 -- Commit Summary -- * Makefile.defs: support for FreeBSD build * influxdbc: support for FreeBSD build -- File Changes -- M src/Makefile.defs (2) M src/modules/influxdbc/ic.c (1) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4099.patch https://github.com/kamailio/kamailio/pull/4099.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4099 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4099(a)github.com>

2 weeks, 6 days

[kamailio/kamailio] ims_dialog: missing srdb1 schema definition (Issue #4100)

by Victor Seva

there's no ``kamailio-ims_dialog.xml`` at ``src/lib/srdb1/schema`` but there's a manual file created at ``utils/kamctl/mysql/ims_dialog-create.sql`` Same thing for: - ``utils/kamctl/mysql/ims_charging-create.sql`` - ``utils/kamctl/mysql/ims_usrloc_pcscf-create.sql`` - ``utils/kamctl/mysql/ims_usrloc_scscf-create.sql`` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4100 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4100(a)github.com>

2 weeks, 6 days

[kamailio/kamailio] lib/srdb1/schema: ims_dialog definitions (PR #4101)

by Victor Seva

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [x] Related to issue #4100 #### Description db_schema for ims_dialog module You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4101 -- Commit Summary -- * lib/srdb1/schema: ims_dialog definitions * utils/kamctl: regenerate db table definitions -- File Changes -- A src/lib/srdb1/schema/dialog_in.xml (180) A src/lib/srdb1/schema/dialog_out.xml (116) A src/lib/srdb1/schema/kamailio-ims_dialog.xml (14) A utils/kamctl/db_berkeley/kamailio/dialog_in (10) A utils/kamctl/db_berkeley/kamailio/dialog_out (10) M utils/kamctl/db_berkeley/kamailio/version (6) A utils/kamctl/db_redis/kamailio/dialog_in (2) A utils/kamctl/db_redis/kamailio/dialog_out (2) A utils/kamctl/db_sqlite/ims_dialog-create.sql (55) A utils/kamctl/dbtext/kamailio/dialog_in (1) A utils/kamctl/dbtext/kamailio/dialog_out (1) M utils/kamctl/dbtext/kamailio/version (4) A utils/kamctl/mongodb/kamailio/dialog_in.json (101) A utils/kamctl/mongodb/kamailio/dialog_out.json (61) M utils/kamctl/mongodb/kamailio/version-create.mongo (2) M utils/kamctl/mysql/ims_dialog-create.sql (87) A utils/kamctl/oracle/ims_dialog-create.sql (79) A utils/kamctl/postgres/ims_dialog-create.sql (55) A utils/kamctl/xhttp_pi/ims_dialog-mod (192) A utils/kamctl/xhttp_pi/ims_dialog-table (50) M utils/kamctl/xhttp_pi/pi_framework.xml (242) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4101.patch https://github.com/kamailio/kamailio/pull/4101.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4101 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4101(a)github.com>

2 weeks, 6 days

git:master:c8290b8f: utils/kamctl: regenerate db table definitions

by Victor Seva

Module: kamailio Branch: master Commit: c8290b8f4ca35f88265073301de4c38e40516206 URL: https://github.com/kamailio/kamailio/commit/c8290b8f4ca35f88265073301de4c38… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-01-15T17:28:12+01:00 utils/kamctl: regenerate db table definitions --- Added: utils/kamctl/db_berkeley/kamailio/dialog_in Added: utils/kamctl/db_berkeley/kamailio/dialog_out Added: utils/kamctl/db_redis/kamailio/dialog_in Added: utils/kamctl/db_redis/kamailio/dialog_out Added: utils/kamctl/db_sqlite/ims_dialog-create.sql Added: utils/kamctl/dbtext/kamailio/dialog_in Added: utils/kamctl/dbtext/kamailio/dialog_out Added: utils/kamctl/mongodb/kamailio/dialog_in.json Added: utils/kamctl/mongodb/kamailio/dialog_out.json Added: utils/kamctl/oracle/ims_dialog-create.sql Added: utils/kamctl/postgres/ims_dialog-create.sql Added: utils/kamctl/xhttp_pi/ims_dialog-mod Added: utils/kamctl/xhttp_pi/ims_dialog-table Modified: utils/kamctl/db_berkeley/kamailio/version Modified: utils/kamctl/dbtext/kamailio/version Modified: utils/kamctl/mongodb/kamailio/version-create.mongo Modified: utils/kamctl/mysql/ims_dialog-create.sql Modified: utils/kamctl/xhttp_pi/pi_framework.xml --- Diff: https://github.com/kamailio/kamailio/commit/c8290b8f4ca35f88265073301de4c38… Patch: https://github.com/kamailio/kamailio/commit/c8290b8f4ca35f88265073301de4c38…

2 weeks, 6 days

git:master:ef6df942: lib/srdb1/schema: ims_dialog definitions

by Victor Seva

Module: kamailio Branch: master Commit: ef6df94258c7ebe542feca9af241de41ca048785 URL: https://github.com/kamailio/kamailio/commit/ef6df94258c7ebe542feca9af241de4… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-01-15T17:28:12+01:00 lib/srdb1/schema: ims_dialog definitions fixes #4100 --- Added: src/lib/srdb1/schema/dialog_in.xml Added: src/lib/srdb1/schema/dialog_out.xml Added: src/lib/srdb1/schema/kamailio-ims_dialog.xml --- Diff: https://github.com/kamailio/kamailio/commit/ef6df94258c7ebe542feca9af241de4… Patch: https://github.com/kamailio/kamailio/commit/ef6df94258c7ebe542feca9af241de4…

2 weeks, 6 days

[kamailio/kamailio] outbound: encode bind address into flow token as destination (PR #4105)

by Alexander Bakker

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [x] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description This is an attempt to fix the combination of the outbound/rr modules and ``tcp_accept_haproxy=yes``. This combination is currently broken, as previously reported on the mailing list: https://www.mail-archive.com/sr-users@lists.kamailio.org/msg21854.html The issue is that the destination address/port combo of the haproxy side is encoded into the flow token. When the rr module decodes the flow token and tries to look up the listening socket using ``find_si``, it cannot be found, because it is given the destination address/port combo of the connection of the haproxy side, not the address/port combo that Kamailio is actually listening on. This patch fixes the issue by encoding the ``bind_address`` of the socket the connection was received on into the flow token as the destination address. The source address remains unchanged, as it *can* be used to look up the TCP connection (with a minor patch to ``_tcpconn_find`` in ``tcp_main.c``) While I've done quite a bit of testing with this patchset, I find it difficult to oversee the full impact of this change in Kamailio's large codebase. Any feedback is welcome. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4105 -- Commit Summary -- * outbound: encode bind address into flow token as destination * core: tcp_main - include local dst port in conn lookup when using haproxy -- File Changes -- M src/core/tcp_main.c (3) M src/modules/outbound/outbound_mod.c (20) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4105.patch https://github.com/kamailio/kamailio/pull/4105.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4105 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4105(a)github.com>

3 weeks

[kamailio/kamailio] secfilter‌: support remove rule in Whitelist and Blacklist (PR #4089)

by AsedMorteza

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description ##### **Summary** This update introduces new functionality to the `secfilter` module, enabling the removal of entries from both the Blacklist and Whitelist. It also includes automatic detection and removal of duplicate values from these lists. ##### **Details** * Users can now remove specific entries from the Blacklist or Whitelist based on type (e.g., IP, domain, user) and a given value. * Supports removal of single or multiple matching entries in one operation. ##### **Benefits** - Improves the usability and flexibility of the `secfilter` module by allowing fine-grained control over list management. - Ensures that the Blacklist and Whitelist are kept clean and free from redundant entries. - Enhances performance by reducing unnecessary duplication in the lists. ##### Testing This feature was tested using `kmcmd` commands in various scenarios: - Removing the **first element** in the list. - Removing an element from the **middle** of the list. - Removing the **last element** in the list. - Removing **all matching elements** in the list. In all cases, the commands worked correctly, and the lists were updated and cleaned as expected. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4089 -- Commit Summary -- * secfilter‌: support remove rule in Whitelist and Blacklist -- File Changes -- M src/modules/secfilter/secfilter.c (8) M src/modules/secfilter/secfilter.h (3) M src/modules/secfilter/secfilter_db.c (106) M src/modules/secfilter/secfilter_rpc.c (95) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4089.patch https://github.com/kamailio/kamailio/pull/4089.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4089 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4089(a)github.com>

3 weeks

[kamailio/kamailio] Handling Duplicate Values in secfilter Module's kamcmd Commands (Issue #4091)

by AsedMorteza

**Description** The `secfilter` module in `kamcmd` currently allows duplicate entries when adding values to certain lists (e.g., blacklists, whitelists). This can lead to unexpected behavior and potential inconsistencies. Could you clarify the reason behind accepting duplicate values? Recently, I submitted a pull request to add delete commands to the `secfilter` module #4089. When a user, for example, executes: `kamcmd secfilter.del_bl user 1005` I iterate through the entire list to ensure all occurrences of `1005` are removed, as I realized duplicates might exist. This is inefficient and could be avoided by preventing duplicates in the first place. **Proposed Solutions** 1. **Prevent Duplicates in Existing `add` Commands:** * I can modify existing `add` commands to directly prevent the addition of duplicate values. This would simplify future operations and improve performance. 2. **Introduce New `add_unique` Commands:** * I can maintain the current `add` commands for backward compatibility. * I can introduce new `add_unique` commands (e.g., `secfilter.add_bl_unique`) that explicitly reject duplicate entries. **Recommendation** I recommend implementing the first solution (preventing duplicates in existing `add` commands) as it provides the most straightforward and efficient approach. **Further Considerations** * Consider adding a check for duplicates during the `add` operation and returning an appropriate error message if a duplicate is encountered. * Document the behavior of duplicate values in the `secfilter` module's documentation. **I would appreciate your feedback and guidance on the best course of action.** -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4091 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4091(a)github.com>

3 weeks

← Newer
1
...
8
9
10
11
12
13
14
...
19
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev January 2025