sr-dev September 2024

sr-dev@lists.kamailio.org

15 participants
170 discussions

[kamailio/kamailio] Build for el9 without legacy geoip (PR #3886)
by Oded Arbel 07 Oct '24

07 Oct '24

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #3592 #### Description The `kamailio-geoip` RPM sub package currently builds both the `geoip` module - based on [the old and out of support MaxMind GeoIP library](https://github.com/maxmind/geoip-api-c) - and the newer `geoip2` module - based on [the currently supported `libmaxminddb`](https://github.com/maxmind/libmaxminddb). The old GeoIP C library had its end of support date at May 2022 but for a while was still shipped for many distributions. At this point though, the EPEL repository that shipped the GeoIP library for RHEL-based operating systems, has removed it from their repositories for "Enterprise Linux 9": ![Screenshot_20240620_144233](https://github.com/kamailio/kamailio/assets/381782/bb1f2481-57f7-48af-b0f1-0ba1c14a3042) Therefor builds using the bundled spec file fail on EL9 installations. The suggested change is to add an RPM build option `--with geoip2` that when specified will build just the `geoip2` module for the `kamailio-geoip` RPM subpackage. This build option is not enabled by default, unless the build is running on a RHEL 9 based OS - in which case it is set as the default, because otherwise trivial builds break. To revert to the older behavior in RHEL 9 based OSs (and assuming you have the required unsupported library installed correctly) one will need to set both `--without geoip2 --with geoip`. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3886 -- Commit Summary -- * packaging: RPM build option to build just the geoip2 module * packaging: make 'with geoip2' the default behavior for EL9 -- File Changes -- M pkg/kamailio/obs/kamailio.spec (36) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3886.patch https://github.com/kamailio/kamailio/pull/3886.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3886 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3886(a)github.com>

6 22

[kamailio/kamailio] IMS DB: Adding i-cscf database/tables under utils/kamctl/mysql (orig. from misc/examples/ims/icscf.sql) (PR #3876)
by markusmonka 03 Oct '24

03 Oct '24

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Adding sqlfile ims i-cscf to utils/kamctl/mysql copied from misc/examples/ims/icscf so that sql file will be automatically included in kamailio-mysql-module packages in the future You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3876 -- Commit Summary -- * IMS DB: Adding i-cscf database/tables under utils/kamctl/mysql -- File Changes -- A utils/kamctl/mysql/ims-icscf.sql (94) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3876.patch https://github.com/kamailio/kamailio/pull/3876.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3876 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3876(a)github.com>

4 8

[kamailio/kamailio] dialog: Remove dlg_flag docs (PR #3975)
by Bastian Triller 02 Oct '24

02 Oct '24

Related to #3961   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3975 -- Commit Summary -- * dialog: Remove dlg_flag docs -- File Changes -- M src/modules/dialog/dlg_handlers.c (2) M src/modules/dialog/doc/dialog_admin.xml (16) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3975.patch https://github.com/kamailio/kamailio/pull/3975.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3975 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3975(a)github.com>

2 4

git:master:7acfe772: core: socket info - do not use interface index as internal array index
by Daniel-Constantin Mierla 30 Sep '24

30 Sep '24

Module: kamailio Branch: master Commit: 7acfe7723b4772ca45ce31ae98bf3d0b6948f50a URL: https://github.com/kamailio/kamailio/commit/7acfe7723b4772ca45ce31ae98bf3d0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-09-30T15:43:42+02:00 core: socket info - do not use interface index as internal array index - there are cases when the interface number is high, even if there are only a few real network interfaces, which can result in inability to listen on them --- Modified: src/core/socket_info.c --- Diff: https://github.com/kamailio/kamailio/commit/7acfe7723b4772ca45ce31ae98bf3d0… Patch: https://github.com/kamailio/kamailio/commit/7acfe7723b4772ca45ce31ae98bf3d0… --- diff --git a/src/core/socket_info.c b/src/core/socket_info.c index c8782bc0b3f..4142ab17dce 100644 --- a/src/core/socket_info.c +++ b/src/core/socket_info.c @@ -1494,6 +1494,7 @@ static int build_iface_list(void) char name[MAX_IF_LEN]; int is_link_local = 0; int num = 0; + int ifidx = 0; if(ifaces == NULL) { if((ifaces = (struct idxlist *)pkg_malloc( @@ -1621,31 +1622,42 @@ static int build_iface_list(void) } } - if(index >= MAX_IFACE_NO) { - LM_ERR("Invalid interface index returned: %d (n: %d) - skip\n", - index, num); - pkg_free(entry); - continue; + for(ifidx = 0; ifidx < MAX_IFACE_NO; ifidx++) { + if(ifaces[ifidx].index == index) { + /* interface with same index already found */ + break; + } + } + if(ifidx == MAX_IFACE_NO) { + if(num == MAX_IFACE_NO) { + LM_ERR("too many interfaces: %d (n: %d) - skipping\n", + index, num); + pkg_free(entry); + goto done; + } + ifidx = num; + num++; } - num++; - if(strlen(ifaces[index].name) == 0 && strlen(name) > 0) { - memcpy(ifaces[index].name, name, MAX_IF_LEN - 1); - ifaces[index].name[MAX_IF_LEN - 1] = '\0'; + if(strlen(ifaces[ifidx].name) == 0 && strlen(name) > 0) { + memcpy(ifaces[ifidx].name, name, MAX_IF_LEN - 1); + ifaces[ifidx].name[MAX_IF_LEN - 1] = '\0'; } - ifaces[index].index = index; + ifaces[ifidx].index = index; - if(ifaces[index].addresses == 0) - ifaces[index].addresses = entry; + if(ifaces[ifidx].addresses == 0) + ifaces[ifidx].addresses = entry; else { - for(tmp = ifaces[index].addresses; tmp->next; + for(tmp = ifaces[ifidx].addresses; tmp->next; tmp = tmp->next) /*empty*/ ; tmp->next = entry; } } } + +done: if(nl_sock > 0) close(nl_sock); /* the socket should be closed so we can bind again */

1 0

git:master:566eec1f: pkg/kamailio/deb: version set 6.0.0~dev3 [skip ci]
by Victor Seva 30 Sep '24

30 Sep '24

Module: kamailio Branch: master Commit: 566eec1f6a035479619f6970c5386d501d5fce23 URL: https://github.com/kamailio/kamailio/commit/566eec1f6a035479619f6970c5386d5… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-09-30T13:59:43+02:00 pkg/kamailio/deb: version set 6.0.0~dev3 [skip ci] --- Modified: pkg/kamailio/deb/bionic/changelog Modified: pkg/kamailio/deb/bookworm/changelog Modified: pkg/kamailio/deb/bullseye/changelog Modified: pkg/kamailio/deb/buster/changelog Modified: pkg/kamailio/deb/debian/changelog Modified: pkg/kamailio/deb/focal/changelog Modified: pkg/kamailio/deb/jammy/changelog Modified: pkg/kamailio/deb/jessie/changelog Modified: pkg/kamailio/deb/noble/changelog Modified: pkg/kamailio/deb/precise/changelog Modified: pkg/kamailio/deb/sid/changelog Modified: pkg/kamailio/deb/stretch/changelog Modified: pkg/kamailio/deb/trusty/changelog Modified: pkg/kamailio/deb/wheezy/changelog Modified: pkg/kamailio/deb/xenial/changelog --- Diff: https://github.com/kamailio/kamailio/commit/566eec1f6a035479619f6970c5386d5… Patch: https://github.com/kamailio/kamailio/commit/566eec1f6a035479619f6970c5386d5…

1 0

git:master:b7dcbc37: core: socket info - relocate check for index to get more debugging details
by Daniel-Constantin Mierla 30 Sep '24

30 Sep '24

Module: kamailio Branch: master Commit: b7dcbc37aceaefecf9a0f7367526a331d42269ea URL: https://github.com/kamailio/kamailio/commit/b7dcbc37aceaefecf9a0f7367526a33… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-09-30T12:55:23+02:00 core: socket info - relocate check for index to get more debugging details --- Modified: src/core/socket_info.c --- Diff: https://github.com/kamailio/kamailio/commit/b7dcbc37aceaefecf9a0f7367526a33… Patch: https://github.com/kamailio/kamailio/commit/b7dcbc37aceaefecf9a0f7367526a33… --- diff --git a/src/core/socket_info.c b/src/core/socket_info.c index 281defecffc..c8782bc0b3f 100644 --- a/src/core/socket_info.c +++ b/src/core/socket_info.c @@ -1555,12 +1555,6 @@ static int build_iface_list(void) rtl = IFA_PAYLOAD(nlp); index = ifi->ifa_index; - num++; - if(index >= MAX_IFACE_NO) { - LM_ERR("Invalid interface index returned: %d (n: %d) - skip\n", - index, num); - continue; - } entry = (struct idx *)pkg_malloc(sizeof(struct idx)); if(entry == 0) { @@ -1627,6 +1621,14 @@ static int build_iface_list(void) } } + if(index >= MAX_IFACE_NO) { + LM_ERR("Invalid interface index returned: %d (n: %d) - skip\n", + index, num); + pkg_free(entry); + continue; + } + num++; + if(strlen(ifaces[index].name) == 0 && strlen(name) > 0) { memcpy(ifaces[index].name, name, MAX_IF_LEN - 1); ifaces[index].name[MAX_IF_LEN - 1] = '\0';

1 0

[kamailio/kamailio] The tm.cancel function does not generate a “tm:local-request” event. (Issue #3831)
by JuanPascual2 30 Sep '24

30 Sep '24

Hello The tm.t_uac_start function generates a “tm:local-request” event. But the tm.cancel function doesn't generete “tm:local-request” event. Is it possible to activate a parameter in the TM or TMX module to generate the event? Thanks Juan -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3831 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3831(a)github.com>

4 12

git:master:ccc10692: tm: move local-request event route to the right location to access CANCEL
by Xenofon Karamanos 30 Sep '24

30 Sep '24

Module: kamailio Branch: master Commit: ccc106922802213253f03f181d10fe83aa93da94 URL: https://github.com/kamailio/kamailio/commit/ccc106922802213253f03f181d10fe8… Author: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Committer: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Date: 2024-09-30T10:56:15+03:00 tm: move local-request event route to the right location to access CANCEL --- Modified: src/modules/tm/t_cancel.c --- Diff: https://github.com/kamailio/kamailio/commit/ccc106922802213253f03f181d10fe8… Patch: https://github.com/kamailio/kamailio/commit/ccc106922802213253f03f181d10fe8… --- diff --git a/src/modules/tm/t_cancel.c b/src/modules/tm/t_cancel.c index 03e919f6abe..753b261111e 100644 --- a/src/modules/tm/t_cancel.c +++ b/src/modules/tm/t_cancel.c @@ -89,11 +89,6 @@ void prepare_to_cancel( int i; int branches_no; branch_bm_t mask; - int rt, backup_rt; - struct run_act_ctx ctx; - sip_msg_t msg; - sr_kemi_eng_t *keng = NULL; - str evname = str_init("tm:local-request"); *cancel_bm = 0; branches_no = t->nr_of_outgoings; @@ -103,49 +98,6 @@ void prepare_to_cancel( *cancel_bm |= ((mask & (1 << i)) && prepare_cancel_branch(t, i, 1)) << i; } - - rt = -1; - if(tm_event_callback.s == NULL || tm_event_callback.len <= 0) { - rt = route_lookup(&event_rt, "tm:local-request"); - if(rt < 0 || event_rt.rlist[rt] == NULL) { - LM_DBG("tm:local-request not found\n"); - return; - } - } else { - keng = sr_kemi_eng_get(); - if(keng == NULL) { - LM_DBG("event callback (%s) set, but no cfg engine\n", - tm_event_callback.s); - return; - } - } - - /* Check if msg is null */ - if(build_sip_msg_from_buf( - &msg, t->uac->request.buffer, t->uac->request.buffer_len, 0) - < 0) { - LM_ERR("fail to parse msg\n"); - return; - } - - /* Call event */ - backup_rt = get_route_type(); - set_route_type(REQUEST_ROUTE); - init_run_actions_ctx(&ctx); - if(rt >= 0) { - run_top_route(event_rt.rlist[rt], &msg, 0); - } else { - if(keng != NULL) { - - if(sr_kemi_route( - keng, &msg, EVENT_ROUTE, &tm_event_callback, &evname) - < 0) { - LM_ERR("error running event route kemi callback\n"); - } - } - } - set_route_type(backup_rt); - free_sip_msg(&msg); } @@ -262,6 +214,11 @@ int cancel_branch(struct cell *t, int branch, sip_msg_t *cancel_msg, struct cancel_info tmp_cd; void *pcbuf; int reply_status; + int rt, backup_rt; + struct run_act_ctx ctx; + sip_msg_t msg; + sr_kemi_eng_t *keng = NULL; + str evname = str_init("tm:local-request"); crb = &t->uac[branch].local_cancel; irb = &t->uac[branch].request; @@ -378,6 +335,46 @@ int cancel_branch(struct cell *t, int branch, sip_msg_t *cancel_msg, crb->buffer_len = len; LM_DBG("sending cancel...\n"); + + rt = -1; + if(tm_event_callback.s == NULL || tm_event_callback.len <= 0) { + rt = route_lookup(&event_rt, evname.s); + if(rt < 0 || event_rt.rlist[rt] == NULL) { + LM_DBG("tm:local-request not found\n"); + } + } else { + keng = sr_kemi_eng_get(); + if(keng == NULL) { + LM_DBG("event callback (%s) set, but no cfg engine\n", + tm_event_callback.s); + } + } + + // /* Check if msg is null */ + if(build_sip_msg_from_buf(&msg, crb->buffer, crb->buffer_len, 0) < 0) { + LM_ERR("fail to parse msg\n"); + } + + /* Call event */ + backup_rt = get_route_type(); + set_route_type(REQUEST_ROUTE); + init_run_actions_ctx(&ctx); + if(rt >= 0) { + LM_ALERT("tm:local-request found [%d]\n", rt); + run_top_route(event_rt.rlist[rt], &msg, 0); + } else { + if(keng != NULL) { + + if(sr_kemi_route( + keng, &msg, EVENT_ROUTE, &tm_event_callback, &evname) + < 0) { + LM_ERR("error running event route kemi callback\n"); + } + } + } + set_route_type(backup_rt); + free_sip_msg(&msg); + if(SEND_BUFFER(crb) >= 0) { if(unlikely(has_tran_tmcbs(t, TMCB_REQUEST_OUT))) run_trans_callbacks_with_buf(

1 0

[kamailio/kamailio] t_relay failed when a user has several locations but some of them are stale (Issue #3985)
by Corey 27 Sep '24

27 Sep '24

### Description I followed the page 18~23 of this slide [20-Federico.Cabiddu-Kamailio-In-A-Mobile-World](https://www.kamailio.org/ev… to implement suspension & push notification, it worked well on mobile devices. However, callee might have several location records on some occasions, for instance, they forcibly quit the app or kill the browser, meaning they don't de-register, the location hasn't expired and still exists, but it is stale and unreachable, this makes `t_relay` failed (return code is -2 and didn't trigger failure_route) since Kamailio `lookup` the stale location rather than the new one as they get push notification, below are some part of logs. ``` ERROR: tm [t_fwd.c:484]: prepare_new_uac(): could not build request ERROR: tm [t_fwd.c:1764]: t_forward_nonack(): failure to add branches ERROR: <script>: not t_relay by INVITE -2 ERROR: <script>: check status code is 100 ``` The rest of Kamailio code triggers `sl_reply_error`, caller gets 500 and terminates. ### Expected behavior When callee has several locations, even if some of them are stale, callee should not terminate the call and should find a valid location to ring the target. #### Actual observed behavior Caller finds invalid locations and gets 500 error msg. #### Debugging Data What I have tried 1. Run `suspend` when `t_relay` failed. ``` if (!t_relay()) { revert_uri(); route(SUSPEND); } ``` It doesn't work since `t_continue` still tries to recover the call with the stale location. 2. Run `append_branch` before `t_relay`. ``` if (!lookup("location")) { send_replay("100", "Trying"); route(SUSPEND); } else { append_branch($tu); t_relay(); ts_store(); $sht(vtp=>stored::$rU) = 1; xdbg("stored transaction [$T(id_index):$T(id_label)] $fU=> $rU\n"); } ``` This version of caller won't get 500 and terminate, but callee cannot finds the resumed call. 3. Use `t_load_contacts` and `t_next_contact`. ``` t_load_contacts(); while (t_next_contacts()) { xlog ("==== $ru\n"); } ``` t_next_contacts always return -2 (nothing to do), but I can see the new location via command `kamctl ul show`. #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` (paste your output here) ``` * **Operating System**:  ``` (paste your output here) ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3985 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3985(a)github.com>

2 4

[kamailio/kamailio] siptrace: handle trace_to_database param at runtime (PR #3877)
by Gustavo Almeida 27 Sep '24

27 Sep '24

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description This change allows to enable/disable the insertion of SIP traces into the DB at runtime (i know we could do this with `siptrace.status`, but this is a different case). This feature is strictly important if you start `Kamailio` with `trace_to_database` parameter disabled, and you want to enable it later and at runtime. Nowadays, if you try to start `Kamailio` with `trace_to_database` enabled, but without a connection to the DB, the service won't start (`child_init` logic). In this type of situation, it makes sense to start `Kamailio` disabling the `trace_to_database` parameter, and when the DB is ok, at runtime, we enable `trace_to_database` parameter. This prevents the need to restart the service, and also we can start `Kamailio` without problems, if DB of SIP Traces is NOK at that time. My PR may need some improvements, especially on the enable side, so feel free to make any changes to improve that. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3877 -- Commit Summary -- * siptrace: handle trace_to_database param at runtime -- File Changes -- M src/modules/siptrace/siptrace.c (100) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3877.patch https://github.com/kamailio/kamailio/pull/3877.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3877 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3877(a)github.com>

4 14

← Newer
1
2
3
4
5
6
7
...
17
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev September 2024