sr-dev September 2024

sr-dev@lists.kamailio.org

13 participants
142 discussions

git:5.7:85988887: tm: remove extra + used before MAXFWD_HEADER_LEN

by Daniel-Constantin Mierla

Module: kamailio Branch: 5.7 Commit: 859888876418605abdffcc57bea8b5988860476d URL: https://github.com/kamailio/kamailio/commit/859888876418605abdffcc57bea8b59… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-09-19T08:56:09+02:00 tm: remove extra + used before MAXFWD_HEADER_LEN (cherry picked from commit 307d6db88c218ffd5dc9d6e7de6425ac4ef24748) (cherry picked from commit 672c3e75c4679681c1ddfb42f852682d93e42c31) --- Modified: src/modules/tm/t_msgbuilder.c --- Diff: https://github.com/kamailio/kamailio/commit/859888876418605abdffcc57bea8b59… Patch: https://github.com/kamailio/kamailio/commit/859888876418605abdffcc57bea8b59… --- diff --git a/src/modules/tm/t_msgbuilder.c b/src/modules/tm/t_msgbuilder.c index 6ff3d8d61d5..5f0f9575f4d 100644 --- a/src/modules/tm/t_msgbuilder.c +++ b/src/modules/tm/t_msgbuilder.c @@ -1246,7 +1246,7 @@ char *build_dlg_ack(struct sip_msg *rpl, struct cell *Trans, /* headers */ *len += Trans->from_hdr.len + Trans->callid_hdr.len + to->len - + Trans->cseq_hdr_n.len + 1 + ACK_LEN + +MAXFWD_HEADER_LEN + + Trans->cseq_hdr_n.len + 1 + ACK_LEN + MAXFWD_HEADER_LEN + CRLF_LEN; /* copy'n'paste Route headers */

8 hours, 41 minutes

git:5.8:672c3e75: tm: remove extra + used before MAXFWD_HEADER_LEN

by Daniel-Constantin Mierla

Module: kamailio Branch: 5.8 Commit: 672c3e75c4679681c1ddfb42f852682d93e42c31 URL: https://github.com/kamailio/kamailio/commit/672c3e75c4679681c1ddfb42f852682… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-09-19T08:55:43+02:00 tm: remove extra + used before MAXFWD_HEADER_LEN (cherry picked from commit 307d6db88c218ffd5dc9d6e7de6425ac4ef24748) --- Modified: src/modules/tm/t_msgbuilder.c --- Diff: https://github.com/kamailio/kamailio/commit/672c3e75c4679681c1ddfb42f852682… Patch: https://github.com/kamailio/kamailio/commit/672c3e75c4679681c1ddfb42f852682… --- diff --git a/src/modules/tm/t_msgbuilder.c b/src/modules/tm/t_msgbuilder.c index 1aa680aa9a4..65c7be46a0e 100644 --- a/src/modules/tm/t_msgbuilder.c +++ b/src/modules/tm/t_msgbuilder.c @@ -1246,7 +1246,7 @@ char *build_dlg_ack(struct sip_msg *rpl, struct cell *Trans, /* headers */ *len += Trans->from_hdr.len + Trans->callid_hdr.len + to->len - + Trans->cseq_hdr_n.len + 1 + ACK_LEN + +MAXFWD_HEADER_LEN + + Trans->cseq_hdr_n.len + 1 + ACK_LEN + MAXFWD_HEADER_LEN + CRLF_LEN; /* copy'n'paste Route headers */

8 hours, 41 minutes

git:master:307d6db8: tm: remove extra + used before MAXFWD_HEADER_LEN

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 307d6db88c218ffd5dc9d6e7de6425ac4ef24748 URL: https://github.com/kamailio/kamailio/commit/307d6db88c218ffd5dc9d6e7de6425a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-09-19T08:54:32+02:00 tm: remove extra + used before MAXFWD_HEADER_LEN --- Modified: src/modules/tm/t_msgbuilder.c --- Diff: https://github.com/kamailio/kamailio/commit/307d6db88c218ffd5dc9d6e7de6425a… Patch: https://github.com/kamailio/kamailio/commit/307d6db88c218ffd5dc9d6e7de6425a… --- diff --git a/src/modules/tm/t_msgbuilder.c b/src/modules/tm/t_msgbuilder.c index 9adc4613421..2092d7dd5ff 100644 --- a/src/modules/tm/t_msgbuilder.c +++ b/src/modules/tm/t_msgbuilder.c @@ -1320,7 +1320,7 @@ char *build_dlg_ack(struct sip_msg *rpl, struct cell *Trans, /* headers */ *len += Trans->from_hdr.len + Trans->callid_hdr.len + to->len - + Trans->cseq_hdr_n.len + 1 + ACK_LEN + +MAXFWD_HEADER_LEN + + Trans->cseq_hdr_n.len + 1 + ACK_LEN + MAXFWD_HEADER_LEN + CRLF_LEN; /* copy'n'paste Route headers */

8 hours, 42 minutes

git:master:f7045d1c: core: reqorked check for incompatible modes of bind_ipv6_link_local

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: f7045d1c08d37e91ee7e96e415c06b218aee98fd URL: https://github.com/kamailio/kamailio/commit/f7045d1c08d37e91ee7e96e415c06b2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-09-18T19:23:28+02:00 core: reqorked check for incompatible modes of bind_ipv6_link_local --- Modified: src/core/cfg.y --- Diff: https://github.com/kamailio/kamailio/commit/f7045d1c08d37e91ee7e96e415c06b2… Patch: https://github.com/kamailio/kamailio/commit/f7045d1c08d37e91ee7e96e415c06b2… --- diff --git a/src/core/cfg.y b/src/core/cfg.y index 8bb77351230..afb07b415dd 100644 --- a/src/core/cfg.y +++ b/src/core/cfg.y @@ -1001,7 +1001,8 @@ assign_stm: | IPV6_HEX_STYLE error { yyerror("string value expected"); } | BIND_IPV6_LINK_LOCAL EQUAL NUMBER { sr_bind_ipv6_link_local = $3; - if(!(sr_bind_ipv6_link_local && (KSR_IPV6_LINK_LOCAL_BIND|KSR_IPV6_LINK_LOCAL_SKIP))) { + if((sr_bind_ipv6_link_local & KSR_IPV6_LINK_LOCAL_BIND) + && (sr_bind_ipv6_link_local & KSR_IPV6_LINK_LOCAL_SKIP)) { yyerror("incompatible modes set"); } }

22 hours, 13 minutes

[kamailio/kamailio] The tm.cancel function does not generate a “tm:local-request” event. (Issue #3831)

by JuanPascual2

Hello The tm.t_uac_start function generates a “tm:local-request” event. But the tm.cancel function doesn't generete “tm:local-request” event. Is it possible to activate a parameter in the TM or TMX module to generate the event? Thanks Juan -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3831 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3831(a)github.com>

1 day

git:5.7:30776c97: tm: add mandatory Max-Forwards header to local AC

by Xenofon Karamanos

Module: kamailio Branch: 5.7 Commit: 30776c97b97f0b6836b313af3f4d385fd6492073 URL: https://github.com/kamailio/kamailio/commit/30776c97b97f0b6836b313af3f4d385… Author: Juha Heinanen <jh(a)tutpro.com> Committer: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Date: 2024-09-18T14:27:30Z tm: add mandatory Max-Forwards header to local AC (cherry picked from commit 3a34b468ad93904c507bd0fc7ef592b25321807f) --- Modified: src/modules/tm/t_msgbuilder.c --- Diff: https://github.com/kamailio/kamailio/commit/30776c97b97f0b6836b313af3f4d385… Patch: https://github.com/kamailio/kamailio/commit/30776c97b97f0b6836b313af3f4d385… --- diff --git a/src/modules/tm/t_msgbuilder.c b/src/modules/tm/t_msgbuilder.c index 22289830df9..6ff3d8d61d5 100644 --- a/src/modules/tm/t_msgbuilder.c +++ b/src/modules/tm/t_msgbuilder.c @@ -1246,7 +1246,8 @@ char *build_dlg_ack(struct sip_msg *rpl, struct cell *Trans, /* headers */ *len += Trans->from_hdr.len + Trans->callid_hdr.len + to->len - + Trans->cseq_hdr_n.len + 1 + ACK_LEN + CRLF_LEN; + + Trans->cseq_hdr_n.len + 1 + ACK_LEN + +MAXFWD_HEADER_LEN + + CRLF_LEN; /* copy'n'paste Route headers */ @@ -1291,6 +1292,8 @@ char *build_dlg_ack(struct sip_msg *rpl, struct cell *Trans, append_str(p, Trans->callid_hdr.s, Trans->callid_hdr.len); append_str(p, to->s, to->len); + append_str(p, MAXFWD_HEADER, MAXFWD_HEADER_LEN); + append_str(p, Trans->cseq_hdr_n.s, Trans->cseq_hdr_n.len); append_str(p, " ", 1); append_str(p, ACK, ACK_LEN);

1 day, 1 hour

[kamailio/kamailio] tm: move local-request event route to the right location to access CANCEL (PR #3979)

by Xenofon Karamanos

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #3831 #### Description  This PR fixes the error introduced in #3962, about not being able to access the generated CANCEL message. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3979 -- Commit Summary -- * tm: move local-request event route to the right location to access CANCEL -- File Changes -- M src/modules/tm/t_cancel.c (93) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3979.patch https://github.com/kamailio/kamailio/pull/3979.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3979 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3979(a)github.com>

1 day, 2 hours

[kamailio/kamailio] Wrong Route header order in called party re-INVITE when using topos (Issue #3778)

by Javi Montoro

Hi There, We found a situation where topos seems to break, let me explain... Assuming the following scenario: ``` Caller ---- Callee A: ------INVITE-----> Record-Route:A.A.A.A, Record-Route:B.B.B.B B: <-----200 OK------ C: <-----INVITE------ Route: A.A.A.A, B.B.B.B D: ------200 OK-----> Record-Route:B.B.B.B, Record-Route:A.A.A.A (reversed order) E: <======INVITE===== Route: B.B.B.B, A.A.A.A (wrong) ``` A and B establish the connection from caller to callee, and topos works fine. C (re-INVITE from callee) sends the Route header according to the Record-Routes from the original INVITE (A) D is the 200 OK sent from the caller to the first re-INVITE (C) coming from the callee, with the Record-Route headers reversed, because is the order in which the callee received them; and according to the RFC it's working as intended: ``` When a UAS responds to a request with a response that establishes a dialog (such as a 2xx to INVITE), the UAS MUST copy all Record-Route header field values from the request into the response (including the URIs, URI parameters, and any Record-Route header field parameters, whether they are known or unknown to the UAS) and MUST maintain the order of those values. [...] [When a UAC receives a response...] The route set MUST be set to the list of URIs in the Record-Route header field from the response, taken in reverse order and preserving all URI parameters. ``` E takes the Route order from the last 200 OK ignoring they are in reversed order and assuming the top one is the first one, when it should be the other way around, sending to an IP address not reachable from the callee. And I think here is the issue, topos should not update the path on the Record-Routes from a 200 OK but if it does, it should take the reverse order When disabling topos, everything works fine, or with topos enabled, by setting rr_update=0 works for us, but what if there is a real path update, rr_update=0 wouldn't work for us anymore. The Kamailio version is 5.8.0-rc0 Let me know if you need more information. Thanks a lot, Javi -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3778 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3778(a)github.com>

1 day, 4 hours

[kamailio/kamailio] Build for el9 without legacy geoip (PR #3886)

by Oded Arbel

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #3592 #### Description The `kamailio-geoip` RPM sub package currently builds both the `geoip` module - based on [the old and out of support MaxMind GeoIP library](https://github.com/maxmind/geoip-api-c) - and the newer `geoip2` module - based on [the currently supported `libmaxminddb`](https://github.com/maxmind/libmaxminddb). The old GeoIP C library had its end of support date at May 2022 but for a while was still shipped for many distributions. At this point though, the EPEL repository that shipped the GeoIP library for RHEL-based operating systems, has removed it from their repositories for "Enterprise Linux 9": ![Screenshot_20240620_144233](https://github.com/kamailio/kamailio/assets/381782/bb1f2481-57f7-48af-b0f1-0ba1c14a3042) Therefor builds using the bundled spec file fail on EL9 installations. The suggested change is to add an RPM build option `--with geoip2` that when specified will build just the `geoip2` module for the `kamailio-geoip` RPM subpackage. This build option is not enabled by default, unless the build is running on a RHEL 9 based OS - in which case it is set as the default, because otherwise trivial builds break. To revert to the older behavior in RHEL 9 based OSs (and assuming you have the required unsupported library installed correctly) one will need to set both `--without geoip2 --with geoip`. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3886 -- Commit Summary -- * packaging: RPM build option to build just the geoip2 module * packaging: make 'with geoip2' the default behavior for EL9 -- File Changes -- M pkg/kamailio/obs/kamailio.spec (36) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3886.patch https://github.com/kamailio/kamailio/pull/3886.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3886 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3886(a)github.com>

1 day, 4 hours

git:master:ba6ab04e: pkg/kamailio: removed geoip module rpm packaging [skip ci]

by Sergey Safarov

Module: kamailio Branch: master Commit: ba6ab04e06b0dfd66874749e0cb1225f2ee273ac URL: https://github.com/kamailio/kamailio/commit/ba6ab04e06b0dfd66874749e0cb1225… Author: Sergey Safarov <s.safarov(a)gmail.com> Committer: Sergey Safarov <s.safarov(a)gmail.com> Date: 2024-09-18T13:59:37+03:00 pkg/kamailio: removed geoip module rpm packaging [skip ci] fixes #GH3886 --- Modified: pkg/kamailio/obs/kamailio.spec --- Diff: https://github.com/kamailio/kamailio/commit/ba6ab04e06b0dfd66874749e0cb1225… Patch: https://github.com/kamailio/kamailio/commit/ba6ab04e06b0dfd66874749e0cb1225… --- diff --git a/pkg/kamailio/obs/kamailio.spec b/pkg/kamailio/obs/kamailio.spec index c182edb28a7..bf1d35bc50c 100644 --- a/pkg/kamailio/obs/kamailio.spec +++ b/pkg/kamailio/obs/kamailio.spec @@ -8,7 +8,6 @@ %bcond_without cnxcc %bcond_with dnssec %bcond_without evapi -%bcond_without geoip %bcond_without http_async_client %bcond_without ims %bcond_without jansson @@ -45,7 +44,6 @@ %bcond_without cnxcc %bcond_with dnssec %bcond_without evapi -%bcond_without geoip %bcond_without http_async_client %bcond_without ims %bcond_without jansson @@ -92,7 +90,6 @@ %bcond_without cnxcc %bcond_with dnssec %bcond_without evapi -%bcond_without geoip %bcond_without http_async_client %bcond_without ims %bcond_without jansson @@ -139,7 +136,6 @@ %bcond_without cnxcc %bcond_with dnssec %bcond_without evapi -%bcond_without geoip %bcond_without http_async_client %bcond_without ims %bcond_without jansson @@ -169,7 +165,6 @@ %bcond_without cnxcc %bcond_with dnssec %bcond_with evapi -%bcond_without geoip %bcond_without http_async_client %bcond_without ims %bcond_without jansson @@ -466,16 +461,14 @@ suspended when sending the event, to be resumed at a later point, maybe triggere %endif -%if %{with geoip} %package geoip Summary: MaxMind GeoIP support for Kamailio Group: %{PKGGROUP} -Requires: GeoIP, libmaxminddb, kamailio = %ver -BuildRequires: GeoIP-devel, libmaxminddb-devel +Requires: libmaxminddb, kamailio = %ver +BuildRequires: libmaxminddb-devel %description geoip MaxMind GeoIP support for Kamailio. -%endif %package gzcompress @@ -1226,10 +1219,7 @@ make every-module skip_modules="app_mono db_cassandra db_oracle iptrtpproxy \ %if %{with evapi} kev \ %endif -%if %{with geoip} - kgeoip \ kgeoip2 \ -%endif kgzcompress \ %if %{with http_async_client} khttp_async \ @@ -1339,10 +1329,7 @@ make install-modules-all skip_modules="app_mono db_cassandra db_oracle \ %if %{with evapi} kev \ %endif -%if %{with geoip} - kgeoip \ kgeoip2 \ -%endif kgzcompress \ %if %{with http_async_client} khttp_async \ @@ -1935,14 +1922,10 @@ fi %endif -%if %{with geoip} %files geoip %defattr(-,root,root) -%doc %{_docdir}/kamailio/modules/README.geoip %doc %{_docdir}/kamailio/modules/README.geoip2 -%{_libdir}/kamailio/modules/geoip.so %{_libdir}/kamailio/modules/geoip2.so -%endif %files gzcompress

1 day, 4 hours

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev September 2024