sr-dev September 2024

sr-dev@lists.kamailio.org

13 participants
142 discussions

by Daniel-Constantin Mierla

Hello, I am considering to release Kamailio v5.8.3 (out of branch 5.8) sometime next week, most likely on Wednesday, Sep 4, 2024. If anyone is aware of issues not yet on the bug tracker, report them there asap in order to have a better chance to be fixed. Cheers, Daniel -- Daniel-Constantin Mierla (@ asipto.com) twitter.com/miconda -- linkedin.com/in/miconda Kamailio Consultancy, Training and Development Services -- asipto.com

2 weeks, 1 day

git:master:1c2cb998: registrar: when provided, use host part from uri parameter

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 1c2cb9980082a6a1a8e3986330d9b80c49ef7801 URL: https://github.com/kamailio/kamailio/commit/1c2cb9980082a6a1a8e3986330d9b80… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-09-03T23:24:49+02:00 registrar: when provided, use host part from uri parameter - instread of the To URI, which can be different --- Modified: src/modules/registrar/save.c --- Diff: https://github.com/kamailio/kamailio/commit/1c2cb9980082a6a1a8e3986330d9b80… Patch: https://github.com/kamailio/kamailio/commit/1c2cb9980082a6a1a8e3986330d9b80… --- diff --git a/src/modules/registrar/save.c b/src/modules/registrar/save.c index c94f56563b2..2e25c8e000a 100644 --- a/src/modules/registrar/save.c +++ b/src/modules/registrar/save.c @@ -1094,22 +1094,29 @@ int unregister(struct sip_msg *_m, udomain_t *_d, str *_uri, str *_ruid) { str aor = {0, 0}; sip_uri_t *u; + sip_uri_t turi; urecord_t *r; ucontact_t *c; int res; - if(_ruid == NULL) { + if(_ruid == NULL || _ruid->len <= 0) { /* No ruid provided - remove all contacts for aor */ - - if(extract_aor(_uri, &aor, NULL) < 0) { - LM_ERR("failed to extract Address Of Record\n"); - return -1; - } - - u = parse_to_uri(_m); - if(u == NULL) { - LM_ERR("failed to extract Address Of Record\n"); - return -1; + if(_uri->len > 0) { + if(extract_aor(_uri, &aor, &turi) < 0) { + LM_ERR("failed to extract Address Of Record\n"); + return -1; + } + u = &turi; + } else { + u = parse_to_uri(_m); + if(u == NULL) { + LM_ERR("failed to extract Address Of Record\n"); + return -1; + } + if(extract_aor(&(get_to(_m)->uri), &aor, NULL) < 0) { + LM_ERR("failed to extract Address Of Record\n"); + return -1; + } } if(star(_m, _d, &aor, &u->host) < 0) {

2 weeks, 1 day

git:master:cf99bd53: modules: readme files regenerated - secsipid ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: cf99bd53379694f9077433e05b5ac00ca43fda85 URL: https://github.com/kamailio/kamailio/commit/cf99bd53379694f9077433e05b5ac00… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2024-09-03T18:16:10+02:00 modules: readme files regenerated - secsipid ... [skip ci] --- Modified: src/modules/secsipid/README --- Diff: https://github.com/kamailio/kamailio/commit/cf99bd53379694f9077433e05b5ac00… Patch: https://github.com/kamailio/kamailio/commit/cf99bd53379694f9077433e05b5ac00… --- diff --git a/src/modules/secsipid/README b/src/modules/secsipid/README index 9297251072a..3cf63aade71 100644 --- a/src/modules/secsipid/README +++ b/src/modules/secsipid/README @@ -505,12 +505,9 @@ request_route { The module needs "secsipdi_proc.so" module that depends on "libsecsipid", which is a component of "sipsecidx" project from https://github.com/asipto/secsipidx/. The library is implemented in Go - language, with generated C API and library. Until the libsecsipid is - going to be packaged in OS distributions, the secsipid_proc module can - be compiled by copying secsipid.h libsecsipid.h and libsecsipid.a files - in the folder of the module. + language, with generated C API and library. - To generate the libsecsipid.a file, it requires to have Go language + To generate the libsecsipid files, it requires to have Go language installed and its environment configured, then run the following commands: @@ -519,9 +516,8 @@ request_route { export GO111MODULE=off go get https://github.com/asipto/secsipidx cd $GOPATH/src/github.com/asipto/secsipidx/csecsipid/ -make liba -cp secsipid.h libsecsipid.h libsecsipid.a \ - /path/to/kamailio/src/modules/secsipid_proc/ +make all +make install cd /path/to/kamailio/ make include_modules="secsipid secsipid_proc ..." cfg

2 weeks, 1 day

git:master:7abbc93d: secsipid: docs update about libsecsipid installation

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 7abbc93d8db807077ca2afc10b026be0835f4b65 URL: https://github.com/kamailio/kamailio/commit/7abbc93d8db807077ca2afc10b026be… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-09-03T18:08:44+02:00 secsipid: docs update about libsecsipid installation --- Modified: src/modules/secsipid/doc/secsipid_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/7abbc93d8db807077ca2afc10b026be… Patch: https://github.com/kamailio/kamailio/commit/7abbc93d8db807077ca2afc10b026be… --- diff --git a/src/modules/secsipid/doc/secsipid_admin.xml b/src/modules/secsipid/doc/secsipid_admin.xml index f8f2e823a21..4009f745149 100644 --- a/src/modules/secsipid/doc/secsipid_admin.xml +++ b/src/modules/secsipid/doc/secsipid_admin.xml @@ -550,13 +550,10 @@ request_route { The module needs "secsipdi_proc.so" module that depends on "libsecsipid", which is a component of "sipsecidx" project from https://github.com/asipto/secsipidx/. The library is - implemented in Go language, with generated C API and library. Until the - libsecsipid is going to be packaged in OS distributions, the secsipid_proc - module can be compiled by copying secsipid.h libsecsipid.h and libsecsipid.a - files in the folder of the module. + implemented in Go language, with generated C API and library. </para> <para> - To generate the libsecsipid.a file, it requires to have Go language + To generate the libsecsipid files, it requires to have Go language installed and its environment configured, then run the following commands: </para> <example> @@ -566,9 +563,8 @@ request_route { export GO111MODULE=off go get https://github.com/asipto/secsipidx cd $GOPATH/src/github.com/asipto/secsipidx/csecsipid/ -make liba -cp secsipid.h libsecsipid.h libsecsipid.a \ - /path/to/kamailio/src/modules/secsipid_proc/ +make all +make install cd /path/to/kamailio/ make include_modules="secsipid secsipid_proc ..." cfg

2 weeks, 1 day

[kamailio/kamailio] rtpengine: export api (PR #3948)

by Farzaneh Soltanzadeh

#### Pre-Submission Checklist    - [* ] Commit message has the format required by CONTRIBUTING guide - [* ] Commits are split per component (core, individual modules, libs, utils, ...) - [* ] Each component has a single commit (if not, squash them into one commit) - [* ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [* ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Rtpengine module doesn't export api to be used by other modules. Api for four of module functions are added. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3948 -- Commit Summary -- * export api in rtpengine module * Merge branch 'master' into Feature/1-rtpengine-export-api-in-module -- File Changes -- A src/modules/rtpengine/api.h (65) M src/modules/rtpengine/rtpengine.c (22) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3948.patch https://github.com/kamailio/kamailio/pull/3948.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3948 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3948(a)github.com>

2 weeks, 2 days

[kamailio/kamailio] rtpengine: fix api using ki functions (PR #3956)

by Farzaneh Soltanzadeh

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ x] PR should be backported to stable branches - [x ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Exported API functions changed to use the KEMI functions. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3956 -- Commit Summary -- * use ki functions as exported api functions -- File Changes -- M src/modules/rtpengine/api.h (21) M src/modules/rtpengine/rtpengine.c (11) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3956.patch https://github.com/kamailio/kamailio/pull/3956.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3956 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3956(a)github.com>

2 weeks, 3 days

git:master:324611b2: rtpengine: use ki functions as exported api functions (#3956)

by GitHub

Module: kamailio Branch: master Commit: 324611b2ecfe2fda25abc8114361d00a9e654772 URL: https://github.com/kamailio/kamailio/commit/324611b2ecfe2fda25abc8114361d00… Author: Farzaneh Soltanzadeh <f.soltanzade72(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2024-09-02T08:04:19-04:00 rtpengine: use ki functions as exported api functions (#3956) - remove extra funcs - change functions name Co-authored-by: Farzaneh Soltanzadeh <fr.soltanzadeh(a)resaa.net> --- Modified: src/modules/rtpengine/api.h Modified: src/modules/rtpengine/rtpengine.c --- Diff: https://github.com/kamailio/kamailio/commit/324611b2ecfe2fda25abc8114361d00… Patch: https://github.com/kamailio/kamailio/commit/324611b2ecfe2fda25abc8114361d00… --- diff --git a/src/modules/rtpengine/api.h b/src/modules/rtpengine/api.h index fa499916238..d5c68e6d871 100644 --- a/src/modules/rtpengine/api.h +++ b/src/modules/rtpengine/api.h @@ -26,18 +26,17 @@ #include "../../core/parser/msg_parser.h" -typedef int (*rtpengine_start_recording_f)( - struct sip_msg *msg, char *str1, char *str2); -typedef int (*rtpengine_answer_f)(struct sip_msg *msg, char *str1, char *str2); -typedef int (*rtpengine_offer_f)(struct sip_msg *msg, char *str1, char *str2); -typedef int (*rtpengine_delete_f)(struct sip_msg *msg, char *str1, char *str2); +typedef int (*rtpengine_start_recording_f)(struct sip_msg *msg); +typedef int (*rtpengine_answer_f)(struct sip_msg *msg, str *str); +typedef int (*rtpengine_offer_f)(struct sip_msg *msg, str *str); +typedef int (*rtpengine_delete_f)(struct sip_msg *msg, str *str); typedef struct rtpengine_api { - rtpengine_start_recording_f start_recording; - rtpengine_answer_f answer; - rtpengine_offer_f offer; - rtpengine_delete_f delete; + rtpengine_start_recording_f rtpengine_start_recording; + rtpengine_answer_f rtpengine_answer; + rtpengine_offer_f rtpengine_offer; + rtpengine_delete_f rtpengine_delete; } rtpengine_api_t; typedef int (*bind_rtpengine_f)(rtpengine_api_t *api); diff --git a/src/modules/rtpengine/rtpengine.c b/src/modules/rtpengine/rtpengine.c index 84bf5951752..e31feb3ceeb 100644 --- a/src/modules/rtpengine/rtpengine.c +++ b/src/modules/rtpengine/rtpengine.c @@ -5794,10 +5794,10 @@ static int bind_rtpengine(rtpengine_api_t *api) LM_ERR("Invalid parameter value\n"); return -1; } - api->start_recording = start_recording_f; - api->answer = rtpengine_answer1_f; - api->offer = rtpengine_offer1_f; - api->delete = rtpengine_delete1_f; + api->rtpengine_start_recording = ki_start_recording; + api->rtpengine_answer = ki_rtpengine_answer; + api->rtpengine_offer = ki_rtpengine_offer; + api->rtpengine_delete = ki_rtpengine_delete; return 0; } \ No newline at end of file

2 weeks, 3 days

git:5.8:9e0f6acc: app_python3: Fixes Kemi TypeError thrown when latency_limit_action is exceeded.

by Daniel-Constantin Mierla

Module: kamailio Branch: 5.8 Commit: 9e0f6acc23313f5b25300660b6a4b75aab5bd168 URL: https://github.com/kamailio/kamailio/commit/9e0f6acc23313f5b25300660b6a4b75… Author: Michel Pelletier <michel(a)voip.ms> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-09-02T09:37:27+02:00 app_python3: Fixes Kemi TypeError thrown when latency_limit_action is exceeded. Replace PyBytes_AsString(..) calls with calls to PyUnicode_AsUTF8(..) in the PY_VERSION_HEX >= 0x030B0000 block of apy_kemi.c. The PyBytes_AsString expects a Bytes value but receives a Unicode value instead, thus causing the TypeError exception. (cherry picked from commit 6cae3661419d8d79fc8fb0463f6787b06911fa9d) --- Modified: src/modules/app_python3/apy_kemi.c --- Diff: https://github.com/kamailio/kamailio/commit/9e0f6acc23313f5b25300660b6a4b75… Patch: https://github.com/kamailio/kamailio/commit/9e0f6acc23313f5b25300660b6a4b75… --- diff --git a/src/modules/app_python3/apy_kemi.c b/src/modules/app_python3/apy_kemi.c index 718d8ecedaf..0c1ab535809 100644 --- a/src/modules/app_python3/apy_kemi.c +++ b/src/modules/app_python3/apy_kemi.c @@ -379,8 +379,8 @@ PyObject *sr_apy_kemi_exec_func(PyObject *self, PyObject *args, int idx) " took too long [%u ms] (file:%s func:%s line:%d)\n", (ket->mname.len > 0) ? ket->mname.s : "", (ket->mname.len > 0) ? "." : "", ket->fname.s, tdiff, - (pcode) ? PyBytes_AsString(pcode->co_filename) : "", - (pcode) ? PyBytes_AsString(pcode->co_name) : "", + (pcode) ? PyUnicode_AsUTF8(pcode->co_filename) : "", + (pcode) ? PyUnicode_AsUTF8(pcode->co_name) : "", (pframe) ? PyFrame_GetLineNumber(pframe) : 0); #else LOG(cfg_get(core, core_cfg, latency_log),

2 weeks, 3 days

git:5.8:661b2670: usrloc: mark contacts with keepalive sent

by Daniel-Constantin Mierla

Module: kamailio Branch: 5.8 Commit: 661b2670168530c21ee4dd23fcb29abf8b5bc3ba URL: https://github.com/kamailio/kamailio/commit/661b2670168530c21ee4dd23fcb29ab… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-09-02T09:37:04+02:00 usrloc: mark contacts with keepalive sent - properly detect if the contact record has to be expired or not (cherry picked from commit 6502872d35d9bd7043bf54cd1d640dd64ae87115) --- Modified: src/modules/usrloc/ul_keepalive.c Modified: src/modules/usrloc/usrloc.h --- Diff: https://github.com/kamailio/kamailio/commit/661b2670168530c21ee4dd23fcb29ab… Patch: https://github.com/kamailio/kamailio/commit/661b2670168530c21ee4dd23fcb29ab… --- diff --git a/src/modules/usrloc/ul_keepalive.c b/src/modules/usrloc/ul_keepalive.c index e5a013b45a3..16fb66021c1 100644 --- a/src/modules/usrloc/ul_keepalive.c +++ b/src/modules/usrloc/ul_keepalive.c @@ -148,7 +148,8 @@ int ul_ka_urecord(urecord_t *ur) } } - if(ul_keepalive_timeout > 0 && uc->last_keepalive > 0) { + if(ul_keepalive_timeout > 0 && uc->last_keepalive > 0 + && (uc->flags & FL_KASENT)) { if(uc->last_keepalive + ul_keepalive_timeout < tnow) { /* set contact as expired in 10s */ LM_DBG("set expired contact on keepalive (%u + %u < %u)" @@ -257,7 +258,9 @@ int ul_ka_urecord(urecord_t *ur) kabuf_len, kabuf); kamsg.s = kabuf; kamsg.len = kabuf_len; - ul_ka_send(&kamsg, &idst); + if(ul_ka_send(&kamsg, &idst) >= 0) { + uc->flags |= FL_KASENT; + } } } return 0; diff --git a/src/modules/usrloc/usrloc.h b/src/modules/usrloc/usrloc.h index 54f7986080d..370baf0da86 100644 --- a/src/modules/usrloc/usrloc.h +++ b/src/modules/usrloc/usrloc.h @@ -63,6 +63,7 @@ typedef enum flags FL_MEM = 1 << 0, /*!< Update memory only */ FL_DMQRPL = 1 << 1, /*!< DMQ replication */ FL_EXPCLB = 1 << 2, /*!< Expired callback executed */ + FL_KASENT = 1 << 3, /*!< Keepalive sent to contact */ FL_ALL = (int)0xFFFFFFFF /*!< All flags set */ } flags_t;

2 weeks, 3 days

git:master:c3c75bf2: secfilter: cfg functions execute the kemi functions

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: c3c75bf23fd07db1b5a2b83fa06eddc86ae2ed0f URL: https://github.com/kamailio/kamailio/commit/c3c75bf23fd07db1b5a2b83fa06eddc… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-09-02T08:44:30+02:00 secfilter: cfg functions execute the kemi functions - cfg functions may get the option to have cfg variables, which can break the old approach without any warning - itnernal function rename to not use common cfg wrapper prefix and also have pointer to parameter, not value - small formatting updates --- Modified: src/modules/secfilter/secfilter.c --- Diff: https://github.com/kamailio/kamailio/commit/c3c75bf23fd07db1b5a2b83fa06eddc… Patch: https://github.com/kamailio/kamailio/commit/c3c75bf23fd07db1b5a2b83fa06eddc…

2 weeks, 3 days

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev September 2024