sr-dev September 2024

sr-dev@lists.kamailio.org

13 participants
142 discussions

Re: [kamailio/kamailio] tls: extend startup information for OpenSSL library (0420809)

by Daniel-Constantin Mierla

A modparam would be useful in the context of people willing to get more and more details (e.g., available providers, cyphers, ... or whatever else can be extracted from the lib). Otherwise, fine for me. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/04208090638a639cdf03fafb1df161c… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/04208090638a639cdf03fafb1df161cd71f74c7e/146217938(a)github.com>

2 weeks, 1 day

git:5.8:d86350ea: pkg/kamailio/deb: set version to 5.8.3

by Victor Seva

Module: kamailio Branch: 5.8 Commit: d86350ea9078b89677323ac86053b0f37b7d1722 URL: https://github.com/kamailio/kamailio/commit/d86350ea9078b89677323ac86053b0f… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-09-04T09:30:26+02:00 pkg/kamailio/deb: set version to 5.8.3 --- Modified: pkg/kamailio/deb/bionic/changelog Modified: pkg/kamailio/deb/bookworm/changelog Modified: pkg/kamailio/deb/bullseye/changelog Modified: pkg/kamailio/deb/buster/changelog Modified: pkg/kamailio/deb/debian/changelog Modified: pkg/kamailio/deb/focal/changelog Modified: pkg/kamailio/deb/jammy/changelog Modified: pkg/kamailio/deb/jessie/changelog Modified: pkg/kamailio/deb/precise/changelog Modified: pkg/kamailio/deb/sid/changelog Modified: pkg/kamailio/deb/stretch/changelog Modified: pkg/kamailio/deb/trusty/changelog Modified: pkg/kamailio/deb/wheezy/changelog Modified: pkg/kamailio/deb/xenial/changelog --- Diff: https://github.com/kamailio/kamailio/commit/d86350ea9078b89677323ac86053b0f… Patch: https://github.com/kamailio/kamailio/commit/d86350ea9078b89677323ac86053b0f…

2 weeks, 1 day

Re: [kamailio/kamailio] tls: extend startup information for OpenSSL library (0420809)

by Henning Westerholt

Sure, I can also output the "number" version, will add another commit. About the FIPS, other projects do it in a similar way (e.g. haproxy). But one simple change would be to have LM_INFO if FIPS is in fact enabled (this is rarely done), and DBG for FIPS mode not enabled, without the need for a new module parameter. Will change it. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/04208090638a639cdf03fafb1df161c… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/04208090638a639cdf03fafb1df161cd71f74c7e/146217533(a)github.com>

2 weeks, 1 day

Re: [kamailio/kamailio] tls: extend startup information for OpenSSL library (0420809)

by Daniel-Constantin Mierla

I would prefer to keep logging the OPENSSL_VERSION_NUMBER even for OPENSSL_VERSION_NUMBER >= 0x030000000L, it is something easy to extract by regex/grepping. In addition, the detailed version info can be printed. I am not sure if FIPS logging is commonly used and relevant to be INFO, there will be questions when not enabled. IMO, DEBUG should do it here or a modparam (e.g., `libinfo`) can be introduced to dump exhaustive details about ssl library at startup (e.g., the version text, fips mode, ...). -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/04208090638a639cdf03fafb1df161c… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/04208090638a639cdf03fafb1df161cd71f74c7e/146217391(a)github.com>

2 weeks, 1 day

Re: [kamailio/kamailio] tls: replace em dash with hyphen (reported from Bastian Triller, GH #3966) (228c598)

by Henning Westerholt

I found and commited the mistake already before I saw the PR, then I amended the commit message to have it linked to it. I will split it in two lines then if required in the future, sure. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/228c59851878fed15d8b34e43938c28… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/228c59851878fed15d8b34e43938c281729e518d/146217108(a)github.com>

2 weeks, 1 day

Re: [kamailio/kamailio] tls: replace em dash with hyphen (reported from Bastian Triller, GH #3966) (228c598)

by Daniel-Constantin Mierla

Credits and reference to issues or PRs have to be done in the description content of the commit message, not in the first line, as per contributing guidelines. Also, as I could see if I haven't missed something, in this case the PR was proposing exactly the same change, with proper commit message, so it could have just been merged directly, not doing a separate commit and reference the PR. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/228c59851878fed15d8b34e43938c28… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/228c59851878fed15d8b34e43938c281729e518d/146216488(a)github.com>

2 weeks, 1 day

[kamailio/kamailio] tls: Replace em dash with hyphen (PR #3966)

by Bastian Triller

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3966 -- Commit Summary -- * tls: Replace em dash with hyphen -- File Changes -- M src/modules/tls/tls_mod.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3966.patch https://github.com/kamailio/kamailio/pull/3966.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3966 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3966(a)github.com>

2 weeks, 1 day

git:master:228c5985: tls: replace em dash with hyphen (reported from Bastian Triller, GH #3966)

by Henning Westerholt

Module: kamailio Branch: master Commit: 228c59851878fed15d8b34e43938c281729e518d URL: https://github.com/kamailio/kamailio/commit/228c59851878fed15d8b34e43938c28… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2024-09-04T06:53:31Z tls: replace em dash with hyphen (reported from Bastian Triller, GH #3966) --- Modified: src/modules/tls/tls_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/228c59851878fed15d8b34e43938c28… Patch: https://github.com/kamailio/kamailio/commit/228c59851878fed15d8b34e43938c28… --- diff --git a/src/modules/tls/tls_mod.c b/src/modules/tls/tls_mod.c index f46d4aaddfd..84d9ff33412 100644 --- a/src/modules/tls/tls_mod.c +++ b/src/modules/tls/tls_mod.c @@ -508,7 +508,7 @@ static int mod_init(void) LM_INFO("OpenSSL supports Diffie-Hellman\n"); #endif #ifndef OPENSSL_NO_ECDH - LM_INFO("OpenSSL supports Elliptic-curve Diffie��Hellman\n"); + LM_INFO("OpenSSL supports Elliptic-curve Diffie-Hellman\n"); #endif if(sr_tls_event_callback.s == NULL || sr_tls_event_callback.len <= 0) { tls_lookup_event_routes();

2 weeks, 1 day

git:master:5526809c: tls: improve informational messages on startup for DH and ECDH support in OpenSSL

by Henning Westerholt

Module: kamailio Branch: master Commit: 5526809c2f00a50dfa217d2fbfd688c7abed99f3 URL: https://github.com/kamailio/kamailio/commit/5526809c2f00a50dfa217d2fbfd688c… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2024-09-04T06:30:45Z tls: improve informational messages on startup for DH and ECDH support in OpenSSL --- Modified: src/modules/tls/tls_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/5526809c2f00a50dfa217d2fbfd688c… Patch: https://github.com/kamailio/kamailio/commit/5526809c2f00a50dfa217d2fbfd688c… --- diff --git a/src/modules/tls/tls_mod.c b/src/modules/tls/tls_mod.c index 3c25eb1cb66..f46d4aaddfd 100644 --- a/src/modules/tls/tls_mod.c +++ b/src/modules/tls/tls_mod.c @@ -504,11 +504,11 @@ static int mod_init(void) } #endif -#ifndef OPENSSL_NO_ECDH - LM_INFO("With ECDH-Support!\n"); -#endif #ifndef OPENSSL_NO_DH - LM_INFO("With Diffie Hellman\n"); + LM_INFO("OpenSSL supports Diffie-Hellman\n"); +#endif +#ifndef OPENSSL_NO_ECDH + LM_INFO("OpenSSL supports Elliptic-curve Diffie��Hellman\n"); #endif if(sr_tls_event_callback.s == NULL || sr_tls_event_callback.len <= 0) { tls_lookup_event_routes();

2 weeks, 1 day

git:master:04208090: tls: extend startup information for OpenSSL library

by Henning Westerholt

Module: kamailio Branch: master Commit: 04208090638a639cdf03fafb1df161cd71f74c7e URL: https://github.com/kamailio/kamailio/commit/04208090638a639cdf03fafb1df161c… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2024-09-04T06:23:47Z tls: extend startup information for OpenSSL library - output compiled and run-time library version for OpensSL - also output FIPS mode if activated - needs at least OpenSSL version 3.x --- Modified: src/modules/tls/tls_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/04208090638a639cdf03fafb1df161c… Patch: https://github.com/kamailio/kamailio/commit/04208090638a639cdf03fafb1df161c… --- diff --git a/src/modules/tls/tls_mod.c b/src/modules/tls/tls_mod.c index cce34148470..3c25eb1cb66 100644 --- a/src/modules/tls/tls_mod.c +++ b/src/modules/tls/tls_mod.c @@ -490,7 +490,20 @@ static int mod_init(void) if(tls_check_sockets(*tls_domains_cfg) < 0) goto error; - LM_INFO("use OpenSSL version: %08x\n", (uint32_t)(OPENSSL_VERSION_NUMBER)); + +#if OPENSSL_VERSION_NUMBER < 0x030000000L + LM_INFO("compiled with OpenSSL version: %08x\n", (uint32_t)(OPENSSL_VERSION_NUMBER)); +#elif OPENSSL_VERSION_NUMBER >= 0x030000000L + LM_INFO("compiled with OpenSSL: %s\n", OPENSSL_VERSION_TEXT); + LM_INFO("run-time OpenSSL library: %s\n", OpenSSL_version(OPENSSL_VERSION)); + + if(EVP_default_properties_is_fips_enabled(NULL) == 1) { + LM_INFO("FIPS mode enabled in OpenSSL library\n"); + } else { + LM_INFO("FIPS mode not enabled in OpenSSL library\n"); + } +#endif + #ifndef OPENSSL_NO_ECDH LM_INFO("With ECDH-Support!\n"); #endif

2 weeks, 1 day

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev September 2024