sr-dev January 2024

sr-dev@lists.kamailio.org

19 participants
313 discussions

[kamailio/kamailio] ndb_redis doesn't use AUTH on a slave server in redis cluster. (Issue #3654)
by Dries De Gendt 19 Jan '24

19 Jan '24

### Description & troubleshooting I have defined a redis cluster as followed. The cluster consists of 3 masters (port 6379) and 3 slaves (port 6380). The password is identical on all nodes through redis option 'requirepass'. ``` modparam("ndb_redis", "server", "name=sbcredis;addr=SBCMASTERREDISIP;port=6379;db=0;pass=REDACTED") modparam("ndb_redis", "server", "name=sbcredis;addr=PRIVATEIP;port=6380;db=0;pass=REDACTED") modparam("ndb_redis", "server", "name=sbcredis;addr=ASTP5IP;port=6380;db=0;pass=REDACTED") modparam("ndb_redis", "server", "name=sbcredis;addr=ASTP6IP;port=6379;db=0;pass=REDACTED") modparam("ndb_redis", "server", "name=sbcredis;addr=ASTP3IP;port=6380;db=0;pass=REDACTED") modparam("ndb_redis", "server", "name=sbcredis;addr=ASTP4IP;port=6379;db=0;pass=REDACTED") modparam("ndb_redis", "cluster", 1) modparam("ndb_redis", "allow_dynamic_nodes", 1) modparam("ndb_redis", "debug", 3) ``` When executing the redis_cmd command, most of the times an expected warning is shown due to another server providing the requested slot: `"(error) MOVED ... 192.168.136.241:6380"` Notice that I've enabled "allow_dynamic_nodes" to make sure there is an automated connection attempt to the indicated server. However, it appears that sometimes a "NOAUTH Authentication required." error is thrown when there is a redirection to a slave server serving that slot. I can authenticate succesfull on the redis-cli when using the identical password though. Also note that when a redis master is queried, the redis_cmd is successful. #### Reproduction Each simple redis command that needs authentication (GET, SET, ...) `redis_cmd("sbcredis", "SET TESTKEY TESTVALUE", "r");` #### Log Messages ``` ndb_redis [redis_client.c:1089]: redisc_exec(): Redis error:NOAUTH Authentication required. ``` ### Possible Solutions None for now except disabling the password on all nodes. ### Additional Information ``` kamailio 5.7.2 ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3654 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3654(a)github.com>

2 2

git:master:8a161309: core: parser - check diversion pointer before accessing it
by Daniel-Constantin Mierla 18 Jan '24

18 Jan '24

Module: kamailio Branch: master Commit: 8a1613096ad86db125398e50d2ecced5d3ff1978 URL: https://github.com/kamailio/kamailio/commit/8a1613096ad86db125398e50d2ecced… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-01-18T18:48:22+01:00 core: parser - check diversion pointer before accessing it --- Modified: src/core/parser/parse_diversion.c --- Diff: https://github.com/kamailio/kamailio/commit/8a1613096ad86db125398e50d2ecced… Patch: https://github.com/kamailio/kamailio/commit/8a1613096ad86db125398e50d2ecced… --- diff --git a/src/core/parser/parse_diversion.c b/src/core/parser/parse_diversion.c index 92690296935..557950052fa 100644 --- a/src/core/parser/parse_diversion.c +++ b/src/core/parser/parse_diversion.c @@ -210,17 +210,19 @@ int parse_diversion_header(struct sip_msg *msg) int free_diversion_body(diversion_body_t *div_b) { - int i = 0; + int i; + + if(div_b == NULL) { + return -1; + } for(i = 0; i < div_b->num_ids; i++) { /* Free to_body pointer parameters */ if(div_b->id[i].param_lst) { free_to_params(&(div_b->id[i])); } } + pkg_free(div_b); - if(div_b != NULL) { - pkg_free(div_b); - } return 0; }

1 0

git:master:a972c3bd: gcrypt: init allocated buffer
by Daniel-Constantin Mierla 18 Jan '24

18 Jan '24

Module: kamailio Branch: master Commit: a972c3bd5287177f8fa73dfb0ed5b2da8e3f4f57 URL: https://github.com/kamailio/kamailio/commit/a972c3bd5287177f8fa73dfb0ed5b2d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-01-18T18:37:41+01:00 gcrypt: init allocated buffer --- Modified: src/modules/gcrypt/gcrypt_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/a972c3bd5287177f8fa73dfb0ed5b2d… Patch: https://github.com/kamailio/kamailio/commit/a972c3bd5287177f8fa73dfb0ed5b2d… --- diff --git a/src/modules/gcrypt/gcrypt_mod.c b/src/modules/gcrypt/gcrypt_mod.c index 8a5550139c8..69be4432535 100644 --- a/src/modules/gcrypt/gcrypt_mod.c +++ b/src/modules/gcrypt/gcrypt_mod.c @@ -183,6 +183,7 @@ static int ki_gcrypt_aes_encrypt_helper( SYS_MEM_ERROR; goto error; } + encypted_txt[0] = '\0'; gcry_ret = gcry_cipher_encrypt(cipher_hd, // gcry_cipher_hd_t h encypted_txt, // unsigned char *out ins->len, // size_t outsize @@ -349,6 +350,7 @@ static int ki_gcrypt_aes_decrypt_helper( SYS_MEM_ERROR; goto error; } + decrypted_txt[0] = '\0'; gcry_ret = gcry_cipher_decrypt(cipher_hd, // gcry_cipher_hd_t h decrypted_txt, // unsigned char *out etext.len, // size_t outsize

1 0

git:master:304b8a41: modules: readme files regenerated - kex ... [skip ci]
by Kamailio Dev 18 Jan '24

18 Jan '24

Module: kamailio Branch: master Commit: 304b8a41464f1bed83d733a3002088b759c7e679 URL: https://github.com/kamailio/kamailio/commit/304b8a41464f1bed83d733a3002088b… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2024-01-18T16:01:19+01:00 modules: readme files regenerated - kex ... [skip ci] --- Modified: src/modules/kex/README --- Diff: https://github.com/kamailio/kamailio/commit/304b8a41464f1bed83d733a3002088b… Patch: https://github.com/kamailio/kamailio/commit/304b8a41464f1bed83d733a3002088b… --- diff --git a/src/modules/kex/README b/src/modules/kex/README index 55d341211d0..d0661e611ed 100644 --- a/src/modules/kex/README +++ b/src/modules/kex/README @@ -47,9 +47,10 @@ Ovidiu Sas 3.9. isdsturiset() 3.10. pv_printf(var, str) 3.11. is_myself(uri) - 3.12. setdebug(level) - 3.13. resetdebug() - 3.14. km_append_branch([uri]) + 3.12. is_myhost(uri) + 3.13. setdebug(level) + 3.14. resetdebug() + 3.15. km_append_branch([uri]) 4. RPC Commands @@ -102,8 +103,9 @@ Ovidiu Sas 1.9. isdsturiset usage 1.10. pv_printf usage 1.11. is_myself usage - 1.12. setdebug usage - 1.13. resetdebug usage + 1.12. is_myhost usage + 1.13. setdebug usage + 1.14. resetdebug usage Chapter 1. Admin Guide @@ -128,9 +130,10 @@ Chapter 1. Admin Guide 3.9. isdsturiset() 3.10. pv_printf(var, str) 3.11. is_myself(uri) - 3.12. setdebug(level) - 3.13. resetdebug() - 3.14. km_append_branch([uri]) + 3.12. is_myhost(uri) + 3.13. setdebug(level) + 3.14. resetdebug() + 3.15. km_append_branch([uri]) 4. RPC Commands @@ -206,9 +209,10 @@ Chapter 1. Admin Guide 3.9. isdsturiset() 3.10. pv_printf(var, str) 3.11. is_myself(uri) - 3.12. setdebug(level) - 3.13. resetdebug() - 3.14. km_append_branch([uri]) + 3.12. is_myhost(uri) + 3.13. setdebug(level) + 3.14. resetdebug() + 3.15. km_append_branch([uri]) 3.1. setsflag(flag) @@ -391,7 +395,8 @@ pv_printf("$avp(x)", "From: $fU - To: $tU"); Meaning of the parameters is as follows: * uri - Valid SIP URI or IP address to check against the list of - local IP addresses or domains. The parameter value can contain + local IP addresses or domains, matching as well the port and + protocol if they are provided. The parameter value can contain pseudo-variables. This function can be used from ANY_ROUTE. @@ -403,7 +408,27 @@ if(is_myself("$fu")) { } ... -3.12. setdebug(level) +3.12. is_myhost(uri) + + Check if the host part of the parameter matches a local domain or IP + address. + + Meaning of the parameters is as follows: + * uri - Valid SIP URI, hostname of IP address to check against the + list of local IP addresses or domains. If it is a SIP URI, the port + and protocol are ignored. The parameter value can contain + pseudo-variables. + + This function can be used from ANY_ROUTE. + + Example 1.12. is_myhost usage +... +if(is_myhost("$tu")) { + ... +} +... + +3.13. setdebug(level) Set the debug log level per process. @@ -413,7 +438,7 @@ if(is_myself("$fu")) { This function can be used from ANY_ROUTE. - Example 1.12. setdebug usage + Example 1.13. setdebug usage ... setdebug("1"); ... @@ -421,19 +446,19 @@ $var(level) = 2; setdebug("$var(level)"); ... -3.13. resetdebug() +3.14. resetdebug() Reset the local debug log level back to the value of core parameter 'debug'. This function can be used from ANY_ROUTE. - Example 1.13. resetdebug usage + Example 1.14. resetdebug usage ... resetdebug(); ... -3.14. km_append_branch([uri]) +3.15. km_append_branch([uri]) This function was replaced by append_branch() from corex module, starting with version 4.0.0.

1 0

git:master:2ebf19b1: kex: reformat exported structures
by Daniel-Constantin Mierla 18 Jan '24

18 Jan '24

Module: kamailio Branch: master Commit: 2ebf19b16987b815b2fc2902bff5ccbea6e90e13 URL: https://github.com/kamailio/kamailio/commit/2ebf19b16987b815b2fc2902bff5ccb… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-01-18T11:44:32+01:00 kex: reformat exported structures --- Modified: src/modules/kex/kex_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/2ebf19b16987b815b2fc2902bff5ccb… Patch: https://github.com/kamailio/kamailio/commit/2ebf19b16987b815b2fc2902bff5ccb…

1 0

git:master:ee191ccd: kex: docs for is_myhost()
by Daniel-Constantin Mierla 18 Jan '24

18 Jan '24

Module: kamailio Branch: master Commit: ee191ccd01ec6391c715e22efed2dc6581fe9d72 URL: https://github.com/kamailio/kamailio/commit/ee191ccd01ec6391c715e22efed2dc6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-01-18T09:29:21+01:00 kex: docs for is_myhost() --- Modified: src/modules/kex/doc/kex_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/ee191ccd01ec6391c715e22efed2dc6… Patch: https://github.com/kamailio/kamailio/commit/ee191ccd01ec6391c715e22efed2dc6… --- diff --git a/src/modules/kex/doc/kex_admin.xml b/src/modules/kex/doc/kex_admin.xml index 91080d8c1db..9f99e6a6bc4 100644 --- a/src/modules/kex/doc/kex_admin.xml +++ b/src/modules/kex/doc/kex_admin.xml @@ -360,7 +360,8 @@ pv_printf("$avp(x)", "From: $fU - To: $tU"); <listitem> <para> <emphasis>uri</emphasis> - Valid SIP URI or IP address to - check against the list of local IP addresses or domains. + check against the list of local IP addresses or domains, matching + as well the port and protocol if they are provided. The parameter value can contain pseudo-variables. </para> </listitem> @@ -376,6 +377,37 @@ if(is_myself("$fu")) { ... } ... +</programlisting> + </example> + </section> + <section id="kex.f.is_myhost"> + <title><function moreinfo="none">is_myhost(uri)</function></title> + <para> + Check if the host part of the parameter matches a local domain + or IP address. + </para> + <para>Meaning of the parameters is as follows:</para> + <itemizedlist> + <listitem> + <para> + <emphasis>uri</emphasis> - Valid SIP URI, hostname of IP address to + check against the list of local IP addresses or domains. If it + is a SIP URI, the port and protocol are ignored. + The parameter value can contain pseudo-variables. + </para> + </listitem> + </itemizedlist> + <para> + This function can be used from ANY_ROUTE. + </para> + <example> + <title><function>is_myhost</function> usage</title> + <programlisting format="linespecific"> +... +if(is_myhost("$tu")) { + ... +} +... </programlisting> </example> </section> @@ -992,4 +1024,3 @@ Module: kex </section> </chapter> -

1 0

git:master:aaec01e0: kex: added is_myhost(uri) - check if host part only is local
by Daniel-Constantin Mierla 18 Jan '24

18 Jan '24

Module: kamailio Branch: master Commit: aaec01e0556bf6148ec50795f896af71f9680a70 URL: https://github.com/kamailio/kamailio/commit/aaec01e0556bf6148ec50795f896af7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-01-18T09:29:21+01:00 kex: added is_myhost(uri) - check if host part only is local - similar to is_myself() but ignores the port and protocol --- Modified: src/modules/kex/kex_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/aaec01e0556bf6148ec50795f896af7… Patch: https://github.com/kamailio/kamailio/commit/aaec01e0556bf6148ec50795f896af7… --- diff --git a/src/modules/kex/kex_mod.c b/src/modules/kex/kex_mod.c index 452639c3cbd..4a1047acb2a 100644 --- a/src/modules/kex/kex_mod.c +++ b/src/modules/kex/kex_mod.c @@ -50,6 +50,7 @@ MODULE_VERSION /** module functions */ int w_is_myself(struct sip_msg *msg, char *uri, str *s2); +int w_is_myhost(struct sip_msg *msg, char *uri, str *s2); int w_setdebug(struct sip_msg *msg, char *level, str *s2); int w_resetdebug(struct sip_msg *msg, char *uri, str *s2); @@ -96,6 +97,8 @@ static cmd_export_t cmds[] = { ANY_ROUTE}, {"is_myself", (cmd_function)w_is_myself, 1, fixup_spve_null, fixup_free_spve_null, ANY_ROUTE}, + {"is_myhost", (cmd_function)w_is_myhost, 1, fixup_spve_null, + fixup_free_spve_null, ANY_ROUTE}, {"setdebug", (cmd_function)w_setdebug, 1, fixup_igp_null, fixup_free_igp_null, ANY_ROUTE}, {"resetdebug", (cmd_function)w_resetdebug, 0, 0, 0, ANY_ROUTE}, @@ -188,6 +191,35 @@ int w_is_myself(struct sip_msg *msg, char *uri, str *s2) return 1; } +/** + * + */ +int w_is_myhost(struct sip_msg *msg, char *uri, str *s2) +{ + int ret; + str suri; + struct sip_uri puri; + + if(fixup_get_svalue(msg, (gparam_p)uri, &suri) != 0) { + LM_ERR("cannot get the URI parameter\n"); + return -1; + } + if(suri.len > 4 + && (strncmp(suri.s, "sip:", 4) == 0 + || strncmp(suri.s, "sips:", 5) == 0)) { + if(parse_uri(suri.s, suri.len, &puri) != 0) { + LM_ERR("failed to parse uri [%.*s]\n", suri.len, suri.s); + return -1; + } + ret = check_self(&puri.host, 0, 0); + } else { + ret = check_self(&suri, 0, 0); + } + if(ret != 1) + return -1; + return 1; +} + int w_setdebug(struct sip_msg *msg, char *level, str *s2) { int lval = 0;

1 0

[kamailio/kamailio] Add support for LoongArch. (PR #3715)
by liuxiang88 18 Jan '24

18 Jan '24

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Add support for LoongArch.The LoongArch architecture (LoongArch) is an Instruction Set Architecture (ISA) that has a RISC style. Documentations: ISA: https://loongson.github.io/LoongArch-Documentation/LoongArch-Vol1-EN.html ABI: https://loongson.github.io/LoongArch-Documentation/LoongArch-ELF-ABI-EN.html More docs can be found at: https://loongson.github.io/LoongArch-Documentation/README-EN.html You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3715 -- Commit Summary -- * Add support for LoongArch. -- File Changes -- M src/modules/app_jsdt/duk_config.h (11) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3715.patch https://github.com/kamailio/kamailio/pull/3715.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3715 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3715(a)github.com>

2 3

Kamailio v5.7.4 Released
by Daniel-Constantin Mierla 18 Jan '24

18 Jan '24

Hello, Kamailio SIP Server v5.7.4 stable release is out. This is a maintenance release of the latest stable branch, 5.7, that includes fixes since the release of v5.7.3. There is no change to database schema or configuration language structure that you have to do on previous installations of v5.7.x. Deployments running previous v5.7.x versions are strongly recommended to be upgraded to v5.7.4. For more details about version 5.7.4 (including links and guidelines to download the tarball or from GIT repository), visit: * https://www.kamailio.org/w/2024/01/kamailio-v5-7-4-released/ RPM, Debian/Ubuntu packages will be available soon as well. Many thanks to all contributing and using Kamailio! Cheers, Daniel -- Daniel-Constantin Mierla (@ asipto.com) twitter.com/miconda -- linkedin.com/in/miconda Kamailio Consultancy, Training and Development Services -- asipto.com Kamailio Advanced Training, February 20-22, 2024 -- asipto.com Kamailio World Conference, April 18-19, 2024, Berlin -- kamailioworld.com

1 0

Help needed with GH CI/CD after pushes to master
by Richard Chan 18 Jan '24

18 Jan '24

Hi devs, The CI/CD seems to be broken after I pushed a few commits to master. There seem to be docker pull errors. Appreciate if someone could take a look. Regards Shih-Ping

2 1

← Newer
1
...
13
14
15
16
17
18
19
...
32
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev January 2024