sr-dev January 2024

sr-dev@lists.kamailio.org

19 participants
311 discussions

[kamailio/kamailio] core/cfg has memory leak if string value is set (#2094)

by Bastian Triller

### Description Setting string values via `cfg_rpc` leaves old strings in SHM. #### Reproduction  Set some string value to e.g. `tm.ac_extra_hdrs`: ```shell x=10 while [ $x -gt 0 ] ; do sudo kamctl rpc cfg.sets tm ac_extra_hdrs das$x >/dev/null sleep 0.001 x=$((x - 1)) done ``` #### Debugging Data After running above snippet four times: ``` sudo kamcmd cfg.set_now_int core mem_dump_shm 1 grep "^Oct 4 15:11:4.* qm_status:.*alloc'd" /var/log/syslog | cut -d: -f6- | sort | uniq -c | sort -n | grep core/cfg/cfg 1 alloc'd from core: core/cfg/cfg_struct.c: cfg_shmize(217) 1 alloc'd from core: core/cfg/cfg_struct.c: sr_cfg_init(322) 1 alloc'd from core: core/cfg/cfg_struct.c: sr_cfg_init(334) 1 alloc'd from core: core/cfg/cfg_struct.c: sr_cfg_init(346) 1 alloc'd from core: core/cfg/cfg_struct.c: sr_cfg_init(353) 1 alloc'd from core: core/cfg/cfg_struct.c: sr_cfg_init(360) 2 alloc'd from core: core/cfg/cfg_ctx.c: cfg_register_ctx(47) 3 alloc'd from core: core/cfg/cfg_struct.c: cfg_clone_global(625) 39 alloc'd from core: core/cfg/cfg_ctx.c: cfg_set_now(559) 40 alloc'd from core: core/cfg/cfg_struct.c: cfg_child_cb_new(828) 42 alloc'd from core: core/cfg/cfg_struct.c: cfg_clone_str(130) sudo kamcmd mod.stats core shm|grep \\bcfg_ cfg_clone_global(625): 1392 cfg_set_now(559): 624 cfg_clone_str(130): 384 cfg_shmize(217): 696 cfg_register_ctx(47): 64 cfg_child_cb_new(828): 2560 ``` memory values from cfg_clone_str addresses: ``` grep -B1 'Oct 4 15:11:4.*cfg_clone_str' /var/log/syslog|sed '/address=/!d' | cut -d: -f6- 55. N address=0x7f1310eab7f8 frag=0x7f1310eab7c0 size=40 used=1 56. N address=0x7f1310eab888 frag=0x7f1310eab850 size=24 used=1 62. N address=0x7f1310ec7b10 frag=0x7f1310ec7ad8 size=8 used=1 65. N address=0x7f1310ec7ca0 frag=0x7f1310ec7c68 size=8 used=1 68. N address=0x7f1310ec7e30 frag=0x7f1310ec7df8 size=8 used=1 69. N address=0x7f1310ec7ea0 frag=0x7f1310ec7e68 size=8 used=1 72. N address=0x7f1310ec8030 frag=0x7f1310ec7ff8 size=8 used=1 75. N address=0x7f1310ec81c0 frag=0x7f1310ec8188 size=8 used=1 78. N address=0x7f1310ec8350 frag=0x7f1310ec8318 size=8 used=1 81. N address=0x7f1310ec84e0 frag=0x7f1310ec84a8 size=8 used=1 84. N address=0x7f1310ec8670 frag=0x7f1310ec8638 size=8 used=1 87. N address=0x7f1310ec8800 frag=0x7f1310ec87c8 size=8 used=1 90. N address=0x7f1310ec8990 frag=0x7f1310ec8958 size=8 used=1 93. N address=0x7f1310ec8b20 frag=0x7f1310ec8ae8 size=8 used=1 96. N address=0x7f1310ec8cb0 frag=0x7f1310ec8c78 size=8 used=1 99. N address=0x7f1310ec8e40 frag=0x7f1310ec8e08 size=8 used=1 103. N address=0x7f1310ec92f0 frag=0x7f1310ec92b8 size=8 used=1 106. N address=0x7f1310ec9480 frag=0x7f1310ec9448 size=8 used=1 109. N address=0x7f1310ec9610 frag=0x7f1310ec95d8 size=8 used=1 112. N address=0x7f1310ec97a0 frag=0x7f1310ec9768 size=8 used=1 115. N address=0x7f1310ec9930 frag=0x7f1310ec98f8 size=8 used=1 118. N address=0x7f1310ec9ac0 frag=0x7f1310ec9a88 size=8 used=1 121. N address=0x7f1310ec9c50 frag=0x7f1310ec9c18 size=8 used=1 124. N address=0x7f1310ec9de0 frag=0x7f1310ec9da8 size=8 used=1 127. N address=0x7f1310ec9f70 frag=0x7f1310ec9f38 size=8 used=1 131. N address=0x7f1310eca420 frag=0x7f1310eca3e8 size=8 used=1 134. N address=0x7f1310eca5b0 frag=0x7f1310eca578 size=8 used=1 137. N address=0x7f1310eca740 frag=0x7f1310eca708 size=8 used=1 140. N address=0x7f1310eca8d0 frag=0x7f1310eca898 size=8 used=1 144. N address=0x7f1310ecad80 frag=0x7f1310ecad48 size=8 used=1 147. N address=0x7f1310ecaf10 frag=0x7f1310ecaed8 size=8 used=1 150. N address=0x7f1310ecb0a0 frag=0x7f1310ecb068 size=8 used=1 153. N address=0x7f1310ecb230 frag=0x7f1310ecb1f8 size=8 used=1 156. N address=0x7f1310ecb3c0 frag=0x7f1310ecb388 size=8 used=1 159. N address=0x7f1310ecb550 frag=0x7f1310ecb518 size=8 used=1 162. N address=0x7f1310ecb6e0 frag=0x7f1310ecb6a8 size=8 used=1 165. N address=0x7f1310ecb870 frag=0x7f1310ecb838 size=8 used=1 168. N address=0x7f1310ecba00 frag=0x7f1310ecb9c8 size=8 used=1 172. N address=0x7f1310ecbeb0 frag=0x7f1310ecbe78 size=8 used=1 175. N address=0x7f1310ecc040 frag=0x7f1310ecc008 size=8 used=1 178. N address=0x7f1310ecc1d0 frag=0x7f1310ecc198 size=8 used=1 181. N address=0x7f1310ecc360 frag=0x7f1310ecc328 size=8 used=1 0x7f1310eab7f8: "trying -- your call is important to us" 0x7f1310eab888: "Server Internal Error" 0x7f1310ec7b10: "das10" 0x7f1310ec7ca0: "das9" 0x7f1310ec7e30: "das10" 0x7f1310ec7ea0: "das10" 0x7f1310ec8030: "das9" 0x7f1310ec81c0: "das9" 0x7f1310ec8350: "das8" 0x7f1310ec84e0: "das7" 0x7f1310ec8670: "das6" 0x7f1310ec8800: "das5" 0x7f1310ec8990: "das4" 0x7f1310ec8b20: "das3" 0x7f1310ec8cb0: "das2" 0x7f1310ec8e40: "das1" 0x7f1310ec92f0: "das10" 0x7f1310ec9480: "das9" 0x7f1310ec9610: "das8" 0x7f1310ec97a0: "das7" 0x7f1310ec9930: "das6" 0x7f1310ec9ac0: "das5" 0x7f1310ec9c50: "das4" 0x7f1310ec9de0: "das3" 0x7f1310ec9f70: "das2" 0x7f1310eca420: "das1" 0x7f1310eca5b0: "das8" 0x7f1310eca740: "das7" 0x7f1310eca8d0: "das6" 0x7f1310ecad80: "das5" 0x7f1310ecaf10: "das4" 0x7f1310ecb0a0: "das3" 0x7f1310ecb230: "das2" 0x7f1310ecb3c0: "das1" 0x7f1310ecb550: "das8" 0x7f1310ecb6e0: "das7" 0x7f1310ecb870: "das6" 0x7f1310ecba00: "das5" 0x7f1310ecbeb0: "das4" 0x7f1310ecc040: "das3" 0x7f1310ecc1d0: "das2" 0x7f1310ecc360: "das1" ``` ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` /usr/sbin/kamailio -v version: kamailio 5.2.4 (x86_64/linux) flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 6.3.0 ``` * **Operating System**: ``` Debian 9.11 ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2094

11 months, 2 weeks

git:5.7:784bb3b3: tls: set parameter name for tls_h_mod_randctx()

by Elena-Ramona Modroiu

Module: kamailio Branch: 5.7 Commit: 784bb3b397cc1922d06054c611c443dd19216504 URL: https://github.com/kamailio/kamailio/commit/784bb3b397cc1922d06054c611c443d… Author: Elena-Ramona Modroiu <anomarme(a)users.noreply.github.com> Committer: Elena-Ramona Modroiu <anomarme(a)gmail.com> Date: 2024-01-16T16:13:19+01:00 tls: set parameter name for tls_h_mod_randctx() - without it fails to compile on Unbuntu 22.04 with low latency kernel (cherry picked from commit 03456e5e5983e2236b8e182cf3317d14ebf34e18) --- Modified: src/modules/tls/tls_init.c --- Diff: https://github.com/kamailio/kamailio/commit/784bb3b397cc1922d06054c611c443d… Patch: https://github.com/kamailio/kamailio/commit/784bb3b397cc1922d06054c611c443d… --- diff --git a/src/modules/tls/tls_init.c b/src/modules/tls/tls_init.c index 629f69ad6b3..1c6b19f560e 100644 --- a/src/modules/tls/tls_init.c +++ b/src/modules/tls/tls_init.c @@ -737,7 +737,8 @@ int tls_pre_init(void) * left here in case more complex requirements arise in * OpenSSL >= 3.2. */ -long tls_h_mod_randctx(void *) { +long tls_h_mod_randctx(void *param) +{ do { OSSL_LIB_CTX *osslglobal = NULL; EVP_RAND_CTX *randctx = NULL;

11 months, 2 weeks

git:master:03456e5e: tls: set parameter name for tls_h_mod_randctx()

by GitHub

Module: kamailio Branch: master Commit: 03456e5e5983e2236b8e182cf3317d14ebf34e18 URL: https://github.com/kamailio/kamailio/commit/03456e5e5983e2236b8e182cf3317d1… Author: Elena-Ramona Modroiu <anomarme(a)users.noreply.github.com> Committer: GitHub <noreply(a)github.com> Date: 2024-01-16T16:07:43+01:00 tls: set parameter name for tls_h_mod_randctx() - without it fails to compile on Unbuntu 22.04 with low latency kernel --- Modified: src/modules/tls/tls_init.c --- Diff: https://github.com/kamailio/kamailio/commit/03456e5e5983e2236b8e182cf3317d1… Patch: https://github.com/kamailio/kamailio/commit/03456e5e5983e2236b8e182cf3317d1… --- diff --git a/src/modules/tls/tls_init.c b/src/modules/tls/tls_init.c index bb1d0f19207..6992d4a65e2 100644 --- a/src/modules/tls/tls_init.c +++ b/src/modules/tls/tls_init.c @@ -739,7 +739,8 @@ int tls_pre_init(void) * left here in case more complex requirements arise in * OpenSSL >= 3.2. */ -long tls_h_mod_randctx(void *) { +long tls_h_mod_randctx(void *param) +{ do { OSSL_LIB_CTX *osslglobal = NULL; EVP_RAND_CTX *randctx = NULL;

11 months, 2 weeks

git: new commits in branch 5.7

by Daniel-Constantin Mierla

- URL: https://github.com/kamailio/kamailio/commit/18fead63dca0982df500b35b7c4e2d0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-01-16T11:10:53+01:00 core: set proto on fixing forward actions (cherry picked from commit e51ccd11fe51f2d53dd7719b8fdec561a6ba7494) - URL: https://github.com/kamailio/kamailio/commit/065203150aaf2f99bd6fe40ce5ffb96… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-01-16T11:16:40+01:00 dialog: prevent duplicate of leg1 attributes in json for dmq - reported by #3656 (cherry picked from commit ca7e1e49aecd3e0f12cc783e3b97868980f1d3d2) - URL: https://github.com/kamailio/kamailio/commit/3046d01bed4bdd0fe763fd770ffc8f7… Author: Pe��ter Baraba��s <peter.barabas(a)securesoft.hu> Date: 2024-01-16T11:18:24+01:00 uac: fix socket length settings - set _uac_req.s_sock.len value to 0 in pv_set_uac_req() method in case of "all" case - change setting of _uac_req.s_apasswd.len to _uac_req.s_sock.len in pv_set_uac_req() method in case of "sock" case (cherry picked from commit 10519d199f6cac116399f4473bd82f2b08de72ba) - URL: https://github.com/kamailio/kamailio/commit/81dce4e5003f3c00301671144ac6787… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-01-16T11:20:20+01:00 core: xavp - info long when skipping serializing a field (cherry picked from commit 5d97afefd2a8f53072a36b6eb8927c180fb984c9) - URL: https://github.com/kamailio/kamailio/commit/37621005e38a0191a93fbaf4f39b8b8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-01-16T11:21:55+01:00 dialog: check first the size (cherry picked from commit 9db18bc48bff0d230e66973a45c8e72e1b7744e8) - URL: https://github.com/kamailio/kamailio/commit/1189bb2962dd80c21a1d497125f3199… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-01-16T11:23:24+01:00 tm: check get_t() result for consistency (cherry picked from commit 1191ab4e5e03b35714ec1ad9d9bf2dd9665c71fd) - URL: https://github.com/kamailio/kamailio/commit/0712576dc4d57ba41e45012486dd206… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-01-16T11:23:49+01:00 registrar: check returned branch pointer (cherry picked from commit 5d641f56fc1bc342d9be008ecd96959e114fef66) - URL: https://github.com/kamailio/kamailio/commit/62b76c076ff0f36b847a13c180b7d50… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-01-16T11:24:10+01:00 core: check if conversion could not be done (cherry picked from commit 077651fa3bfd50e0f654c907f3783b1421497bd5) - URL: https://github.com/kamailio/kamailio/commit/4371adffc07bb555e2a52dedd6cd5af… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-01-16T11:24:20+01:00 app_python3: check allocated pointer (cherry picked from commit 49b3b90cd229b7c4da06b61cdfd782450d383cc9) - URL: https://github.com/kamailio/kamailio/commit/0ca30e87655798e3841c005abb63ca6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-01-16T11:24:53+01:00 core: srjson - init vars and check scanned values (cherry picked from commit 678b1a68de86d9539adeaf0262d9735b8d435077) - URL: https://github.com/kamailio/kamailio/commit/2d385c1983a921a95fb392e8aea0332… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-01-16T11:25:18+01:00 pv: typo in transformation log message (cherry picked from commit ca2a9479adf720e67bf50c9d2795cc8937e223dc) - URL: https://github.com/kamailio/kamailio/commit/5a26d9e9fba36a49a93bb3b88683661… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-01-16T11:25:38+01:00 pv: removed unnecessary condition (cherry picked from commit 2f43510be37c157f800389dfb432b6c52d7435a7) - URL: https://github.com/kamailio/kamailio/commit/916d02d883dc938247576bdf8f5c5b2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-01-16T11:27:30+01:00 tm: make lookup event_route[tm:local-response] only once - related to issue #3064 and PR #3687 (cherry picked from commit 1f5444fd2e25d227ffd70f1087d057a3b8002558) - URL: https://github.com/kamailio/kamailio/commit/6cd8f2acc0601fbd040999d776f15b8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-01-16T11:28:03+01:00 tmx: rework cleaning up on init failure (cherry picked from commit 5192e5d275761ccd1af49d4bf9dd12e1438947b7) - URL: https://github.com/kamailio/kamailio/commit/fc0bd88b55121e3588f5793480f0594… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-01-16T11:28:34+01:00 statsd: use bool type for local variable to match return of function (cherry picked from commit 0186246fce8f0e4bb46b30c05174983cd957a3ba) - URL: https://github.com/kamailio/kamailio/commit/be5b4b160ecff8dc398735fbd28ceb7… Author: Nikolay Ivanuschak <ivanuschak.nikolay(a)gmail.com> Date: 2024-01-16T11:29:08+01:00 core: fixed haproxy protocol parser fixes GH #3683 (cherry picked from commit c5237830f3e7fbeec403a0190471a066081c1117) - URL: https://github.com/kamailio/kamailio/commit/37a07037b6e3485f3ddd1b27b1998af… Author: Dennis Yurasov <dennis-y(a)yandex-team.ru> Date: 2024-01-16T11:29:22+01:00 dialog: fixed saving dialogs on shutdown that are already loaded at startup when using db_mode 3 - The dialogs that loaded at startup are not saved in DB on shutdown, and so not loaded at restart, fixes issue #3669 (cherry picked from commit 2d00ce546bb0852dc1784d5bc2e794d06f919577) - URL: https://github.com/kamailio/kamailio/commit/dc59286c26e9799f86e698a9698c9da… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-01-16T11:31:59+01:00 htable: read rpc number value as long - remove autoconvert for number, it is only for string values - GH #3674 (cherry picked from commit 577fb11010ff61af3c4b567581c0bbc5404654c8) - URL: https://github.com/kamailio/kamailio/commit/2dff6f52d1393cf8eabe714262ec8e5… Author: Federico Cabiddu <federico.cabiddu(a)gmail.com> Date: 2024-01-16T11:32:25+01:00 http_async_client: exit mod_init if tm is not loaded (cherry picked from commit 5a40d1ef1b484c4fc437a3f0183a101241e80313) - URL: https://github.com/kamailio/kamailio/commit/a539ca32ec3a898e354aab90d899b99… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-01-16T11:32:57+01:00 core: keep listen socket even if advertise address does not resolve - the core advertise_address parameter works in the same fashion - previously it was starting by skipping the listen, which resulted in unexpected runtime list of sockets (cherry picked from commit b50036200c5bc09fd2d412a18585b42d63763b27)

11 months, 2 weeks

git:master:14828091: rtp_media_server: use local user for building contact

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 14828091b06dca86c91659d705a4f58a6fead4d3 URL: https://github.com/kamailio/kamailio/commit/14828091b06dca86c91659d705a4f58… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-01-16T13:10:34+01:00 rtp_media_server: use local user for building contact - GH #3380 --- Modified: src/modules/rtp_media_server/rtp_media_server.c --- Diff: https://github.com/kamailio/kamailio/commit/14828091b06dca86c91659d705a4f58… Patch: https://github.com/kamailio/kamailio/commit/14828091b06dca86c91659d705a4f58… --- diff --git a/src/modules/rtp_media_server/rtp_media_server.c b/src/modules/rtp_media_server/rtp_media_server.c index 0026c2e0fff..a41b5715022 100644 --- a/src/modules/rtp_media_server/rtp_media_server.c +++ b/src/modules/rtp_media_server/rtp_media_server.c @@ -408,12 +408,27 @@ static int rms_sip_reply( return 1; } +static str _rms_default_user = str_init("rms"); +static void rms_link_user(str *suri, str *suser) +{ + sip_uri_t puri; + if(parse_uri(suri->s, suri->len, &puri) < 0 || puri.user.s == NULL + || puri.user.len <= 0) { + suser->s = _rms_default_user.s; + suser->len = _rms_default_user.len; + return; + } + suser->s = puri.user.s; + suser->len = puri.user.len; +} + static int rms_answer_call( struct cell *cell, rms_dialog_info_t *di, rms_sdp_info_t *sdp_info) { - char buffer[128]; + char buffer[256]; str reason = str_init("OK"); str contact_hdr; + str luser; if(di->state == RMS_ST_CONNECTED) { return 1; } @@ -428,9 +443,10 @@ static int rms_answer_call( sdp_info->local_ip.s = di->local_ip.s; sdp_info->local_ip.len = di->local_ip.len; - snprintf(buffer, 128, - "Contact: <sip:rms@%s:%d>\r\nContent-Type: application/sdp\r\n", - di->local_ip.s, di->local_port); + rms_link_user(&di->local_uri, &luser); + snprintf(buffer, 256, + "Contact: <sip:%.*s@%s:%d>\r\nContent-Type: application/sdp\r\n", + luser.len, luser.s, di->local_ip.s, di->local_port); contact_hdr.len = strlen(buffer); contact_hdr.s = buffer; @@ -592,6 +608,7 @@ static int rms_bridging_call(rms_dialog_info_t *di, rms_action_t *a) int result; str method_invite = str_init("INVITE"); str headers; + str luser; struct sip_uri ruri_t; str *param_uri = &a->param; @@ -609,10 +626,11 @@ static int rms_bridging_call(rms_dialog_info_t *di, rms_action_t *a) goto error; } + rms_link_user(&di->local_uri, &luser); snprintf(buff, 256, "Max-Forwards: 70\r\nContact: " - "<sip:rms@%s:%d>\r\nContent-Type: application/sdp\r\n", - di->local_ip.s, di->local_port); + "<sip:%.*s@%s:%d>\r\nContent-Type: application/sdp\r\n", + luser.len, luser.s, di->local_ip.s, di->local_port); headers.len = strlen(buff); headers.s = buff; LM_INFO("si[%p]call-id[%.*s]cseq[%d]ruri[%d|%s]remote_uri[%s]local_uri[%s]" @@ -997,6 +1015,7 @@ static int rms_sip_forward( int result; str headers; char buff[1024]; + str luser; if(!rms_create_trans(msg)) return 0; @@ -1020,10 +1039,11 @@ static int rms_sip_forward( return 0; } + rms_link_user(&di->local_uri, &luser); snprintf(buff, 256, "Max-Forwards: 70\r\nContact: " - "<sip:rms@%s:%d>\r\nContent-Type: application/sdp\r\n", - di->local_ip.s, di->local_port); + "<sip:%.*s@%s:%d>\r\nContent-Type: application/sdp\r\n", + luser.len, luser.s, di->local_ip.s, di->local_port); headers.len = strlen(buff); headers.s = buff;

11 months, 2 weeks

[kamailio/kamailio] dmq_usrloc not replicating contact attributes (#1968)

by pwakano

### Description  The dmq_usrloc module is not replicating the extra attributes saved in the xavp for the contact. So remote nodes don't receive these values, being unable to access it properly. It is expected that the attributes are replicated as well. #### Reproduction  Setup two nodes using the dmq_usrloc and usrloc in db_mode=0. When receiving a REGISTER, before saving the contact add some attribute in the xavp_contact. In a subsequent message to this contact (e.g.: INVITE) use a lookup() or registered() and try to access the desired xavp_contact attribute. If the request is received in the local node (which received the original REGISTER), the attribute will be valid, but if the request is received in the remote node, the attribute is empty. #### Log Messages  ``` May 29 16:06:18 kamailio-2 /usr/sbin/kamailio[23230]: DEBUG: registrar [save.c:410]: pack_ci(): generated ruid is: uloc-5cee2114-5abe-2 May 29 16:06:18 kamailio-2 /usr/sbin/kamailio[23230]: DEBUG: usrloc [ucontact.c:73]: ucontact_xavp_store(): trying to clone per contact xavps May 29 16:06:18 kamailio-2 /usr/sbin/kamailio[23230]: DEBUG: <core> [core/xavp.c:697]: xavp_clone_level_nodata(): cloned root xavp [ulattrs] May 29 16:06:18 kamailio-2 /usr/sbin/kamailio[23230]: DEBUG: <core> [core/xavp.c:721]: xavp_clone_level_nodata(): cloned inner xavp [cluster_node] May 29 16:06:18 kamailio-2 /usr/sbin/kamailio[23230]: DEBUG: usrloc [ucontact.c:1701]: update_ucontact(): exists callback for type= UL_CONTACT_UPDATE May 29 16:06:18 kamailio-2 /usr/sbin/kamailio[23230]: DEBUG: usrloc [ul_callback.h:84]: run_ul_callbacks(): contact=0x7f51b624d418, callback type 2/15, id 1 entered May 29 16:06:18 kamailio-2 /usr/sbin/kamailio[23230]: DEBUG: dmq_usrloc [usrloc_sync.c:776]: dmq_ul_cb_contact(): Callback from usrloc with type=2 May 29 16:06:18 kamailio-2 /usr/sbin/kamailio[23230]: DEBUG: dmq_usrloc [usrloc_sync.c:427]: init_usrloc_dmq_recv(): Initializing usrloc_dmq_recv for pid (23230) May 29 16:06:18 kamailio-2 /usr/sbin/kamailio[23230]: DEBUG: dmq_usrloc [usrloc_sync.c:785]: dmq_ul_cb_contact(): Replicating local update to other nodes... May 29 16:06:18 kamailio-2 /usr/sbin/kamailio[23230]: DEBUG: dmq_usrloc [usrloc_sync.c:746]: usrloc_dmq_send_contact(): sending serialized data {"action":1,"aor":"345671002","ruid":"uloc-5cee20df-5953-1","c":"sip:345671002@172.28.128.200:5060;rinstance=38e53fed7e84e081;transport=UDP","received":"","path":"<sip:172.28.128.102:5060;received=sip:172.28.128.200:5060;lr>","callid":"NOeeFh1Bh5JR0eJG8DENkg..","user_agent":"Z 3.15.40006 rv2.8.20","instance":"","expires":1559110577,"cseq":12,"flags":0,"cflags":3072,"q":-1,"last_modified":1559109977,"methods":4294967295,"reg_id":0,"server_id":0} May 29 16:06:18 kamailio-2 /usr/sbin/kamailio[23230]: DEBUG: dmq_usrloc [usrloc_sync.c:315]: usrloc_dmq_send(): sending dmq broadcast... ``` ### Possible Solutions  Only workaround seems to use usrloc with db_mode=3 and then not use the dmq_usrloc, having the usrloc with attributes info shared via the DB.... ### Additional Information Kamailio 5.2.2 installed from the repo. ``` # kamailio -v version: kamailio 5.2.2 (x86_64/linux) 67f967 flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 67f967 compiled on 11:40:41 Mar 11 2019 with gcc 4.8.5 ``` * **Operating System**:  ``` # cat /etc/centos-release CentOS Linux release 7.3.1611 (Core) # uname -a Linux kamailio-2 3.10.0-514.21.2.el7.x86_64 #1 SMP Tue Jun 20 12:24:47 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1968

11 months, 2 weeks

git:master:167d8af9: core: snexpr - rename some inner blocks variables

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 167d8af9ff1c55804a66cc948670ab1d3069e063 URL: https://github.com/kamailio/kamailio/commit/167d8af9ff1c55804a66cc948670ab1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-01-16T11:03:02+01:00 core: snexpr - rename some inner blocks variables --- Modified: src/core/utils/snexpr.h --- Diff: https://github.com/kamailio/kamailio/commit/167d8af9ff1c55804a66cc948670ab1… Patch: https://github.com/kamailio/kamailio/commit/167d8af9ff1c55804a66cc948670ab1… --- diff --git a/src/core/utils/snexpr.h b/src/core/utils/snexpr.h index cdfe55c45d8..5b159a256e3 100644 --- a/src/core/utils/snexpr.h +++ b/src/core/utils/snexpr.h @@ -1254,10 +1254,10 @@ extern "C" sne_vec_free(&arg.args); goto cleanup; /* first argument is not a variable */ } - struct snexpr_var *v; - for(v = vars->head; v; v = v->next) { - if(v == u->param.var.vref) { - struct macro m = {v->name, arg.args}; + struct snexpr_var *v1; + for(v1 = vars->head; v1; v1 = v1->next) { + if(v1 == u->param.var.vref) { + struct macro m = {v1->name, arg.args}; sne_vec_push(&macros, m); break; } @@ -1284,9 +1284,9 @@ extern "C" char varname[14]; snprintf(varname, sizeof(varname) - 1, "$%d", (j + 1)); - struct snexpr_var *v = snexpr_var_find( + struct snexpr_var *v1 = snexpr_var_find( vars, varname, strlen(varname)); - struct snexpr ev = snexpr_varref(v); + struct snexpr ev = snexpr_varref(v1); struct snexpr assign = snexpr_binary(SNE_OP_ASSIGN, ev, sne_vec_nth(&arg.args, j)); @@ -1409,10 +1409,10 @@ extern "C" cleanup: sne_vec_foreach(&macros, m, i) { - struct snexpr e; - sne_vec_foreach(&m.body, e, j) + struct snexpr e1; + sne_vec_foreach(&m.body, e1, j) { - snexpr_destroy_args(&e); + snexpr_destroy_args(&e1); } sne_vec_free(&m.body); }

11 months, 2 weeks

git:master:6ebe3b61: ss7ops: rename local variable that hides the function parameter

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 6ebe3b612d60e02854c7b88cd241615b50666b00 URL: https://github.com/kamailio/kamailio/commit/6ebe3b612d60e02854c7b88cd241615… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-01-16T11:03:02+01:00 ss7ops: rename local variable that hides the function parameter --- Modified: src/modules/ss7ops/isup_parsed.c --- Diff: https://github.com/kamailio/kamailio/commit/6ebe3b612d60e02854c7b88cd241615… Patch: https://github.com/kamailio/kamailio/commit/6ebe3b612d60e02854c7b88cd241615… --- diff --git a/src/modules/ss7ops/isup_parsed.c b/src/modules/ss7ops/isup_parsed.c index 5ebc2d7f348..75a132435f8 100644 --- a/src/modules/ss7ops/isup_parsed.c +++ b/src/modules/ss7ops/isup_parsed.c @@ -1067,7 +1067,7 @@ static int do_parse( while(opt_left > 0) { uint8_t ie = opt_data[0]; - size_t len; + size_t len1; opt_data += 1; opt_left -= 1; @@ -1078,20 +1078,20 @@ static int do_parse( LM_ERR("ISUP no space for len %zu\n", opt_left); return -1; } - len = opt_data[0]; + len1 = opt_data[0]; opt_left -= 1; opt_data += 1; - if(opt_left < len) { + if(opt_left < len1) { LM_ERR("ISUP no space optional data %zu vs. %zu\n", opt_left, - len); + len1); return -1; } - visitor(ie, opt_data, len, ptr); + visitor(ie, opt_data, len1, ptr); - opt_data += len; - opt_left -= len; + opt_data += len1; + opt_left -= len1; } }

11 months, 2 weeks

auto build failure

by Henning Westerholt

Hello, the kamailio auto build is failing, I noticed after my last commit. But it seems to be related to some docker issue: [...] Starting job container /usr/bin/docker --config /home/runner/work/_temp/.docker_0ae486ca-dcaa-4edb-a953-36dca2bac9d9 login ghcr.io -u henningw --password-stdin /usr/bin/docker --config /home/runner/work/_temp/.docker_0ae486ca-dcaa-4edb-a953-36dca2bac9d9 pull ghcr.io/kamailio/pkg-kamailio-docker:master-sid master-sid: Pulling from kamailio/pkg-kamailio-docker manifest unknown Warning: Docker pull failed with exit code 1, back off 1.515 seconds before retry. /usr/bin/docker --config /home/runner/work/_temp/.docker_0ae486ca-dcaa-4edb-a953-36dca2bac9d9 pull ghcr.io/kamailio/pkg-kamailio-docker:master-sid master-sid: Pulling from kamailio/pkg-kamailio-docker manifest unknown Warning: Docker pull failed with exit code 1, back off 1.58 seconds before retry. /usr/bin/docker --config /home/runner/work/_temp/.docker_0ae486ca-dcaa-4edb-a953-36dca2bac9d9 pull ghcr.io/kamailio/pkg-kamailio-docker:master-sid master-sid: Pulling from kamailio/pkg-kamailio-docker manifest unknown Error: Docker pull failed with exit code 1 Is this an issue from the github infrastructure or some issue in our scripts? Cheers, Henning

11 months, 2 weeks

git:5.7:d411c6ea: dialog: don't send the BYE if dialog is in deleted state (#3714)

by Federico Cabiddu

Module: kamailio Branch: 5.7 Commit: d411c6ea4358e6d9dd367349e877ed5f5bf4bb2f URL: https://github.com/kamailio/kamailio/commit/d411c6ea4358e6d9dd367349e877ed5… Author: Federico Cabiddu <federico.cabiddu(a)gmail.com> Committer: Federico Cabiddu <federico.cabiddu(a)gmail.com> Date: 2024-01-16T09:51:14+01:00 dialog: don't send the BYE if dialog is in deleted state (#3714) (cherry picked from commit 695f155f3a127f0bbe220a6b44a0fc3887e1e4be) --- Modified: src/modules/dialog/dlg_req_within.c --- Diff: https://github.com/kamailio/kamailio/commit/d411c6ea4358e6d9dd367349e877ed5… Patch: https://github.com/kamailio/kamailio/commit/d411c6ea4358e6d9dd367349e877ed5… --- diff --git a/src/modules/dialog/dlg_req_within.c b/src/modules/dialog/dlg_req_within.c index aab22da3c64..fb5f2e51e32 100644 --- a/src/modules/dialog/dlg_req_within.c +++ b/src/modules/dialog/dlg_req_within.c @@ -383,6 +383,14 @@ static inline int send_bye(struct dlg_cell *cell, int dir, str *hdrs) dlg_iuid_t *iuid = NULL; str lhdrs; + /* dialog is already in deleted state, nothing to do */ + if(cell->state == DLG_STATE_DELETED) { + LM_WARN("dlg [%u:%u] with callid %.*s already in deleted state, BYE " + "not sent.\n", + cell->h_entry, cell->h_id, cell->callid.len, cell->callid.s); + return 0; + } + /* Send Cancel or final response for non-confirmed dialogs */ if(cell->state != DLG_STATE_CONFIRMED_NA && cell->state != DLG_STATE_CONFIRMED) {

11 months, 2 weeks

← Newer
1
...
15
16
17
18
19
20
21
...
32
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev January 2024