sr-dev January 2024

sr-dev@lists.kamailio.org

19 participants
311 discussions

[kamailio/kamailio] Silence “make: --libs: No such file or directory” warnings (PR #3475)

by Дилян Палаузов

With GNU make 4.4 building Kamailio prints many “make: --libs: No such file or directory” and similar warnings. This changeset utilizes immediate variables and silences the warnings on my systems. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3475 -- Commit Summary -- * lib/ims: Aviod “make: --libs: No such file or directory” warnings * auth_identity: Aviod “make: --libs: No such file or directory” warnings * auth_ephemeral: Aviod “make: --libs: No such file or directory” warnings * app_python3: Avoid “/bin/sh: line 1: --ldflags: command not found” warnings * app_python3s: Avoid “/bin/sh: line 1: --ldflags: command not found” warnings * cdp: Aviod “make: --libs: No such file or directory” warnings * cnxcc: Avoid “make: --libs-only-L: No such file or directory” warnings * cplc: Avoid “make: --libs-only-L: No such file or directory” warnings * crypto: Aviod “make: --libs: No such file or directory” warnings * db_postgres: Avoid “make: --libs-only-L: No such file or directory” warnings * db_redis: Avoid “make: --libs-only-L: No such file or directory” warning * dialplan: Avoid “make: --libs-only-L: No such file or directory” warning * gzcompress: Aviod “make: --libs: No such file or directory” warnings * http_async_client: Aviod “make: --libs: No such file or directory” warnings * http_client: Aviod “make: --libs: No such file or directory” warning * ims_auth: Avoid “make: --libs-only-L: No such file or directory” warning * ims_icscf: Aviod “make: --libs: No such file or directory” warning * ims_registrar_scscf: Avoid “make: --libs-only-L: No such file or directory” warnings * ims_registrar_pcscf: Aviod “make: --libs: No such file or directory” warning * ims_isc: Avoid “make: --libs-only-L: No such file or directory” warnings * jansson: Aviod “make: --libs: No such file or directory” warning * kazoo: Avoid “make: --libs: No such file or directory’ warning * lcr: Aviod “make: --libs: No such file or directory” warning * log_systemd: Aviod “make: --libs: No such file or directory” warning * lost: Aviod “make: --libs: No such file or directory” warnings * lwsc: Aviod “make: --libs: No such file or directory” warning * ndb_redis: Aviod “make: --libs: No such file or directory” warning * osp: Avoid “make: --libs: No such file or directory’ warning * outbound: Aviod “make: --libs: No such file or directory” warnings * presence: Avoid “make: --libs-only-L: No such file or directory” warnings * presence_conference: Aviod “make: --libs: No such file or directory” warning * presence_dialog: Aviod “make: --libs: No such file or directory” warning * presence_reginfo: Aviod “make: --libs: No such file or directory” warning * presence_xml: Avoid “make: --libs-only-L: No such file or directory” warnings * pua: Avoid “make: --libs-only-L: No such file or directory” warnings * pua_bla: Aviod “make: --libs: No such file or directory” warning * pua_dialoginfo: Aviod “make: --libs: No such file or directory” warning * pua_reginfo: Aviod “make: --libs: No such file or directory” warning * pua_usrloc: Aviod “make: --libs: No such file or directory” warning * pua_xmpp: Aviod “make: --libs: No such file or directory” warning * regex: Aviod “make: --libs: No such file or directory” warning * rls: Avoid “make: --libs-only-L: No such file or directory” warnings * slack: Aviod “make: --libs: No such file or directory” warning * systemdops: Avoid “make: --libs-only-L: No such file or directory” warning * tls: Aviod “make: --libs: No such file or directory” warnings * tlsa: Avoid “make: --libs-only-L: No such file or directory” warning * topos_redis: Aviod “make: --libs: No such file or directory” warning * utils: Avoid “make: --libs-only-L: No such file or directory” warnings * uuid: Aviod “make: --libs: No such file or directory” warning * websocket: Aviod “make: --libs: No such file or directory” warnings * xcap_server: Avoid “make: --libs-only-L: No such file or directory” warnings * xhttp_pi: Avoid “make: --libs-only-L: No such file or directory” warnings * xmlops: Aviod “make: --libs: No such file or directory” warning * xmlrpc: Aviod “make: --libs: No such file or directory” warning -- File Changes -- M src/lib/ims/Makefile (4) M src/modules/app_python3/Makefile (6) M src/modules/app_python3s/Makefile (6) M src/modules/auth_ephemeral/Makefile (2) M src/modules/auth_identity/Makefile (4) M src/modules/cdp/Makefile (4) M src/modules/cnxcc/Makefile (4) M src/modules/cplc/Makefile (4) M src/modules/crypto/Makefile (2) M src/modules/db_postgres/Makefile (2) M src/modules/db_redis/Makefile (2) M src/modules/dialplan/Makefile (2) M src/modules/gzcompress/Makefile (2) M src/modules/http_async_client/Makefile (6) M src/modules/http_client/Makefile (2) M src/modules/ims_auth/Makefile (4) M src/modules/ims_icscf/Makefile (4) M src/modules/ims_isc/Makefile (4) M src/modules/ims_registrar_pcscf/Makefile (4) M src/modules/ims_registrar_scscf/Makefile (4) M src/modules/jansson/Makefile (2) M src/modules/kazoo/Makefile (2) M src/modules/lcr/Makefile (2) M src/modules/log_systemd/Makefile (2) M src/modules/lost/Makefile (6) M src/modules/lwsc/Makefile (2) M src/modules/ndb_redis/Makefile (2) M src/modules/osp/Makefile (2) M src/modules/outbound/Makefile (7) M src/modules/presence/Makefile (4) M src/modules/presence_conference/Makefile (4) M src/modules/presence_dialoginfo/Makefile (4) M src/modules/presence_reginfo/Makefile (4) M src/modules/presence_xml/Makefile (4) M src/modules/pua/Makefile (4) M src/modules/pua_bla/Makefile (4) M src/modules/pua_dialoginfo/Makefile (4) M src/modules/pua_reginfo/Makefile (4) M src/modules/pua_usrloc/Makefile (4) M src/modules/pua_xmpp/Makefile (4) M src/modules/regex/Makefile (2) M src/modules/rls/Makefile (4) M src/modules/slack/Makefile (2) M src/modules/systemdops/Makefile (2) M src/modules/tls/Makefile (4) M src/modules/tlsa/Makefile (4) M src/modules/topos_redis/Makefile (2) M src/modules/utils/Makefile (4) M src/modules/uuid/Makefile (2) M src/modules/websocket/Makefile (2) M src/modules/xcap_server/Makefile (4) M src/modules/xhttp_pi/Makefile (4) M src/modules/xmlops/Makefile (4) M src/modules/xmlrpc/Makefile (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3475.patch https://github.com/kamailio/kamailio/pull/3475.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3475 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3475(a)github.com>

11 months

[kamailio/kamailio] cfgt: doesn't support tm_suspend() tm_continue() (#684)

by Victor Seva

Actual implementation doesn't work with async. Need to investigate how to support it --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/684

11 months

[kamailio/kamailio] github: [skip ci]: bump tj-actions/changed-files from 41 to 42 (PR #3724)

by dependabot[bot]

Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 41 to 42. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/tj-actions/changed-files/releases">tj… releases</a>.</em></p> <blockquote> <h2>v42</h2> <h1>Changes in v42.0.0</h1> <h2>🔥🔥 BREAKING CHANGE 🔥🔥</h2> <ul> <li>Input file patterns that end with a <code>/</code> would now match all sub-files within the directory without requiring you to specify the globstar pattern.</li> </ul> <h3></h3> <pre lang="yaml"><code>... - name: Get changed files id: changed-files uses: tj-actions/changed-files@v42 with: files: 'dir/' # Would also be the same as dir/** </code></pre> <h2>What's Changed</h2> <ul> <li>Upgraded to v41.1.2 by <a href="https://github.com/tj-actions-bot"><code>@tj-acti… in <a href="https://redirect.github.com/tj-actions/changed-files/pull/1869&q… <li>chore(deps): update dependency prettier to v3.2.4 by <a href="https://github.com/renovate"><code>@renovate</… in <a href="https://redirect.github.com/tj-actions/changed-files/pull/1871&q… <li>fix: update input warning by <a href="https://github.com/jackton1"><code>@jackton1</… in <a href="https://redirect.github.com/tj-actions/changed-files/pull/1870&q… <li>rename: unsupported REST API inputs constant name by <a href="https://github.com/jackton1"><code>@jackton1</… in <a href="https://redirect.github.com/tj-actions/changed-files/pull/1872&q… <li>feat: add support for include/exclude all nested files when a directory is specified and ends with a slash by <a href="https://github.com/jackton1"><code>@jackton1</… in <a href="https://redirect.github.com/tj-actions/changed-files/pull/1873&q… </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/tj-actions/changed-files/compare/v41...v42.0.… <hr /> <h2>v42.0.0</h2> <h2>🔥🔥 BREAKING CHANGE 🔥🔥</h2> <ul> <li>Input file patterns that end with a <code>/</code> would now match all sub-files within the directory without requiring you to specify the globstar pattern.</li> </ul> <h3></h3> <pre lang="yaml"><code>... - name: Get changed files id: changed-files uses: tj-actions/changed-files@v42 with: files: 'dir/' # Would also be the same as dir/** </code></pre> <h2>What's Changed</h2> <ul> <li>Upgraded to v41.1.2 by <a href="https://github.com/tj-actions-bot"><code>@tj-acti… in <a href="https://redirect.github.com/tj-actions/changed-files/pull/1869&q… <li>chore(deps): update dependency prettier to v3.2.4 by <a href="https://github.com/renovate"><code>@renovate</… in <a href="https://redirect.github.com/tj-actions/changed-files/pull/1871&q… <li>fix: update input warning by <a href="https://github.com/jackton1"><code>@jackton1</… in <a href="https://redirect.github.com/tj-actions/changed-files/pull/1870&q… <li>rename: unsupported REST API inputs constant name by <a href="https://github.com/jackton1"><code>@jackton1</… in <a href="https://redirect.github.com/tj-actions/changed-files/pull/1872&q… <li>feat: add support for include/exclude all nested files when a directory is specified and ends with a slash by <a href="https://github.com/jackton1"><code>@jackton1</… in <a href="https://redirect.github.com/tj-actions/changed-files/pull/1873&q… </ul>  </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/tj-actions/changed-files/blob/main/HISTORY.md… changelog</a>.</em></p> <blockquote> <h1>Changelog</h1> <h1><a href="https://github.com/tj-actions/changed-files/compare/v41.1.2...v4… - (2024-01-18)</h1> <h2>🚀 Features</h2> <ul> <li>Add support for include/exclude all nested files when a directory is specified and ends with a slash (<a href="https://redirect.github.com/tj-actions/changed-files/issues/1873…) (<a href="https://github.com/tj-actions/changed-files/commit/ae82ed4ae0458…) - (Tonye Jack)</li> </ul> <h2>🐛 Bug Fixes</h2> <ul> <li>Update input warning (<a href="https://redirect.github.com/tj-actions/changed-files/issues/1870…) (<a href="https://github.com/tj-actions/changed-files/commit/6c9dcea4432fd…) - (Tonye Jack)</li> </ul> <h2>📝 Rename</h2> <ul> <li>Unsupported REST API inputs constant name (<a href="https://redirect.github.com/tj-actions/changed-files/issues/1872…) (<a href="https://github.com/tj-actions/changed-files/commit/cbd59070e8276…) - (Tonye Jack)</li> </ul> <h2>⚙️ Miscellaneous Tasks</h2> <ul> <li><strong>deps:</strong> Update dependency prettier to v3.2.4 (<a href="https://github.com/tj-actions/changed-files/commit/79b060d445076…) - (renovate[bot])</li> </ul> <h2>⬆️ Upgrades</h2> <ul> <li>Upgraded to v41.1.2 (<a href="https://redirect.github.com/tj-actions/changed-files/issues/1869… </ul> <p>Co-authored-by: jackton1 <a href="mailto:jackton1@users.noreply.github.com">jackton1@users.noreply.github.com</a> (<a href="https://github.com/tj-actions/changed-files/commit/434b67ebc3051…) - (tj-actions[bot])</p> <h1><a href="https://github.com/tj-actions/changed-files/compare/v41.1.1...v4… - (2024-01-17)</h1> <h2>🚀 Features</h2> <ul> <li>Enhance error handling and working directory resolution (<a href="https://redirect.github.com/tj-actions/changed-files/issues/1859…) (<a href="https://github.com/tj-actions/changed-files/commit/a60bf3759e069…) - (Tonye Jack)</li> </ul> <h2>🐛 Bug Fixes</h2> <ul> <li>Bug with incorrect action path (<a href="https://redirect.github.com/tj-actions/changed-files/issues/1866…) (<a href="https://github.com/tj-actions/changed-files/commit/3f8189989ba6f…) - (Tonye Jack)</li> </ul> <h2>⚙️ Miscellaneous Tasks</h2> <ul> <li><strong>deps:</strong> Update dependency <code>@types/node</code> to v20.11.5 (<a href="https://github.com/tj-actions/changed-files/commit/cbda684547adc…) - (renovate[bot])</li> <li><strong>deps:</strong> Update dependency prettier to v3.2.3 (<a href="https://github.com/tj-actions/changed-files/commit/67a1f54f6f5ec…) - (renovate[bot])</li> <li><strong>deps:</strong> Update tj-actions/eslint-changed-files action to v22 (<a href="https://redirect.github.com/tj-actions/changed-files/issues/1864…) (<a href="https://github.com/tj-actions/changed-files/commit/99248a443855d…) - (renovate[bot])</li> <li><strong>deps:</strong> Update dependency <code>@types/node</code> to v20.11.4 (<a href="https://github.com/tj-actions/changed-files/commit/878743189ba0b…) - (renovate[bot])</li> <li><strong>deps:</strong> Update dependency <code>@types/node</code> to v20.11.3 (<a href="https://github.com/tj-actions/changed-files/commit/98d1d84e2f7a4…) - (renovate[bot])</li> <li><strong>deps:</strong> Update typescript-eslint monorepo to v6.19.0 (<a href="https://github.com/tj-actions/changed-files/commit/bc46e4c4222c3…) - (renovate[bot])</li> <li><strong>deps:</strong> Update dependency <code>@types/node</code> to v20.11.2 (<a href="https://github.com/tj-actions/changed-files/commit/fba40673489d4…) - (renovate[bot])</li> <li><strong>deps:</strong> Update dependency <code>@types/node</code> to v20.11.1 (<a href="https://github.com/tj-actions/changed-files/commit/e4b86747326bc…) - (renovate[bot])</li> <li><strong>deps:</strong> Lock file maintenance (<a href="https://github.com/tj-actions/changed-files/commit/bc2b5aef20add…) - (renovate[bot])</li> <li><strong>deps:</strong> Update dependency prettier to v3.2.2 (<a href="https://github.com/tj-actions/changed-files/commit/63c36a563a305…) - (renovate[bot])</li> </ul> <h2>⬆️ Upgrades</h2>  </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/tj-actions/changed-files/commit/ae82ed4ae0458… feat: add support for include/exclude all nested files when a directory is sp...</li> <li><a href="https://github.com/tj-actions/changed-files/commit/cbd59070e8276… rename: unsupported REST API inputs constant name (<a href="https://redirect.github.com/tj-actions/changed-files/issues/1872… <li><a href="https://github.com/tj-actions/changed-files/commit/6c9dcea4432fd… fix: update input warning (<a href="https://redirect.github.com/tj-actions/changed-files/issues/1870… <li><a href="https://github.com/tj-actions/changed-files/commit/79b060d445076… chore(deps): update dependency prettier to v3.2.4</li> <li><a href="https://github.com/tj-actions/changed-files/commit/434b67ebc3051… Upgraded to v41.1.2 (<a href="https://redirect.github.com/tj-actions/changed-files/issues/1869… <li>See full diff in <a href="https://github.com/tj-actions/changed-files/compare/v41...v42&qu… view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?d… Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3724 -- Commit Summary -- * github: [skip ci]: bump tj-actions/changed-files from 41 to 42 -- File Changes -- M .github/workflows/devcontainer.yaml (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3724.patch https://github.com/kamailio/kamailio/pull/3724.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3724 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3724(a)github.com>

11 months

git:master:100d96bf: github: [skip ci]: bump tj-actions/changed-files from 41 to 42

by Victor Seva

Module: kamailio Branch: master Commit: 100d96bf3819082ac38f8a4fae1f3c64c8d0c5e1 URL: https://github.com/kamailio/kamailio/commit/100d96bf3819082ac38f8a4fae1f3c6… Author: dependabot[bot] <49699333+dependabot[bot](a)users.noreply.github.com> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-01-23T01:06:07+01:00 github: [skip ci]: bump tj-actions/changed-files from 41 to 42 Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 41 to 42. - [Release notes](https://github.com/tj-actions/changed-files/releases) - [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md) - [Commits](https://github.com/tj-actions/changed-files/compare/v41...v42) --- updated-dependencies: - dependency-name: tj-actions/changed-files dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support(a)github.com> --- Modified: .github/workflows/devcontainer.yaml --- Diff: https://github.com/kamailio/kamailio/commit/100d96bf3819082ac38f8a4fae1f3c6… Patch: https://github.com/kamailio/kamailio/commit/100d96bf3819082ac38f8a4fae1f3c6… --- diff --git a/.github/workflows/devcontainer.yaml b/.github/workflows/devcontainer.yaml index 1c2a584ed84..2da1e56c742 100644 --- a/.github/workflows/devcontainer.yaml +++ b/.github/workflows/devcontainer.yaml @@ -33,14 +33,14 @@ jobs: - name: Get changed files if: ${{ ! inputs.force }} id: changed-files - uses: tj-actions/changed-files@v41 + uses: tj-actions/changed-files@v42 with: since_last_remote_commit: true - name: changes in relevant files if: ${{ ! inputs.force }} id: changed-files-builder - uses: tj-actions/changed-files@v41 + uses: tj-actions/changed-files@v42 with: files: | .devcontainer/**

11 months

[kamailio/kamailio] TLS related crash in Kamailio 5.7.2 (double free) (Issue #3635)

by Sebastian Damm

### Description We have updated one system from a Ubuntu Focal 5.6.x container to a Ubuntu Jammy 5.7.2 container. In the last 24 hours, we saw three crashes. The logs of the last crash say: ``` Nov 09 20:39:34 sipproxy /usr/sbin/kamailio[4332]: CRITICAL: <core> [core/mem/q_malloc.c:519]: qm_free(): BUG: freeing already freed pointer (0x7f[4434056180](tel:4434056180)), called from tls: tls_init.c: ser_free> Nov 09 20:39:34 sipproxy /usr/sbin/kamailio[4331]: CRITICAL: <core> [core/mem/q_malloc.c:123]: qm_debug_check_frag(): BUG: qm: fragm. 0x7f[44340561](tel:44340561)d0 (address 0x7f[4434056208](tel:4434056208)) beginning overwritten > Nov 09 20:39:43 sipproxy /usr/sbin/kamailio[4273]: ALERT: <core> [main.c:776]: handle_sigs(): child process 4331 exited by a signal 6 Nov 09 20:39:43 sipproxy /usr/sbin/kamailio[4273]: ALERT: <core> [main.c:779]: handle_sigs(): core was generated ``` #### Debugging Data Backtraces of the three crashes are attached. [kamailio-crash1.log](https://github.com/kamailio/kamailio/files/13313115/ka… [kamailio-crash2.log](https://github.com/kamailio/kamailio/files/13313116/ka… [kamailio-crash3.log](https://github.com/kamailio/kamailio/files/13313117/ka… ### Additional Information We are using the official Kamailio debian packages. * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.7.2 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 11.4.0 ``` * **Operating System**:  ``` root@sipproxy:/WORKSPACE/sipproxy-container# lsb_release -a No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 22.04.3 LTS Release: 22.04 Codename: jammy root@sipproxy:/WORKSPACE/sipproxy-container# uname -a Linux sipproxy 5.15.0-87-generic #97-Ubuntu SMP Mon Oct 2 21:09:21 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3635 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3635(a)github.com>

11 months

git:master:569b5364: tm: mark request with final reply flag

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 569b536404afd855742a42320d7c858a8bb4952b URL: https://github.com/kamailio/kamailio/commit/569b536404afd855742a42320d7c858… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-01-22T14:11:29+01:00 tm: mark request with final reply flag - send error function checks flag and returns if set to avoid sending more than one final reply in case of failure --- Modified: src/modules/tm/t_reply.c Modified: src/modules/tm/tm.c --- Diff: https://github.com/kamailio/kamailio/commit/569b536404afd855742a42320d7c858… Patch: https://github.com/kamailio/kamailio/commit/569b536404afd855742a42320d7c858… --- diff --git a/src/modules/tm/t_reply.c b/src/modules/tm/t_reply.c index f52ecc7d3ad..e012dc29c28 100644 --- a/src/modules/tm/t_reply.c +++ b/src/modules/tm/t_reply.c @@ -640,6 +640,11 @@ static int _reply_light(struct cell *trans, char *buf, unsigned int len, * (timer_allow_del()) (there's no chance of having the wait handler * executed while we still need t) --andrei */ put_on_wait(trans); + + /* mark the request with final reply flag */ + if(trans->uas.request != NULL) { + trans->uas.request->msg_flags |= FL_FINAL_REPLY; + } } pkg_free(buf); LM_DBG("finished\n"); diff --git a/src/modules/tm/tm.c b/src/modules/tm/tm.c index 0be958a0848..0147bf44579 100644 --- a/src/modules/tm/tm.c +++ b/src/modules/tm/tm.c @@ -1608,6 +1608,11 @@ int ki_t_reply_error(sip_msg_t *msg) int sip_err; int ret; + if(msg->msg_flags & FL_FINAL_REPLY) { + LM_INFO("message marked with final-reply flag\n"); + return -2; + } + ret = err2reason_phrase( prev_ser_error, &sip_err, err_buffer, sizeof(err_buffer), "TM"); if(ret > 0) {

11 months

git:master:1a2477ba: sl: mark request with final reply flag

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 1a2477ba348928e6bdff15be765cb907e32cffc4 URL: https://github.com/kamailio/kamailio/commit/1a2477ba348928e6bdff15be765cb90… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-01-22T14:02:47+01:00 sl: mark request with final reply flag - send error function checks flag and returns if set to avoid sending more than one final reply in case of failures --- Modified: src/modules/sl/sl.c Modified: src/modules/sl/sl_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/1a2477ba348928e6bdff15be765cb90… Patch: https://github.com/kamailio/kamailio/commit/1a2477ba348928e6bdff15be765cb90… --- diff --git a/src/modules/sl/sl.c b/src/modules/sl/sl.c index 2a8f49fe78c..83eb8bac0d3 100644 --- a/src/modules/sl/sl.c +++ b/src/modules/sl/sl.c @@ -335,6 +335,12 @@ static int w_send_reply(struct sip_msg *msg, char *p1, char *p2) static int ki_send_reply_error(sip_msg_t *msg) { int ret; + + if(msg->msg_flags & FL_FINAL_REPLY) { + LM_INFO("message marked with final-reply flag\n"); + return -2; + } + if(sl_bind_tm != 0 && tmb.t_reply_error != NULL) { ret = tmb.t_reply_error(msg); if(ret > 0) { diff --git a/src/modules/sl/sl_funcs.c b/src/modules/sl/sl_funcs.c index 253686a4a77..29ef6835e22 100644 --- a/src/modules/sl/sl_funcs.c +++ b/src/modules/sl/sl_funcs.c @@ -337,6 +337,10 @@ int sl_reply_helper(struct sip_msg *msg, int code, char *reason, str *tag) goto error; } + if(code >= 200) { + msg->msg_flags |= FL_FINAL_REPLY; + } + update_sl_stats(code); return 1; @@ -408,6 +412,11 @@ int sl_reply_error(struct sip_msg *msg) return -2; } + if(msg->msg_flags & FL_FINAL_REPLY) { + LM_INFO("message marked with final-reply flag\n"); + return -2; + } + ret = err2reason_phrase( prev_ser_error, &sip_error, err_buf, sizeof(err_buf), "SL"); if(ret > 0) {

11 months

git:master:c3b47e0c: core: parser - flag to mark request when a local final reply is sent

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: c3b47e0c5cf4ed405b02aa2d0d4cb31073bab0aa URL: https://github.com/kamailio/kamailio/commit/c3b47e0c5cf4ed405b02aa2d0d4cb31… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-01-22T13:50:08+01:00 core: parser - flag to mark request when a local final reply is sent --- Modified: src/core/parser/msg_parser.h --- Diff: https://github.com/kamailio/kamailio/commit/c3b47e0c5cf4ed405b02aa2d0d4cb31… Patch: https://github.com/kamailio/kamailio/commit/c3b47e0c5cf4ed405b02aa2d0d4cb31… --- diff --git a/src/core/parser/msg_parser.h b/src/core/parser/msg_parser.h index 67650523451..303c8c04248 100644 --- a/src/core/parser/msg_parser.h +++ b/src/core/parser/msg_parser.h @@ -133,6 +133,8 @@ typedef enum request_method /* WARNING: Value (1 << 31) is reserved for use in kamailio * nat_traversal module (flag FL_DO_KEEPALIVE)! */ +#define FL_FINAL_REPLY (1ULL << 32) /* final reply sent */ + #define FL_MTU_FB_MASK (FL_MTU_TCP_FB | FL_MTU_TLS_FB | FL_MTU_SCTP_FB)

11 months

git:master:15aafe49: presence: prefix short global variables

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 15aafe49a6a022809f278f596812c97dc5404982 URL: https://github.com/kamailio/kamailio/commit/15aafe49a6a022809f278f596812c97… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-01-22T13:25:04+01:00 presence: prefix short global variables --- Modified: src/modules/presence/notify.c Modified: src/modules/presence/presence.c Modified: src/modules/presence/presence.h Modified: src/modules/presence/presentity.c Modified: src/modules/presence/subscribe.c Modified: src/modules/presence/utils_func.c --- Diff: https://github.com/kamailio/kamailio/commit/15aafe49a6a022809f278f596812c97… Patch: https://github.com/kamailio/kamailio/commit/15aafe49a6a022809f278f596812c97…

11 months

git:master:7da07508: presence: removed unused external variable

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 7da07508bc74a6a0c87e1dc7993d0061b65e2faa URL: https://github.com/kamailio/kamailio/commit/7da07508bc74a6a0c87e1dc7993d006… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-01-22T13:18:15+01:00 presence: removed unused external variable --- Modified: src/modules/presence/publish.c --- Diff: https://github.com/kamailio/kamailio/commit/7da07508bc74a6a0c87e1dc7993d006… Patch: https://github.com/kamailio/kamailio/commit/7da07508bc74a6a0c87e1dc7993d006… --- diff --git a/src/modules/presence/publish.c b/src/modules/presence/publish.c index 2399ff43e10..fa39498d986 100644 --- a/src/modules/presence/publish.c +++ b/src/modules/presence/publish.c @@ -46,8 +46,6 @@ #include "publish.h" #include "presentity.h" -extern gen_lock_set_t *set; - static str pu_400a_rpl = str_init("Bad request"); static str pu_400b_rpl = str_init("Invalid request"); static str pu_500_rpl = str_init("Server Internal Error"); @@ -713,4 +711,4 @@ int update_hard_presentity( } return ret; -} \ No newline at end of file +}

11 months

← Newer
1
...
10
11
12
13
14
15
16
...
32
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev January 2024