[kamailio/kamailio] Silence “make: --libs: No such file or directory” warnings (PR #3475)
1 Jun
2023
1 Jun
'23
10:42 p.m.
With GNU make 4.4 building Kamailio prints many “make: --libs: No such file or directory”
and similar warnings. This changeset utilizes immediate variables and silences the
warnings on my systems.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3475
-- Commit Summary --
* lib/ims: Aviod “make: --libs: No such file or directory” warnings
* auth_identity: Aviod “make: --libs: No such file or directory” warnings
* auth_ephemeral: Aviod “make: --libs: No such file or directory” warnings
* app_python3: Avoid “/bin/sh: line 1: --ldflags: command not found” warnings
* app_python3s: Avoid “/bin/sh: line 1: --ldflags: command not found” warnings
* cdp: Aviod “make: --libs: No such file or directory” warnings
* cnxcc: Avoid “make: --libs-only-L: No such file or directory” warnings
* cplc: Avoid “make: --libs-only-L: No such file or directory” warnings
* crypto: Aviod “make: --libs: No such file or directory” warnings
* db_postgres: Avoid “make: --libs-only-L: No such file or directory” warnings
* db_redis: Avoid “make: --libs-only-L: No such file or directory” warning
* dialplan: Avoid “make: --libs-only-L: No such file or directory” warning
* gzcompress: Aviod “make: --libs: No such file or directory” warnings
* http_async_client: Aviod “make: --libs: No such file or directory” warnings
* http_client: Aviod “make: --libs: No such file or directory” warning
* ims_auth: Avoid “make: --libs-only-L: No such file or directory” warning
* ims_icscf: Aviod “make: --libs: No such file or directory” warning
* ims_registrar_scscf: Avoid “make: --libs-only-L: No such file or directory” warnings
* ims_registrar_pcscf: Aviod “make: --libs: No such file or directory” warning
* ims_isc: Avoid “make: --libs-only-L: No such file or directory” warnings
* jansson: Aviod “make: --libs: No such file or directory” warning
* kazoo: Avoid “make: --libs: No such file or directory’ warning
* lcr: Aviod “make: --libs: No such file or directory” warning
* log_systemd: Aviod “make: --libs: No such file or directory” warning
* lost: Aviod “make: --libs: No such file or directory” warnings
* lwsc: Aviod “make: --libs: No such file or directory” warning
* ndb_redis: Aviod “make: --libs: No such file or directory” warning
* osp: Avoid “make: --libs: No such file or directory’ warning
* outbound: Aviod “make: --libs: No such file or directory” warnings
* presence: Avoid “make: --libs-only-L: No such file or directory” warnings
* presence_conference: Aviod “make: --libs: No such file or directory” warning
* presence_dialog: Aviod “make: --libs: No such file or directory” warning
* presence_reginfo: Aviod “make: --libs: No such file or directory” warning
* presence_xml: Avoid “make: --libs-only-L: No such file or directory” warnings
* pua: Avoid “make: --libs-only-L: No such file or directory” warnings
* pua_bla: Aviod “make: --libs: No such file or directory” warning
* pua_dialoginfo: Aviod “make: --libs: No such file or directory” warning
* pua_reginfo: Aviod “make: --libs: No such file or directory” warning
* pua_usrloc: Aviod “make: --libs: No such file or directory” warning
* pua_xmpp: Aviod “make: --libs: No such file or directory” warning
* regex: Aviod “make: --libs: No such file or directory” warning
* rls: Avoid “make: --libs-only-L: No such file or directory” warnings
* slack: Aviod “make: --libs: No such file or directory” warning
* systemdops: Avoid “make: --libs-only-L: No such file or directory” warning
* tls: Aviod “make: --libs: No such file or directory” warnings
* tlsa: Avoid “make: --libs-only-L: No such file or directory” warning
* topos_redis: Aviod “make: --libs: No such file or directory” warning
* utils: Avoid “make: --libs-only-L: No such file or directory” warnings
* uuid: Aviod “make: --libs: No such file or directory” warning
* websocket: Aviod “make: --libs: No such file or directory” warnings
* xcap_server: Avoid “make: --libs-only-L: No such file or directory” warnings
* xhttp_pi: Avoid “make: --libs-only-L: No such file or directory” warnings
* xmlops: Aviod “make: --libs: No such file or directory” warning
* xmlrpc: Aviod “make: --libs: No such file or directory” warning
-- File Changes --
M src/lib/ims/Makefile (4)
M src/modules/app_python3/Makefile (6)
M src/modules/app_python3s/Makefile (6)
M src/modules/auth_ephemeral/Makefile (2)
M src/modules/auth_identity/Makefile (4)
M src/modules/cdp/Makefile (4)
M src/modules/cnxcc/Makefile (4)
M src/modules/cplc/Makefile (4)
M src/modules/crypto/Makefile (2)
M src/modules/db_postgres/Makefile (2)
M src/modules/db_redis/Makefile (2)
M src/modules/dialplan/Makefile (2)
M src/modules/gzcompress/Makefile (2)
M src/modules/http_async_client/Makefile (6)
M src/modules/http_client/Makefile (2)
M src/modules/ims_auth/Makefile (4)
M src/modules/ims_icscf/Makefile (4)
M src/modules/ims_isc/Makefile (4)
M src/modules/ims_registrar_pcscf/Makefile (4)
M src/modules/ims_registrar_scscf/Makefile (4)
M src/modules/jansson/Makefile (2)
M src/modules/kazoo/Makefile (2)
M src/modules/lcr/Makefile (2)
M src/modules/log_systemd/Makefile (2)
M src/modules/lost/Makefile (6)
M src/modules/lwsc/Makefile (2)
M src/modules/ndb_redis/Makefile (2)
M src/modules/osp/Makefile (2)
M src/modules/outbound/Makefile (7)
M src/modules/presence/Makefile (4)
M src/modules/presence_conference/Makefile (4)
M src/modules/presence_dialoginfo/Makefile (4)
M src/modules/presence_reginfo/Makefile (4)
M src/modules/presence_xml/Makefile (4)
M src/modules/pua/Makefile (4)
M src/modules/pua_bla/Makefile (4)
M src/modules/pua_dialoginfo/Makefile (4)
M src/modules/pua_reginfo/Makefile (4)
M src/modules/pua_usrloc/Makefile (4)
M src/modules/pua_xmpp/Makefile (4)
M src/modules/regex/Makefile (2)
M src/modules/rls/Makefile (4)
M src/modules/slack/Makefile (2)
M src/modules/systemdops/Makefile (2)
M src/modules/tls/Makefile (4)
M src/modules/tlsa/Makefile (4)
M src/modules/topos_redis/Makefile (2)
M src/modules/utils/Makefile (4)
M src/modules/uuid/Makefile (2)
M src/modules/websocket/Makefile (2)
M src/modules/xcap_server/Makefile (4)
M src/modules/xhttp_pi/Makefile (4)
M src/modules/xmlops/Makefile (4)
M src/modules/xmlrpc/Makefile (4)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3475.patch
https://github.com/kamailio/kamailio/pull/3475.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3475
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3475(a)github.com>
12 Jun
12 Jun
11:33 a.m.
Afaik `:=` evaluates the variable expression only once, does it evaluate it for each
module Makefile, or only for the first time that variable is assigned? I mean, if module
`a` and `b` have something like `BUILDER=...` in their Makefile, a `make all` is going to
evaluate `BUILDER` variable each time, or the one from module `a` propagate to `b`
compilation?
On the other hand `=` evaluates every time the variable is used.
GCC 4.4 is really old, I would avoid fixing warning for it if it can create side effects
by propagating values when not expecting.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3475#issuecomment-1586958651
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3475/c1586958651(a)github.com>
20 Jun
20 Jun
9:56 p.m.
When the file `a` contains `BUILDER:=a`, the file `b` contains `BUILDER:=b`, and
`Makefile` contains
```make
include a
include b
all:
@echo $(BUILDER)
```
(there is a TAB before @), then typing `make` prints `b`.
I do not understand the question and I do not understand the build system of Kamailio.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3475#issuecomment-1599415772
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3475/c1599415772(a)github.com>
8 Nov
8 Nov
9:23 a.m.
This PR is stale because it has been open 6 weeks with no activity. Remove stale label or
comment or this will be closed in 2 weeks.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3475#issuecomment-1801302782
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3475/c1801302782(a)github.com>
23 Nov
23 Nov
3:42 a.m.
Closed #3475.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3475#event-11042732661
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3475/issue_event/11042732661(a)github.com>
26 Nov
26 Nov
1:51 p.m.
The proposed here change does fix problems (warnings). I object that this PR is closed,
instead of fixing the underlying warnings by the suggested or other ways.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3475#issuecomment-1826776355
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3475/c1826776355(a)github.com>
7:08 p.m.
The automatic actions have the purpose to keep the reporter, and devs when it is the case,
engaged. An issue or PR marked `stale` can have the label removed by reporter if it is
still interested in it. Also, a closed issue or PR can be reopened. Note also that the
`stale` label is added based on inactivity period, comments are considered activity, so
the inactivity is reset with each of them..
Have in mind that this is a collaborative project, so everyone have to stay engaged,
nobody pays for time spent by developers on reviewing commits. From that point of view, I
think it is fair that the reporter reacts on a stale or close notification and indicate
that the issue is still there or the PR is still relevant. Just coming to blame, it is by
far not a nice approach. Some of developers here spent significant resources and time
without any direct benefits over the past 20 years to make this application available,
that should be appreciated. This kind of automatisation tries to make the life easier for
everyone, feel free to propose tools or processes that can help improving and moving
forward.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3475#issuecomment-1826855824
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3475/c1826855824(a)github.com>
8:44 p.m.
From that point of view, I think it is fair that the
reporter reacts on a stale or close notification and indicate that the issue is still
there or the PR is still relevant.
Writing repeatedly any text just for the sake of keeping a ticket open does not help
anyhow.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3475#issuecomment-1826879056
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3475/c1826879056(a)github.com>
9:06 p.m.
Probably you missed the note that you can simply remove the label `stale`. It was a
message on sr-dev a few weeks ago as well.
The remark about comments was to clarify that they count as activity, so it is not about
time since open, but time since `no interest`.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3475#issuecomment-1826883787
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3475/c1826883787(a)github.com>
9:33 p.m.
An issue or PR marked `stale` can have the label
removed by reporter…
This is not correct.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3475#issuecomment-1826889285
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3475/c1826889285(a)github.com>
10 p.m.
I was not aware of the `triage` role. Anyhow, making a small comment from time to time is
a fair effort to keep the interest open and notify/remind the others about.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3475#issuecomment-1826895104
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3475/c1826895104(a)github.com>
10:01 p.m.
And, furthermore, I guess the option of the reporter to reopen the issue is still
available.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3475#issuecomment-1826895381
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3475/c1826895381(a)github.com>
10:09 p.m.
I guess the option of the reporter to reopen the
issue/pr is still available.
I do not see such option.
Currently the only way to prevent automatic closing is to write (probably periodically)
any text.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3475#issuecomment-1826897196
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3475/c1826897196(a)github.com>
27 Nov
27 Nov
2:21 p.m.
I've implemented a way to manage ``stale`` and re-open ``expired`` issues and pull
requests.
So, if the comment as /notexpired it will be re-opened and labels ``expired`` and
``stale`` will be removed.
Hope this helps
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3475#issuecomment-1827822552
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3475/c1827822552(a)github.com>
2:21 p.m.
Reopened #3475.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3475#event-11070940915
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3475/issue_event/11070940915(a)github.com>
9 Jan
9 Jan
3:42 a.m.
This PR is stale because it has been open 6 weeks with no activity. Remove stale label or
comment or this will be closed in 2 weeks.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3475#issuecomment-1882244394
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3475/c1882244394(a)github.com>
23 Jan
23 Jan
3:44 a.m.
Closed #3475.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3475#event-11564226634
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3475/issue_event/11564226634(a)github.com>
101
days inactive
337
days old
16 comments
4 participants
participants (4)
-
Daniel-Constantin Mierla -
github-actions[bot]
-
Victor Seva
-
Дилян Палаузов