sr-dev May 2022

sr-dev@lists.kamailio.org

12 participants
290 discussions

git:master:ba3f7d51: auth: Fix typos
by Henning Westerholt 08 May '22

08 May '22

Module: kamailio Branch: master Commit: ba3f7d5157819d55a67a054de1b7d0f8fc521140 URL: https://github.com/kamailio/kamailio/commit/ba3f7d5157819d55a67a054de1b7d0f… Author: Bastian Triller <bastian.triller(a)gmail.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2022-05-08T17:30:14+02:00 auth: Fix typos --- Modified: src/modules/auth/challenge.c Modified: src/modules/auth/nonce.c --- Diff: https://github.com/kamailio/kamailio/commit/ba3f7d5157819d55a67a054de1b7d0f… Patch: https://github.com/kamailio/kamailio/commit/ba3f7d5157819d55a67a054de1b7d0f… --- diff --git a/src/modules/auth/challenge.c b/src/modules/auth/challenge.c index 93142391b4..c5a769ed21 100644 --- a/src/modules/auth/challenge.c +++ b/src/modules/auth/challenge.c @@ -81,7 +81,7 @@ void strip_realm(str* _realm) * @param nonce_len A value/result parameter. Initially it contains the * nonce buffer length. If the length is too small, it * will be set to the needed length and the function will - * return error immediately. After a succesfull call it will + * return error immediately. After a successful call it will * contain the size of nonce written into the buffer, * without the terminating 0. * @param cfg This is the value of one of the three module parameters that diff --git a/src/modules/auth/nonce.c b/src/modules/auth/nonce.c index 4ec4d0a3af..b07515084a 100644 --- a/src/modules/auth/nonce.c +++ b/src/modules/auth/nonce.c @@ -158,12 +158,12 @@ inline static int calc_bin_nonce_md5(union bin_nonce* b_nonce, int cfg, * This function creates the nonce string as it will be sent to the * user agent in digest challenge. The format of the nonce string * depends on the value of three module parameters, auth_checks_register, - * auth_checks_no_dlg, and auth_checks_in_dlg. These module parameters - * control the amount of information from the SIP requst that will be + * auth_checks_no_dlg and auth_checks_in_dlg. These module parameters + * control the amount of information from the SIP request that will be * stored in the nonce string for verification purposes. * * If all three parameters contain zero then the nonce string consists - * of time in seconds since 1.1. 1970 and a secret phrase: + * of time in seconds since 1.1.1970 and a secret phrase: * <expire_time> <valid_since> MD5(<expire_time>, <valid_since>, secret) * If any of the parameters is not zero (some optional checks are enabled * then the nonce string will also contain MD5 hash of selected parts @@ -175,7 +175,7 @@ inline static int calc_bin_nonce_md5(union bin_nonce* b_nonce, int cfg, * @param nonce_len A value/result parameter. Initially it contains the * nonce buffer length. If the length is too small, it * will be set to the needed length and the function will - * return error immediately. After a succesfull call it will + * return error immediately. After a successful call it will * contain the size of nonce written into the buffer, * without the terminating 0. * @param cfg This is the value of one of the three module parameters that @@ -187,7 +187,7 @@ inline static int calc_bin_nonce_md5(union bin_nonce* b_nonce, int cfg, * @param n_id Nounce count and/or one-time nonce index value * (32 bit counter) * @param pf First 2 bits are flags, the rest is the index pool number - * used if nonce counts or one-time nonces are enabled. + * used if nonce counts or one-time nonces are enabled. * The possible flags values are: NF_VALID_NC_ID which means * the nonce-count support is enabled and NF_VALID_OT_ID * which means the one-time nonces support is enabled. @@ -200,7 +200,7 @@ inline static int calc_bin_nonce_md5(union bin_nonce* b_nonce, int cfg, * MD5(<msg_parts(auth_extra_checks)>, secret2). * @param msg The message for which the nonce is computed. If * auth_extra_checks is set, the MD5 of some fields of the - * message will be included in the generated nonce. + * message will be included in the generated nonce. * @return 0 on success and -1 on error */ int calc_nonce(char* nonce, int *nonce_len, int cfg, int since, int expires,

1 0

git:master:5e71d010: acc: Fix typos
by Henning Westerholt 08 May '22

08 May '22

Module: kamailio Branch: master Commit: 5e71d0100ff93e345d31b7210e93be92cde88111 URL: https://github.com/kamailio/kamailio/commit/5e71d0100ff93e345d31b7210e93be9… Author: Bastian Triller <bastian.triller(a)gmail.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2022-05-08T17:30:14+02:00 acc: Fix typos --- Modified: src/modules/acc/doc/acc_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/5e71d0100ff93e345d31b7210e93be9… Patch: https://github.com/kamailio/kamailio/commit/5e71d0100ff93e345d31b7210e93be9… --- diff --git a/src/modules/acc/doc/acc_admin.xml b/src/modules/acc/doc/acc_admin.xml index 036163da14..04fe28a8da 100644 --- a/src/modules/acc/doc/acc_admin.xml +++ b/src/modules/acc/doc/acc_admin.xml @@ -1123,7 +1123,7 @@ modparam("acc", "cdr_start_on_confirmed", 1) <title><varname>cdr_facility</varname> (integer)</title> <para> Log facility to which CDR messages are issued to syslog. - This allows to easily seperate CDR-specific logging from + This allows to easily separate CDR-specific logging from the other log messages. </para> <para>

1 0

git:master:4b2b8925: lib: Fix typos
by Henning Westerholt 08 May '22

08 May '22

Module: kamailio Branch: master Commit: 4b2b8925c2c8f195f135ff262f7b45601b111b0d URL: https://github.com/kamailio/kamailio/commit/4b2b8925c2c8f195f135ff262f7b456… Author: Bastian Triller <bastian.triller(a)gmail.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2022-05-08T17:30:14+02:00 lib: Fix typos --- Modified: src/lib/cds/dstring.h Modified: src/lib/srdb1/schema/uid_credentials.xml Modified: src/lib/srdb2/db_cmd.c Modified: src/lib/srdb2/schema/credentials.xml --- Diff: https://github.com/kamailio/kamailio/commit/4b2b8925c2c8f195f135ff262f7b456… Patch: https://github.com/kamailio/kamailio/commit/4b2b8925c2c8f195f135ff262f7b456… --- diff --git a/src/lib/cds/dstring.h b/src/lib/cds/dstring.h index 039ed2b099..5dc2de5c91 100644 --- a/src/lib/cds/dstring.h +++ b/src/lib/cds/dstring.h @@ -77,7 +77,7 @@ typedef struct _dstring_t { /** predefined buffer size */ int buff_size; - /** a operation on this string was unsuccesfull -> + /** a operation on this string was unsuccessful -> * all other operations will produce error */ int error; } dstring_t; diff --git a/src/lib/srdb1/schema/uid_credentials.xml b/src/lib/srdb1/schema/uid_credentials.xml index 8391e28e1c..d0089693e0 100644 --- a/src/lib/srdb1/schema/uid_credentials.xml +++ b/src/lib/srdb1/schema/uid_credentials.xml @@ -16,7 +16,7 @@ users identified by uid. Credentials can be used in digest authentication in SIP and/or authentication in SERWeb. In most situations credentials for digest authentication and SERWeb authentication are same. There are cases, - however, where seperate credentials for SERWeb and separate credentials + however, where separate credentials for SERWeb and separate credentials for digest authentication may be needed. One such example are setups where subscribers get HW user agents with locked configuration and thay do not know the password and are not allowed to change it. If they should be able diff --git a/src/lib/srdb2/db_cmd.c b/src/lib/srdb2/db_cmd.c index 0adeca646a..691b5f2999 100644 --- a/src/lib/srdb2/db_cmd.c +++ b/src/lib/srdb2/db_cmd.c @@ -73,8 +73,8 @@ db_cmd_t* db_cmd(enum db_cmd_type type, db_ctx_t* ctx, char* table, } /* FIXME: This should be redesigned so that we do not need to connect - * connections in context before comands are created, this takes splitting - * the command initializatio sequence in two steps, one would be creating + * connections in context before commands are created, this takes splitting + * the command initialization sequence in two steps, one would be creating * all the data structures and the second would be checking corresponding * fields and tables on the server. */ diff --git a/src/lib/srdb2/schema/credentials.xml b/src/lib/srdb2/schema/credentials.xml index 8bc7809fbf..a6c3ccadfb 100644 --- a/src/lib/srdb2/schema/credentials.xml +++ b/src/lib/srdb2/schema/credentials.xml @@ -15,7 +15,7 @@ users identified by uid. Credentials can be used in digest authentication in SIP and/or authentication in SERWeb. In most situations credentials for digest authentication and SERWeb authentication are same. There are cases, - however, where seperate credentials for SERWeb and separate credentials + however, where separate credentials for SERWeb and separate credentials for digest authentication may be needed. One such example are setups where subscribers get HW user agents with locked configuration and thay do not know the password and are not allowed to change it. If they should be able

1 0

git:master:5dd8f0a6: core: Fix typos
by Henning Westerholt 08 May '22

08 May '22

Module: kamailio Branch: master Commit: 5dd8f0a6ff30fd3aa917a98b006106bef61506e5 URL: https://github.com/kamailio/kamailio/commit/5dd8f0a6ff30fd3aa917a98b006106b… Author: Bastian Triller <bastian.triller(a)gmail.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2022-05-08T17:30:14+02:00 core: Fix typos --- Modified: src/core/atomic/atomic_mips2.h Modified: src/core/dns_cache.c Modified: src/core/forward.c Modified: src/core/resolve.c Modified: src/core/tcp_main.c --- Diff: https://github.com/kamailio/kamailio/commit/5dd8f0a6ff30fd3aa917a98b006106b… Patch: https://github.com/kamailio/kamailio/commit/5dd8f0a6ff30fd3aa917a98b006106b…

1 0

git:master:e8bdf2b9: pkg: Fix typos
by Henning Westerholt 08 May '22

08 May '22

Module: kamailio Branch: master Commit: e8bdf2b99de1ecfe8f276e2d9bed54e01588210b URL: https://github.com/kamailio/kamailio/commit/e8bdf2b99de1ecfe8f276e2d9bed54e… Author: Bastian Triller <bastian.triller(a)gmail.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2022-05-08T17:30:14+02:00 pkg: Fix typos --- Modified: pkg/kamailio/deb/bionic/rules Modified: pkg/kamailio/deb/bookworm/rules Modified: pkg/kamailio/deb/bullseye/rules Modified: pkg/kamailio/deb/buster/rules Modified: pkg/kamailio/deb/debian/rules Modified: pkg/kamailio/deb/focal/rules Modified: pkg/kamailio/deb/jessie/rules Modified: pkg/kamailio/deb/precise/rules Modified: pkg/kamailio/deb/sid/rules Modified: pkg/kamailio/deb/stretch/rules Modified: pkg/kamailio/deb/trusty/rules Modified: pkg/kamailio/deb/wheezy/rules Modified: pkg/kamailio/deb/xenial/rules --- Diff: https://github.com/kamailio/kamailio/commit/e8bdf2b99de1ecfe8f276e2d9bed54e… Patch: https://github.com/kamailio/kamailio/commit/e8bdf2b99de1ecfe8f276e2d9bed54e…

1 0

git:master:5497d157: doc: Fix typos
by Henning Westerholt 08 May '22

08 May '22

Module: kamailio Branch: master Commit: 5497d15766d25625b4704a3bd3e884ef2f1149da URL: https://github.com/kamailio/kamailio/commit/5497d15766d25625b4704a3bd3e884e… Author: Bastian Triller <bastian.triller(a)gmail.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2022-05-08T17:30:14+02:00 doc: Fix typos --- Modified: doc/misc/NEWS Modified: doc/tutorials/locking.txt --- Diff: https://github.com/kamailio/kamailio/commit/5497d15766d25625b4704a3bd3e884e… Patch: https://github.com/kamailio/kamailio/commit/5497d15766d25625b4704a3bd3e884e… --- diff --git a/doc/misc/NEWS b/doc/misc/NEWS index 9b62dd39c1..09b63a72b4 100644 --- a/doc/misc/NEWS +++ b/doc/misc/NEWS @@ -338,7 +338,7 @@ modules: the retransmissions which would otherwise be challenged). The major advantage is greatly enhanced security (extremely small probability of - a succesfull replay attack) combine with support + a successful replay attack) combine with support for cached credentials (if the UAs do support qop and auth) - nc_array_size - size of the array used for storing diff --git a/doc/tutorials/locking.txt b/doc/tutorials/locking.txt index 7507a5d002..3ff12f6c85 100644 --- a/doc/tutorials/locking.txt +++ b/doc/tutorials/locking.txt @@ -109,7 +109,7 @@ Locking & unlocking: void lock_get(gen_lock_t* lock); - lock (mutex down) void lock_release(gen_lock_t* lock); - unlock (mutex up) int lock_try(gen_lock_t* lock); - tries to lock and returns 0 - if succesfull, -1 if not (this is + if successful, -1 if not (this is a non-blocking lock_get()) @@ -164,7 +164,7 @@ Locking & unlocking: void lock_set_get(lock_set_t* s, int i); void lock_set_release(lock_set_t* s, int i); int lock_set_try(lock_set_t* s, int i); - tries to lock the i-th lock - from the set. If succesfull + from the set. If successful returns 0, if not -1. Example:

1 0

git:master:543cd8f8: ipops: add dns container in dns_update_pv() if not created before
by Daniel-Constantin Mierla 06 May '22

06 May '22

Module: kamailio Branch: master Commit: 543cd8f897bc43d5fe1eb4c562d8351b32778209 URL: https://github.com/kamailio/kamailio/commit/543cd8f897bc43d5fe1eb4c562d8351… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-05-06T13:50:13+02:00 ipops: add dns container in dns_update_pv() if not created before - dns context creation relied on using the dns variable in some way, the main purpose of dns_update_pv() being to fill the variable, but one may want to use it for testing only --- Modified: src/modules/ipops/ipops_pv.c --- Diff: https://github.com/kamailio/kamailio/commit/543cd8f897bc43d5fe1eb4c562d8351… Patch: https://github.com/kamailio/kamailio/commit/543cd8f897bc43d5fe1eb4c562d8351… --- diff --git a/src/modules/ipops/ipops_pv.c b/src/modules/ipops/ipops_pv.c index 1afc806541..9ee6f5879a 100644 --- a/src/modules/ipops/ipops_pv.c +++ b/src/modules/ipops/ipops_pv.c @@ -373,7 +373,7 @@ int dns_update_pv(str *hostname, str *name) return -2; } - dr = sr_dns_get_item(name); + dr = sr_dns_add_item(name); if(dr==NULL) { LM_DBG("container not found: %s\n", name->s);

1 0

git:master:0f9a833f: ipops: warning when too many dns containers are created
by Daniel-Constantin Mierla 06 May '22

06 May '22

Module: kamailio Branch: master Commit: 0f9a833fcc7cbc306a5d47413f6449ccc5a37f59 URL: https://github.com/kamailio/kamailio/commit/0f9a833fcc7cbc306a5d47413f6449c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-05-06T12:46:28+02:00 ipops: warning when too many dns containers are created --- Modified: src/modules/ipops/ipops_pv.c --- Diff: https://github.com/kamailio/kamailio/commit/0f9a833fcc7cbc306a5d47413f6449c… Patch: https://github.com/kamailio/kamailio/commit/0f9a833fcc7cbc306a5d47413f6449c… --- diff --git a/src/modules/ipops/ipops_pv.c b/src/modules/ipops/ipops_pv.c index 6e9d86b5a6..1afc806541 100644 --- a/src/modules/ipops/ipops_pv.c +++ b/src/modules/ipops/ipops_pv.c @@ -95,6 +95,7 @@ sr_dns_item_t *sr_dns_add_item(str *name) { sr_dns_item_t *it = NULL; unsigned int hashid = 0; + int n = 0; hashid = get_hash1_raw(name->s, name->len); @@ -105,7 +106,13 @@ sr_dns_item_t *sr_dns_add_item(str *name) && strncmp(it->name.s, name->s, name->len)==0) return it; it = it->next; + n++; } + if(n > 20) { + LM_WARN("too many dns containers - adding nunmber %d - can fill memory\n", + n); + } + /* add new */ it = (sr_dns_item_t*)pkg_malloc(sizeof(sr_dns_item_t)); if(it==NULL)

1 0

Re: [sr-dev] sr-dev Digest, Vol 162, Issue 61
by Luis Azedo 06 May '22

06 May '22

Hello, seeing some weirdness in kamailio logs while testing kamailio under docker/kubernetes and logging to stderr, not sure if its related to kamailio or the infrastructure itself. running in 8 core host, it looks like the write to stderr has some race condition if that's even possible. the breaks happen with different processes and i wonder if the LOG_FX and DPRINT_NON_CRIT macros are responsible for that. it looks like 2 different processes could evaluate to true and try to write to stderr at same time. two examples real output 116(354) INFO: 2022-04-28T18:08:14.476102048Z 3ebe6ff3-1799-4798-baa3-a109df32711d registrar-role.cfg:745 (route_to_external_aor) 117(355) INFO: 2022-04-28T18:08:14.473375226Z 5f2567bf-25bb-4cb1-a306-dc28711d9fcb default.cfg:305 (log_request) to sip:1117@1.sip-stress.com 117(355) INFO: 2022-04-28T18:08:14.476592352Z 5f2567bf-25bb-4cb1-a306-dc28711d9fcb default.cfg:324 (classify_source) end - routing to contact sip:1104@10.23.0.2:9181 originated from internal sources should be 116(354) INFO: 2022-04-28T18:08:14.476102048Z 3ebe6ff3-1799-4798-baa3-a109df32711d registrar-role.cfg:745 (route_to_external_aor) end - routing to contact sip:1104@10.23.0.2:9181 117(355) INFO: 2022-04-28T18:08:14.473375226Z 5f2567bf-25bb-4cb1-a306-dc28711d9fcb default.cfg:305 (log_request) to sip:1117@1.sip-stress.com 117(355) INFO: 2022-04-28T18:08:14.476592352Z 5f2567bf-25bb-4cb1-a306-dc28711d9fcb default.cfg:324 (classify_source) originated from internal sources second example real output 71(309) INFO: 2022-04-28T18:08:14.514892167Z cid-10440-3(a)10.21.0.1 default.cfg:304 (log_request) 116(354) INFO: 2022-04-28T18:08:14.521506921Z cid-10440-26(a)10.21.0.1 default.cfg:751 (internal_reply) 200 OK from sip:1002@1.sip-stress.com should be 71(309) INFO: 2022-04-28T18:08:14.514892167Z cid-10440-3(a)10.21.0.1 default.cfg:304 (log_request) from sip:1002@1.sip-stress.com 116(354) INFO: 2022-04-28T18:08:14.521506921Z cid-10440-26(a)10.21.0.1 default.cfg:751 (internal_reply) 200 OK Any hints/thoughts ? should we try to have a better way to handle this inb dprint.c/dprint.h ? Thanks

1 1

[kamailio/kamailio] LCR function from_gw (Issue #3077)
by Antoineb2s 06 May '22

06 May '22

Hi, Kamailio 5.5.4 from deb packages I tried to use the lcr function from_gw(lcr_id[, ip_addr, proto]) I've declared several gws with different lcr_id Unfortunately from_gw doesn't work with lcr_ids > 1 For example : if (from_gw(2,$si,1)) { .... } ... ki_from_gw(): invalid lcr_id parameter value 2 -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3077 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3077(a)github.com>

3 2

← Newer
1
...
22
23
24
25
26
27
28
29
Older →

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev May 2022