sr-dev May 2022

sr-dev@lists.kamailio.org

12 participants
284 discussions

git:master:0c99fed4: snmpstats: fix allocator sizeof operand mismatch

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 0c99fed48403e2cc4f24441901b81b7c51411511 URL: https://github.com/kamailio/kamailio/commit/0c99fed48403e2cc4f24441901b81b7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-05-03T19:07:41+02:00 snmpstats: fix allocator sizeof operand mismatch --- Modified: src/modules/snmpstats/snmpSIPRegUserLookupTable.c Modified: src/modules/snmpstats/snmpSIPRegUserTable.c --- Diff: https://github.com/kamailio/kamailio/commit/0c99fed48403e2cc4f24441901b81b7… Patch: https://github.com/kamailio/kamailio/commit/0c99fed48403e2cc4f24441901b81b7… --- diff --git a/src/modules/snmpstats/snmpSIPRegUserLookupTable.c b/src/modules/snmpstats/snmpSIPRegUserLookupTable.c index 9ded597b83..f00dde9ac7 100644 --- a/src/modules/snmpstats/snmpSIPRegUserLookupTable.c +++ b/src/modules/snmpstats/snmpSIPRegUserLookupTable.c @@ -520,7 +520,7 @@ void kamailioSIPRegUserLookupTable_set_action(netsnmp_request_group *rg) case COLUMN_KAMAILIOSIPREGUSERLOOKUPURI: row_ctx->kamailioSIPRegUserLookupURI = - pkg_malloc(sizeof(char) * (var->val_len + 1)); + pkg_malloc(sizeof(unsigned char) * (var->val_len + 1)); memcpy(row_ctx->kamailioSIPRegUserLookupURI, var->val.string, var->val_len); @@ -776,4 +776,4 @@ kamailioSIPRegUserLookupTable_get_by_idx(netsnmp_index *hdr) { return (const kamailioSIPRegUserLookupTable_context *)CONTAINER_FIND( cb.container, hdr); -} \ No newline at end of file +} diff --git a/src/modules/snmpstats/snmpSIPRegUserTable.c b/src/modules/snmpstats/snmpSIPRegUserTable.c index 4ad5bf3307..6d4270a188 100644 --- a/src/modules/snmpstats/snmpSIPRegUserTable.c +++ b/src/modules/snmpstats/snmpSIPRegUserTable.c @@ -248,7 +248,7 @@ int createRegUserRow(char *stringToRegister) theRow->kamailioSIPUserIndex = index; theRow->kamailioSIPUserUri = - (unsigned char *)pkg_malloc(stringLength * sizeof(char)); + (unsigned char *)pkg_malloc(stringLength * sizeof(unsigned char)); if(theRow->kamailioSIPUserUri == NULL) { pkg_free(OIDIndex); free(theRow); @@ -378,4 +378,4 @@ const kamailioSIPRegUserTable_context *kamailioSIPRegUserTable_get_by_idx( { return (const kamailioSIPRegUserTable_context *)CONTAINER_FIND( cb.container, hdr); -} \ No newline at end of file +}

2 years

[kamailio/kamailio] core: add an option to trigger also an RST on tcp connection close (PR #3100)

by Rick Barenthin

- This gives an option to also send RST in case kamailio closes the connection. There are cases where a FIN,ACK back forth leaves the connection in the host in TIME_WAIT state, but the ports on both sides are fixed. This leads to no request can send until the TIME_WAIT state is gone.   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  We have seen that in deployments where there are strict port requirements on both side, there are tcp connections in TIME_WAIT state causing no fresh TCP connections possible until the TIME_WAIT is gone. In a lot of these case the clients are sending from them self a RST after they send a FIN,ACK from there side but some aren't doing this. The basic idea of this PR is to give an extra option for the tcp configuration from the cfg to trigger always an RST on connection close from Kamailio side. This currently done by enabling SO_LINGER with a value of 0 just before close. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3100 -- Commit Summary -- * core: add an option to trigger also an RST on tcp connection close -- File Changes -- M src/core/cfg.lex (2) M src/core/cfg.y (9) M src/core/tcp_main.c (7) M src/core/tcp_options.c (3) M src/core/tcp_options.h (1) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3100.patch https://github.com/kamailio/kamailio/pull/3100.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3100 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3100(a)github.com>

2 years

git:master:c0b5e627: core: clang format for sip msg clone code

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: c0b5e62782e0c8d5eb10eeb9d8e0952b1cb720d6 URL: https://github.com/kamailio/kamailio/commit/c0b5e62782e0c8d5eb10eeb9d8e0952… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-05-03T12:09:07+02:00 core: clang format for sip msg clone code --- Modified: src/core/sip_msg_clone.c Modified: src/core/sip_msg_clone.h --- Diff: https://github.com/kamailio/kamailio/commit/c0b5e62782e0c8d5eb10eeb9d8e0952… Patch: https://github.com/kamailio/kamailio/commit/c0b5e62782e0c8d5eb10eeb9d8e0952…

2 years

[kamailio/kamailio] pv_headers: fix possible mem. overflow issue and wrong size string (PR #3095)

by Tomohare

#### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [X] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  - remove a variable creation Put two variable accessible to the entire function, renaming one to have some clarity. Remove the useless variable. - Change from using snprintf to memset (no more \0 at last position) This fix possible a memory overflow while using `snprintf`. This also add a \0 at the end of the structure, so a more direct approach with `memset` was used. - change the destination of an allocated space being smaller than the source Elements were being put into a smaller string, this commit makes the destination bigger then the source. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3095 -- Commit Summary -- * pv_headers: fix possible mem. overflow issue and wrong size string -- File Changes -- M src/modules/pv_headers/pvh_func.c (26) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3095.patch https://github.com/kamailio/kamailio/pull/3095.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3095 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3095(a)github.com>

2 years

git:master:82f14f54: pv_headers: fix possible mem. overflow issue and wrong size string

by Victor Seva

Module: kamailio Branch: master Commit: 82f14f54a45a2d0ddd4c870d6fb4adae7e1a65f1 URL: https://github.com/kamailio/kamailio/commit/82f14f54a45a2d0ddd4c870d6fb4ada… Author: Fabricio Santolin da Silva <fabricio.santolin-da-silva(a)al-enterprise.com> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2022-05-03T10:04:17+02:00 pv_headers: fix possible mem. overflow issue and wrong size string - remove a variable creation - change from using snprintf to memset (no more \0 at last position) - change the destination of a allocated space being smaller than the source --- Modified: src/modules/pv_headers/pvh_func.c --- Diff: https://github.com/kamailio/kamailio/commit/82f14f54a45a2d0ddd4c870d6fb4ada… Patch: https://github.com/kamailio/kamailio/commit/82f14f54a45a2d0ddd4c870d6fb4ada… --- diff --git a/src/modules/pv_headers/pvh_func.c b/src/modules/pv_headers/pvh_func.c index c2a3f98e41..dde1b8301b 100644 --- a/src/modules/pv_headers/pvh_func.c +++ b/src/modules/pv_headers/pvh_func.c @@ -383,13 +383,13 @@ int pvh_header_param_exists(struct sip_msg *msg, str *hname, str *hvalue) int pvh_remove_header_param(struct sip_msg *msg, int idx, str *hname, str *elements, str *toRemove) { + int notTarget, writtenChars; int offset = 0; int ret = -1; char *next_token; char *token; char *result = (char*)pkg_malloc(elements->len - toRemove->len); - char *t = (char*)pkg_malloc(elements->len); - int maxSize = elements->len; + char *t = (char*)pkg_malloc(elements->len+1); if (result == NULL || t == NULL) { @@ -397,37 +397,35 @@ int pvh_remove_header_param(struct sip_msg *msg, int idx, str *hname, str *eleme goto clean; } - snprintf(result, elements->len - toRemove->len, "%*s", elements->len - toRemove->len, ""); snprintf(t, elements->len+1, "%s", elements->s); token = strtok_r(t, ", ", &next_token); while(token) { - int notTarget = strncmp(token, toRemove->s, toRemove->len); + notTarget = strncmp(token, toRemove->s, toRemove->len); if (notTarget) { - int n = snprintf(result + offset, maxSize - offset, "%s", token); - if (n < 0 || n >= maxSize - offset) + writtenChars = snprintf(result + offset, elements->len - offset, "%s", token); + if (writtenChars < 0 || writtenChars >= elements->len - offset) { break; } - offset += n; + offset += writtenChars; } token = strtok_r(NULL, ", ", &next_token); - if (token && notTarget && maxSize - offset - toRemove->len > 2) + if (token && notTarget && elements->len - offset - toRemove->len > 2) { - int n = snprintf(result + offset, maxSize - offset, ", "); - if (n < 0 || n >= maxSize - offset) + writtenChars = snprintf(result + offset, elements->len - offset, ", "); + if (writtenChars < 0 || writtenChars >= elements->len - offset) { break; } - offset += n; + offset += writtenChars; } } if (elements->len-toRemove->len > 0) { - snprintf(elements->s, elements->len, "%*s", elements->len-toRemove->len, ""); snprintf(elements->s, (strlen(result)%elements->len)+1, "%s", result); elements->len = strlen(result); ret = 1;

2 years

git:master:64d14117: modules: readme files regenerated - userblocklist ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: 64d141170430fad2e9dbe09fc5bec0b96cedf040 URL: https://github.com/kamailio/kamailio/commit/64d141170430fad2e9dbe09fc5bec0b… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2022-05-02T17:01:19+02:00 modules: readme files regenerated - userblocklist ... [skip ci] --- Modified: src/modules/userblocklist/README --- Diff: https://github.com/kamailio/kamailio/commit/64d141170430fad2e9dbe09fc5bec0b… Patch: https://github.com/kamailio/kamailio/commit/64d141170430fad2e9dbe09fc5bec0b…

2 years

[kamailio/kamailio] userblocklist: add RPC functions (PR #3097)

by Stefan Mititelu

#### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Ported mi functions to RPC. Note that in order to send long number strings (e.g. username) from kamcmd one must prefix it with "s:" You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3097 -- Commit Summary -- * userblocklist: add RPC functions -- File Changes -- M src/modules/userblocklist/userblocklist.c (348) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3097.patch https://github.com/kamailio/kamailio/pull/3097.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3097 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3097(a)github.com>

2 years

git:master:4192d734: userblocklist: add RPC functions

by Henning Westerholt

Module: kamailio Branch: master Commit: 4192d734640acedbc6509170166876a20675f2a7 URL: https://github.com/kamailio/kamailio/commit/4192d734640acedbc6509170166876a… Author: Stefan Mititelu <stefan-cristian.mititelu(a)1and1.ro> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2022-05-02T16:54:00+02:00 userblocklist: add RPC functions --- Modified: src/modules/userblocklist/doc/userblocklist_admin.xml Modified: src/modules/userblocklist/userblocklist.c --- Diff: https://github.com/kamailio/kamailio/commit/4192d734640acedbc6509170166876a… Patch: https://github.com/kamailio/kamailio/commit/4192d734640acedbc6509170166876a…

2 years

[kamailio/kamailio] pua_dialoginfo: Determine dialog event types in mod_init (PR #3079)

by Bastian Triller

Determine dialog event types for dialog callback on module initialization, since these will not change.   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3079 -- Commit Summary -- * pua_dialoginfo: Determine dialog event types in mod_init -- File Changes -- M src/modules/pua_dialoginfo/pua_dialoginfo.c (29) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3079.patch https://github.com/kamailio/kamailio/pull/3079.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3079 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3079(a)github.com>

2 years

git:master:fa3cf27a: pua_dialoginfo: Determine dialog event types in mod_init

by Henning Westerholt

Module: kamailio Branch: master Commit: fa3cf27abf1f76ef90941f47ef81adef4ffae68e URL: https://github.com/kamailio/kamailio/commit/fa3cf27abf1f76ef90941f47ef81ade… Author: Bastian Triller <bastian.triller(a)gmail.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2022-05-02T16:42:35+02:00 pua_dialoginfo: Determine dialog event types in mod_init Determine dialog event types for dialog callback on module initialization, since these will not change. --- Modified: src/modules/pua_dialoginfo/pua_dialoginfo.c --- Diff: https://github.com/kamailio/kamailio/commit/fa3cf27abf1f76ef90941f47ef81ade… Patch: https://github.com/kamailio/kamailio/commit/fa3cf27abf1f76ef90941f47ef81ade… --- diff --git a/src/modules/pua_dialoginfo/pua_dialoginfo.c b/src/modules/pua_dialoginfo/pua_dialoginfo.c index 7b27e666c5..2dae4d449b 100644 --- a/src/modules/pua_dialoginfo/pua_dialoginfo.c +++ b/src/modules/pua_dialoginfo/pua_dialoginfo.c @@ -101,6 +101,7 @@ int disable_callee_publish_flag = DEF_DISABLE_CALLEE_PUBLISH_FLAG; char * pubruri_caller_avp = DEF_PUBRURI_CALLER_AVP; char * pubruri_callee_avp = DEF_PUBRURI_CALLEE_AVP; int publish_dialog_req_within = DEF_PUBLISH_DIALOG_REQ_WITHIN; +int dialog_event_types = DLGCB_FAILED| DLGCB_CONFIRMED_NA | DLGCB_TERMINATED | DLGCB_EXPIRED | DLGCB_EARLY; int puadinfo_attribute_display = 0; @@ -622,25 +623,12 @@ struct dlginfo_cell* get_dialog_data(struct dlg_cell *dlg, int type, int disable } /* register dialog callbacks which triggers sending PUBLISH */ - if (publish_dialog_req_within) { - if (dlg_api.register_dlgcb(dlg, - DLGCB_FAILED| DLGCB_CONFIRMED_NA | DLGCB_TERMINATED - | DLGCB_EXPIRED | DLGCB_REQ_WITHIN | DLGCB_EARLY, - __dialog_sendpublish, dlginfo, free_dlginfo_cell) != 0) { - LM_ERR("cannot register callback for interesting dialog types\n"); - free_dlginfo_cell(dlginfo); - return NULL; - } - } else { - if (dlg_api.register_dlgcb(dlg, - DLGCB_FAILED| DLGCB_CONFIRMED_NA | DLGCB_TERMINATED - | DLGCB_EXPIRED | DLGCB_EARLY, - __dialog_sendpublish, dlginfo, free_dlginfo_cell) != 0) { - LM_ERR("cannot register callback for interesting dialog types\n"); - free_dlginfo_cell(dlginfo); - return NULL; - } - } + if (dlg_api.register_dlgcb(dlg, dialog_event_types, + __dialog_sendpublish, dlginfo, free_dlginfo_cell) != 0) { + LM_ERR("cannot register callback for interesting dialog types\n"); + free_dlginfo_cell(dlginfo); + return NULL; + } #ifdef PUA_DIALOGINFO_DEBUG /* dialog callback testing (registered last to be executed first) */ @@ -856,6 +844,9 @@ static int mod_init(void) LM_DBG("configured to use headers for uri values\n"); } + if(publish_dialog_req_within) + dialog_event_types |= DLGCB_REQ_WITHIN; + return 0; }

2 years

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev May 2022